Subject: Re: [bug#60992] [PATCH] gnu: Add emacs-paradox.

From: Nicolas Goaziou <[email-masked]>
Date: Sun, 22 Jan 2023 17:43:54 +0100

Hello,

Cayetano Santos via Guix-patches via <[email-masked]> writes:

> * gnu/packages/emacs-xyz.scm (emacs-paradox): New variable.

Thank you.

This project is no longer maintained, and the repository is read-only.
Last release is more than 3 years old. Do you think the whole thing is
worth packaging nonetheless ?

> +(define-public emacs-paradox
> +  (let ((version "2.5.5")
> +        (commit "96401577ed02f433debe7604e49afd478e9eda61"))
> +    (package
> +      (name "emacs-paradox")
> +      (version version)

You can insert version directly here. No need for a binding.

> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/Malabarba/paradox")
> +               (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32
> +           "0v9hmvq6bcr2hwlb09ldsd6pjl19ri5n2hl2bs3x52fqjj6fdzzn"))))
> +      (build-system emacs-build-system)
> +      (propagated-inputs
> +       (list emacs-seq emacs-let-alist emacs-spinner emacs-hydra))

Please order inputs alphabetically.

> +      (home-page "https://github.com/Malabarba/paradox")
> +      (synopsis "A modern Packages Menu")

Synopsis must not start with article "A". Also, "modern" may be vague.

> +      (description
> +       "Project for modernizing Emacs' Package Menu.  With improved appearance,
> +mode-line information.  Github integration, customizability, asynchronous
> +upgrading, and more.")

Description should consist of complete sentences.

Regards,
-- 
Nicolas Goaziou