GNU bug report logs - #60977
29.0.60; Dired: invalid face reference with dir symlinks

Previous Next

Full log

Message #17 received at 60977 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 60977 <at> debbugs.gnu.org, juri <at> linkov.net
Subject: Re: bug#60977: 29.0.60; Dired: invalid face reference with dir
 symlinks
Date: Wed, 25 Jan 2023 00:23:52 +0000

Eli Zaretskii [2023-01-24 08:29 -0500] wrote:

>> Cc: 60977 <at> debbugs.gnu.org
>> Date: Mon, 23 Jan 2023 21:04:00 +0000
>> From:  "Basil L. Contovounesios" via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>> 
>> >> But I don't know whether it's acceptable for emacs-29, or whether it
>> >> conses too much during font lock.  In the latter case, we could evaluate
>> >> dired-directory-face once (when dired-font-lock-keywords is defined), or
>> >> we could use the 'dired-directory' face directly.  WDYT?
>> >
>> > I think the effect of consing is negligible.
>> 
>> Thanks for confirming.
>> I'll install it once we hear from Eli re: emacs-29.
>
> I'm sorry, but I don't see any questions you asked me about this
> issue, and neither do I see it on debbugs in the discussion of the
> issue.  What did I miss?

My question was whether the patch in https://bugs.gnu.org/60977#5 is
efficient and suitable enough for emacs-29, to fix a font lock
regression.

Thanks,

-- 
Basil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.