From unknown Sun Aug 10 09:12:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60971: build failure of v3.0.9rc1 on mac os 12.6 Resent-From: lloda Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Fri, 20 Jan 2023 19:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 60971 X-GNU-PR-Package: guile X-GNU-PR-Keywords: To: 60971@debbugs.gnu.org X-Debbugs-Original-To: "bug-guile@gnu.org" Received: via spool by submit@debbugs.gnu.org id=B.167424218722695 (code B ref -1); Fri, 20 Jan 2023 19:17:01 +0000 Received: (at submit) by debbugs.gnu.org; 20 Jan 2023 19:16:27 +0000 Received: from localhost ([127.0.0.1]:47122 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIwsF-0005ty-0Y for submit@debbugs.gnu.org; Fri, 20 Jan 2023 14:16:27 -0500 Received: from lists.gnu.org ([209.51.188.17]:42230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIwsC-0005tp-JO for submit@debbugs.gnu.org; Fri, 20 Jan 2023 14:16:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIwsC-0006eN-9q for bug-guile@gnu.org; Fri, 20 Jan 2023 14:16:24 -0500 Received: from mta-07-4.privateemail.com ([68.65.122.27]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIwsA-00025O-Es for bug-guile@gnu.org; Fri, 20 Jan 2023 14:16:24 -0500 Received: from mta-07.privateemail.com (localhost [127.0.0.1]) by mta-07.privateemail.com (Postfix) with ESMTP id 7BB8318000B0 for ; Fri, 20 Jan 2023 14:16:18 -0500 (EST) Received: from [192.168.1.105] (unknown [51.154.167.214]) by mta-07.privateemail.com (Postfix) with ESMTPA id 1A9E418000A6 for ; Fri, 20 Jan 2023 14:16:17 -0500 (EST) From: lloda Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\)) Message-Id: Date: Fri, 20 Jan 2023 20:16:15 +0100 X-Mailer: Apple Mail (2.3608.120.23.2.7) X-Virus-Scanned: ClamAV using ClamSMTP Received-SPF: pass client-ip=68.65.122.27; envelope-from=lloda@sarc.name; helo=MTA-07-4.privateemail.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hello, v3.0.9rc1 fails on mac os 12.6.2 & gcc 12.2 or clang 14, same error in = either case. gcc's error is: ------------------------------------ CC libguile_3.0_la-posix.lo In file included from ../../../src/guile4/libguile/posix.c:82: ../../../src/guile4/libguile/posix.c:109:9: error: lvalue required as = unary '&' operand 109 | verify (WEXITSTATUS (W_EXITCODE (127, 0)) =3D=3D 127); | ^~~~~~~~~~~ ../../../src/guile4/lib/verify.h:213:57: note: in definition of macro = '_GL_VERIFY' 213 | # define _GL_VERIFY(R, DIAGNOSTIC, ...) _Static_assert (R, = DIAGNOSTIC) | ^ ../../../src/guile4/libguile/posix.c:109:1: note: in expansion of macro = 'verify' 109 | verify (WEXITSTATUS (W_EXITCODE (127, 0)) =3D=3D 127); | ^~~~~~ ../../../src/guile4/libguile/posix.c:109:9: error: expression in static = assertion is not an integer 109 | verify (WEXITSTATUS (W_EXITCODE (127, 0)) =3D=3D 127); | ^~~~~~~~~~~ ../../../src/guile4/lib/verify.h:213:57: note: in definition of macro = '_GL_VERIFY' 213 | # define _GL_VERIFY(R, DIAGNOSTIC, ...) _Static_assert (R, = DIAGNOSTIC) | ^ ../../../src/guile4/libguile/posix.c:109:1: note: in expansion of macro = 'verify' 109 | verify (WEXITSTATUS (W_EXITCODE (127, 0)) =3D=3D 127); | ^~~~~~ ------------------------------------ The problematic section in libguile/posix.c ... #if HAVE_SYS_WAIT_H # include #endif #ifndef WEXITSTATUS # define WEXITSTATUS(stat_val) ((unsigned)(stat_val) >> 8) #endif #ifndef WIFEXITED # define WIFEXITED(stat_val) (((stat_val) & 255) =3D=3D 0) #endif #ifndef W_EXITCODE /* Macro for constructing a status value. Found in glibc. */ # ifdef _WIN32 /* see Gnulib's posix-w32.h */ # define W_EXITCODE(ret, sig) (ret) # else # define W_EXITCODE(ret, sig) ((ret) << 8 | (sig)) # endif #endif verify (WEXITSTATUS (W_EXITCODE (127, 0)) =3D=3D 127); ... adding -o .libs/libguile_3.0_la-posix.i -E to the build line shows line = 109 as _Static_assert ( (((*(int *)&((( 127 ) << 8 | ( 0 )))) >> 8) & = 0x000000ff) =3D=3D 127, "verify (" "WEXITSTATUS (W_EXITCODE (127, 0)) =3D=3D= 127" ")"); ^ forcing redefinition of WEXITSTATUS shows the previous definition at = /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Devel= oper/SDKs/MacOSX.sdk/usr/include/sys/wait.h ... #if defined(_POSIX_C_SOURCE) && !defined(_DARWIN_C_SOURCE) #define _W_INT(i) (i) #else #define _W_INT(w) (*(int *)&(w)) /* convert union wait to int */ = <------------- problem #define WCOREFLAG 0200 #endif /* (_POSIX_C_SOURCE && !_DARWIN_C_SOURCE) */ /* These macros are permited, as they are in the implementation = namespace */ #define _WSTATUS(x) (_W_INT(x) & 0177) #define _WSTOPPED 0177 /* _WSTATUS if process is = stopped */ /* * [XSI] The header shall define the following macros for * analysis of process status values */ #if __DARWIN_UNIX03 #define WEXITSTATUS(x) ((_W_INT(x) >> 8) & 0x000000ff) #else /* !__DARWIN_UNIX03 */ #define WEXITSTATUS(x) (_W_INT(x) >> 8) #endif /* !__DARWIN_UNIX03 */ /* 0x13 =3D=3D SIGCONT */ #define WSTOPSIG(x) (_W_INT(x) >> 8) #define WIFCONTINUED(x) (_WSTATUS(x) =3D=3D _WSTOPPED && WSTOPSIG(x) =3D=3D= 0x13) #define WIFSTOPPED(x) (_WSTATUS(x) =3D=3D _WSTOPPED && WSTOPSIG(x) !=3D = 0x13) #define WIFEXITED(x) (_WSTATUS(x) =3D=3D 0) #define WIFSIGNALED(x) (_WSTATUS(x) !=3D _WSTOPPED && _WSTATUS(x) !=3D = 0) #define WTERMSIG(x) (_WSTATUS(x)) #if (!defined(_POSIX_C_SOURCE) || defined(_DARWIN_C_SOURCE)) #define WCOREDUMP(x) (_W_INT(x) & WCOREFLAG) #define W_EXITCODE(ret, sig) ((ret) << 8 | (sig)) #define W_STOPCODE(sig) ((sig) << 8 | _WSTOPPED) #endif /* (!defined(_POSIX_C_SOURCE) || defined(_DARWIN_C_SOURCE)) */ ... so that's the problem, but I'm not sure what the solution is. The way = it's written, W_EXITCODE() is always going to give up a number... Thanks Daniel From unknown Sun Aug 10 09:12:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60971: GNU Guile 3.0.9rc1 available for testing! Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Mon, 23 Jan 2023 10:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60971 X-GNU-PR-Package: guile X-GNU-PR-Keywords: To: Greg Troxel Cc: 60971@debbugs.gnu.org, lloda , "guile-devel@gnu.org" Received: via spool by 60971-submit@debbugs.gnu.org id=B60971.167447090431993 (code B ref 60971); Mon, 23 Jan 2023 10:49:01 +0000 Received: (at 60971) by debbugs.gnu.org; 23 Jan 2023 10:48:24 +0000 Received: from localhost ([127.0.0.1]:53456 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJuNE-0008Jw-99 for submit@debbugs.gnu.org; Mon, 23 Jan 2023 05:48:24 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33036) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJuN9-0008JA-Kj for 60971@debbugs.gnu.org; Mon, 23 Jan 2023 05:48:22 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJuN4-0004hI-Ca; Mon, 23 Jan 2023 05:48:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=9+vhtfHikyJCy7N210cLTBc7oC4aGj+jM+WgScAb2fs=; b=EBWZdJLhfuaAA7i/TEVc uepQjEA5YKvx0MRxdKy9Wc6wqmQqIGy5SS30b16QkxO3jvxlG+/gzGjabD7Y4PlWQJtYgoZ+pSgx1 +NRV9guJXSQnaOWFM1f1Z92hjYkxgeyS5oAb9Svfe6TkPLzCuWY9bjTxUZSMvtbyaLoqK2j6mW6UF BI0pzIUKFQiwT4x8J6qWMnNuFEOZMFWNtTTCegUwUJihKoBI7RZ+CoVugWXLeJ/3s3DGGzk/m4njt 3SnQbnPrVwG9ilL/RC8e1/Eel1sG13sZC/4vLQhS3tZZEhJ7FVgOY1gDjDmkaBSs5M7ZRKImFjHjx MT9atCuAplK0wQ==; Received: from [193.50.110.246] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJuN3-0002Ew-Dc; Mon, 23 Jan 2023 05:48:14 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87v8l15hb2.fsf@inria.fr> <562CD6BE-42D3-4D4C-AB4C-2B4A5341F525@sarc.name> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Quartidi 4 =?UTF-8?Q?Pluvi=C3=B4se?= an 231 de la =?UTF-8?Q?R=C3=A9volution,?= jour du Perce-neige X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 23 Jan 2023 11:48:11 +0100 In-Reply-To: (Greg Troxel's message of "Sun, 22 Jan 2023 09:39:17 -0500") Message-ID: <87h6wh34t0.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Greg Troxel skribis: > lloda writes: > >> This looks like https://debbugs.gnu.org/60971 on mac os. > > Yes, it does. > > My quick reaction is that if the POSIX-required macros operation on > system types that might be struct, then faking up ints for testing is > unsound. > > Maybe only do verify if guile has to define macros, and don't try to > test the OS? So something like the patch below? Thanks, Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/libguile/posix.c b/libguile/posix.c index 74c743119..0b1fe2637 100644 --- a/libguile/posix.c +++ b/libguile/posix.c @@ -105,8 +105,8 @@ # else # define W_EXITCODE(ret, sig) ((ret) << 8 | (sig)) # endif -#endif verify (WEXITSTATUS (W_EXITCODE (127, 0)) == 127); +#endif #include --=-=-=-- From unknown Sun Aug 10 09:12:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60971: GNU Guile 3.0.9rc1 available for testing! Resent-From: lloda Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Mon, 23 Jan 2023 18:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60971 X-GNU-PR-Package: guile X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 60971@debbugs.gnu.org, "guile-devel@gnu.org" , Greg Troxel Received: via spool by 60971-submit@debbugs.gnu.org id=B60971.167449706732391 (code B ref 60971); Mon, 23 Jan 2023 18:05:01 +0000 Received: (at 60971) by debbugs.gnu.org; 23 Jan 2023 18:04:27 +0000 Received: from localhost ([127.0.0.1]:55284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pK1BD-0008QL-6X for submit@debbugs.gnu.org; Mon, 23 Jan 2023 13:04:27 -0500 Received: from mta-09-3.privateemail.com ([68.65.122.19]:8386) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pK1BC-0008Q1-Cs for 60971@debbugs.gnu.org; Mon, 23 Jan 2023 13:04:26 -0500 Received: from mta-09.privateemail.com (localhost [127.0.0.1]) by mta-09.privateemail.com (Postfix) with ESMTP id DA4EB18000A4; Mon, 23 Jan 2023 13:04:19 -0500 (EST) Received: from [192.168.1.105] (unknown [51.154.167.214]) by mta-09.privateemail.com (Postfix) with ESMTPA id DACE818000A1; Mon, 23 Jan 2023 13:04:15 -0500 (EST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\)) From: lloda In-Reply-To: <87h6wh34t0.fsf@gnu.org> Date: Mon, 23 Jan 2023 19:04:13 +0100 Content-Transfer-Encoding: 7bit Message-Id: <079E639D-3A09-48E6-AAE1-913896DC692E@sarc.name> References: <87v8l15hb2.fsf@inria.fr> <562CD6BE-42D3-4D4C-AB4C-2B4A5341F525@sarc.name> <87h6wh34t0.fsf@gnu.org> X-Mailer: Apple Mail (2.3608.120.23.2.7) X-Virus-Scanned: ClamAV using ClamSMTP X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) lgtm, no other issues on mac os. thanks Daniel From unknown Sun Aug 10 09:12:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#60971: GNU Guile 3.0.9rc1 available for testing! Resent-From: Aleix Conchillo =?UTF-8?Q?Flaqu=C3=A9?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Mon, 23 Jan 2023 18:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60971 X-GNU-PR-Package: guile X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 60971@debbugs.gnu.org, lloda , "guile-devel@gnu.org" , Greg Troxel Received: via spool by 60971-submit@debbugs.gnu.org id=B60971.16744996924532 (code B ref 60971); Mon, 23 Jan 2023 18:49:02 +0000 Received: (at 60971) by debbugs.gnu.org; 23 Jan 2023 18:48:12 +0000 Received: from localhost ([127.0.0.1]:55339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pK1rY-0001B2-2n for submit@debbugs.gnu.org; Mon, 23 Jan 2023 13:48:12 -0500 Received: from mail-vs1-f48.google.com ([209.85.217.48]:46601) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pK1rW-0001Ao-KD for 60971@debbugs.gnu.org; Mon, 23 Jan 2023 13:48:11 -0500 Received: by mail-vs1-f48.google.com with SMTP id j185so13943136vsc.13 for <60971@debbugs.gnu.org>; Mon, 23 Jan 2023 10:48:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qu/smVQDe29BflMq5YQLMNf6Z/kdsqMiNUimbBG4MIk=; b=T3XKJKzw91ihviQ7XmFTcwWfWy0FRWJ/f9CkwMY1M+j5llaX/zCmT8ASFygk4Fs1gI vuFlKXYnBV+Hnnz9hnbuKlUJ7bK/cgJK1Bw/sRKl4NoprNVScoavFaQWH5zRgBhhLSxU YLqvoxtwQnZ7+U310Dv3oIv9fpeOnrPM5WOyuhbXPhSxgx2nJ6fxDM0YTDhMqc6Yjdj+ jcfw/CIBcrm4bSFv2M+5q/LPxeH1QN+MTO0zp0/j43CR87Ht4A9JVnm+W2c0QtuzWthA tMCvmYpCKMVeDiz5ltFjaUaqjQ4Dfy2emVqMDkpkS4Kd82eyQliV+LAjnMTgiCuWuBdt uPSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qu/smVQDe29BflMq5YQLMNf6Z/kdsqMiNUimbBG4MIk=; b=R4CEYYoyvX8lJtH1lA3B2PYt8A4pctBr+kO4YDCrmww/S4qF9UdocJPVjtWtvuX4Sl m6IeKxzcz9J9RcWRFgr9+B53d5M4aepTKcF7BUnYzLZBd9yHiDGwF1lUKBzcc8a/L/Z/ v2ttPzfv5AHo4pX9z4Fg5kZVcxYygkY7ZjqYitfwSONLxSsVMPgE4zYVMWfmzNLy6CjX JTX0DKsvfQVjqaH7LkxxNCYyu9NU8YrnxJSA4HzjxsyDbRP6nesxilBVWccUIiY6xxJE 4Pd0iCi4IsaqN2gCaORxfycslG9W019fi0/f2pxGz0doKxkXEFGmb8Pxo5khsF5fOOHH 4fkg== X-Gm-Message-State: AFqh2kqvHirKANadhGNgFsXXCm/Y48b8iPyNnO7yFEPzMzzLh+1HYgdk fMmVpdPb9oDuSM90eMJhcXSwGk3/EjbRUOxlUbs= X-Google-Smtp-Source: AMrXdXvtXDCLTRyklJq3mrjE05fisVsjD1QhRdTsgnVS5dqQeHghiKwhowbumcbmMuksbypXRnVD2cbNvJljS7TWu4A= X-Received: by 2002:a05:6102:36c7:b0:3d3:e33e:89f4 with SMTP id z7-20020a05610236c700b003d3e33e89f4mr3512006vss.56.1674499684927; Mon, 23 Jan 2023 10:48:04 -0800 (PST) MIME-Version: 1.0 References: <87v8l15hb2.fsf@inria.fr> <562CD6BE-42D3-4D4C-AB4C-2B4A5341F525@sarc.name> <87h6wh34t0.fsf@gnu.org> In-Reply-To: <87h6wh34t0.fsf@gnu.org> From: Aleix Conchillo =?UTF-8?Q?Flaqu=C3=A9?= Date: Mon, 23 Jan 2023 10:47:48 -0800 Message-ID: Content-Type: multipart/alternative; boundary="000000000000e58f7905f2f2d697" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000e58f7905f2f2d697 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jan 23, 2023 at 2:48 AM Ludovic Court=C3=A8s wrote: > Hi, > > Greg Troxel skribis: > > > lloda writes: > > > >> This looks like https://debbugs.gnu.org/60971 < > https://debbugs.gnu.org/60971> on mac os. > > > > Yes, it does. > > > > My quick reaction is that if the POSIX-required macros operation on > > system types that might be struct, then faking up ints for testing is > > unsound. > > > > Maybe only do verify if guile has to define macros, and don't try to > > test the OS? > > So something like the patch below? > Oh, I missed the other report. Yes, this works on macOS as just reported by Daniel. No other issues. Aleix --000000000000e58f7905f2f2d697 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Mon, Jan 23, 2023 at 2:48 AM Ludovic Court=C3=A8s <<= a href=3D"mailto:ludo@gnu.org">ludo@gnu.org> wrote:
=
Hi,

Greg Troxel <gdt@lex= ort.com> skribis:

> lloda <lloda@s= arc.name> writes:
>
>> This looks like https://debbugs.gnu.org/60971 <htt= ps://debbugs.gnu.org/60971> on mac os.
>
> Yes, it does.
>
> My quick reaction is that if the POSIX-required macros operation on > system types that might be struct, then faking up ints for testing is<= br> > unsound.
>
> Maybe only do verify if guile has to define macros, and don't try = to
> test the OS?

So something like the patch below?

Oh, I missed the other report. Yes, this wor= ks on macOS as just reported by Daniel. No other issues.

=
Aleix
--000000000000e58f7905f2f2d697-- From unknown Sun Aug 10 09:12:59 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: lloda Subject: bug#60971: closed (Re: bug#60971: build failure of v3.0.9rc1 on mac os 12.6) Message-ID: References: <87mt68zzca.fsf_-_@gnu.org> X-Gnu-PR-Message: they-closed 60971 X-Gnu-PR-Package: guile Reply-To: 60971@debbugs.gnu.org Date: Mon, 23 Jan 2023 22:00:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1674511203-9764-1" This is a multi-part message in MIME format... ------------=_1674511203-9764-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #60971: build failure of v3.0.9rc1 on mac os 12.6 which was filed against the guile package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 60971@debbugs.gnu.org. --=20 60971: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D60971 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1674511203-9764-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 60971-done) by debbugs.gnu.org; 23 Jan 2023 22:00:00 +0000 Received: from localhost ([127.0.0.1]:55491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pK4rA-0002Ww-9H for submit@debbugs.gnu.org; Mon, 23 Jan 2023 17:00:00 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pK4r8-0002Wh-JC for 60971-done@debbugs.gnu.org; Mon, 23 Jan 2023 16:59:59 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pK4r3-0006bQ-64; Mon, 23 Jan 2023 16:59:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=BLGsT+Ka6U96TA7K0DeQr4eiGsztrQ26g4cD9nTELZ4=; b=PfKvVTYPZ40jop1FQbBY qZPfw0sQa+VQdh94sF/580ZdbgD5pQK4XvoZ6jnwQLyPETx5rxOlCbNIu4dwqyr1CLddRZ9mVnNqT xji0Q0Qqr6cIdYrhcjlWbjZaKDKZm1WZfSdemAb57MjvxDwHtLIqM3Y0M+jHa4T7SHVGgoYfPI7fO zVY0ViTmn449/Z069kyt3vNDlr/vXLngW5/1tBo6OfsD+RnTIWYL5LYAQvEyhw0X8lEfgneieecqn +to0EjdfgDmZ719tvVph5k0QlANbOKevS3ewXqVFk8sreKYkUFJ6bR6394s/Qqw3E+u6VLPaPbQad EHvXLQzL9dttHQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pK4r2-00045a-H5; Mon, 23 Jan 2023 16:59:52 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: lloda Subject: Re: bug#60971: build failure of v3.0.9rc1 on mac os 12.6 References: <87v8l15hb2.fsf@inria.fr> <562CD6BE-42D3-4D4C-AB4C-2B4A5341F525@sarc.name> <87h6wh34t0.fsf@gnu.org> <079E639D-3A09-48E6-AAE1-913896DC692E@sarc.name> Date: Mon, 23 Jan 2023 22:59:49 +0100 In-Reply-To: <079E639D-3A09-48E6-AAE1-913896DC692E@sarc.name> (lloda@sarc.name's message of "Mon, 23 Jan 2023 19:04:13 +0100") Message-ID: <87mt68zzca.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60971-done Cc: 60971-done@debbugs.gnu.org, Greg Troxel , "guile-devel@gnu.org" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) lloda skribis: > lgtm, no other issues on mac os. Awesome, pushed as 9b20ca275dba758a194073936cde7c95311bd51e. Ludo=E2=80=99. ------------=_1674511203-9764-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 20 Jan 2023 19:16:27 +0000 Received: from localhost ([127.0.0.1]:47122 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIwsF-0005ty-0Y for submit@debbugs.gnu.org; Fri, 20 Jan 2023 14:16:27 -0500 Received: from lists.gnu.org ([209.51.188.17]:42230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIwsC-0005tp-JO for submit@debbugs.gnu.org; Fri, 20 Jan 2023 14:16:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIwsC-0006eN-9q for bug-guile@gnu.org; Fri, 20 Jan 2023 14:16:24 -0500 Received: from mta-07-4.privateemail.com ([68.65.122.27]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIwsA-00025O-Es for bug-guile@gnu.org; Fri, 20 Jan 2023 14:16:24 -0500 Received: from mta-07.privateemail.com (localhost [127.0.0.1]) by mta-07.privateemail.com (Postfix) with ESMTP id 7BB8318000B0 for ; Fri, 20 Jan 2023 14:16:18 -0500 (EST) Received: from [192.168.1.105] (unknown [51.154.167.214]) by mta-07.privateemail.com (Postfix) with ESMTPA id 1A9E418000A6 for ; Fri, 20 Jan 2023 14:16:17 -0500 (EST) From: lloda Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\)) Subject: build failure of v3.0.9rc1 on mac os 12.6 Message-Id: Date: Fri, 20 Jan 2023 20:16:15 +0100 To: "bug-guile@gnu.org" X-Mailer: Apple Mail (2.3608.120.23.2.7) X-Virus-Scanned: ClamAV using ClamSMTP Received-SPF: pass client-ip=68.65.122.27; envelope-from=lloda@sarc.name; helo=MTA-07-4.privateemail.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hello, v3.0.9rc1 fails on mac os 12.6.2 & gcc 12.2 or clang 14, same error in = either case. gcc's error is: ------------------------------------ CC libguile_3.0_la-posix.lo In file included from ../../../src/guile4/libguile/posix.c:82: ../../../src/guile4/libguile/posix.c:109:9: error: lvalue required as = unary '&' operand 109 | verify (WEXITSTATUS (W_EXITCODE (127, 0)) =3D=3D 127); | ^~~~~~~~~~~ ../../../src/guile4/lib/verify.h:213:57: note: in definition of macro = '_GL_VERIFY' 213 | # define _GL_VERIFY(R, DIAGNOSTIC, ...) _Static_assert (R, = DIAGNOSTIC) | ^ ../../../src/guile4/libguile/posix.c:109:1: note: in expansion of macro = 'verify' 109 | verify (WEXITSTATUS (W_EXITCODE (127, 0)) =3D=3D 127); | ^~~~~~ ../../../src/guile4/libguile/posix.c:109:9: error: expression in static = assertion is not an integer 109 | verify (WEXITSTATUS (W_EXITCODE (127, 0)) =3D=3D 127); | ^~~~~~~~~~~ ../../../src/guile4/lib/verify.h:213:57: note: in definition of macro = '_GL_VERIFY' 213 | # define _GL_VERIFY(R, DIAGNOSTIC, ...) _Static_assert (R, = DIAGNOSTIC) | ^ ../../../src/guile4/libguile/posix.c:109:1: note: in expansion of macro = 'verify' 109 | verify (WEXITSTATUS (W_EXITCODE (127, 0)) =3D=3D 127); | ^~~~~~ ------------------------------------ The problematic section in libguile/posix.c ... #if HAVE_SYS_WAIT_H # include #endif #ifndef WEXITSTATUS # define WEXITSTATUS(stat_val) ((unsigned)(stat_val) >> 8) #endif #ifndef WIFEXITED # define WIFEXITED(stat_val) (((stat_val) & 255) =3D=3D 0) #endif #ifndef W_EXITCODE /* Macro for constructing a status value. Found in glibc. */ # ifdef _WIN32 /* see Gnulib's posix-w32.h */ # define W_EXITCODE(ret, sig) (ret) # else # define W_EXITCODE(ret, sig) ((ret) << 8 | (sig)) # endif #endif verify (WEXITSTATUS (W_EXITCODE (127, 0)) =3D=3D 127); ... adding -o .libs/libguile_3.0_la-posix.i -E to the build line shows line = 109 as _Static_assert ( (((*(int *)&((( 127 ) << 8 | ( 0 )))) >> 8) & = 0x000000ff) =3D=3D 127, "verify (" "WEXITSTATUS (W_EXITCODE (127, 0)) =3D=3D= 127" ")"); ^ forcing redefinition of WEXITSTATUS shows the previous definition at = /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Devel= oper/SDKs/MacOSX.sdk/usr/include/sys/wait.h ... #if defined(_POSIX_C_SOURCE) && !defined(_DARWIN_C_SOURCE) #define _W_INT(i) (i) #else #define _W_INT(w) (*(int *)&(w)) /* convert union wait to int */ = <------------- problem #define WCOREFLAG 0200 #endif /* (_POSIX_C_SOURCE && !_DARWIN_C_SOURCE) */ /* These macros are permited, as they are in the implementation = namespace */ #define _WSTATUS(x) (_W_INT(x) & 0177) #define _WSTOPPED 0177 /* _WSTATUS if process is = stopped */ /* * [XSI] The header shall define the following macros for * analysis of process status values */ #if __DARWIN_UNIX03 #define WEXITSTATUS(x) ((_W_INT(x) >> 8) & 0x000000ff) #else /* !__DARWIN_UNIX03 */ #define WEXITSTATUS(x) (_W_INT(x) >> 8) #endif /* !__DARWIN_UNIX03 */ /* 0x13 =3D=3D SIGCONT */ #define WSTOPSIG(x) (_W_INT(x) >> 8) #define WIFCONTINUED(x) (_WSTATUS(x) =3D=3D _WSTOPPED && WSTOPSIG(x) =3D=3D= 0x13) #define WIFSTOPPED(x) (_WSTATUS(x) =3D=3D _WSTOPPED && WSTOPSIG(x) !=3D = 0x13) #define WIFEXITED(x) (_WSTATUS(x) =3D=3D 0) #define WIFSIGNALED(x) (_WSTATUS(x) !=3D _WSTOPPED && _WSTATUS(x) !=3D = 0) #define WTERMSIG(x) (_WSTATUS(x)) #if (!defined(_POSIX_C_SOURCE) || defined(_DARWIN_C_SOURCE)) #define WCOREDUMP(x) (_W_INT(x) & WCOREFLAG) #define W_EXITCODE(ret, sig) ((ret) << 8 | (sig)) #define W_STOPCODE(sig) ((sig) << 8 | _WSTOPPED) #endif /* (!defined(_POSIX_C_SOURCE) || defined(_DARWIN_C_SOURCE)) */ ... so that's the problem, but I'm not sure what the solution is. The way = it's written, W_EXITCODE() is always going to give up a number... Thanks Daniel ------------=_1674511203-9764-1--