GNU bug report logs - #60970
[PATCH] gnu: mpdris2: Remove input latels and add inputs.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Simon Streit <simon <at> netpanic.org>
Subject: bug#60970: closed (Re: [bug#60970] [PATCH] gnu: mpdris2: Remove
 input latels and add inputs.)
Date: Thu, 23 Feb 2023 14:42:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#60970: [PATCH] gnu: mpdris2: Remove input latels and add inputs.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 60970 <at> debbugs.gnu.org.

-- 
60970: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60970
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Simon Streit <simon <at> netpanic.org>
Cc: 60970-done <at> debbugs.gnu.org
Subject: Re: [bug#60970] [PATCH] gnu: mpdris2: Remove input latels and add
 inputs.
Date: Thu, 23 Feb 2023 15:41:24 +0100

Hello,

Simon Streit <simon <at> netpanic.org> writes:

> * gnu/packages/mpd.scm (mpdris2)[inputs]: Remove labels.  Add bash-minimal and
> python-mutagen.  [native-inputs]: Remove labels.

Thank you. I applied it and took the liberty to further improve package
style (using G-expressions, and using complete sentences in the
description).

Regards,
-- 
Nicolas Goaziou

[Message part 3 (message/rfc822, inline)]

From: Simon Streit <simon <at> netpanic.org>
To: guix-patches <at> gnu.org
Cc: Simon Streit <simon <at> netpanic.org>
Subject: [PATCH] gnu: mpdris2: Remove input latels and add inputs.
Date: Fri, 20 Jan 2023 20:07:09 +0100

* gnu/packages/mpd.scm (mpdris2)[inputs]: Remove labels.  Add bash-minimal and
python-mutagen.  [native-inputs]: Remove labels.
---
 gnu/packages/mpd.scm | 22 ++++++++++++----------
 1 file changed, 12 insertions(+), 10 deletions(-)

diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm
index 63163e09dc..7d6b05f99e 100644
--- a/gnu/packages/mpd.scm
+++ b/gnu/packages/mpd.scm
@@ -9,7 +9,7 @@
 ;;; Copyright © 2019 Evan Straw <evan.straw99 <at> gmail.com>
 ;;; Copyright © 2020, 2021 Ricardo Wurmus <rekado <at> elephly.net>
 ;;; Copyright © 2020 Lars-Dominik Braun <lars <at> 6xq.net>
-;;; Copyright © 2020–2022 Simon Streit <simon <at> netpanic.org>
+;;; Copyright © 2020–2023 Simon Streit <simon <at> netpanic.org>
 ;;; Copyright © 2021 Noah Evans <noah <at> nevans.me>
 ;;;
 ;;; This file is part of GNU Guix.
@@ -442,15 +442,17 @@ (define-public mpdris2
                (wrap-program (string-append out "/bin/mpDris2")
                  `("GUIX_PYTHONPATH" ":" prefix (,python-path)))
                #t))))))
-    (inputs
-     (list python-mpd2 python-dbus python-pygobject python))             ; Sets GUIX_PYTHONPATH.
-    ;; For bootstrapping.
-    (native-inputs
-     `(("autoconf" ,autoconf)
-       ("automake" ,automake)
-       ("gettext" ,gettext-minimal)
-       ("which" ,which)
-       ("intltool" ,intltool)))
+    (inputs (list bash-minimal
+                  python
+                  python-dbus
+                  python-mpd2
+                  python-mutagen
+                  python-pygobject))
+    (native-inputs (list autoconf
+                         automake
+                         gettext-minimal
+                         intltool
+                         which))
     (synopsis "MPRIS V2.1 support for MPD")
     (description "Client for the Music Player Daemon providing MPRIS 2
 support")
-- 
2.39.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.