From unknown Sun Jun 22 08:08:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#60962] [PATCH v3] tests: Fix implicit function declaration in ax/depcomp.sh Resent-From: =?UTF-8?Q?Fr=C3=A9d=C3=A9ric_?= =?UTF-8?Q?B=C3=A9rat?= Original-Sender: "Debbugs-submit" Resent-CC: automake-patches@gnu.org Resent-Date: Fri, 20 Jan 2023 10:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 60962 X-GNU-PR-Package: automake-patches X-GNU-PR-Keywords: patch To: 60962@debbugs.gnu.org Cc: Frederic Berat X-Debbugs-Original-To: automake-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16742119137034 (code B ref -1); Fri, 20 Jan 2023 10:52:01 +0000 Received: (at submit) by debbugs.gnu.org; 20 Jan 2023 10:51:53 +0000 Received: from localhost ([127.0.0.1]:45711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIozx-0001pO-F8 for submit@debbugs.gnu.org; Fri, 20 Jan 2023 05:51:53 -0500 Received: from lists.gnu.org ([209.51.188.17]:41798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIozu-0001pF-FL for submit@debbugs.gnu.org; Fri, 20 Jan 2023 05:51:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIozu-000772-8S for automake-patches@gnu.org; Fri, 20 Jan 2023 05:51:50 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIozs-0005XD-HN for automake-patches@gnu.org; Fri, 20 Jan 2023 05:51:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674211907; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5lGgM6cZtEDXUW5hxuEJZ+NPfonk2uNkjVQd9tIHRDQ=; b=X1J9bN+XWzD03n1UuwrdDKPW96ENlgNgCccVkLR/1rdYV4kNA9JrFsVJdI6YuASNizmwkI 4lR0ZjKf7dhWxdheDM5ba2fw01loRE148TPUDZgFCtHYZTn6dYYtyXoOTJHuGc5v+iffhn 5HOD8qX5OhZ+1XVOZZCbk7wIlI5x5EI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-446-_aiRsWxvOxK2vV1J5Am9Cw-1; Fri, 20 Jan 2023 05:51:45 -0500 X-MC-Unique: _aiRsWxvOxK2vV1J5Am9Cw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6FB15101A521 for ; Fri, 20 Jan 2023 10:51:45 +0000 (UTC) Received: from Nymeria-redhat.redhat.com (unknown [10.39.192.231]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D516F39D93; Fri, 20 Jan 2023 10:51:44 +0000 (UTC) From: =?UTF-8?Q?Fr=C3=A9d=C3=A9ric_?= =?UTF-8?Q?B=C3=A9rat?= Date: Fri, 20 Jan 2023 11:51:39 +0100 Message-Id: <20230120105139.191539-1-fberat@redhat.com> In-Reply-To: <20230113064804.580F5340B54@smtp.gentoo.org> References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true Received-SPF: pass client-ip=170.10.133.124; envelope-from=fberat@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) From: Frederic Berat Change since v2: - Replace the mv operation by a cp operation to ensure that subfoo.h is considered being modified. -- 8< -- In depcomp.sh, the following occurs: 1. Files are created so that headers and units are available in subdirectories 2. Multiple "make" are executed, while modifying the content of the headers, some should fail, others should succeed. 3. At the end, the "sub/subfoo.h" header gets removed. 4. make is executed again, which is expected to succeed. Yet, with c99, this can't work as the subfoo.h header contains declaration that are used by foo.c. Thus, we need to get them back, either by inserting the declaration in foo.c (or any other header/unit), or by restoring subfoo.h to its original state. The later solution seems the easiest path, being less intrusive in depcomp.sh. --- t/ax/depcomp.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/ax/depcomp.sh b/t/ax/depcomp.sh index 7a3ac63a7..c92f7c8df 100644 --- a/t/ax/depcomp.sh +++ b/t/ax/depcomp.sh @@ -243,6 +243,7 @@ cat > sub/subfoo.h <<'END' #include extern int subfoo (void); END +cp sub/subfoo.h sub/subfoo.save cat > src/baz.c <<'END' #include "baz.h" @@ -399,8 +400,7 @@ do_test () && rewrite "$srcdir"/sub/subfoo.h echo 'choke me' \ && not $MAKE \ && delete "$srcdir"/sub/subfoo.h \ - && edit "$srcdir"/sub/subfoo.c -e 1d \ - && edit "$srcdir"/foo.h -e 2d \ + && cp "$srcdir"/sub/subfoo.save "$srcdir"/sub/subfoo.h \ && make_ok \ || r='not ok' result_ "$r" "$pfx dependency tracking works" -- 2.39.0 From unknown Sun Jun 22 08:08:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#60962] [PATCH v3] tests: Fix implicit function declaration in ax/depcomp.sh References: <20230120105139.191539-1-fberat@redhat.com> Resent-From: Karl Berry Original-Sender: "Debbugs-submit" Resent-CC: automake-patches@gnu.org Resent-Date: Mon, 28 Aug 2023 13:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60962 X-GNU-PR-Package: automake-patches X-GNU-PR-Keywords: patch To: fberat@redhat.com Cc: 60962@debbugs.gnu.org Received: via spool by 60962-submit@debbugs.gnu.org id=B60962.169322842418644 (code B ref 60962); Mon, 28 Aug 2023 13:14:02 +0000 Received: (at 60962) by debbugs.gnu.org; 28 Aug 2023 13:13:44 +0000 Received: from localhost ([127.0.0.1]:47378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qac3r-0004qd-Kp for submit@debbugs.gnu.org; Mon, 28 Aug 2023 09:13:43 -0400 Received: from frenzy.freefriends.org ([198.99.81.75]:48448 helo=freefriends.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qac3m-0004qC-0u; Mon, 28 Aug 2023 09:13:38 -0400 X-Envelope-From: karl@freefriends.org Received: from freefriends.org (localhost [127.0.0.1]) by freefriends.org (8.14.7/8.14.7) with ESMTP id 37SDDTtt000755 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Aug 2023 07:13:29 -0600 Received: (from apache@localhost) by freefriends.org (8.14.7/8.14.7/Submit) id 37SDDT7N000754; Mon, 28 Aug 2023 07:13:29 -0600 Date: Mon, 28 Aug 2023 07:13:29 -0600 Message-Id: <202308281313.37SDDT7N000754@freefriends.org> From: Karl Berry In-Reply-To: <20230120105139.191539-1-fberat@redhat.com> X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Frédéric, [in t/ax/depcomp.sh] - Replace the mv operation by a cp operation to ensure that subfoo.h is considered being modified. Thanks for the clear explanation and simple patch :). I (finally) installed it, just adding a comment, so am closing this. Happy hacking, Karl From unknown Sun Jun 22 08:08:17 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: =?UTF-8?Q?Fr=C3=A9d=C3=A9ric_?= =?UTF-8?Q?B=C3=A9rat?= Subject: bug#60962: closed (Re: [bug#60962] [PATCH v3] tests: Fix implicit function declaration in ax/depcomp.sh) Message-ID: References: <202308281313.37SDDT7N000754@freefriends.org> <20230120105139.191539-1-fberat@redhat.com> X-Gnu-PR-Message: they-closed 60962 X-Gnu-PR-Package: automake-patches X-Gnu-PR-Keywords: patch Reply-To: 60962@debbugs.gnu.org Date: Mon, 28 Aug 2023 13:14:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1693228443-18705-1" This is a multi-part message in MIME format... ------------=_1693228443-18705-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #60962: [PATCH v3] tests: Fix implicit function declaration in ax/depcomp.sh which was filed against the automake-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 60962@debbugs.gnu.org. --=20 60962: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D60962 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1693228443-18705-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 60962-done) by debbugs.gnu.org; 28 Aug 2023 13:13:40 +0000 Received: from localhost ([127.0.0.1]:47376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qac3o-0004qR-AI for submit@debbugs.gnu.org; Mon, 28 Aug 2023 09:13:40 -0400 Received: from frenzy.freefriends.org ([198.99.81.75]:48448 helo=freefriends.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qac3m-0004qC-0u; Mon, 28 Aug 2023 09:13:38 -0400 X-Envelope-From: karl@freefriends.org Received: from freefriends.org (localhost [127.0.0.1]) by freefriends.org (8.14.7/8.14.7) with ESMTP id 37SDDTtt000755 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Aug 2023 07:13:29 -0600 Received: (from apache@localhost) by freefriends.org (8.14.7/8.14.7/Submit) id 37SDDT7N000754; Mon, 28 Aug 2023 07:13:29 -0600 Date: Mon, 28 Aug 2023 07:13:29 -0600 Message-Id: <202308281313.37SDDT7N000754@freefriends.org> From: Karl Berry To: fberat@redhat.com Subject: Re: [bug#60962] [PATCH v3] tests: Fix implicit function declaration in ax/depcomp.sh In-Reply-To: <20230120105139.191539-1-fberat@redhat.com> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60962-done Cc: 60962@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Frédéric, [in t/ax/depcomp.sh] - Replace the mv operation by a cp operation to ensure that subfoo.h is considered being modified. Thanks for the clear explanation and simple patch :). I (finally) installed it, just adding a comment, so am closing this. Happy hacking, Karl ------------=_1693228443-18705-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 20 Jan 2023 10:51:53 +0000 Received: from localhost ([127.0.0.1]:45711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIozx-0001pO-F8 for submit@debbugs.gnu.org; Fri, 20 Jan 2023 05:51:53 -0500 Received: from lists.gnu.org ([209.51.188.17]:41798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIozu-0001pF-FL for submit@debbugs.gnu.org; Fri, 20 Jan 2023 05:51:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIozu-000772-8S for automake-patches@gnu.org; Fri, 20 Jan 2023 05:51:50 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIozs-0005XD-HN for automake-patches@gnu.org; Fri, 20 Jan 2023 05:51:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674211907; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5lGgM6cZtEDXUW5hxuEJZ+NPfonk2uNkjVQd9tIHRDQ=; b=X1J9bN+XWzD03n1UuwrdDKPW96ENlgNgCccVkLR/1rdYV4kNA9JrFsVJdI6YuASNizmwkI 4lR0ZjKf7dhWxdheDM5ba2fw01loRE148TPUDZgFCtHYZTn6dYYtyXoOTJHuGc5v+iffhn 5HOD8qX5OhZ+1XVOZZCbk7wIlI5x5EI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-446-_aiRsWxvOxK2vV1J5Am9Cw-1; Fri, 20 Jan 2023 05:51:45 -0500 X-MC-Unique: _aiRsWxvOxK2vV1J5Am9Cw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6FB15101A521 for ; Fri, 20 Jan 2023 10:51:45 +0000 (UTC) Received: from Nymeria-redhat.redhat.com (unknown [10.39.192.231]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D516F39D93; Fri, 20 Jan 2023 10:51:44 +0000 (UTC) From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20B=C3=A9rat?= To: automake-patches@gnu.org Subject: [PATCH v3] tests: Fix implicit function declaration in ax/depcomp.sh Date: Fri, 20 Jan 2023 11:51:39 +0100 Message-Id: <20230120105139.191539-1-fberat@redhat.com> In-Reply-To: <20230113064804.580F5340B54@smtp.gentoo.org> References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true Received-SPF: pass client-ip=170.10.133.124; envelope-from=fberat@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Frederic Berat X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) From: Frederic Berat Change since v2: - Replace the mv operation by a cp operation to ensure that subfoo.h is considered being modified. -- 8< -- In depcomp.sh, the following occurs: 1. Files are created so that headers and units are available in subdirectories 2. Multiple "make" are executed, while modifying the content of the headers, some should fail, others should succeed. 3. At the end, the "sub/subfoo.h" header gets removed. 4. make is executed again, which is expected to succeed. Yet, with c99, this can't work as the subfoo.h header contains declaration that are used by foo.c. Thus, we need to get them back, either by inserting the declaration in foo.c (or any other header/unit), or by restoring subfoo.h to its original state. The later solution seems the easiest path, being less intrusive in depcomp.sh. --- t/ax/depcomp.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/ax/depcomp.sh b/t/ax/depcomp.sh index 7a3ac63a7..c92f7c8df 100644 --- a/t/ax/depcomp.sh +++ b/t/ax/depcomp.sh @@ -243,6 +243,7 @@ cat > sub/subfoo.h <<'END' #include extern int subfoo (void); END +cp sub/subfoo.h sub/subfoo.save cat > src/baz.c <<'END' #include "baz.h" @@ -399,8 +400,7 @@ do_test () && rewrite "$srcdir"/sub/subfoo.h echo 'choke me' \ && not $MAKE \ && delete "$srcdir"/sub/subfoo.h \ - && edit "$srcdir"/sub/subfoo.c -e 1d \ - && edit "$srcdir"/foo.h -e 2d \ + && cp "$srcdir"/sub/subfoo.save "$srcdir"/sub/subfoo.h \ && make_ok \ || r='not ok' result_ "$r" "$pfx dependency tracking works" -- 2.39.0 ------------=_1693228443-18705-1--