GNU bug report logs - #6096
24.0.50; code error in accept-change-group

Previous Next

Package: emacs;

Reported by: Andreas Politz <politza <at> fh-trier.de>

Date: Mon, 3 May 2010 20:00:03 UTC

Severity: normal

Merged with 6095

Found in version 24.0.50

Done: Chong Yidong <cyd <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

Message #13 received at 6096 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> gnu.org>
To: Andreas Politz <politza <at> fh-trier.de>
Cc: 6096 <at> debbugs.gnu.org, 6095 <at> debbugs.gnu.org
Subject: Re: bug#6095: 24.0.50; code error in accept-change-group
Date: Mon, 23 Apr 2012 23:48:49 +0800

Andreas Politz <politza <at> fh-trier.de> writes:

> (defun accept-change-group (handle)
>   "Finish a change group made with `prepare-change-group' (which see).
> This finishes the change group by accepting its changes as final."
>   (dolist (elt handle)
>     (with-current-buffer (car elt)
>       (if (eq elt t)
> 	  (setq buffer-undo-list t)))))
>
> I think this should be more like `(eq (cdr elt) t)', it should
> redeactivate undo.  This test can not possibly succeed anyway.

Committed to trunk, thanks.
This bug report was last modified 13 years and 84 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.