From unknown Mon Aug 11 18:19:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6095: 24.0.50; code error in accept-change-group Resent-From: Andreas Politz Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 May 2010 19:59:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 6095 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 6095@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.127291671321766 (code B ref -1); Mon, 03 May 2010 19:59:04 +0000 Received: (at submit) by debbugs.gnu.org; 3 May 2010 19:58:33 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O91mi-0005ex-Vf for submit@debbugs.gnu.org; Mon, 03 May 2010 15:58:33 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O91md-0005ek-Oe for submit@debbugs.gnu.org; Mon, 03 May 2010 15:58:29 -0400 Received: from lists.gnu.org ([199.232.76.165]:42170) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1O91mZ-0001TG-J1 for submit@debbugs.gnu.org; Mon, 03 May 2010 15:58:23 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O91mZ-0005Lf-73 for bug-gnu-emacs@gnu.org; Mon, 03 May 2010 15:58:23 -0400 Received: from [140.186.70.92] (port=37218 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O91mX-0005LL-Dh for bug-gnu-emacs@gnu.org; Mon, 03 May 2010 15:58:22 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.0 (2010-01-18) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, T_DKIM_INVALID,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.0 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O91mR-00033T-0Q for bug-gnu-emacs@gnu.org; Mon, 03 May 2010 15:58:21 -0400 Received: from gateway-b.fh-trier.de ([143.93.54.182]:49279) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O91mQ-000337-OZ for bug-gnu-emacs@gnu.org; Mon, 03 May 2010 15:58:14 -0400 Received: from raven (dslb-084-059-215-212.pools.arcor-ip.net [84.59.215.212]) (Authenticated sender: politza) by gateway-b.fh-trier.de (Postfix) with ESMTP id 10F9017B43F for ; Mon, 3 May 2010 21:58:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha1; c=simple/simple; d=fh-trier.de; s=default; t=1272916685; bh=hOgfbaQLl01ZQClDXdAgsN+HIQo=; h=From:To:Subject: Date:Message-ID:MIME-Version:Content-Type; b=D1d3zFlSqK3rCALSSE7JQ YIev4xdcGBCb4NCxW6YvY0UG8v3yJMrlvlmGSw9KpU8eK0dsYBOXrnjdTT01Y1strrU g4b8gKB3DwLrdzr+4/Vyr0UuW8CTxdW/XmdyhVejgIFDtmwyuC4CvBEm3o60cuOJWpe yjrgNsZYhRLuGI1g= From: Andreas Politz Date: Mon, 03 May 2010 21:58:04 +0200 Message-ID: <87hbmosqpf.fsf@fh-trier.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by Amavisd-new + McAfee uvscan + ClamAV [Rechenzentrum FH-Trier (r/ft)] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.5 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.7 (-----) (defun accept-change-group (handle) "Finish a change group made with `prepare-change-group' (which see). This finishes the change group by accepting its changes as final." (dolist (elt handle) (with-current-buffer (car elt) (if (eq elt t) (setq buffer-undo-list t))))) I think this should be more like `(eq (cdr elt) t)', it should redeactivate undo. This test can not possibly succeed anyway. -ap In GNU Emacs 24.0.50.3 (x86_64-unknown-linux-gnu, GTK+ Version 2.18.9) of 2010-05-03 on raven Windowing system distributor `The X.Org Foundation', version 11.0.10705000 Important settings: value of $LC_ALL: C value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_US.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: Emacs-Lisp Minor modes in effect: diff-auto-refine-mode: t narrow-stack-mode: t server-mode: t easy-repeat-mode: t eldoc-mode: t shell-dirtrack-mode: t recentf-mode: t ido-hacks-mode: t window-numbering-mode: t which-function-mode: t show-paren-mode: t ido-everywhere: t icomplete-mode: t global-hi-lock-mode: t hi-lock-mode: t display-time-mode: t savehist-mode: t tooltip-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Recent input: SPC n e e d SPC t o SPC ` p r e p a r e ' SPC a l l SPC b u f f e r s , SPC b e c a u s e SPC a SPC m a c r o SPC c a n SPC d o SPC a b o u t SPC a n y t h i n g . M-q C-h SPC t o SPC a n y SPC b u f f e r . M-q C-j C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-k C-k C-k C-k C-M-a C-M-SPC M-w C-M-e C-j - a p C-x h M-w C-x C-g C-x h C-w C-x b C-s F M-> C-j C-y M-{ M-{ M-{ C-n C-n M-d t h e M-q M-f M-f M-f C-f C-j C-j M-q M-{ M-{ M-{ M-{ M-{ M-{ M-{ C-c C-c 2 x q g q q C-y M-y M-y M-y C-u C-x b C-n C-M-a C-M-a C-M-e C-n C-M-l C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-l C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p M-1 C-x b f f o o M-h M-x b u f f SPC - d i M-x C-g M-x k m M-p C-/ C-/ M-2 C-M-a C-n C-n C-n C-n C-n C-n C-p M-f M-f C-f ( c d r SPC M-f ) C-M-x M-1 M-x C-g C-p M-x M-p M-p M-x M-p M-p C-/ M-2 C-M-a C-M-SPC M-w M-1 M-x r e p o Recent messages: Saving /home/politza/.emacs.d/gnus/.newsrc.eld...done Mark set [4 times] Quit Undo! undo-more: No further undo information Mark set [2 times] accept-change-group Quit undo-start: No undo information in this buffer Mark set [3 times] Load-path shadows: /home/politza/.emacs.d/minor-modes/ido hides /home/politza/src/emacs23/lisp/ido Features: (canlock sha1 hex-util info-look info mailalias smtpmail sendmail shadow emacsbug whitespace diff-mode diff browse-kill-ring apropos gnus-cite smiley ansi-color gnus-async gnus-bcklg qp sort gnus-ml disp-table parse-time nnfolder nnmbox utf-7 utf7 netrc starttls nnimap imap nndraft nnmh bbdb-gnus bbdb-snarf mail-extr bbdb-com warnings nnnil gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg gnus-art mm-uu mml2015 epg-config mm-view smime dig mailcap nntp gnus-cache gnus-sum nnoo gnus-group gnus-undo nnmail mail-source gnus-start gnus-spec gnus-win jka-compr find-dired cl-specs edebug newcomment thingatpt help-mode view debug vc-dispatcher vc-svn reposition etags multi-isearch vc-git cc-mode cc-fonts cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs find-func minibuffer-regexp pascal narrow-stack org org-footnote org-src org-list org-faces org-compat org-entities org-macs noutline outline ispell closure byte-opt bytecomp byte-compile gnus-int gnus-range message rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev gmm-utils mailheader gnus gnus-ems nnheader mail-utils mm-util mail-prsvr avoid server easy-repeat repeat eldoc linux tex-site auto-loads ibuf-macs ibuf-ext ibuffer dired-x dired-aux dired dired-details tramp-imap assoc tramp-gw tramp-fish tramp-smb tramp-cache tramp-ftp tramp-cmds tramp auth-source gnus-util shell password-cache format-spec tramp-compat trampver time-date recentf tree-widget wid-edit easymenu generic ido-hacks hippie-exp my-anything anything edmacro kmacro kbd-helper derived org-install bbdb-autoloads bbdb timezone persistent-scratch-buffer window-numbering easy-mmode cl cl-19 uniquify winner which-func imenu paren ido icomplete grep compile comint regexp-opt ring hi-lock time cus-start cus-load saveplace savehist advice help-fns advice-preload tooltip ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image fringe lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mldrag mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev loaddefs button minibuffer faces cus-face files text-properties overlay md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind dynamic-setting font-render-setting gtk x-toolkit x multi-tty emacs) From debbugs-submit-bounces@debbugs.gnu.org Mon May 03 18:10:10 2010 Received: (at control) by debbugs.gnu.org; 3 May 2010 22:10:10 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O93q6-0006aI-HR for submit@debbugs.gnu.org; Mon, 03 May 2010 18:10:10 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O93q4-0006aD-Od for control@debbugs.gnu.org; Mon, 03 May 2010 18:10:09 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1O93q0-00063D-Gv; Mon, 03 May 2010 18:10:04 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19423.18876.335529.331433@fencepost.gnu.org> Date: Mon, 3 May 2010 18:10:04 -0400 From: Glenn Morris To: control Subject: control X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: yellow X-Ran: )Z'fl,6sOk0vWy&ggk\)viy.SqMaJc~^nU|tq"=6+Tq\qkkYs(le\Lwij[TxW9/~"t%NCZ X-Debbugs-No-Ack: yes X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) merge 6090 6091 6092 merge 6095 6096 From unknown Mon Aug 11 18:19:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6095: 24.0.50; code error in accept-change-group Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 Apr 2012 15:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6095 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Andreas Politz Cc: 6096@debbugs.gnu.org, 6095@debbugs.gnu.org Received: via spool by 6095-submit@debbugs.gnu.org id=B6095.133519618413067 (code B ref 6095); Mon, 23 Apr 2012 15:50:01 +0000 Received: (at 6095) by debbugs.gnu.org; 23 Apr 2012 15:49:44 +0000 Received: from localhost ([127.0.0.1]:49191 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SMLWK-0003Od-BW for submit@debbugs.gnu.org; Mon, 23 Apr 2012 11:49:44 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:34939 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SMLWG-0003OQ-L8; Mon, 23 Apr 2012 11:49:41 -0400 Received: from bb116-14-12-6.singnet.com.sg ([116.14.12.6]:45416 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1SMLVY-0006MQ-Pg; Mon, 23 Apr 2012 11:48:57 -0400 From: Chong Yidong References: <87hbmosqpf.fsf@fh-trier.de> Date: Mon, 23 Apr 2012 23:48:49 +0800 In-Reply-To: <87hbmosqpf.fsf@fh-trier.de> (Andreas Politz's message of "Mon, 03 May 2010 21:58:04 +0200") Message-ID: <87aa2230v2.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.9 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Andreas Politz writes: > (defun accept-change-group (handle) > "Finish a change group made with `prepare-change-group' (which see). > This finishes the change group by accepting its changes as final." > (dolist (elt handle) > (with-current-buffer (car elt) > (if (eq elt t) > (setq buffer-undo-list t))))) > > I think this should be more like `(eq (cdr elt) t)', it should > redeactivate undo. This test can not possibly succeed anyway. Committed to trunk, thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 23 11:49:56 2012 Received: (at control) by debbugs.gnu.org; 23 Apr 2012 15:49:56 +0000 Received: from localhost ([127.0.0.1]:49194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SMLWV-0003P3-L3 for submit@debbugs.gnu.org; Mon, 23 Apr 2012 11:49:55 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:34942 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SMLWT-0003Ox-MU for control@debbugs.gnu.org; Mon, 23 Apr 2012 11:49:53 -0400 Received: from bb116-14-12-6.singnet.com.sg ([116.14.12.6]:45418 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1SMLVm-0006N5-Ix for control@debbugs.gnu.org; Mon, 23 Apr 2012 11:49:11 -0400 From: Chong Yidong To: control@debbugs.gnu.org Subject: close 6095 Date: Mon, 23 Apr 2012 23:49:04 +0800 Message-ID: <87fwbula8f.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) close 6095 thanks