GNU bug report logs - #60943
28.2; ‘tramp-handle-file-regular-p’ misses symlinks

Previous Next

Full log

View this message in rfc822 format

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Greg Pfeil <greg <at> technomadic.org>
Cc: 60943 <at> debbugs.gnu.org
Subject: bug#60943: 28.2; ‘tramp-handle-file-regular-p’ misses symlinks
Date: Thu, 19 Jan 2023 14:12:24 +0100

[Message part 1 (text/plain, inline)]

Greg Pfeil <greg <at> technomadic.org> writes:

Hi Greg,

> I was having an issue where .dir-locals.el on remote machines weren’t getting picked up when they were a symlink. Local symlinks worked fine, and remote non-symlinks also worked.
>
> Digging in, ‘tramp-handle-regular-file-p’ explicitly checks that the first character in ‘file-attribute-mode’ is ?-. However, for symlinks, that character will be ?l.
>
> Modifying ‘dir-locals--all-files’ to check
>
>   (or (file-regular-p f) (file-symlink-p f))
>
> \(which is ostensibly redundant) instead of simply
>
>   (file-regular-p f)

Indeed, there's a bug. Thanks for the report!

> fixes the behavior, since TRAMP will now check with both ‘tramp-handle-file-regular-p’ and ‘tramp-handle-file-symlink-p’. The correct fix is to make ‘tramp-handle-file-regular-p’ match the behavior of ‘file-regular-p’.

The appended patch fixes this. Eli, is it OK to push to the emacs-29 branch?

Best regards, Michael.

[Message part 2 (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.