From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 18 22:36:48 2023 Received: (at submit) by debbugs.gnu.org; 19 Jan 2023 03:36:48 +0000 Received: from localhost ([127.0.0.1]:42256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pILjM-0000rl-8J for submit@debbugs.gnu.org; Wed, 18 Jan 2023 22:36:48 -0500 Received: from lists.gnu.org ([209.51.188.17]:54022) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pILjK-0000re-SA for submit@debbugs.gnu.org; Wed, 18 Jan 2023 22:36:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pILjK-00006T-8b for bug-gnu-emacs@gnu.org; Wed, 18 Jan 2023 22:36:46 -0500 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pILjH-0002yI-T3 for bug-gnu-emacs@gnu.org; Wed, 18 Jan 2023 22:36:45 -0500 Received: by mail-pl1-x62d.google.com with SMTP id d9so1090804pll.9 for ; Wed, 18 Jan 2023 19:36:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:from:content-language:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=Dg8smBFTirszdU5lKinxcqLBd3HXTNisSOPiflLXgGw=; b=UgjDf7I0LlzyKUqaBtgMkvApaR+s7W0+U/clsVAQP+qGHvDYtXB7w01gKgnU+e74p4 LWLrQJpVSJjWTcNVKoH71iZ+mxUIF6Ta1e76mWBLfwNS9Vq8dzYME8RVD49Q9uGcH6jU P5FmEQQL0ejhMJsdjAyyY7rLctPPu0xfI3PlrKtnUgHIX9EHbjtBvOEe9epo9Yla1I+h pNLmBPGiFqDKqOGQ971jLeLRNYRKpJodFsTHFFhB5WaWyftlPvXp47gpVcMpxYlf3vcw RXnAaZBgimf4uDlv1W0d/7hOdYd3TAJw5Zxh9bw3NDJPcCeI3zjxaDzgNGrguvQCZn92 yJ3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:from:content-language:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Dg8smBFTirszdU5lKinxcqLBd3HXTNisSOPiflLXgGw=; b=4cAqRky9MT/7zzzG/cUGKnIXXd04hQ2FRUIiGNhtvS1SvyPDTVQP5LD8D0lpnpmOXm GIlyXLLQ/AJX7xGIhrKEH+thC2CF93sg3XtvG4yxW2kgEVt1uzvo9Gtp4G7OzIjxhr1b XWgKC4yOtEjyWt7up4bLWf23iZhq6cE2RjGEJmpIqPG5CuE45hFKomkSC8U9zNc1hp/D G0T51w9lNH2TohEsNaonJsYv4Ii3TKeUF7Ey5KXt8fQKN4rxrQhCikZqKUJDJuKpYUsl i2ZrSGFqfRGz1tgUTT6kAsvLpPAheV28+gn2Ry6pK5yIXqQ41MzdyUh0Z0irTpFh3HK3 g86A== X-Gm-Message-State: AFqh2kqng6dPGlHBzf6RLNgBIL3YPZfs+eQ/PdqhNKAWMMjXYxfeoGgQ 3SqWFoSeTdANxPq7TjDw1yGVfu2lePk0Ng== X-Google-Smtp-Source: AMrXdXuXZchSNBAajpncdzcyKAkHAL6/d0dvhKAbbXbnQm17xrJRsTGUltWxuei8hHlbxFJsX/y53Q== X-Received: by 2002:a17:902:e5d2:b0:191:3808:14b0 with SMTP id u18-20020a170902e5d200b00191380814b0mr13417938plf.4.1674099402124; Wed, 18 Jan 2023 19:36:42 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id y23-20020a17090264d700b00192820d00d0sm23810954pli.120.2023.01.18.19.36.41 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Jan 2023 19:36:41 -0800 (PST) Content-Type: multipart/mixed; boundary="------------xJwvNFB70b1KdAYIWSk6pdhL" Message-ID: <20e5cb2f-aabe-53fd-d3af-81ec5ff11e7b@gmail.com> Date: Wed, 18 Jan 2023 19:36:41 -0800 MIME-Version: 1.0 X-Mozilla-News-Host: news://news.gmane.io:119 Content-Language: en-US From: Jim Porter Subject: 30.0.50; [PATCH] Indices in Eshell variable interpolation don't work with async subcommands To: bug-gnu-emacs@gnu.org Received-SPF: pass client-ip=2607:f8b0:4864:20::62d; envelope-from=jporterbugs@gmail.com; helo=mail-pl1-x62d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------xJwvNFB70b1KdAYIWSk6pdhL Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Starting from "emacs -Q -f eshell": ~ $ echo $exec-path[0] /usr/local/sbin ~ $ echo $exec-path[${echo 0}] /usr/local/sbin ~ $ echo $exec-path[${*echo 0}] ;; no output This is because 'eshell-eval-indices' gets an S-expr describing code to evaluate for the indices, and it just passes that to 'eval'. That's not the right way to do things for Eshell: instead, we should rely on 'eshell-do-eval', which properly handles asynchronous evaluation. That's required for working with external commands like "*echo" (which calls the real /bin/echo). The attached patch fixes this by changing 'eshell-eval-indices' to 'eshell-indices', which does some minimal transformations on the S-expr for the indices, and then uses it to build the final S-expr to pass to 'eshell-do-eval'. This could possibly go in Emacs 29, since it's a bugfix to add onto a previous bugfix (see commit 990f36fa10). However, I'd lean towards just merging to master; this is a fairly obscure issue, and we can't just fix *every* bug we find on the release branch, or the branch will never stabilize. If someone else thinks it's important enough to go on the release branch though, I won't argue. --------------xJwvNFB70b1KdAYIWSk6pdhL Content-Type: text/plain; charset=UTF-8; name="0001-Fix-evaluation-of-asynchronous-expansions-in-Eshell-.patch" Content-Disposition: attachment; filename*0="0001-Fix-evaluation-of-asynchronous-expansions-in-Eshell-.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAxYmJhZjU0N2Q4ZDY2NjhiY2E3MzJlMTRkYzE5MDQxNmM1YjUyNjcxIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFdlZCwgMTggSmFuIDIwMjMgMTk6MTU6MzggLTA4MDAKU3ViamVjdDogW1BB VENIXSBGaXggZXZhbHVhdGlvbiBvZiBhc3luY2hyb25vdXMgZXhwYW5zaW9ucyBpbiBFc2hl bGwgaW5kaWNlcwoKUHJldmlvdXNseSwgdGhpcyBjb2RlIHBhc3NlZCB0aGUgaW5kaWNlcyB0 byBhIHNlcGFyYXRlIGZ1bmN0aW9uLCB3aGljaApjYWxsZWQgJ2V2YWwnIG9uIHRoZW0sIGJ1 dCBpdCBzaG91bGQgaW5zdGVhZCBtYWtlIGFuIFMtZXhwciB0aGF0Cidlc2hlbGwtZG8tZXZh bCcgY2FuIGV2YWx1YXRlLgoKKiBsaXNwL2VzaGVsbC9lc2gtdmFyLmVsIChlc2hlbGwtZXZh bC1pbmRpY2VzKTogUmVuYW1lIHRvLi4uCihlc2hlbGwtaW5kaWNlcyk6IC4uLiB0aGlzLCBh bmQgYWRqdXN0IGltcGxlbWVudGF0aW9uIHRvIHJldHVybiBhIGZvcm0KdG8gZXZhbHVhdGUg dmlhICdlc2hlbGwtZG8tZXZhbCcuCihlc2hlbGwtcGFyc2UtdmFyaWFibGUpOiBVc2UgJ2Vz aGVsbC1pbmRpY2VzJy4gIEFsc28sIHJlbW92ZQppcnJlbGV2YW50IGNvbW1lbnQuCihlc2hl bGwtcGFyc2UtdmFyaWFibGUtcmVmKTogRml4IHF1b3RpbmcgaW4gZG9jc3RyaW5nLgooZXNo ZWxsLXBhcnNlLWluZGljZXMpOiBGaXggdHlwbyBpbiBkb2NzdHJpbmcuCgoqIHRlc3QvbGlz cC9lc2hlbGwvZXNoLXZhci10ZXN0cy5lbAooZXNoLXZhci10ZXN0L2ludGVycC12YXItaW5k aWNlcy1zdWJjb21tYW5kKQooZXNoLXZhci10ZXN0L3F1b3RlZC1pbnRlcnAtdmFyLWluZGlj ZXMtc3ViY29tbWFuZCk6IE5ldyB0ZXN0cy4KLS0tCiBsaXNwL2VzaGVsbC9lc2gtdmFyLmVs ICAgICAgICAgICAgfCAxNSArKysrKysrLS0tLS0tLS0KIHRlc3QvbGlzcC9lc2hlbGwvZXNo LXZhci10ZXN0cy5lbCB8IDI1ICsrKysrKysrKysrKysrKysrKysrKysrKysKIDIgZmlsZXMg Y2hhbmdlZCwgMzIgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9saXNwL2VzaGVsbC9lc2gtdmFyLmVsIGIvbGlzcC9lc2hlbGwvZXNoLXZhci5lbAppbmRl eCBmZDc2YTJjNmYwOS4uMmRhMzUyMjIwNDQgMTAwNjQ0Ci0tLSBhL2xpc3AvZXNoZWxsL2Vz aC12YXIuZWwKKysrIGIvbGlzcC9lc2hlbGwvZXNoLXZhci5lbApAQCAtNDY3LDkgKzQ2Nyw3 IEBAIGVzaGVsbC1wYXJzZS12YXJpYWJsZQogCSAgaW5kaWNlcyAoYW5kIChub3QgKGVvYnAp KQogCQkgICAgICAgKGVxIChjaGFyLWFmdGVyKSA/XFspCiAJCSAgICAgICAoZXNoZWxsLXBh cnNlLWluZGljZXMpKQotICAgICAgICAgIDs7IFRoaXMgaXMgYW4gZXhwcmVzc2lvbiB0aGF0 IHdpbGwgYmUgZXZhbHVhdGVkIGJ5IGBlc2hlbGwtZG8tZXZhbCcsCi0gICAgICAgICAgOzsg d2hpY2ggb25seSBzdXBwb3J0IGxldC1iaW5kaW5nIG9mIGR5bmFtaWNhbGx5LXNjb3BlZCB2 YXJzCi0JICB2YWx1ZSBgKGxldCAoKGluZGljZXMgKGVzaGVsbC1ldmFsLWluZGljZXMgJyxp bmRpY2VzKSkpICx2YWx1ZSkpCisgICAgICAgICAgdmFsdWUgYChsZXQgKChpbmRpY2VzICwo ZXNoZWxsLWluZGljZXMgaW5kaWNlcykpKSAsdmFsdWUpKQogICAgICh3aGVuIGdldC1sZW4K ICAgICAgIChzZXRxIHZhbHVlIGAobGVuZ3RoICx2YWx1ZSkpKQogICAgICh3aGVuIGVzaGVs bC1jdXJyZW50LXF1b3RlZApAQCAtNDk2LDcgKzQ5NCw3IEBAIGVzaGVsbC1wYXJzZS12YXJp YWJsZS1yZWYKIAogICBOQU1FICAgICAgICAgIGFuIGVudmlyb25tZW50IG9yIExpc3AgdmFy aWFibGUgdmFsdWUKICAgXCJMT05HLU5BTUVcIiAgIGRpc2FtYmlndWF0ZXMgdGhlIGxlbmd0 aCBvZiB0aGUgbmFtZQotICBgTE9ORy1OQU1FJyAgIGFzIGFib3ZlCisgIFxcPSdMT05HLU5B TUVcXD0nICAgYXMgYWJvdmUKICAge0NPTU1BTkR9ICAgICByZXN1bHQgb2YgY29tbWFuZCBp cyB2YXJpYWJsZSdzIHZhbHVlCiAgIChMSVNQLUZPUk0pICAgcmVzdWx0IG9mIExpc3AgZm9y bSBpcyB2YXJpYWJsZSdzIHZhbHVlCiAgIDxDT01NQU5EPiAgICAgd3JpdGUgdGhlIG91dHB1 dCBvZiBjb21tYW5kIHRvIGEgdGVtcG9yYXJ5IGZpbGU7CkBAIC01OTEsNyArNTg5LDcgQEAg ZXNoZWxsLXBhcnNlLWluZGljZXMKICAgIlBhcnNlIGFuZCByZXR1cm4gYSBsaXN0IG9mIGlu ZGV4LWxpc3RzLgogCiBGb3IgZXhhbXBsZSwgXCJbMCAxXVsyXVwiIGJlY29tZXM6Ci0gICgo XCIwXCIgXCIxXCIpIChcIjJcIikuIgorICAoKFwiMFwiIFwiMVwiKSAoXCIyXCIpKS4iCiAg IChsZXQgKGluZGljZXMpCiAgICAgKHdoaWxlIChlcSAoY2hhci1hZnRlcikgP1xbKQogICAg ICAgKGxldCAoKGVuZCAoZXNoZWxsLWZpbmQtZGVsaW1pdGVyID9cWyA/XF0pKSkKQEAgLTYw Nyw5ICs2MDUsMTAgQEAgZXNoZWxsLXBhcnNlLWluZGljZXMKIAkgIChnb3RvLWNoYXIgKDEr IGVuZCkpKSkpCiAgICAgKG5yZXZlcnNlIGluZGljZXMpKSkKIAotKGRlZnVuIGVzaGVsbC1l dmFsLWluZGljZXMgKGluZGljZXMpCi0gICJFdmFsdWF0ZSBJTkRJQ0VTLCBhIGxpc3Qgb2Yg aW5kZXgtbGlzdHMgZ2VuZXJhdGVkIGJ5IGBlc2hlbGwtcGFyc2UtaW5kaWNlcycuIgotICAo bWFwY2FyIChsYW1iZGEgKGkpIChtYXBjYXIgIydldmFsIGkpKSBpbmRpY2VzKSkKKyhkZWZ1 biBlc2hlbGwtaW5kaWNlcyAoaW5kaWNlcykKKyAgIlByZXBhcmUgSU5ESUNFUyB0byBiZSBl dmFsdWF0ZWQgYnkgRXNoZWxsLgorSU5ESUNFUyBpcyBhIGxpc3Qgb2YgaW5kZXgtbGlzdHMg Z2VuZXJhdGVkIGJ5IGBlc2hlbGwtcGFyc2UtaW5kaWNlcycuIgorICBgKGxpc3QgLEAobWFw Y2FyIChsYW1iZGEgKGlkeC1saXN0KSAoY29ucyAnbGlzdCBpZHgtbGlzdCkpIGluZGljZXMp KSkKIAogKGRlZnVuIGVzaGVsbC1nZXQtdmFyaWFibGUgKG5hbWUgJm9wdGlvbmFsIGluZGlj ZXMgcXVvdGVkKQogICAiR2V0IHRoZSB2YWx1ZSBmb3IgdGhlIHZhcmlhYmxlIE5BTUUuCmRp ZmYgLS1naXQgYS90ZXN0L2xpc3AvZXNoZWxsL2VzaC12YXItdGVzdHMuZWwgYi90ZXN0L2xp c3AvZXNoZWxsL2VzaC12YXItdGVzdHMuZWwKaW5kZXggMGNjMWI5MjI2NmYuLjgyMzI0ZDcy MTYzIDEwMDY0NAotLS0gYS90ZXN0L2xpc3AvZXNoZWxsL2VzaC12YXItdGVzdHMuZWwKKysr IGIvdGVzdC9saXNwL2VzaGVsbC9lc2gtdmFyLXRlc3RzLmVsCkBAIC04Miw2ICs4MiwxNyBA QCBlc2gtdmFyLXRlc3QvaW50ZXJwLXZhci1pbmRpY2VzCiAgICAgKGVzaGVsbC1jb21tYW5k LXJlc3VsdC1lcXVhbCAiZWNobyAkZXNoZWxsLXRlc3QtdmFsdWVbMCAyIDRdIgogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgJygiemVybyIgInR3byIgImZvdXIiKSkpKQog CisoZXJ0LWRlZnRlc3QgZXNoLXZhci10ZXN0L2ludGVycC12YXItaW5kaWNlcy1zdWJjb21t YW5kICgpCisgICJJbnRlcnBvbGF0ZSBsaXN0IHZhcmlhYmxlIHdpdGggc3ViY29tbWFuZCBl eHBhbnNpb24gZm9yIGluZGljZXMiCisgIChza2lwLXVubGVzcyAoZXhlY3V0YWJsZS1maW5k ICJlY2hvIikpCisgIChsZXQgKChlc2hlbGwtdGVzdC12YWx1ZSAnKCJ6ZXJvIiAib25lIiAi dHdvIiAidGhyZWUiICJmb3VyIikpKQorICAgIChlc2hlbGwtY29tbWFuZC1yZXN1bHQtZXF1 YWwKKyAgICAgImVjaG8gJGVzaGVsbC10ZXN0LXZhbHVlWyR7KmVjaG8gMH1dIgorICAgICAi emVybyIpCisgICAgKGVzaGVsbC1jb21tYW5kLXJlc3VsdC1lcXVhbAorICAgICAiZWNobyAk ZXNoZWxsLXRlc3QtdmFsdWVbJHsqZWNobyAwfSAkeyplY2hvIDJ9XSIKKyAgICAgJygiemVy byIgInR3byIpKSkpCisKIChlcnQtZGVmdGVzdCBlc2gtdmFyLXRlc3QvaW50ZXJwLXZhci1z cGxpdC1pbmRpY2VzICgpCiAgICJJbnRlcnBvbGF0ZSBzdHJpbmcgdmFyaWFibGUgd2l0aCBp bmRpY2VzIgogICAobGV0ICgoZXNoZWxsLXRlc3QtdmFsdWUgInplcm8gb25lIHR3byB0aHJl ZSBmb3VyIikpCkBAIC0yNzEsNiArMjgyLDIwIEBAIGVzaC12YXItdGVzdC9xdW90ZWQtaW50 ZXJwLXZhci1pbmRpY2VzCiAgICAgKGVzaGVsbC1jb21tYW5kLXJlc3VsdC1lcXVhbCAiZWNo byBcIiRlc2hlbGwtdGVzdC12YWx1ZVsxIDIgNF1cIiIKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICIoXCJvbmVcIiBcInR3b1wiIFwiZm91clwiKSIpKSkKIAorKGVydC1k ZWZ0ZXN0IGVzaC12YXItdGVzdC9xdW90ZS1pbnRlcnAtdmFyLWluZGljZXMtc3ViY29tbWFu ZCAoKQorICAiSW50ZXJwb2xhdGUgbGlzdCB2YXJpYWJsZSB3aXRoIHN1YmNvbW1hbmQgZXhw YW5zaW9uIGZvciBpbmRpY2VzCitpbnNpZGUgZG91YmxlLXF1b3RlcyIKKyAgKHNraXAtdW5s ZXNzIChleGVjdXRhYmxlLWZpbmQgImVjaG8iKSkKKyAgKGxldCAoKGVzaGVsbC10ZXN0LXZh bHVlICcoInplcm8iICJvbmUiICJ0d28iICJ0aHJlZSIgImZvdXIiKSkpCisgICAgKGVzaGVs bC1jb21tYW5kLXJlc3VsdC1lcXVhbAorICAgICAiZWNobyBcIiRlc2hlbGwtdGVzdC12YWx1 ZVskeyplY2hvIDB9XVwiIgorICAgICAiemVybyIpCisgICAgOzsgRklYTUU6IFRoZXNlIHRl c3RzIHdvdWxkIHVzZSB0aGUgMHRoIGluZGV4IGxpa2UgdGhlIG90aGVyIHRlc3RzCisgICAg OzsgaGVyZSwgYnV0IHNlZSBhYm92ZS4KKyAgICAoZXNoZWxsLWNvbW1hbmQtcmVzdWx0LWVx dWFsCisgICAgICJlY2hvIFwiJGVzaGVsbC10ZXN0LXZhbHVlWyR7KmVjaG8gMX0gJHsqZWNo byAyfV1cIiIKKyAgICAgIihcIm9uZVwiIFwidHdvXCIpIikpKQorCiAoZXJ0LWRlZnRlc3Qg ZXNoLXZhci10ZXN0L3F1b3RlZC1pbnRlcnAtdmFyLXNwbGl0LWluZGljZXMgKCkKICAgIklu dGVycG9sYXRlIHN0cmluZyB2YXJpYWJsZSB3aXRoIGluZGljZXMgaW5zaWRlIGRvdWJsZS1x dW90ZXMiCiAgIChsZXQgKChlc2hlbGwtdGVzdC12YWx1ZSAiemVybyBvbmUgdHdvIHRocmVl IGZvdXIiKSkKLS0gCjIuMjUuMQoK --------------xJwvNFB70b1KdAYIWSk6pdhL-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 19 01:49:31 2023 Received: (at 60942) by debbugs.gnu.org; 19 Jan 2023 06:49:31 +0000 Received: from localhost ([127.0.0.1]:42396 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIOjq-0005wJ-Mp for submit@debbugs.gnu.org; Thu, 19 Jan 2023 01:49:30 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIOjo-0005w6-94 for 60942@debbugs.gnu.org; Thu, 19 Jan 2023 01:49:28 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIOji-0006gO-Oy; Thu, 19 Jan 2023 01:49:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=BGp/B4Ss+VlsXZn7yJBX88tWICobivqVgwInBdggwwE=; b=lPZIdbshqbPH UnlyB5sm19nOHsY0nGNugV4eUlYKO/7n3IPsRiAlkrsTACgQpwO+OjXMVuvwkOZ/5GA3LFlKoqZWc v7f3k1Cp1xXfWc7VRIc4TLSoCJBYmKuF38epEgQwzs7VKkXnO/WaGRgYhVp98FOgej0dzCZRLDoJU h3lKKvsfo8u+bCnrmu55OPOXXVbL6NLf0+og6+N1thcyJI07YMYYYLLkG8dMFg71OhJsiUGGN1ABA j26Lew/3OOV35HHMjIONVVfSpFPOzVDhN9TrlguCeIEvnte3PwKSti5i0F+PwBDoLzmk6GpHWJRk5 qRl1dFbvyp2WsKZ+hdFjhg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIOjf-0008Tw-UP; Thu, 19 Jan 2023 01:49:21 -0500 Date: Thu, 19 Jan 2023 08:49:34 +0200 Message-Id: <83wn5jyq69.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: <20e5cb2f-aabe-53fd-d3af-81ec5ff11e7b@gmail.com> (message from Jim Porter on Wed, 18 Jan 2023 19:36:41 -0800) Subject: Re: bug#60942: 30.0.50; [PATCH] Indices in Eshell variable interpolation don't work with async subcommands References: <20e5cb2f-aabe-53fd-d3af-81ec5ff11e7b@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60942 Cc: 60942@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 18 Jan 2023 19:36:41 -0800 > From: Jim Porter > > Starting from "emacs -Q -f eshell": > > ~ $ echo $exec-path[0] > /usr/local/sbin > ~ $ echo $exec-path[${echo 0}] > /usr/local/sbin > ~ $ echo $exec-path[${*echo 0}] > ;; no output > > This is because 'eshell-eval-indices' gets an S-expr describing code to > evaluate for the indices, and it just passes that to 'eval'. That's not > the right way to do things for Eshell: instead, we should rely on > 'eshell-do-eval', which properly handles asynchronous evaluation. That's > required for working with external commands like "*echo" (which calls > the real /bin/echo). > > The attached patch fixes this by changing 'eshell-eval-indices' to > 'eshell-indices', which does some minimal transformations on the S-expr > for the indices, and then uses it to build the final S-expr to pass to > 'eshell-do-eval'. > > This could possibly go in Emacs 29, since it's a bugfix to add onto a > previous bugfix (see commit 990f36fa10). However, I'd lean towards just > merging to master; this is a fairly obscure issue, and we can't just fix > *every* bug we find on the release branch, or the branch will never > stabilize. If someone else thinks it's important enough to go on the > release branch though, I won't argue. Why do you remove a non-internal function? We cannot possibly do that if this is going to be installed on the emacs-29 branch. But even if you are going to install on master, why not leave that function alone? Some code somewhere could be using it, and we don't usually remove functions before a period of deprecation. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 19 02:37:21 2023 Received: (at 60942) by debbugs.gnu.org; 19 Jan 2023 07:37:21 +0000 Received: from localhost ([127.0.0.1]:42436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIPU8-00075A-ND for submit@debbugs.gnu.org; Thu, 19 Jan 2023 02:37:20 -0500 Received: from mail-pj1-f41.google.com ([209.85.216.41]:56098) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIPU6-00074x-N6 for 60942@debbugs.gnu.org; Thu, 19 Jan 2023 02:37:19 -0500 Received: by mail-pj1-f41.google.com with SMTP id dw9so1532785pjb.5 for <60942@debbugs.gnu.org>; Wed, 18 Jan 2023 23:37:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=4RAAkoBlpg2kwTgnXMvVzeh1me1PavRuGrXvRIxOH/I=; b=jwB7Hw6ILINRsqvQoy83pvwhi9/FPEZjY7ndM03zaHsokpALHtc9ygmhQjN/XOVE4K s1Jf1CmDadqVEe0HA65+LlMqYK7ODxeEDDNJFtuY0BNXy6O4Pxzly1VLEgcdM9Y68kg6 rdaTw9kE+Xpzgf2caQcP2ggWvH/bM/FBAkDzxL4lCzb9Rj04+9OQmW+um5LXAgmYlHTy Es7sOy3bInscy00F0Wk8N1/kFqCAioa7LSbB7P7Iu+yiDeof20WUkjkuxIf/E4U2jYm9 wJSoC1T0aHx7DrWc2jIlEWULYqwypwf6tmNvsuuo7PzNto8UFNvXErPAhCKYCQG2RDO2 ay2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4RAAkoBlpg2kwTgnXMvVzeh1me1PavRuGrXvRIxOH/I=; b=sBKS42ImTb6oOFMPkuU4d484lrhn+6ZvBaZNrj2EqZDsq2mclBGpUGHVHGxjNXe93E AspiJ05xyizJSd53PwV/jxYB7i9mZZC4hb6vZ5bE5chBOTyWpSfS2sb3QSB5QHQb1uDc S7HA10i3J0Cx++WAOPNUVZ0heaxrFoatJ2M1p7f8s63YOGEWbcogR0Sf//niv5ns3vFS vznK7Ph7d0f8iDUaHmVmuisInD8rGKh2GQ3vk9tMmkO+ROYE7eN4Da+VtinkRU67iu4W 1emr0veMgM8+vZ19/3TT0uHSibXkWWhJprR+mH8Nh8ayKtvk1Eap1BwTbqdSJZqozWXJ j+UA== X-Gm-Message-State: AFqh2kpugO8v1e2DQeNsRqL3ZlPzcAd3kSMOVgoAfV0h2prjzTgQeGP9 B661X9w6N/Ynxg7f0fegxRvVGdMFq+LW3g== X-Google-Smtp-Source: AMrXdXtTevWd0Q5l1z0C8JwPO/cm9bOnL4GBv0jMrgzmxiBNgTyjwf7cyknzoqCJ317prh2c8yR2jg== X-Received: by 2002:a17:90a:f606:b0:228:f6cc:dc4f with SMTP id bw6-20020a17090af60600b00228f6ccdc4fmr10385272pjb.10.1674113832653; Wed, 18 Jan 2023 23:37:12 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id c22-20020a6566d6000000b0045dc85c4a5fsm16379331pgw.44.2023.01.18.23.37.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Jan 2023 23:37:12 -0800 (PST) Message-ID: Date: Wed, 18 Jan 2023 23:37:12 -0800 MIME-Version: 1.0 Subject: Re: bug#60942: 30.0.50; [PATCH] Indices in Eshell variable interpolation don't work with async subcommands Content-Language: en-US To: Eli Zaretskii References: <20e5cb2f-aabe-53fd-d3af-81ec5ff11e7b@gmail.com> <83wn5jyq69.fsf@gnu.org> From: Jim Porter In-Reply-To: <83wn5jyq69.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60942 Cc: 60942@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 1/18/2023 10:49 PM, Eli Zaretskii wrote: > Why do you remove a non-internal function? We cannot possibly do that > if this is going to be installed on the emacs-29 branch. But even if > you are going to install on master, why not leave that function alone? > Some code somewhere could be using it, and we don't usually remove > functions before a period of deprecation. I can keep 'eshell-eval-indices' around and mark it obsolete if you prefer; it wouldn't hurt anything. I could also fix this bug in that function, though it would be an inferior fix compared to the new 'eshell-indices' function, so we definitely want that new function (or something very similar). I'm not sure fixing 'eshell-eval-indices' is worth it though, since I'd be very surprised if anyone called that function directly. For context, 'eshell-eval-indices' is a function I added in Emacs 29 to fix some related issues with indices[1], but at the time I didn't fully understand Eshell's internals and so implemented the fix incorrectly (though it works for most common cases). It probably could have been marked as internal at the time, but Eshell doesn't seem to do that regularly, even for functions that external code would be very unlikely to find useful. [1] In particular, the second case in my original message fails even more severely in Emacs 28: ~/config $ echo $exec-path[${echo 0}] Wrong type argument: number-or-marker-p, (eshell-escape-arg (let ((indices 'nil)) (eshell-convert (eshell-command-to-value (eshell-as-subcommand (eshell-trap-errors (eshell-named-command "echo" (list #("0" 0 1 (number t)))))))))) From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 19 14:31:35 2023 Received: (at 60942) by debbugs.gnu.org; 19 Jan 2023 19:31:36 +0000 Received: from localhost ([127.0.0.1]:44770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIadL-0006SN-FL for submit@debbugs.gnu.org; Thu, 19 Jan 2023 14:31:35 -0500 Received: from mail-pf1-f170.google.com ([209.85.210.170]:38693) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIadJ-0006SA-DH for 60942@debbugs.gnu.org; Thu, 19 Jan 2023 14:31:34 -0500 Received: by mail-pf1-f170.google.com with SMTP id 207so2302545pfv.5 for <60942@debbugs.gnu.org>; Thu, 19 Jan 2023 11:31:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=EhtkYEPcUIIG8H1J5y1DERgLO1zYEm23pI9DXTeyC9c=; b=eAQ9iHdv70x21mh8fThJxdTAgJP/RZLiDA4k9e/3DmGgnyQbqXqSoRsSzcgWL9n3dW x/CmmyXmpgy88hh7r8N3Cak9fY3JyygwMiIExMnGHXyjwsKMZPeEHqQ4u9okNHVFWyiC hPuYnUKDEnDKXGRospVXFDy5N3Ga8uoPNznYmBz0h/Xs9Bnw/jvgY4ddYi4s6nA9m1Dp b5aF1OTHpUVVOT/MpZnbrzUmPhqyGEr6UQJgHvghSQTFcNy7Gm8AckRDjPiazaGNm8h5 /G7sUsHkrigYWWl+kea3uIOGNR3oJXmwrXoeNKGIfHeG7KxgX9PZkxfB/0PWlHxckjHJ mI5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=EhtkYEPcUIIG8H1J5y1DERgLO1zYEm23pI9DXTeyC9c=; b=l+pCBCNOAwhDw1ZZ+SuP4c7cwoE/feKLpi/Obtt2jk6myXVhhOWxnnI4l0pJqqTo0S UNEegNEltjbIIOFGX9Nj9zUQq5oC/czjfIyKeeFfRH9x05JmUuunwgDW+PX7LFFHZDS8 3n9uZuDwx9NHQFPvJRPJ+WJIgnbD1K7kseDysnjxyDA1Yu0cmgac62O98Sx8kbnTFeUo p5ZCuoEcIellvC0kItmqTchHkT/QL5QVBEn9L+Rz/eMr/NbVPOcSkp99a9f3EKWpx52b pYZlaIVgoPzDyEnK7V95Et3U+4tx6Nb8e0OLwFK59mkllO2z8m0YQax3J805VhuFBMaZ GYlA== X-Gm-Message-State: AFqh2krykYYjj0JgYF32eViWymT50p1MAM96lj4N3k3hj3Fq7/FOAp0K J3y3bCUBoHtO8DEjmp1UuMA= X-Google-Smtp-Source: AMrXdXs5oggRL9xS/MnXfbdBJj3j3hIwZfKhaNLVVTPtUbaCYhkxGeo9SWzOCmPl83oFWQUu4vPrxw== X-Received: by 2002:a05:6a00:b53:b0:574:a541:574a with SMTP id p19-20020a056a000b5300b00574a541574amr16695026pfo.0.1674156687530; Thu, 19 Jan 2023 11:31:27 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id b20-20020aa79514000000b0058d91fb2239sm9365720pfp.63.2023.01.19.11.31.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Jan 2023 11:31:26 -0800 (PST) Content-Type: multipart/mixed; boundary="------------6gLveoTpwVyhVOUH80ctPzV5" Message-ID: Date: Thu, 19 Jan 2023 11:31:24 -0800 MIME-Version: 1.0 Subject: Re: bug#60942: 30.0.50; [PATCH] Indices in Eshell variable interpolation don't work with async subcommands Content-Language: en-US From: Jim Porter To: Eli Zaretskii References: <20e5cb2f-aabe-53fd-d3af-81ec5ff11e7b@gmail.com> <83wn5jyq69.fsf@gnu.org> In-Reply-To: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60942 Cc: 60942@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------6gLveoTpwVyhVOUH80ctPzV5 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 1/18/2023 11:37 PM, Jim Porter wrote: > On 1/18/2023 10:49 PM, Eli Zaretskii wrote: >> Why do you remove a non-internal function?  We cannot possibly do that >> if this is going to be installed on the emacs-29 branch.  But even if >> you are going to install on master, why not leave that function alone? >> Some code somewhere could be using it, and we don't usually remove >> functions before a period of deprecation. > > I can keep 'eshell-eval-indices' around and mark it obsolete if you > prefer; it wouldn't hurt anything. Here's a patch that does this. It doesn't try to fix 'eshell-eval-indices', since people shouldn't use that anyway. (I also renamed the new 'eshell-indices' to 'eshell-prepare-indices' to be clearer.) --------------6gLveoTpwVyhVOUH80ctPzV5 Content-Type: text/plain; charset=UTF-8; name="0001-Fix-evaluation-of-asynchronous-expansions-in-Eshell-.patch" Content-Disposition: attachment; filename*0="0001-Fix-evaluation-of-asynchronous-expansions-in-Eshell-.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA0Y2MxNDY0NmE1MGIyMzdkMzhjZmI2NjQzODU4Y2IzNzkzNjYxNDFhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFdlZCwgMTggSmFuIDIwMjMgMTk6MTU6MzggLTA4MDAKU3ViamVjdDogW1BB VENIXSBGaXggZXZhbHVhdGlvbiBvZiBhc3luY2hyb25vdXMgZXhwYW5zaW9ucyBpbiBFc2hl bGwgaW5kaWNlcwoKUHJldmlvdXNseSwgdGhpcyBjb2RlIHBhc3NlZCB0aGUgaW5kaWNlcyB0 byBhIHNlcGFyYXRlIGZ1bmN0aW9uLCB3aGljaApjYWxsZWQgJ2V2YWwnIG9uIHRoZW0sIGJ1 dCBpdCBzaG91bGQgaW5zdGVhZCBtYWtlIGFuIFMtZXhwciB0aGF0Cidlc2hlbGwtZG8tZXZh bCcgY2FuIGV2YWx1YXRlLgoKKiBsaXNwL2VzaGVsbC9lc2gtdmFyLmVsIChlc2hlbGwtZXZh bC1pbmRpY2VzKTogTWFyayBvYnNvbGV0ZS4KKGVzaGVsbC1wcmVwYXJlLWluZGljZXMpOiBO ZXcgZnVuY3Rpb24uLi4KKGVzaGVsbC1wYXJzZS12YXJpYWJsZSk6IC4uLiB1c2UgaXQuICBB bHNvLCByZW1vdmUgaXJyZWxldmFudCBjb21tZW50LgooZXNoZWxsLXBhcnNlLXZhcmlhYmxl LXJlZik6IEZpeCBxdW90aW5nIGluIGRvY3N0cmluZy4KKGVzaGVsbC1wYXJzZS1pbmRpY2Vz KTogRml4IHR5cG8gaW4gZG9jc3RyaW5nLgoKKiB0ZXN0L2xpc3AvZXNoZWxsL2VzaC12YXIt dGVzdHMuZWwKKGVzaC12YXItdGVzdC9pbnRlcnAtdmFyLWluZGljZXMtc3ViY29tbWFuZCkK KGVzaC12YXItdGVzdC9xdW90ZWQtaW50ZXJwLXZhci1pbmRpY2VzLXN1YmNvbW1hbmQpOiBO ZXcgdGVzdHMuCi0tLQogbGlzcC9lc2hlbGwvZXNoLXZhci5lbCAgICAgICAgICAgIHwgMTQg KysrKysrKysrLS0tLS0KIHRlc3QvbGlzcC9lc2hlbGwvZXNoLXZhci10ZXN0cy5lbCB8IDI1 ICsrKysrKysrKysrKysrKysrKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMzQgaW5zZXJ0 aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL2VzaGVsbC9lc2gt dmFyLmVsIGIvbGlzcC9lc2hlbGwvZXNoLXZhci5lbAppbmRleCBmZDc2YTJjNmYwOS4uMDk5 OGZjNmI4NmEgMTAwNjQ0Ci0tLSBhL2xpc3AvZXNoZWxsL2VzaC12YXIuZWwKKysrIGIvbGlz cC9lc2hlbGwvZXNoLXZhci5lbApAQCAtNDY3LDkgKzQ2Nyw3IEBAIGVzaGVsbC1wYXJzZS12 YXJpYWJsZQogCSAgaW5kaWNlcyAoYW5kIChub3QgKGVvYnApKQogCQkgICAgICAgKGVxIChj aGFyLWFmdGVyKSA/XFspCiAJCSAgICAgICAoZXNoZWxsLXBhcnNlLWluZGljZXMpKQotICAg ICAgICAgIDs7IFRoaXMgaXMgYW4gZXhwcmVzc2lvbiB0aGF0IHdpbGwgYmUgZXZhbHVhdGVk IGJ5IGBlc2hlbGwtZG8tZXZhbCcsCi0gICAgICAgICAgOzsgd2hpY2ggb25seSBzdXBwb3J0 IGxldC1iaW5kaW5nIG9mIGR5bmFtaWNhbGx5LXNjb3BlZCB2YXJzCi0JICB2YWx1ZSBgKGxl dCAoKGluZGljZXMgKGVzaGVsbC1ldmFsLWluZGljZXMgJyxpbmRpY2VzKSkpICx2YWx1ZSkp CisgICAgICAgICAgdmFsdWUgYChsZXQgKChpbmRpY2VzICwoZXNoZWxsLXByZXBhcmUtaW5k aWNlcyBpbmRpY2VzKSkpICx2YWx1ZSkpCiAgICAgKHdoZW4gZ2V0LWxlbgogICAgICAgKHNl dHEgdmFsdWUgYChsZW5ndGggLHZhbHVlKSkpCiAgICAgKHdoZW4gZXNoZWxsLWN1cnJlbnQt cXVvdGVkCkBAIC00OTYsNyArNDk0LDcgQEAgZXNoZWxsLXBhcnNlLXZhcmlhYmxlLXJlZgog CiAgIE5BTUUgICAgICAgICAgYW4gZW52aXJvbm1lbnQgb3IgTGlzcCB2YXJpYWJsZSB2YWx1 ZQogICBcIkxPTkctTkFNRVwiICAgZGlzYW1iaWd1YXRlcyB0aGUgbGVuZ3RoIG9mIHRoZSBu YW1lCi0gIGBMT05HLU5BTUUnICAgYXMgYWJvdmUKKyAgXFw9J0xPTkctTkFNRVxcPScgICBh cyBhYm92ZQogICB7Q09NTUFORH0gICAgIHJlc3VsdCBvZiBjb21tYW5kIGlzIHZhcmlhYmxl J3MgdmFsdWUKICAgKExJU1AtRk9STSkgICByZXN1bHQgb2YgTGlzcCBmb3JtIGlzIHZhcmlh YmxlJ3MgdmFsdWUKICAgPENPTU1BTkQ+ICAgICB3cml0ZSB0aGUgb3V0cHV0IG9mIGNvbW1h bmQgdG8gYSB0ZW1wb3JhcnkgZmlsZTsKQEAgLTU5MSw3ICs1ODksNyBAQCBlc2hlbGwtcGFy c2UtaW5kaWNlcwogICAiUGFyc2UgYW5kIHJldHVybiBhIGxpc3Qgb2YgaW5kZXgtbGlzdHMu CiAKIEZvciBleGFtcGxlLCBcIlswIDFdWzJdXCIgYmVjb21lczoKLSAgKChcIjBcIiBcIjFc IikgKFwiMlwiKS4iCisgICgoXCIwXCIgXCIxXCIpIChcIjJcIikpLiIKICAgKGxldCAoaW5k aWNlcykKICAgICAod2hpbGUgKGVxIChjaGFyLWFmdGVyKSA/XFspCiAgICAgICAobGV0ICgo ZW5kIChlc2hlbGwtZmluZC1kZWxpbWl0ZXIgP1xbID9cXSkpKQpAQCAtNjA5LDggKzYwNywx NCBAQCBlc2hlbGwtcGFyc2UtaW5kaWNlcwogCiAoZGVmdW4gZXNoZWxsLWV2YWwtaW5kaWNl cyAoaW5kaWNlcykKICAgIkV2YWx1YXRlIElORElDRVMsIGEgbGlzdCBvZiBpbmRleC1saXN0 cyBnZW5lcmF0ZWQgYnkgYGVzaGVsbC1wYXJzZS1pbmRpY2VzJy4iCisgIChkZWNsYXJlIChv YnNvbGV0ZSBlc2hlbGwtcHJlcGFyZS1pbmRpY2VzICIzMC4xIikpCiAgIChtYXBjYXIgKGxh bWJkYSAoaSkgKG1hcGNhciAjJ2V2YWwgaSkpIGluZGljZXMpKQogCisoZGVmdW4gZXNoZWxs LXByZXBhcmUtaW5kaWNlcyAoaW5kaWNlcykKKyAgIlByZXBhcmUgSU5ESUNFUyB0byBiZSBl dmFsdWF0ZWQgYnkgRXNoZWxsLgorSU5ESUNFUyBpcyBhIGxpc3Qgb2YgaW5kZXgtbGlzdHMg Z2VuZXJhdGVkIGJ5IGBlc2hlbGwtcGFyc2UtaW5kaWNlcycuIgorICBgKGxpc3QgLEAobWFw Y2FyIChsYW1iZGEgKGlkeC1saXN0KSAoY29ucyAnbGlzdCBpZHgtbGlzdCkpIGluZGljZXMp KSkKKwogKGRlZnVuIGVzaGVsbC1nZXQtdmFyaWFibGUgKG5hbWUgJm9wdGlvbmFsIGluZGlj ZXMgcXVvdGVkKQogICAiR2V0IHRoZSB2YWx1ZSBmb3IgdGhlIHZhcmlhYmxlIE5BTUUuCiBJ TkRJQ0VTIGlzIGEgbGlzdCBvZiBpbmRleC1saXN0cyAoc2VlIGBlc2hlbGwtcGFyc2UtaW5k aWNlcycpLgpkaWZmIC0tZ2l0IGEvdGVzdC9saXNwL2VzaGVsbC9lc2gtdmFyLXRlc3RzLmVs IGIvdGVzdC9saXNwL2VzaGVsbC9lc2gtdmFyLXRlc3RzLmVsCmluZGV4IDBjYzFiOTIyNjZm Li44MjMyNGQ3MjE2MyAxMDA2NDQKLS0tIGEvdGVzdC9saXNwL2VzaGVsbC9lc2gtdmFyLXRl c3RzLmVsCisrKyBiL3Rlc3QvbGlzcC9lc2hlbGwvZXNoLXZhci10ZXN0cy5lbApAQCAtODIs NiArODIsMTcgQEAgZXNoLXZhci10ZXN0L2ludGVycC12YXItaW5kaWNlcwogICAgIChlc2hl bGwtY29tbWFuZC1yZXN1bHQtZXF1YWwgImVjaG8gJGVzaGVsbC10ZXN0LXZhbHVlWzAgMiA0 XSIKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICcoInplcm8iICJ0d28iICJm b3VyIikpKSkKIAorKGVydC1kZWZ0ZXN0IGVzaC12YXItdGVzdC9pbnRlcnAtdmFyLWluZGlj ZXMtc3ViY29tbWFuZCAoKQorICAiSW50ZXJwb2xhdGUgbGlzdCB2YXJpYWJsZSB3aXRoIHN1 YmNvbW1hbmQgZXhwYW5zaW9uIGZvciBpbmRpY2VzIgorICAoc2tpcC11bmxlc3MgKGV4ZWN1 dGFibGUtZmluZCAiZWNobyIpKQorICAobGV0ICgoZXNoZWxsLXRlc3QtdmFsdWUgJygiemVy byIgIm9uZSIgInR3byIgInRocmVlIiAiZm91ciIpKSkKKyAgICAoZXNoZWxsLWNvbW1hbmQt cmVzdWx0LWVxdWFsCisgICAgICJlY2hvICRlc2hlbGwtdGVzdC12YWx1ZVskeyplY2hvIDB9 XSIKKyAgICAgInplcm8iKQorICAgIChlc2hlbGwtY29tbWFuZC1yZXN1bHQtZXF1YWwKKyAg ICAgImVjaG8gJGVzaGVsbC10ZXN0LXZhbHVlWyR7KmVjaG8gMH0gJHsqZWNobyAyfV0iCisg ICAgICcoInplcm8iICJ0d28iKSkpKQorCiAoZXJ0LWRlZnRlc3QgZXNoLXZhci10ZXN0L2lu dGVycC12YXItc3BsaXQtaW5kaWNlcyAoKQogICAiSW50ZXJwb2xhdGUgc3RyaW5nIHZhcmlh YmxlIHdpdGggaW5kaWNlcyIKICAgKGxldCAoKGVzaGVsbC10ZXN0LXZhbHVlICJ6ZXJvIG9u ZSB0d28gdGhyZWUgZm91ciIpKQpAQCAtMjcxLDYgKzI4MiwyMCBAQCBlc2gtdmFyLXRlc3Qv cXVvdGVkLWludGVycC12YXItaW5kaWNlcwogICAgIChlc2hlbGwtY29tbWFuZC1yZXN1bHQt ZXF1YWwgImVjaG8gXCIkZXNoZWxsLXRlc3QtdmFsdWVbMSAyIDRdXCIiCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAiKFwib25lXCIgXCJ0d29cIiBcImZvdXJcIikiKSkp CiAKKyhlcnQtZGVmdGVzdCBlc2gtdmFyLXRlc3QvcXVvdGUtaW50ZXJwLXZhci1pbmRpY2Vz LXN1YmNvbW1hbmQgKCkKKyAgIkludGVycG9sYXRlIGxpc3QgdmFyaWFibGUgd2l0aCBzdWJj b21tYW5kIGV4cGFuc2lvbiBmb3IgaW5kaWNlcworaW5zaWRlIGRvdWJsZS1xdW90ZXMiCisg IChza2lwLXVubGVzcyAoZXhlY3V0YWJsZS1maW5kICJlY2hvIikpCisgIChsZXQgKChlc2hl bGwtdGVzdC12YWx1ZSAnKCJ6ZXJvIiAib25lIiAidHdvIiAidGhyZWUiICJmb3VyIikpKQor ICAgIChlc2hlbGwtY29tbWFuZC1yZXN1bHQtZXF1YWwKKyAgICAgImVjaG8gXCIkZXNoZWxs LXRlc3QtdmFsdWVbJHsqZWNobyAwfV1cIiIKKyAgICAgInplcm8iKQorICAgIDs7IEZJWE1F OiBUaGVzZSB0ZXN0cyB3b3VsZCB1c2UgdGhlIDB0aCBpbmRleCBsaWtlIHRoZSBvdGhlciB0 ZXN0cworICAgIDs7IGhlcmUsIGJ1dCBzZWUgYWJvdmUuCisgICAgKGVzaGVsbC1jb21tYW5k LXJlc3VsdC1lcXVhbAorICAgICAiZWNobyBcIiRlc2hlbGwtdGVzdC12YWx1ZVskeyplY2hv IDF9ICR7KmVjaG8gMn1dXCIiCisgICAgICIoXCJvbmVcIiBcInR3b1wiKSIpKSkKKwogKGVy dC1kZWZ0ZXN0IGVzaC12YXItdGVzdC9xdW90ZWQtaW50ZXJwLXZhci1zcGxpdC1pbmRpY2Vz ICgpCiAgICJJbnRlcnBvbGF0ZSBzdHJpbmcgdmFyaWFibGUgd2l0aCBpbmRpY2VzIGluc2lk ZSBkb3VibGUtcXVvdGVzIgogICAobGV0ICgoZXNoZWxsLXRlc3QtdmFsdWUgInplcm8gb25l IHR3byB0aHJlZSBmb3VyIikpCi0tIAoyLjI1LjEKCg== --------------6gLveoTpwVyhVOUH80ctPzV5-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 19 14:41:50 2023 Received: (at 60942) by debbugs.gnu.org; 19 Jan 2023 19:41:50 +0000 Received: from localhost ([127.0.0.1]:44788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIanF-0006h5-Q7 for submit@debbugs.gnu.org; Thu, 19 Jan 2023 14:41:50 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIanD-0006go-46 for 60942@debbugs.gnu.org; Thu, 19 Jan 2023 14:41:48 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIan7-0004vY-Rm; Thu, 19 Jan 2023 14:41:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=EV3rBW8xHYXaph4qaU3Avf8TEs6kHNKs3127aL9rOoA=; b=CVuGfbzap7YT5OvtQJte sEzXSaVp17Un5h1KcVHZ9iqIC8GzVDyfU91EMtaKbJdAoijgHWGldZy+YdGG4nB2udthT8VqxNhni Me5cLt+oDKJjb5yuTWcKwLNqgEzQMK3w+VYTCpiJKAHuUdrJfqlbfdlOoDKL5zKT8kyI+ArYXk3uA kTJfq8WCkZsGDyo6rON77mUdu/8nAOkyfO7Y8D5FKhvimWsfcAXALoHi/lhbetVQkju2H4D/U8w/P 9Nvkp8jHerW4jWIjEhOF+/Sqj/9LC4sDcvAhXwHtvttMQm4hIHkf2wCvOTrYf2k4FIOWgqmLgG5zB IrQOZKiR/FQlkQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIan3-0004BP-8M; Thu, 19 Jan 2023 14:41:38 -0500 Date: Thu, 19 Jan 2023 21:41:34 +0200 Message-Id: <83o7qunwgh.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: (message from Jim Porter on Thu, 19 Jan 2023 11:31:24 -0800) Subject: Re: bug#60942: 30.0.50; [PATCH] Indices in Eshell variable interpolation don't work with async subcommands References: <20e5cb2f-aabe-53fd-d3af-81ec5ff11e7b@gmail.com> <83wn5jyq69.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60942 Cc: 60942@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 19 Jan 2023 11:31:24 -0800 > From: Jim Porter > Cc: 60942@debbugs.gnu.org > > On 1/18/2023 11:37 PM, Jim Porter wrote: > > On 1/18/2023 10:49 PM, Eli Zaretskii wrote: > >> Why do you remove a non-internal function?  We cannot possibly do that > >> if this is going to be installed on the emacs-29 branch.  But even if > >> you are going to install on master, why not leave that function alone? > >> Some code somewhere could be using it, and we don't usually remove > >> functions before a period of deprecation. > > > > I can keep 'eshell-eval-indices' around and mark it obsolete if you > > prefer; it wouldn't hurt anything. > > Here's a patch that does this. It doesn't try to fix > 'eshell-eval-indices', since people shouldn't use that anyway. (I also > renamed the new 'eshell-indices' to 'eshell-prepare-indices' to be clearer.) Is this for master? If so, okay. Otherwise, you'll need to adjust the version in the obsolescence declaration. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 19 15:21:02 2023 Received: (at 60942) by debbugs.gnu.org; 19 Jan 2023 20:21:02 +0000 Received: from localhost ([127.0.0.1]:44819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIbPB-0007lP-Og for submit@debbugs.gnu.org; Thu, 19 Jan 2023 15:21:02 -0500 Received: from mail-pf1-f172.google.com ([209.85.210.172]:43673) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIbP6-0007ku-6C for 60942@debbugs.gnu.org; Thu, 19 Jan 2023 15:21:00 -0500 Received: by mail-pf1-f172.google.com with SMTP id c26so2386133pfp.10 for <60942@debbugs.gnu.org>; Thu, 19 Jan 2023 12:20:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=8di0cpO/4RNU7xtp32B+sXs2OAt9wZ3pn+4uWmGBr5E=; b=m+8GX/1Smk5I8IswMbDgftaX37MU/YZdKDymLIjvv5O1XR4Fbbw15QjShhvZtkjtBz mCyhAdnIOpMyEgm/TGDKOA+GxI6njDBH/ZtwS2GRhbb0Uo9K2aoa37LtzPXLsXcPRb59 H/8HyCspG0//JoT7awhFYCtDJ619kXmCth+yFo1Phsi9rx6zi2gyiPz94y96YSonkLVF jjMMBY9W+n34adeMzHrh09RVi/fjncTm9ak9g00gtAxaCAP6AY1cHhmNmsZlZjncuL84 OuZILqaa0+CjFFOb/neetZWYyygpSz8JVkzXWv4Ry+NJhO93mS1J754w9OaKyT9R2bL9 p8Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8di0cpO/4RNU7xtp32B+sXs2OAt9wZ3pn+4uWmGBr5E=; b=kzD1lLmRoDMwfcJm1PymBWJ1pyZ90vOZms8Ctp11LFSRjjhhFNN55fAjXTfmhKX3U0 9rFa/lesch7yViMq6Cm9KA8Ehe/FDNqIl0iqOH7sB55s4N3Y0pqoRFwXl6O3q+QvnX0C 6MBJIY+7Ne0ae1S8m7txhzEftPxK0IC1Lqocwyk/0wN9sIC/ynXfeOh5glE6/lNXoadK tbJbX0xHLZrNL+xr9J84a9dVY/F+V9Z2YHvY5y633plQ8dfcz3dDKAfZVrLURPh1OxKA 5zhgG1KKhha4fbNI1J3oH3/9mMnyFpnqaGkLfblttNvOmUImxz7d48m0aylSDxmpACTJ 1wBA== X-Gm-Message-State: AFqh2kpxycpcJsvEkZZqZXNr8YztTYeK5bTznUEab2Up8wrb5Rzq+9Ix T2Ljs12+Z4fo0LUuZAweLNo= X-Google-Smtp-Source: AMrXdXuJUZPzbd6zN0zTSTuSJQipS+J0rWJ4N+YGnGKt5QYV7I9ECq1r0GFRyuv+C18TGk9hVM2vTg== X-Received: by 2002:a62:e401:0:b0:575:e8c5:eb14 with SMTP id r1-20020a62e401000000b00575e8c5eb14mr11909567pfh.18.1674159650161; Thu, 19 Jan 2023 12:20:50 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id a69-20020a621a48000000b0056b9df2a15esm16307643pfa.62.2023.01.19.12.20.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Jan 2023 12:20:49 -0800 (PST) Message-ID: Date: Thu, 19 Jan 2023 12:20:48 -0800 MIME-Version: 1.0 Subject: Re: bug#60942: 30.0.50; [PATCH] Indices in Eshell variable interpolation don't work with async subcommands Content-Language: en-US To: Eli Zaretskii References: <20e5cb2f-aabe-53fd-d3af-81ec5ff11e7b@gmail.com> <83wn5jyq69.fsf@gnu.org> <83o7qunwgh.fsf@gnu.org> From: Jim Porter In-Reply-To: <83o7qunwgh.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60942 Cc: 60942@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 1/19/2023 11:41 AM, Eli Zaretskii wrote: > Is this for master? If so, okay. Otherwise, you'll need to adjust > the version in the obsolescence declaration. Personally, I think just for master. The change isn't entirely risk-free. This code is a bit tricky, and I'd want a fair amount of time for people to identify bugs, just in case I regressed something. (If this were for the release branch, we could probably remove 'eshell-eval-indices', since it was introduced in Emacs 29 anyway.) From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 19 20:54:11 2023 Received: (at 60942-done) by debbugs.gnu.org; 20 Jan 2023 01:54:11 +0000 Received: from localhost ([127.0.0.1]:45051 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIgbb-00083r-Bz for submit@debbugs.gnu.org; Thu, 19 Jan 2023 20:54:11 -0500 Received: from mail-pj1-f50.google.com ([209.85.216.50]:52855) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIgbY-00083e-Tf for 60942-done@debbugs.gnu.org; Thu, 19 Jan 2023 20:54:10 -0500 Received: by mail-pj1-f50.google.com with SMTP id o13so4270299pjg.2 for <60942-done@debbugs.gnu.org>; Thu, 19 Jan 2023 17:54:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=O9ArCVvSwLH4Hy4sk4Dp0pv3a+MjBgEkbRjA01DS2yU=; b=mW3HBxhQRybe6mwn1iNHreotH6TOdflSfG2A0POmKk9hl8Vtz8u2MP7eSEbUUk2WAa MYOB+fe5qz0lHaXZzLXQNgGmlWwkQ0l/laC1BBZn6xyG4oABTU/jRbR9QKSw4KBxv8NH UccvW7KOqmIyA246vVN9L7zEQQCgsL0cWc7hxcM14fZd9SuaYkkt5P5QZiTB61kEWYNV LMRTmlmV1fWsABZlYfBs0w4GBzx1WRpyWu36MKZnd8wGXkqttB9C0tHxumn5XQUV4D/w D6TR4ecr/trR9O5vp855+vXkCs3XRmXUkeDH94PPd9xrJWZ/7nUSbGaKYcVXf/fn4WsI xkuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=O9ArCVvSwLH4Hy4sk4Dp0pv3a+MjBgEkbRjA01DS2yU=; b=2QphVutycyzVNN1Vqr1Z0cLqharplmIy6TH1dVDogYU/3YMf4/4n4ymnUhxEmRMUxA Nqa70Hap8vBQcJHXZd04sZNJsLhHIjndCr/504ZC4uY8Y0L9maRy8E7vRr51MfyyE/i/ yU8feiYFfv45DZzZ2u1bv5ZF8PinZ6EMPZCL6gQnVQPQvdVmRLYc0bMHd35/l5Fg5Ol2 dGraUSvAKLDRrwzjc4ddgKLqNsJyQFARzJOPurDoFOOKiRo91QLYqSfL5+WNAvEil4tW V+ZtEnQa8fDVw0QozujE8sBeBTbQiJeVeQGvjhGFiBnMGo8Zrm/fEFZaArzQplNVddGm EreA== X-Gm-Message-State: AFqh2konBdq+SpAIG/1lZ0DgnIMw82RAhNQx7KtAgXSjMklNMLz85Hoy kvkOk/ZJ2ojdrqUYX865Hj7jPpTpQgvc+g== X-Google-Smtp-Source: AMrXdXuT9MpRYsINj2dWCtB8b1Y9n0MGqgrGCtpeoaf+QO1BoOn3i7fwcMMUK+rORmu7IAufN0pmCg== X-Received: by 2002:a05:6a20:4998:b0:b8:652a:79f2 with SMTP id fs24-20020a056a20499800b000b8652a79f2mr11538480pzb.11.1674179643064; Thu, 19 Jan 2023 17:54:03 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id r3-20020a632b03000000b00478e14e6e76sm21814559pgr.32.2023.01.19.17.54.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Jan 2023 17:54:02 -0800 (PST) Message-ID: <3bed595c-6f7e-5049-2c8d-bee83d13c3e8@gmail.com> Date: Thu, 19 Jan 2023 17:54:01 -0800 MIME-Version: 1.0 Subject: Re: bug#60942: 30.0.50; [PATCH] Indices in Eshell variable interpolation don't work with async subcommands Content-Language: en-US From: Jim Porter To: Eli Zaretskii References: <20e5cb2f-aabe-53fd-d3af-81ec5ff11e7b@gmail.com> <83wn5jyq69.fsf@gnu.org> <83o7qunwgh.fsf@gnu.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60942-done Cc: 60942-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 1/19/2023 12:20 PM, Jim Porter wrote: > On 1/19/2023 11:41 AM, Eli Zaretskii wrote: >> Is this for master?  If so, okay.  Otherwise, you'll need to adjust >> the version in the obsolescence declaration. > > Personally, I think just for master. The change isn't entirely > risk-free. This code is a bit tricky, and I'd want a fair amount of time > for people to identify bugs, just in case I regressed something. And now merged to master as 54d5ea66c9. Closing this bug. From unknown Sat Jun 21 10:45:12 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 17 Feb 2023 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator