GNU bug report logs - #60925
29.0.60; [PATCH] Use proper types for Eshell warnings

Previous Next

Package: emacs;

Reported by: Jim Porter <jporterbugs <at> gmail.com>

Date: Wed, 18 Jan 2023 04:57:01 UTC

Severity: normal

Tags: patch

Found in version 29.0.60

Done: Jim Porter <jporterbugs <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#60925: closed (29.0.60; [PATCH] Use proper types for Eshell
 warnings)
Date: Wed, 18 Jan 2023 17:17:01 +0000
[Message part 1 (text/plain, inline)]
Your message dated Wed, 18 Jan 2023 09:16:45 -0800
with message-id <325e9eb7-6887-332f-b864-775b56c00516 <at> gmail.com>
and subject line Re: bug#60925: 29.0.60; [PATCH] Use proper types for Eshell warnings
has caused the debbugs.gnu.org bug report #60925,
regarding 29.0.60; [PATCH] Use proper types for Eshell warnings
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
60925: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60925
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Jim Porter <jporterbugs <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.60; [PATCH] Use proper types for Eshell warnings
Date: Tue, 17 Jan 2023 20:56:51 -0800
[Message part 3 (text/plain, inline)]
Looking over the 'display-warning' code, I realized that I had misread 
the docstring and wasn't calling it properly in Eshell. I gave these 
warnings a type of ':warning', but that's a warning *level*, not a 
warning *type*. Attached is a fix.

I'd like to merge this to the Emacs 29 branch. These are trivial fixes 
to a couple new features, and should make it easier for users to 
properly suppress these warnings if they choose to do so.
[0001-Use-proper-types-for-Eshell-warnings.patch (text/plain, attachment)]
[Message part 5 (message/rfc822, inline)]
From: Jim Porter <jporterbugs <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 60925-done <at> debbugs.gnu.org
Subject: Re: bug#60925: 29.0.60; [PATCH] Use proper types for Eshell warnings
Date: Wed, 18 Jan 2023 09:16:45 -0800
On 1/18/2023 4:08 AM, Eli Zaretskii wrote:
> OK, thanks.

Thanks. Merged to Emacs 29 as dc3f85fd4b, and closing this bug.


This bug report was last modified 2 years and 178 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.