From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 17 23:56:57 2023 Received: (at submit) by debbugs.gnu.org; 18 Jan 2023 04:56:57 +0000 Received: from localhost ([127.0.0.1]:38770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pI0VN-0004HB-8Z for submit@debbugs.gnu.org; Tue, 17 Jan 2023 23:56:57 -0500 Received: from lists.gnu.org ([209.51.188.17]:55576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pI0VL-0004H1-Br for submit@debbugs.gnu.org; Tue, 17 Jan 2023 23:56:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pI0VL-00074v-0w for bug-gnu-emacs@gnu.org; Tue, 17 Jan 2023 23:56:55 -0500 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pI0VJ-0000ih-GB for bug-gnu-emacs@gnu.org; Tue, 17 Jan 2023 23:56:54 -0500 Received: by mail-pj1-x1032.google.com with SMTP id 7-20020a17090a098700b002298931e366so1028584pjo.2 for ; Tue, 17 Jan 2023 20:56:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:content-language:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=Auci4OX9/TVU5gZ+17ktN+BiAFFXVrzlnloaSetGucY=; b=Z8yBHCwVPIRDOnQD6/LWNaO+P6Jpn6KWMcZbZXxW9NSm/W+tmrYWXen7P1+DDiJfLj nE0ULvL896oVqLOgoNFE4OTPI0BO+rTofF92yk3tSxv7YHBoRw1IEki09zOtvfWNKUNo Ltyd+63JaVtQEAiR9knXKc6RvjzNcRb+zUbRS8UoykI6Idmjb0PG4mXd7bQwFqwBS1Qm +xuVxuCMhl9rtuwyp7WvK05meH21XlnbjZVRM21ttJd8bJFbLb+xuOSUzc8uYvi9CTpc IFqJiZcBYdiBnQ/Fue/L7ecx66BpVYhQ+zqaUXqg6rIqub9/2oAYkH9ITQ+W6TN41nRR 9ubg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=subject:from:to:content-language:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Auci4OX9/TVU5gZ+17ktN+BiAFFXVrzlnloaSetGucY=; b=SvNaf3V1sK0fMDVoTAlw6MH/F0cfrkAliQ/nrs3ULilgiUWes+sBPFInG9YcjH6VqL cFBUvbvc5gEGd+cRIaHYNC39oqViu6MLQfc+bPXDRPEeAiMIJmTwyt1RKAEAVGg0QKB2 2w2N46BwP2a2d3UnflbmWqGnDzB/FB6jb6nz2eZHJTQ6JhnjfrIBGRz7kEmPWqFZ/ikN /TQXgheaAcYGyyF3lbtL7LrzoHzEn/SWVnZ7UewYm6XMW/XSjM+lysNuu1VSlBY7vjS5 XGS1uEwnvFhV7Q69jIAXxZyo1EfWmPJ7aSwMomiqEX/qEs1qodpQ6mMYZeZ17mMvEh7C sUDg== X-Gm-Message-State: AFqh2kr9c1RpDsVqMR9lR9Nw4vwh65XSXkgCthZw/ADoP7l0QmR5PcSp 2VJR7eiQaN5k7oUlBLBQj6FdxfX9yw/72A== X-Google-Smtp-Source: AMrXdXuHQ5biAuEvkK348B/QNp7Vx8jn98YPolFmX4kMIYT3QXW/AO47aTbNdh0VSKSUYzCUTtgbpg== X-Received: by 2002:a17:90b:3d0a:b0:219:705c:7193 with SMTP id pt10-20020a17090b3d0a00b00219705c7193mr5666348pjb.11.1674017812033; Tue, 17 Jan 2023 20:56:52 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id u7-20020a17090a410700b00218abadb6a8sm382683pjf.49.2023.01.17.20.56.50 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Jan 2023 20:56:51 -0800 (PST) Content-Type: multipart/mixed; boundary="------------o0DqNeRhHhQO54zD8nxrh4Bo" Message-ID: <2c44af54-9315-b936-a6f7-245c835cc451@gmail.com> Date: Tue, 17 Jan 2023 20:56:51 -0800 MIME-Version: 1.0 X-Mozilla-News-Host: news://news.gmane.io:119 Content-Language: en-US To: bug-gnu-emacs@gnu.org From: Jim Porter Subject: 29.0.60; [PATCH] Use proper types for Eshell warnings Received-SPF: pass client-ip=2607:f8b0:4864:20::1032; envelope-from=jporterbugs@gmail.com; helo=mail-pj1-x1032.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------o0DqNeRhHhQO54zD8nxrh4Bo Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Looking over the 'display-warning' code, I realized that I had misread the docstring and wasn't calling it properly in Eshell. I gave these warnings a type of ':warning', but that's a warning *level*, not a warning *type*. Attached is a fix. I'd like to merge this to the Emacs 29 branch. These are trivial fixes to a couple new features, and should make it easier for users to properly suppress these warnings if they choose to do so. --------------o0DqNeRhHhQO54zD8nxrh4Bo Content-Type: text/plain; charset=UTF-8; name="0001-Use-proper-types-for-Eshell-warnings.patch" Content-Disposition: attachment; filename="0001-Use-proper-types-for-Eshell-warnings.patch" Content-Transfer-Encoding: base64 RnJvbSBkN2Y3YWMxOTBjNjliNWJiNjk1NDNmMzA1MjM5NGY0YTQ3MWVjYWQ3IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFR1ZSwgMTcgSmFuIDIwMjMgMjA6NTE6MTUgLTA4MDAKU3ViamVjdDogW1BB VENIXSBVc2UgcHJvcGVyIHR5cGVzIGZvciBFc2hlbGwgd2FybmluZ3MKCiogbGlzcC9lc2hl bGwvZXNoLXZhci5lbCAoZXNoZWxsLWdldC12YXJpYWJsZSk6CiogbGlzcC9lc2hlbGwvZW0t YmFzaWMgKGVzaGVsbC9lY2hvKTogRG9uJ3QgdXNlICc6d2FybmluZyc7IHRoYXQncyBhCndh cm5pbmcgbGV2ZWwsIG5vdCBhIHdhcm5pbmcgdHlwZS4KLS0tCiBsaXNwL2VzaGVsbC9lbS1i YXNpYy5lbCB8IDMgKystCiBsaXNwL2VzaGVsbC9lc2gtdmFyLmVsICB8IDcgKysrKy0tLQog MiBmaWxlcyBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCgpkaWZm IC0tZ2l0IGEvbGlzcC9lc2hlbGwvZW0tYmFzaWMuZWwgYi9saXNwL2VzaGVsbC9lbS1iYXNp Yy5lbAppbmRleCBkZmJlNGRiMDg5Ni4uYmZmZjNiZGY1NmUgMTAwNjQ0Ci0tLSBhL2xpc3Av ZXNoZWxsL2VtLWJhc2ljLmVsCisrKyBiL2xpc3AvZXNoZWxsL2VtLWJhc2ljLmVsCkBAIC0x MzIsNyArMTMyLDggQEAgZXNoZWxsL2VjaG8KICAgICAgOzsgYnVnIzI3MzYxLgogICAgICAo d2hlbiAoZXF1YWwgb3V0cHV0LW5ld2xpbmUgJyhuaWwpKQogICAgICAgIChkaXNwbGF5LXdh cm5pbmcKLSAgICAgICAgOndhcm5pbmcgIlRvIHRlcm1pbmF0ZSB3aXRoIGEgbmV3bGluZSwg eW91IHNob3VsZCB1c2UgLU4gaW5zdGVhZC4iKSkKKyAgICAgICAgJyhlc2hlbGwgZWNobykK KyAgICAgICAgIlRvIHRlcm1pbmF0ZSB3aXRoIGEgbmV3bGluZSwgeW91IHNob3VsZCB1c2Ug LU4gaW5zdGVhZC4iKSkKICAgICAgKGVzaGVsbC1lY2hvIGFyZ3Mgb3V0cHV0LW5ld2xpbmUp KSkpCiAKIChkZWZ1biBlc2hlbGwvcHJpbnRubCAoJnJlc3QgYXJncykKZGlmZiAtLWdpdCBh L2xpc3AvZXNoZWxsL2VzaC12YXIuZWwgYi9saXNwL2VzaGVsbC9lc2gtdmFyLmVsCmluZGV4 IGZkNzZhMmM2ZjA5Li4yN2U2ODEzOGFhMiAxMDA2NDQKLS0tIGEvbGlzcC9lc2hlbGwvZXNo LXZhci5lbAorKysgYi9saXNwL2VzaGVsbC9lc2gtdmFyLmVsCkBAIC02MjgsOSArNjI4LDEw IEBAIGVzaGVsbC1nZXQtdmFyaWFibGUKICAgICAgICAgICAgICAgKGlmIChvciAoZXEgbWF4 LWFyaXR5ICdtYW55KSAoPj0gbWF4LWFyaXR5IDIpKQogICAgICAgICAgICAgICAgICAgKGZ1 bmNhbGwgdGFyZ2V0IGluZGljZXMgcXVvdGVkKQogICAgICAgICAgICAgICAgIChkaXNwbGF5 LXdhcm5pbmcKLSAgICAgICAgICAgICAgICAgOndhcm5pbmcgKGNvbmNhdCAiRnVuY3Rpb24g Zm9yIGBlc2hlbGwtdmFyaWFibGUtYWxpYXNlcy1saXN0JyAiCi0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgImVudHJ5IHNob3VsZCBhY2NlcHQgdHdvIGFyZ3VtZW50czog SU5ESUNFUyAiCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgImFuZCBRVU9U RUQuJyIpKQorICAgICAgICAgICAgICAgICAnKGVzaGVsbCB2YXJpYWJsZS1hbGlhcykKKyAg ICAgICAgICAgICAgICAgKGNvbmNhdCAiRnVuY3Rpb24gZm9yIGBlc2hlbGwtdmFyaWFibGUt YWxpYXNlcy1saXN0JyAiCisgICAgICAgICAgICAgICAgICAgICAgICAgImVudHJ5IHNob3Vs ZCBhY2NlcHQgdHdvIGFyZ3VtZW50czogSU5ESUNFUyAiCisgICAgICAgICAgICAgICAgICAg ICAgICAgImFuZCBRVU9URUQuJyIpKQogICAgICAgICAgICAgICAgIChmdW5jYWxsIHRhcmdl dCBpbmRpY2VzKSkpKSkKICAgICAgICAgICgoc3ltYm9scCB0YXJnZXQpCiAgICAgICAgICAg KGVzaGVsbC1hcHBseS1pbmRpY2VzIChzeW1ib2wtdmFsdWUgdGFyZ2V0KSBpbmRpY2VzIHF1 b3RlZCkpCi0tIAoyLjI1LjEKCg== --------------o0DqNeRhHhQO54zD8nxrh4Bo-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 18 07:08:05 2023 Received: (at 60925) by debbugs.gnu.org; 18 Jan 2023 12:08:06 +0000 Received: from localhost ([127.0.0.1]:39647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pI7EY-0006T2-6n for submit@debbugs.gnu.org; Wed, 18 Jan 2023 07:08:05 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pI7ES-0006SQ-QZ for 60925@debbugs.gnu.org; Wed, 18 Jan 2023 07:08:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pI7EN-0007eI-Bh; Wed, 18 Jan 2023 07:07:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=GhI07TM81pHbKHKGzAHVZWQE2dhtmcLLgOk+X25rNgw=; b=oszBuiJT+0ap EQxR8D9axDihE5X1bJ5HdW4GydcOVvaxe2vA9IK/zRAymQOc09VBL7y+LCYtyfoPRrrnLrY9vDjUB V6wiCc/Dg+wkrSPWadRbre4LIDhzqQRpuNz/2tJK9/yAsFY14xHliazEs/25wyZ3ogG8F6QFP4SGe ActPsPKmDvcKsptyxEw6qT8AghHyHGMk4tug/qJq/+jI5nypiSWJ1VaehuDKzY3BM3WOsxlkBuk8v Rrc0UY/sn6o21EB9DvG7xyeqc2F3gFfr8gy0IGhBaENw6KM/gcsWRBxGlNEsggpF64wlWhgdAaaHh EjC8i3F5kMq62XpRTg6V9A==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pI7EL-0006LE-Td; Wed, 18 Jan 2023 07:07:51 -0500 Date: Wed, 18 Jan 2023 14:08:04 +0200 Message-Id: <8335882ggr.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: <2c44af54-9315-b936-a6f7-245c835cc451@gmail.com> (message from Jim Porter on Tue, 17 Jan 2023 20:56:51 -0800) Subject: Re: bug#60925: 29.0.60; [PATCH] Use proper types for Eshell warnings References: <2c44af54-9315-b936-a6f7-245c835cc451@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60925 Cc: 60925@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Tue, 17 Jan 2023 20:56:51 -0800 > From: Jim Porter > > Looking over the 'display-warning' code, I realized that I had misread > the docstring and wasn't calling it properly in Eshell. I gave these > warnings a type of ':warning', but that's a warning *level*, not a > warning *type*. Attached is a fix. > > I'd like to merge this to the Emacs 29 branch. These are trivial fixes > to a couple new features, and should make it easier for users to > properly suppress these warnings if they choose to do so. OK, thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 18 12:16:52 2023 Received: (at 60925-done) by debbugs.gnu.org; 18 Jan 2023 17:16:52 +0000 Received: from localhost ([127.0.0.1]:41685 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIC3P-0007jy-RH for submit@debbugs.gnu.org; Wed, 18 Jan 2023 12:16:52 -0500 Received: from mail-pf1-f176.google.com ([209.85.210.176]:45826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIC3P-0007jh-0X for 60925-done@debbugs.gnu.org; Wed, 18 Jan 2023 12:16:51 -0500 Received: by mail-pf1-f176.google.com with SMTP id s3so24203304pfd.12 for <60925-done@debbugs.gnu.org>; Wed, 18 Jan 2023 09:16:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=ChL8bUZgE9D7kEd2nkPJt6NSPPKol4POQEwwVjov3+o=; b=gDLkWEKhpyaWO9MpynzusdgVABdfoNVBgWUzLKydH0d2etQcq3Uv7483huo00wuSQp lBN4PSgIbUOVtRwXA58P+mjoVXfBdJMsCnCoLOct8APKjL1LOlqLlnBnGN2h41NEts+0 0OP4W90UO0uzUJIbuM+tH1M6DzMdsUxvUxB8eSSVowAlY2+EoPOruknkZaTay4//vuI/ xpqvLmajZ2AeTp3DbAVUhGt3hRRBFT1OEE2gN6jBrFxVxI6Uy/4V+xSnH9IbCOACGLCJ A9jsBKivJJSyFxxiWEW3jNyAFxUEjNvPYXe1LU9oP3PvbULmEIP0Yow7yPhvP8zYkfoN L81g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ChL8bUZgE9D7kEd2nkPJt6NSPPKol4POQEwwVjov3+o=; b=UGts7/RI7wCnnd1Pafsdvy7E4a2Jqout5dRdC/1ZjOr6FF+JyIjO6UpKezKQcM5MNi KjsOO6HEi0642u1bH/h62uRwwtUbEPwBF9zPtt0m3CvoPq+Bx79unwkeqTOgJt/xjgMC b0Ys0mFP1qQ70diz1VSEYENSyp9Et/nfgD8oAsg6Z+sKJi/1MDgeQ2huebE+i9q9rPPd KuK42ylLgqRVJStV6HDmPLtMvzJG+5W0k9DAUIzPbB3WAAmPrMMCStlrQZD+Y+LcGXlp Z6l7P0MNojg0uoTGjvi1leFz8KIY5oevVMtEB9hj2vJGqFGBWmOC7aBEEIaYuRt87jXS c62w== X-Gm-Message-State: AFqh2kruDQJMHf1dsDwqqaXhjZwdlEcveNFd+EicYdTc9kHrUoGf3xLD FFvZWg0cx8WI6e+PcRKkgC4= X-Google-Smtp-Source: AMrXdXto8o53kGT0FKF16Q6Z0zxkHzNWqjMhWn9f8GO+1AqCzJ0sFlf1wHqkMscX6kEi3SGaf0jAHQ== X-Received: by 2002:a62:3244:0:b0:583:2971:df8b with SMTP id y65-20020a623244000000b005832971df8bmr7019904pfy.20.1674062205067; Wed, 18 Jan 2023 09:16:45 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id d12-20020aa797ac000000b0058da3f2eba8sm6259685pfq.40.2023.01.18.09.16.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Jan 2023 09:16:44 -0800 (PST) Message-ID: <325e9eb7-6887-332f-b864-775b56c00516@gmail.com> Date: Wed, 18 Jan 2023 09:16:45 -0800 MIME-Version: 1.0 Subject: Re: bug#60925: 29.0.60; [PATCH] Use proper types for Eshell warnings Content-Language: en-US To: Eli Zaretskii References: <2c44af54-9315-b936-a6f7-245c835cc451@gmail.com> <8335882ggr.fsf@gnu.org> From: Jim Porter In-Reply-To: <8335882ggr.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60925-done Cc: 60925-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 1/18/2023 4:08 AM, Eli Zaretskii wrote: > OK, thanks. Thanks. Merged to Emacs 29 as dc3f85fd4b, and closing this bug. From unknown Sat Aug 09 04:53:00 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 16 Feb 2023 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator