From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 17 20:45:29 2023 Received: (at submit) by debbugs.gnu.org; 18 Jan 2023 01:45:30 +0000 Received: from localhost ([127.0.0.1]:38610 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHxW4-0007Uc-SW for submit@debbugs.gnu.org; Tue, 17 Jan 2023 20:45:29 -0500 Received: from lists.gnu.org ([209.51.188.17]:60134) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHxVx-0007SR-FM for submit@debbugs.gnu.org; Tue, 17 Jan 2023 20:45:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHxVx-00023Q-00 for guix-patches@gnu.org; Tue, 17 Jan 2023 20:45:21 -0500 Received: from mail-il1-x132.google.com ([2607:f8b0:4864:20::132]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pHxVv-0006y2-2o for guix-patches@gnu.org; Tue, 17 Jan 2023 20:45:20 -0500 Received: by mail-il1-x132.google.com with SMTP id i17so11543911ila.9 for ; Tue, 17 Jan 2023 17:45:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CEN3zEjZIR8Oo4tRFEZjvXakRAoY7MTC+t1ICzAu2CI=; b=OPENwus8X32m2nEm3AxAxqfbfdVpDqKX1t1xwPDSQ6sBSnRAS19PPKEPRmYkcDD9IS DPxGhnTy6dNNQl3ROAs2242C0kXnc995eigkXp+zUc6fWTN5rIAAVEYrcm9/LSJnvSjO buozFieAcHh9XlvKM34A5J+1k4WUMq8ANWot7MczvtsZiodckb92EfofdVxXIR/jd6DD fp2p32riLdVpZMNHjzoZL6t9AFkUtfMHTqAhAOAGw1GtDOKQGm/T4wu2459yGRjf+xgU sAxFaUeGIoHGOPXWSCmmGcbkEk7TDjxsS31+bdE7ieKQoKbV8vw8HU31Qn9eTFR0z5w/ sLtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CEN3zEjZIR8Oo4tRFEZjvXakRAoY7MTC+t1ICzAu2CI=; b=kiR7UfgyWnEHH0PqmZV1ofJlFF1oJq9zapBJcWedNvdAx2+ZM9Ekg85nANtV+mdjLt K9RiakSnRZnD6NjEDIaRXZWHMX+hH7Qtpj6DQbmcnDsA/Hk6a9tryUHUgpF2StSUiVlr TJIzzSH+QBseDg4YWn4Cii4yZS+XllF/HNqSnwrLNOmr4iFNDFPrrls+64d+6XV8GP7a TD8fbn3Vf6pWTJa56dJJzx7cLO268pT+U7+SSSlkeE4zjKzY3YPOFiXPPuHe7o3ahgO5 adFQlgWST2Q8Ggu+ERyYtXUoKrNaldz7mq78pTdDZxUs6/EiujqDZVMD+RgRxm/DMPoU AYng== X-Gm-Message-State: AFqh2kpxrNcjr+NF4MU2rMv81FLM4FeYDtoMU6DJMbXWkRF5YUGsm+iD UrdpT8oH2DjWNNakaqTYWh5v/s9FCkE= X-Google-Smtp-Source: AMrXdXs5W3U9ss12gONkD6NiCqyyVxjFzPfjOwYfCXP9NsaXKGD/v2QfW6qnMrsChRTzJ2dRbmPqVQ== X-Received: by 2002:a92:2809:0:b0:30e:e3b7:83d9 with SMTP id l9-20020a922809000000b0030ee3b783d9mr5008358ilf.20.1674006318114; Tue, 17 Jan 2023 17:45:18 -0800 (PST) Received: from washu-v4.home.cox-buday.com (c-174-51-139-101.hsd1.co.comcast.net. [174.51.139.101]) by smtp.gmail.com with ESMTPSA id p32-20020a056638192000b0039e89ea68f9sm7889250jal.135.2023.01.17.17.45.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jan 2023 17:45:17 -0800 (PST) From: Katherine Cox-Buday To: guix-patches@gnu.org Subject: [PATCH 08/25] gnu: go-github-com-pkg-diff: Update to 0.0.0-20210226163009-20ebb0f2a09e. Date: Tue, 17 Jan 2023 18:44:53 -0700 Message-Id: <20230118014510.19320-9-cox.katherine.e@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230118014510.19320-1-cox.katherine.e@gmail.com> References: <20230118014510.19320-1-cox.katherine.e@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::132; envelope-from=cox.katherine.e@gmail.com; helo=mail-il1-x132.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Katherine Cox-Buday X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/golang.scm (go-github-com-pkg-diff): Update to 0.0.0-20210226163009-20ebb0f2a09e. --- gnu/packages/golang.scm | 44 +++++++++++++++++++---------------------- 1 file changed, 20 insertions(+), 24 deletions(-) diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm index 9554234c7b..5e8159975f 100644 --- a/gnu/packages/golang.scm +++ b/gnu/packages/golang.scm @@ -8736,30 +8736,26 @@ (define-public go-github-com-go-git-go-git-fixtures (license license:asl2.0))) (define-public go-github-com-pkg-diff - (let ((commit "531926345625d489a6b56f860a569e68245ace36") - (revision "1")) - (package - (name "go-github-com-pkg-diff") - (version (git-version "0.0.1" revision commit)) - (source (origin - (method git-fetch) - (uri (git-reference - (url "https://github.com/pkg/diff") - (commit commit))) - (file-name (git-file-name name version)) - (sha256 - (base32 - "1770m7qhww6lm0wj1v3mhv6hwa2v92p4w2fqxj1xyrg5dd58d944")))) - (build-system go-build-system) - (arguments - `(#:import-path "github.com/pkg/diff")) - (native-inputs - (list go-github-com-sergi-go-diff)) - (home-page "https://github.com/pkg/diff/") - (synopsis "Create and print diffs") - (description - "This package provides a Go library to create and print diffs.") - (license license:bsd-3)))) + (package + (name "go-github-com-pkg-diff") + (version "0.0.0-20210226163009-20ebb0f2a09e") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/pkg/diff") + (commit "20ebb0f2a09e612109b224b32f79370409108bcc"))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1g3dzgwhz4fx3ddpsv7fsa4r1v5clsp2lbw2qrkdk9y1vc5gi8yi")))) + (build-system go-build-system) + (arguments + `(#:import-path "github.com/pkg/diff")) + (home-page "https://github.com/pkg/diff/") + (synopsis "Create and print diffs") + (description + "This package provides a Go library to create and print diffs.") + (license license:bsd-3))) (define-public go-github-com-twpayne-go-shell (package -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 18 05:57:05 2023 Received: (at control) by debbugs.gnu.org; 18 Jan 2023 10:57:05 +0000 Received: from localhost ([127.0.0.1]:39432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pI67s-0005fA-QG for submit@debbugs.gnu.org; Wed, 18 Jan 2023 05:57:05 -0500 Received: from tobias.gr ([80.241.217.52]:40786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pI67q-0005ej-1Q for control@debbugs.gnu.org; Wed, 18 Jan 2023 05:57:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=rZG272GorEjW1 DJ1ueTJCIxQKBgNqS4r2UeoWjljfNg=; h=to:from:date; d=tobias.gr; b=pJ8xGE 4xKTFxDGXTu8JJIxdTXzjHjKQHMPpzOLdDgTsKfydcYwE7eg++d4WhW4FvCCVuGv7neHuY doO2M+tWHslHkbqZPPB+ZequmKLRDsNc/QFfVC4KpDELKtkW9Q6ctxINWpQGJe2JzLXwaA RXt1hnoV0zUiSxmZXf6jp+B5IpHHn6CYT9xaIjeH34RSUNbyuEiIT1+57owCZhuUTnYlQh lK0c2ja5PyBKUu/tVp3CtE9SNY4fUc0Q4ge2kajMRhEyMUCCZMwjE4Ovvsy0rMfIS0qhUw 73tRxdOCEgy5V0Q/MaQ4XJMvrn5QvE7Rgo2lgWS/aXWhkF0KedtpqCRQ== Received: by submission.tobias.gr (OpenSMTPD) with ESMTP id 457c9cdf for ; Wed, 18 Jan 2023 10:56:54 +0000 (UTC) MIME-Version: 1.0 Date: Wed, 18 Jan 2023 11:56:54 +0100 From: Tobias Geerinckx-Rice To: control@debbugs.gnu.org Message-ID: <542e82bcc0f385c117ba662c7dcf1dbf@tobias.gr> Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: merge 60898 60899 60900 60901 60902 merge 60898 60903 60904 60905 60906 merge 60898 60907 60908 60909 60910 merge 60898 60911 60912 60913 60914 merge 60898 60915 60916 60917 60918 merge 60898 60919 60 [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) merge 60898 60899 60900 60901 60902 merge 60898 60903 60904 60905 60906 merge 60898 60907 60908 60909 60910 merge 60898 60911 60912 60913 60914 merge 60898 60915 60916 60917 60918 merge 60898 60919 60920 From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 18 06:43:42 2023 Received: (at control) by debbugs.gnu.org; 18 Jan 2023 11:43:42 +0000 Received: from localhost ([127.0.0.1]:39609 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pI6qz-0003Hz-Oc for submit@debbugs.gnu.org; Wed, 18 Jan 2023 06:43:41 -0500 Received: from tobias.gr ([80.241.217.52]:49144) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pI6qy-0003Ho-68 for control@debbugs.gnu.org; Wed, 18 Jan 2023 06:43:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=hJBWTcXaRHm8s 6Gzva/WF37fY4EhLgcXTE0kSZi4SIY=; h=to:from:date; d=tobias.gr; b=HQFR0l g232sKUrFQwAVl4bjkp37vlXJXu0nDv8lsOWDXnNgP5ATDyo7kPUr9jnAW1ldk87kyMTEC 12cfNk3mR15PuObZZWmeKSauoBlV3ofDwl4YIGk4qMms8hxenZPKyp5uQbxG3B4jtQWPpF MQmkwm3oUpr/R7chlpif5MeJO8VFKXW5ENk1ceuOE78c3EAVjtT34hIC0Kyf05uzzmzSQd tCJL8D5IvcQ82V/VDkEu8zMICLfcI2C+aCgQhhuMy5eNBkRnSN7h25ZHcfR22/XMYopKkD cQMgdz3Ylfx6CY1L3ldAEWkgVZM9FX7lR4sn09qIEO+1/CyVj/cfbwHQ== Received: by submission.tobias.gr (OpenSMTPD) with ESMTP id 2b6b07ef for ; Wed, 18 Jan 2023 11:43:32 +0000 (UTC) MIME-Version: 1.0 Date: Wed, 18 Jan 2023 12:43:32 +0100 From: Tobias Geerinckx-Rice To: control@debbugs.gnu.org Message-ID: <37de5823441633151229c783f2acfca3@tobias.gr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: merge 60898 60921 60922 thanks Weird: I got ‘Unknown command or malformed arguments to command.’ for this obviously correct line. Let's try again. Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) merge 60898 60921 60922 thanks Weird: I got ‘Unknown command or malformed arguments to command.’ for this obviously correct line. Let's try again. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 18 12:07:56 2023 Received: (at control) by debbugs.gnu.org; 18 Jan 2023 17:07:56 +0000 Received: from localhost ([127.0.0.1]:41657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIBum-00052f-22 for submit@debbugs.gnu.org; Wed, 18 Jan 2023 12:07:56 -0500 Received: from mail-il1-f179.google.com ([209.85.166.179]:35657) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIBuk-00052N-3J for control@debbugs.gnu.org; Wed, 18 Jan 2023 12:07:54 -0500 Received: by mail-il1-f179.google.com with SMTP id m15so17345356ilq.2 for ; Wed, 18 Jan 2023 09:07:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=GnPyPOAEGseCgs8OJ4qt7L8AUjlESU5rgqB6ZX0fDs0=; b=LFc833U6GocnaK3CTzP8F10nC3++Vy5+t7udHD0zAniYWoiVnZ/CxyjIOF9jFgpA4I ZA6AV+Z/czz9E+0wWs3U8bXKtRxjKNRpZqMTJThVHfgQFy8b/s7VrueLAudPRevBHxkh elhgr78nM6GT6M57cPJHsgzTyV+AvKUXL2LqJOBEwLKsVhugV/s9htj6B34cdGeRonzt YOZzatJWqPZCdJT8HqCA7ugA6U4+lAx7n5pOllBG8OcvGAckQi2ahM7Hq4x/W5+qJ5H3 w53lLre8p4xicsfjn8wqKwdTK8MNyxaAF6PB3EM4Tf1SfV/hhcRJedI15ADa1TIXQXYB maPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GnPyPOAEGseCgs8OJ4qt7L8AUjlESU5rgqB6ZX0fDs0=; b=z/xGFPzjRDHF07dbpdIL600PFBZdk2JeBCNWkMxjggAjGzwChJzvktmZ4oTsERu1Fd 1UzS3vOJ3o/JSFglvENF/4ltPnCrmV64zf4xYZvm9ImYCpiCZy4Cp9YJkwGvnhAL1WpO GVyThIgYKBQtZJ4QG83kkg+t0yHE0amueeuAlZeUlx0TKK+qpLV7uT1bgSGz9P5iRc7T SHaljdUEx/r9+1mIYRXsS5YdVXlqXOpqM/u8sSM6ptj2OGzTR6y847UJ55Nf26xh4hA6 dUsEiXp1eQBMjCN4xpmq09Jf3aa44LvhJCkdC7p/BYKf4FLo1Akd9NEmVZb9FZjZZYSt YBIw== X-Gm-Message-State: AFqh2koIjhmCxdmvdFQXNHwrPYNAVxh8iC6kt9sORWzy5R5OfGH5gOn9 tlMJMWMKrZ38RNsm1HHhAyo4ck+Hv5o= X-Google-Smtp-Source: AMrXdXvaRHz+POjae6teUiGpxX3dJBg3wg2WSO/lFqXAakcCttq0sg+7+68zm1nB7edoXAVgUfP4wg== X-Received: by 2002:a05:6e02:1a67:b0:30f:333a:7b53 with SMTP id w7-20020a056e021a6700b0030f333a7b53mr2146367ilv.9.1674061668208; Wed, 18 Jan 2023 09:07:48 -0800 (PST) Received: from washu-v4 (c-174-51-139-101.hsd1.co.comcast.net. [174.51.139.101]) by smtp.gmail.com with ESMTPSA id o32-20020a027420000000b0038a5b8d79basm10753904jac.106.2023.01.18.09.07.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Jan 2023 09:07:47 -0800 (PST) From: Katherine Cox-Buday To: control@debbugs.gnu.org Subject: Merging erroneously opened bugs Date: Wed, 18 Jan 2023 10:07:46 -0700 Message-ID: <87zgafrct9.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) merge 60899 60904 60907 60908 60917 60920 60921 60919 60910 60903 60915 60914 60922 60909 60918 60913 60900 60899 60905 60901 60912 60898 60906 60902 60916 60911 -- Katherine From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 06 17:06:59 2023 Received: (at submit) by debbugs.gnu.org; 6 Feb 2023 22:06:59 +0000 Received: from localhost ([127.0.0.1]:50114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pP9da-0006d4-Hy for submit@debbugs.gnu.org; Mon, 06 Feb 2023 17:06:58 -0500 Received: from lists.gnu.org ([209.51.188.17]:53996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pP9dY-0006cv-G0 for submit@debbugs.gnu.org; Mon, 06 Feb 2023 17:06:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pP9dT-0004EI-Rv for guix-patches@gnu.org; Mon, 06 Feb 2023 17:06:56 -0500 Received: from mira.cbaines.net ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pP9dR-00073L-U2 for guix-patches@gnu.org; Mon, 06 Feb 2023 17:06:51 -0500 Received: from localhost (unknown [IPv6:2a02:1808:200:8622:f055:17e:cfb4:2]) by mira.cbaines.net (Postfix) with ESMTPSA id BE52827BBE9; Mon, 6 Feb 2023 22:06:47 +0000 (GMT) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id edadb5b3; Mon, 6 Feb 2023 22:06:41 +0000 (UTC) References: <20230118014510.19320-1-cox.katherine.e@gmail.com> <20230118014510.19320-9-cox.katherine.e@gmail.com> User-agent: mu4e 1.8.11; emacs 28.2 From: Christopher Baines To: Katherine Cox-Buday Subject: Re: [bug#60905] [PATCH 08/25] gnu: go-github-com-pkg-diff: Update to 0.0.0-20210226163009-20ebb0f2a09e. Date: Mon, 06 Feb 2023 23:04:26 +0100 In-reply-to: <20230118014510.19320-9-cox.katherine.e@gmail.com> Message-ID: <87wn4ucuts.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: 60905@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Katherine Cox-Buday writes: > * gnu/packages/golang.scm (go-github-com-pkg-diff): Update to 0.0.0-20210= 226163009-20ebb0f2a09e. > --- > gnu/packages/golang.scm | 44 +++++++++++++++++++---------------------- > 1 file changed, 20 insertions(+), 24 deletions(-) > > diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm > index 9554234c7b..5e8159975f 100644 > --- a/gnu/packages/golang.scm > +++ b/gnu/packages/golang.scm > @@ -8736,30 +8736,26 @@ (define-public go-github-com-go-git-go-git-fixtur= es > (license license:asl2.0))) >=20=20 > (define-public go-github-com-pkg-diff > - (let ((commit "531926345625d489a6b56f860a569e68245ace36") > - (revision "1")) > - (package > - (name "go-github-com-pkg-diff") > - (version (git-version "0.0.1" revision commit)) > - (source (origin > - (method git-fetch) > - (uri (git-reference > - (url "https://github.com/pkg/diff") > - (commit commit))) > - (file-name (git-file-name name version)) > - (sha256 > - (base32 > - "1770m7qhww6lm0wj1v3mhv6hwa2v92p4w2fqxj1xyrg5dd58d944"= )))) > - (build-system go-build-system) > - (arguments > - `(#:import-path "github.com/pkg/diff")) > - (native-inputs > - (list go-github-com-sergi-go-diff)) > - (home-page "https://github.com/pkg/diff/") > - (synopsis "Create and print diffs") > - (description > - "This package provides a Go library to create and print diffs.") > - (license license:bsd-3)))) > + (package > + (name "go-github-com-pkg-diff") > + (version "0.0.0-20210226163009-20ebb0f2a09e") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/pkg/diff") > + (commit "20ebb0f2a09e612109b224b32f79370409108bcc"))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "1g3dzgwhz4fx3ddpsv7fsa4r1v5clsp2lbw2qrkdk9y1vc5gi8yi"))= )) > + (build-system go-build-system) > + (arguments > + `(#:import-path "github.com/pkg/diff")) > + (home-page "https://github.com/pkg/diff/") > + (synopsis "Create and print diffs") > + (description > + "This package provides a Go library to create and print diffs.") > + (license license:bsd-3))) >=20=20 > (define-public go-github-com-twpayne-go-shell > (package I'm not sure I prefer the longer version here, and also having the commit in the origin but then part of it in the version makes this a little harder to update since you have to update both bits. What led you to change from using the (let ((... bit here? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmPhee9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XcCKw/+OlFcTShxtaQHc9dLU/2BxmURE27P5UsE j8v2wLWbQTZTA+CYJDNATS078BcZjkuiQ4OYe443sJolbyRgHZYgBk+wkj8R3gK+ tPjSBDNtGBldGbKoI79OKlmssV/fN9kACVbkfyd4G6TnIq2vi0h8+Zn7D8lariA6 CKSmuK7zMoUVP7+VM3r1bMg6e5QUbDLMzkZOkMys7eSiezGv64HXTyk204aVTCiD 44q9Xixox3GfZPW+3QykXXv9Xm0NtMPST5Dt4twhunzFzFHsgSnJ150cStDmG9vd jVuy67KIxXvuFpokTkzdAYazZGWgQlvoGmtPFk1fIPt6CbuLUGrJjO9gm/40zDoV 7Jq1I08M7JPFC9a5W1agU4B6Q//t5Pzf5rBUt8vN+9HKjeI2BAiyE+s/bx5Ht66A Bv0yY0NiulmMXSBDaqhKfwfQEsS4FETA2AQB/azBVatAXcfT5PIHH4SH6yAaw/Sh QgXJhNwXH+SpYPP0yuyjr0owUnRRAio32rthqmW6f0g8jVmgwuIw8TFB7KPxBmZd pNcZ6Uu/pcyegplYqzXPwS8Ow88R/g2//SwMRrtZYDNZIicwBoHGpd5CbzVxPCbe lUqokbAG0HJWic/yGr9aQnnURT39+woZnwM3L8tP7zRh2L2dX5Wr5p0BP1AauVId x0ev7ZWQTFA= =pxpu -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 06 17:20:30 2023 Received: (at 60905) by debbugs.gnu.org; 6 Feb 2023 22:20:30 +0000 Received: from localhost ([127.0.0.1]:50136 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pP9qg-00070H-62 for submit@debbugs.gnu.org; Mon, 06 Feb 2023 17:20:30 -0500 Received: from knopi.disroot.org ([178.21.23.139]:49332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pP9qd-0006zz-70 for 60905@debbugs.gnu.org; Mon, 06 Feb 2023 17:20:28 -0500 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id A34EB412CE; Mon, 6 Feb 2023 23:20:25 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dM5VT3bzgDWC; Mon, 6 Feb 2023 23:20:24 +0100 (CET) Content-Type: multipart/signed; boundary=8c90c444d5c7a7c5a74a23e092f16453116e17ba0606803bd8e0dc61a3dc; micalg=pgp-sha512; protocol="application/pgp-signature" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1675722024; bh=BFRFHBOrm3o4q5i2ylI5AvpOd1iVtzH5j0aLtd4qi74=; h=Date:Subject:From:To:References:In-Reply-To; b=al4oXP/MyIkoot1/hRy+EmkrYLrw75k2C88UHvhgdWwmE0pHMHd6TVTvYC2nEXq5+ INGY6Ol1jOXV1shmXiF2l1gBBLXnq5cYiXq1HCB8uSX6djxMtDjme4udJgD3odq6WW opaOrfRYz4Z7vL0PBS3cwktCnGWn25PcO8A7axhkFxB6MkC4KltrBMJi3yfemeF0o5 YYcHJNqilzRzI/mUMYVOZ7vV7au9vFcwIVmPk3t2/phFirWKFS+cjBNX/ljkDkaYAb H4DXrh2PIu7pNuW+pxn/LScGeajqRDdQ4uuM1tNb4EC4gb6Rw/R99axAm+8vNgE/Qn 0VCwDwqTnp5vQ== Date: Mon, 06 Feb 2023 22:20:23 +0000 Message-Id: Subject: Re: [bug#60905] [PATCH 08/25] gnu: go-github-com-pkg-diff: Update to 0.0.0-20210226163009-20ebb0f2a09e. From: "(" To: "Katherine Cox-Buday" , <60905@debbugs.gnu.org> References: <20230118014510.19320-1-cox.katherine.e@gmail.com> <20230118014510.19320-9-cox.katherine.e@gmail.com> In-Reply-To: <20230118014510.19320-9-cox.katherine.e@gmail.com> X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 60905 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) --8c90c444d5c7a7c5a74a23e092f16453116e17ba0606803bd8e0dc61a3dc Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 * gnu/packages/golang.scm (go-github-com-pkg-diff): Update to 0.0.0-2021022= 6163009-20ebb0f2a09e. > --- a/gnu/packages/golang.scm > +++ b/gnu/packages/golang.scm > @@ -8736,30 +8736,26 @@ (define-public go-github-com-go-git-go-git-fixtur= es > + (package > + (name "go-github-com-pkg-diff") > + (version "0.0.0-20210226163009-20ebb0f2a09e") As Chris said, don't use this kind of version string :) > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/pkg/diff") > + (commit "20ebb0f2a09e612109b224b32f79370409108bcc"))= ) And especially don't write the commit twice. > + (synopsis "Create and print diffs") (synopsis "Generate and print diffs in Go") > + (description > + "This package provides a Go library to create and print diffs.") (description "This package provides a Go library to generate and print file differences in the @code{diff} format.") -- ( --8c90c444d5c7a7c5a74a23e092f16453116e17ba0606803bd8e0dc61a3dc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEE6Vh10NblKE5doNlW7ImHg/nqI20FAmPhfSgACgkQ7ImHg/nq I21Kfwv/RP3h1xVj1KL3YJMtG2SwzhxEzLfZBf3qs2yBO/jBY0aiBJmveNi6/eR/ W/e1eUz8SDIsUTN4j+bE3GyARXsDl9Stwp5lIFe7ZoVc9W2+h1pHdQW1KAEkcN7z bnJY6vUI5po9JYC76M0wxHfmZd2Vek5vdM/YoyYQe6rLcOlyB5I3/Ouqoe5C4UBP 4y2DyLD40AoQfYMp5RHWHwV5VNkbBaERmQI/XMrFew92mPGyUJvzNvTrEVnMdQzY 0pxCxuvqHmoqmmiUH+IvDYCVcwsiOeb5PJzbR3p5xle34ly7i4L9RJeOUKpJhgts C1U7Ha5B8ub4g8ZX+Wm+bQILa2C0yG6xEz9wR6elt/8jmd8TX3MCGpNK2zVtilQ5 F2owJ4gETGPF+2K9E7uru8A+M7rUMGItoLajCJwjqBoTyMJPvIWkRsJ97z/hYcfs 1IMv/oBvAfhmWCWcelBtil+WFrzHQy9xtMBbqD4+WYbQlKR5sY+6FeROQxtC8nOl GFInEXSu =BusQ -----END PGP SIGNATURE----- --8c90c444d5c7a7c5a74a23e092f16453116e17ba0606803bd8e0dc61a3dc-- From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 07 12:04:51 2023 Received: (at submit) by debbugs.gnu.org; 7 Feb 2023 17:04:51 +0000 Received: from localhost ([127.0.0.1]:53890 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPROk-0001vM-QG for submit@debbugs.gnu.org; Tue, 07 Feb 2023 12:04:51 -0500 Received: from lists.gnu.org ([209.51.188.17]:37024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPROj-0001v7-5F for submit@debbugs.gnu.org; Tue, 07 Feb 2023 12:04:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPRON-0006GK-0m for guix-patches@gnu.org; Tue, 07 Feb 2023 12:04:28 -0500 Received: from mail-io1-xd31.google.com ([2607:f8b0:4864:20::d31]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pPROK-0005SG-Ps for guix-patches@gnu.org; Tue, 07 Feb 2023 12:04:26 -0500 Received: by mail-io1-xd31.google.com with SMTP id a10so599105iod.0 for ; Tue, 07 Feb 2023 09:04:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=wSFb56WLVaFmRA/1Bed5m25GnH18+1xzUYsP9lqAJO8=; b=NclwWNOkBqywXNUmbYG0YkTi0ddwQRpaWJ2v8P3+cLZ81WenAXuKuMctjhBf98O9kT QfTLQIuNCK7VJQ7sFXcv0Xwl5r6FwxfEOker61NyZd3L8U4VhFaeB2esT3/shyLa4GZY U6yndC6n+wzNLFPj2UothOAlg/ER2ENvhV5piU2lHOwO2N/+0CYJBzhBMTB2V6ABuXbJ /xrX+tn7MS+ljLhCdrfAyBsipBg51HrTGx/bauITbTGKgs9hV03eGU1Mg/S9NG3sj2Li aIZcm+jSyqgBTuaEEbC4dbVBNT1xfJ8t5p/yHq37OkcUUX7Ed7JxGLUA/glRHePL/K23 zPpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wSFb56WLVaFmRA/1Bed5m25GnH18+1xzUYsP9lqAJO8=; b=foeg0prfWWInIG7sTqBkWj1yNMHPhtLHk8cMlI2x0MaU9KMN7xa3cL/LOtAPn3zNTw 3hv6Q6tF64rRiCi314z2qqHW+pN1/uaM2UvuhAefXsfRA1dELXKsuK5/xkUgaIEmttrx Ozvlt8fhK9ie8TJ3aGC0lfGBGgW+IbaMxovj0yB7ct3ocbIt/KjozfziwLx4Ukz4HnDK hLpndcuNF59qDX5aH3L99xfm7NN83OrpJWuuRi8yLyiZOvCpCxMaPzGl5IyEat6ea2uZ uzV4Rvhxen7qIq7l0dX1ZkrbN3byBCglwWrZcPUlj5NDg9qVGYLsy1KI95ob7ofWo7y3 nnEg== X-Gm-Message-State: AO0yUKU57VXGcSm6yXYKoYNWFuah3R/zVbwREO7XQHT7kZshuh3d2UUb gw6L5PUxjiP4c/Thc1kDiqrwOJ0g3ffQ9A== X-Google-Smtp-Source: AK7set/kr1MossOPFbA+tWEAWfLYtP3E2Yj7Wh62qpWVXocsFkbajJsD8HjVOfpfS6vVJrW2ipfLpA== X-Received: by 2002:a6b:4a12:0:b0:71e:24ee:5352 with SMTP id w18-20020a6b4a12000000b0071e24ee5352mr3354913iob.17.1675789458914; Tue, 07 Feb 2023 09:04:18 -0800 (PST) Received: from washu-v4 (c-174-51-139-101.hsd1.co.comcast.net. [174.51.139.101]) by smtp.gmail.com with ESMTPSA id q8-20020a027b08000000b003af4300d670sm4662063jac.27.2023.02.07.09.04.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 09:04:18 -0800 (PST) From: Katherine Cox-Buday To: "( via Guix-patches" via , Christopher Baines Subject: Re: [bug#60905] [PATCH 08/25] gnu: go-github-com-pkg-diff: Update to 0.0.0-20210226163009-20ebb0f2a09e. References: <20230118014510.19320-1-cox.katherine.e@gmail.com> <20230118014510.19320-9-cox.katherine.e@gmail.com> Date: Tue, 07 Feb 2023 10:04:17 -0700 In-Reply-To: (guix-patches@gnu.org's message of "Mon, 06 Feb 2023 22:20:23 +0000") Message-ID: <87mt5pxv8u.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::d31; envelope-from=cox.katherine.e@gmail.com; helo=mail-io1-xd31.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: "\(" , 60905@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) "( via Guix-patches" via writes: > * gnu/packages/golang.scm (go-github-com-pkg-diff): Update to > 0.0.0-20210226163009-20ebb0f2a09e. > >> --- a/gnu/packages/golang.scm >> +++ b/gnu/packages/golang.scm > >> @@ -8736,30 +8736,26 @@ (define-public go-github-com-go-git-go-git-fixtures > >> + (package >> + (name "go-github-com-pkg-diff") >> + (version "0.0.0-20210226163009-20ebb0f2a09e") > > As Chris said, don't use this kind of version string :) Ah, I actually have (what I think) is a valid reason for this. In Go, when a module is in development, this long string, including the SHA, is the actual version[1] of the module, and carries semantics for Go developers, i.e. "Signals that the module is still in development and unstable. The release carries no backwards compatibility or stability guarantees." It's how it will be referenced by other Go modules, and so I thought it best to make the version field reflect the actual version. The previous iteration of this package had an incorrect version: upstream did not assign it a 0.0.1 version; that's something we did. I agree that this is confusing for Guix maintainers, and causes duplicate information in the version and commit fields. What are your opinions on this? >> + (source (origin >> + (method git-fetch) >> + (uri (git-reference >> + (url "https://github.com/pkg/diff") >> + (commit "20ebb0f2a09e612109b224b32f79370409108bcc"))) > > And especially don't write the commit twice. > >> + (synopsis "Create and print diffs") > > (synopsis "Generate and print diffs in Go") I only bumped the version here; the synopsis was pre-existing. But: is the language important? Do we say "Diff creates and prints diffs in C"? >> + (description >> + "This package provides a Go library to create and print diffs.") > > (description > "This package provides a Go library to generate and print file > differences in the @code{diff} format.") [1] https://go.dev/doc/modules/version-numbers#in-development -- Katherine From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 07 12:49:15 2023 Received: (at submit) by debbugs.gnu.org; 7 Feb 2023 17:49:15 +0000 Received: from localhost ([127.0.0.1]:53953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPS5j-0003B3-Dw for submit@debbugs.gnu.org; Tue, 07 Feb 2023 12:49:15 -0500 Received: from lists.gnu.org ([209.51.188.17]:45524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPS5h-0003Aw-KK for submit@debbugs.gnu.org; Tue, 07 Feb 2023 12:49:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPS5Z-0004uD-Se for guix-patches@gnu.org; Tue, 07 Feb 2023 12:49:07 -0500 Received: from knopi.disroot.org ([178.21.23.139]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPS5X-0006b8-Ep for guix-patches@gnu.org; Tue, 07 Feb 2023 12:49:05 -0500 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id C67AE41092; Tue, 7 Feb 2023 18:49:01 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aItAzDWHu61E; Tue, 7 Feb 2023 18:49:00 +0100 (CET) Content-Type: multipart/signed; boundary=45cab4afc129225684b4cf5b2bd9449cd8e36fdb170133c86f5df5ce5d8b; micalg=pgp-sha512; protocol="application/pgp-signature" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1675792140; bh=SWy2A4UfWxPdk441Bdt/W0qdX515KP+GucMznrfwW9Y=; h=Date:Subject:From:To:Cc:References:In-Reply-To; b=RCT0z+6s9BBzf6sAy+ZUG387iew5IaXBa4Rem4P16zlKao5iigLRVqyscwV/a3qeW f1G3DTkpmLx6l+jfT4IMkUqcj9D/guiksWmU4PcIvR7ATzKvud9X/h2zW4UOOjqnI7 wLm4JncUhBw3jJMzLRU3YI4vR4t7ljS/gwODabnNRsLKv7aILhIspSDE02mhAqvRyn V1WW3fZjaFPTdnGxz1w6dI1UnBs9MAxq/DLUFNOaxnfs8iU/UMbGIKUGQiMRsM3I7l PAl6JyIKNByWgWRdb2P5f8m3LO6sAdUuJXKHLhWvjMSL67+IunB/gqlxyePpkmmgAw ZwmCZre4eZFyw== Date: Tue, 07 Feb 2023 17:48:59 +0000 Message-Id: Subject: Re: [bug#60905] [PATCH 08/25] gnu: go-github-com-pkg-diff: Update to 0.0.0-20210226163009-20ebb0f2a09e. From: "(" To: "Katherine Cox-Buday" , "( via Guix-patches via" , "Christopher Baines" References: <20230118014510.19320-1-cox.katherine.e@gmail.com> <20230118014510.19320-9-cox.katherine.e@gmail.com> <87mt5pxv8u.fsf@gmail.com> In-Reply-To: <87mt5pxv8u.fsf@gmail.com> Received-SPF: pass client-ip=178.21.23.139; envelope-from=paren@disroot.org; helo=knopi.disroot.org X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MIME_HEADER_CTYPE_ONLY=0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: 60905@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --45cab4afc129225684b4cf5b2bd9449cd8e36fdb170133c86f5df5ce5d8b Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Tue Feb 7, 2023 at 5:04 PM GMT, Katherine Cox-Buday wrote: > What are your opinions on this? Hmm, interesting. I think this would be better answered by more experience= d contributors. > > >> + (source (origin > >> + (method git-fetch) > >> + (uri (git-reference > >> + (url "https://github.com/pkg/diff") > >> + (commit "20ebb0f2a09e612109b224b32f79370409108bcc= "))) > > > > And especially don't write the commit twice. I should've elaborated: use GO-VERSION->GIT-REF here :) > I only bumped the version here; the synopsis was pre-existing. But: is th= e language important? Do we say "Diff creates and prints diffs in > C"? Isn't this also a Go library? If it isn't, then yeah, it's not important, but if it is, I'd say you should add "in Go". -- ( --45cab4afc129225684b4cf5b2bd9449cd8e36fdb170133c86f5df5ce5d8b Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEE6Vh10NblKE5doNlW7ImHg/nqI20FAmPijwwACgkQ7ImHg/nq I22fPgwA5oN+JDo9QPluPDZOs7wcNyjBwYmQvbChBGWrbhhTwxuAjix6X8FCFNZC jVhNt1kf9CbuectvWbAM07Fa0j8mrRxTDEeXOz4QFFyYzrCRurrNDTTzmA0rrMOZ 1kAecmBIQYEwk9YueLO7edztThPSkABJq/7eMTOqYOjTm3itMeWdjPu//F8yMegs YNRZWhgB5a3PfihJp1y9EziJGhrouI0Q+TjKIbOk4MvswymjKx46j8SOplC3z0KG +qV2pnUd/96fROgN8Zl6Z6jU2aioSVld2b6NX/ubFgZ+HCUyQv4ZD777dr0QNyD6 aYsDz8SbuywW23i/ip7as36SIK9P461Y6APpTs6FEU5h4tnuBGneK5bvSoD8t5Hz q9DdGrPe6pvy/S5WMhwveJMWKxKYpNaxZsBcmOeChKGJ5jl5VGJzHEOQlsskXl89 PUPgMANnjxHEn69w9F4ax5BxKr3IQLMn/+SRyaJGKOxfA0t3p58oyj8ODZyE0k0A L0L4qZjR =peD8 -----END PGP SIGNATURE----- --45cab4afc129225684b4cf5b2bd9449cd8e36fdb170133c86f5df5ce5d8b-- From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 08 06:51:27 2023 Received: (at submit) by debbugs.gnu.org; 8 Feb 2023 11:51:28 +0000 Received: from localhost ([127.0.0.1]:54932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPiz1-0006da-Jy for submit@debbugs.gnu.org; Wed, 08 Feb 2023 06:51:27 -0500 Received: from lists.gnu.org ([209.51.188.17]:51728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPiz0-0006dR-7A for submit@debbugs.gnu.org; Wed, 08 Feb 2023 06:51:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPiyz-0008PO-Vj for guix-patches@gnu.org; Wed, 08 Feb 2023 06:51:25 -0500 Received: from mira.cbaines.net ([212.71.252.8]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPiyy-0004gJ-Dk for guix-patches@gnu.org; Wed, 08 Feb 2023 06:51:25 -0500 Received: from localhost (unknown [185.201.63.253]) by mira.cbaines.net (Postfix) with ESMTPSA id 70A5516121; Wed, 8 Feb 2023 11:50:07 +0000 (GMT) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 9bcad4f9; Wed, 8 Feb 2023 11:49:56 +0000 (UTC) References: <20230118014510.19320-1-cox.katherine.e@gmail.com> <20230118014510.19320-9-cox.katherine.e@gmail.com> <87mt5pxv8u.fsf@gmail.com> User-agent: mu4e 1.8.11; emacs 28.2 From: Christopher Baines To: Katherine Cox-Buday Subject: Re: [bug#60905] [PATCH 08/25] gnu: go-github-com-pkg-diff: Update to 0.0.0-20210226163009-20ebb0f2a09e. Date: Wed, 08 Feb 2023 12:47:38 +0100 In-reply-to: <87mt5pxv8u.fsf@gmail.com> Message-ID: <877cws74wr.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=212.71.252.8; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: "\(" , 60905@debbugs.gnu.org, "\( via Guix-patches via" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Katherine Cox-Buday writes: > "( via Guix-patches" via writes: > >> * gnu/packages/golang.scm (go-github-com-pkg-diff): Update to >> 0.0.0-20210226163009-20ebb0f2a09e. >> >>> --- a/gnu/packages/golang.scm >>> +++ b/gnu/packages/golang.scm >> >>> @@ -8736,30 +8736,26 @@ (define-public go-github-com-go-git-go-git-fixtures >> >>> + (package >>> + (name "go-github-com-pkg-diff") >>> + (version "0.0.0-20210226163009-20ebb0f2a09e") >> >> As Chris said, don't use this kind of version string :) > > Ah, I actually have (what I think) is a valid reason for this. In Go, > when a module is in development, this long string, including the SHA, is > the actual version[1] of the module, and carries semantics for Go > developers, i.e. "Signals that the module is still in development and > unstable. The release carries no backwards compatibility or stability > guarantees." > > It's how it will be referenced by other Go modules, and so I thought it > best to make the version field reflect the actual version. The previous > iteration of this package had an incorrect version: upstream did not > assign it a 0.0.1 version; that's something we did. > > I agree that this is confusing for Guix maintainers, and causes > duplicate information in the version and commit fields. > > What are your opinions on this? I guess I'm not that fussed if a long version has some use. What I would say is that as long as the version incorporates the commit in some way and the commit is used in the package source bit, I'd use the (let ((commit ... pattern to avoid duplicating bits of the commit hash and make tweaking the commit easier. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmPjjGRfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xe1cg//VMgthrE21DVF60JWLFe0SUY6JZbHOggi /fT0iEDnrkW4Tr1r7OwBWlZ2BRHoLia44zlZWG08+e7rGJqzbxaVcZGRUv+Dk5Gu 53Vy6OpGttOgldMfRvmpVzciNGVlVuR7BIPN+qjZgWClnq99InTWU0lJ8rxmSCqc XKShr7OuCYtqwMu4LLyz1z3J2h9+Nq7Kq2sSVRuwTFqXmKZK9POjdmODXD4Vuarx 5Cp268KFKB2RAIxGpYv3nzTcBTNobDDDwEyFVrvClAXo9GffrHiT1C0Np2w3AAP1 URjr8/Jgu7Q5Xmk0y7ddq/4z9VqppEaqi6/paC3+iXt/5nofnH3A9pOT6HiaZO0i RJQzBBfBpxoE4WHFCl1ExehzPFyvpcwBGuu1hAjSOsGQc02P4RDCO8nhvYXUuqlJ EIpYifMf9Nz/Pd/lBvFXZtjLT9mtqgKQkJot6NGtmYxR0z5RHkz7Z9kYddFfDqVG 9AgiGSUMVBngHzH/myZsFehvCGvjNPm4ykJqTtVJzerVxoK35VhGG0Rx3G3yUzx5 jOLZyAZjmS23s7RV7xFeNMuOEsMDBNGCHnEVTn7Y/TE6WLNfW1uGsUVXlInA+8zK tNeqpvZb4ipmINcWMekviPDgFyigSVtL2BHNwP9/Z2rcS+jNrO5TVGS3GHHd57/R gMWCzFbPmyM= =2yqj -----END PGP SIGNATURE----- --=-=-=-- From unknown Fri Aug 15 04:04:39 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 08 Mar 2023 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator