GNU bug report logs - #60899
[PATCH 00/25] gnu: golang: Add gopls

Previous Next

Package: guix-patches;

Reported by: Katherine Cox-Buday <cox.katherine.e <at> gmail.com>

Date: Wed, 18 Jan 2023 01:46:02 UTC

Severity: normal

Tags: patch

Merged with 60898, 60900, 60901, 60902, 60903, 60904, 60905, 60906, 60907, 60908, 60909, 60910, 60911, 60912, 60913, 60914, 60915, 60916, 60917, 60918, 60919, 60920, 60921, 60922

Done: Christopher Baines <mail <at> cbaines.net>

Bug is archived. No further changes may be made.

Full log

Message #164 received at 60899 <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: "Katherine Cox-Buday" <cox.katherine.e <at> gmail.com>, <60899 <at> debbugs.gnu.org>
Subject: Re: [bug#60899] [PATCH 25/25] gnu: Add gopls.
Date: Mon, 06 Feb 2023 23:28:13 +0000

[Message part 1 (text/plain, inline)]
* gnu/packages/golang.scm (gopls): New variable.

> --- a/gnu/packages/golang.scm
> +++ b/gnu/packages/golang.scm

> @@ -3021,6 +3021,51 @@ (define-public go-golang-org-x-vuln

> +    (arguments
> +     `(#:import-path "golang.org/x/tools/gopls"
> +       #:unpack-path "golang.org/x/tools"
> +       #:install-source? #f
> +       #:phases (modify-phases %standard-phases
> +                  (add-before 'unpack 'override-tools
> +                    (lambda _
> +                      (delete-file-recursively "src/golang.org/x/tools"))))))

s/override/remove-other/, perhaps?

> +    (propagated-inputs (list go-github-com-google-go-cmp-cmp
> +                             go-github-com-jba-printsrc
> +                             go-github-com-jba-templatecheck
> +                             go-github-com-sergi-go-diff
> +                             go-golang-org-x-mod
> +                             go-golang-org-x-sync
> +                             go-golang-org-x-sys
> +                             go-golang-org-x-text
> +                             go-gopkg-in-yaml-v3
> +                             go-honnef-co-go-tools
> +                             go-github-com-burntsushi-toml
> +                             go-github-com-google-safehtml
> +                             go-golang-org-x-exp
> +                             go-mvdan-cc-gofumpt
> +                             go-golang-org-x-vuln
> +                             go-mvdan-cc-xurls))

Could this be changed to just ``inputs''?

> +    (description
> +     "Pronounced \"Go please\", this is the official Go language server developed by
> +the Go team.  It provides IDE features to any LSP-compatible editor.")

  (description
   "This package provides the official @acronym{LSP, language server protocol}
  server for the Go language, allowing LSP-compatible editors to automatically
  support @acronym{IDE, integrated development environment}-like features.")

    -- (

[signature.asc (application/pgp-signature, inline)]
This bug report was last modified 2 years and 160 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.