From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 17 20:45:25 2023 Received: (at submit) by debbugs.gnu.org; 18 Jan 2023 01:45:25 +0000 Received: from localhost ([127.0.0.1]:38591 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHxW0-0007TK-W7 for submit@debbugs.gnu.org; Tue, 17 Jan 2023 20:45:25 -0500 Received: from lists.gnu.org ([209.51.188.17]:60090) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHxVv-0007SI-0P for submit@debbugs.gnu.org; Tue, 17 Jan 2023 20:45:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHxVr-0001za-Og for guix-patches@gnu.org; Tue, 17 Jan 2023 20:45:16 -0500 Received: from mail-il1-x12c.google.com ([2607:f8b0:4864:20::12c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pHxVp-0006uh-Q9 for guix-patches@gnu.org; Tue, 17 Jan 2023 20:45:15 -0500 Received: by mail-il1-x12c.google.com with SMTP id a3so10443126ilp.6 for ; Tue, 17 Jan 2023 17:45:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=oYE8nnbSS6MHfxwz9J9toI6fQ+Ope2CIzPRI98rxF68=; b=G/Lq9cL+mCQ8zTnxBZ0yY5GMrT2OkolRy3Slp1nrifzk43JWBO6auAXljfXa5JdZiY Ck+yrDRnO75o95yc1MBb4Bl1kOu18IF3v0/G+ukxdcHSjQVXZc+maPBFk1iUlY2WjvAD h4LBzSvRpcOtWBlFzSr2POxgS7OXazjdql15j8c62u4iMEckL2toF3mTyfjDORdMqO+S BeKWGDldg4nUiUaQawe9OU1o/XPswTG40YBNoF5TjwcRY17fc8Q1+zQYvwEmQA2gE9v8 VV6pMc1VxjerH2/2NRx5nLPOS0AK7hVpiR6j0FWBFjKL2dZKielX2lmXrhdMUxUgHRCM 6GVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oYE8nnbSS6MHfxwz9J9toI6fQ+Ope2CIzPRI98rxF68=; b=cpS4OFZSTOdE29MVhv+58MO8YTFQH+C7aY2BMrmxlB5bvdxVEg3YEbnkdevdp3IIPD VwxQ8RcI0RXAWpcJJ7p6YozOLYaLkIb5ErnB//XM1zcwRWKVvyiXQL7cRSRPvwh7p8j4 xrWxqoxVwbnTtTiTSlz7MOmRnYnxZrMI9w1mbDJI6d4RIO0XLFZisDDx0023nWhTwo+T mHlVKoQZMdK9vAPg8+IgwbKOZRwD3E66APxzc8zQUYobVdZ+jL0SQQyme0jfZRXCsNm1 ZaooazksQvaQpg2ErRnIU+c8/5d7jhOgkajiiin9F16uaIZg4ggNHM0rpmv/V5lMPZn6 N/gw== X-Gm-Message-State: AFqh2kr0m+aeCjA9vG3N9oxvyusyoZxAs7JAQljVFjBzQtTWGULCYvSA /9ncKNkqtXsweY25jNvwul7YycXLQZk= X-Google-Smtp-Source: AMrXdXtfjLyMPXS6Xw4Ug7uCQvszdKZBkzQDvw5fo1H3sHu33RIHCF3o0O0RjdrdKlR1KrmJv3jAVw== X-Received: by 2002:a92:6e11:0:b0:30d:c089:f479 with SMTP id j17-20020a926e11000000b0030dc089f479mr4115277ilc.7.1674006311851; Tue, 17 Jan 2023 17:45:11 -0800 (PST) Received: from washu-v4.home.cox-buday.com (c-174-51-139-101.hsd1.co.comcast.net. [174.51.139.101]) by smtp.gmail.com with ESMTPSA id p32-20020a056638192000b0039e89ea68f9sm7889250jal.135.2023.01.17.17.45.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jan 2023 17:45:11 -0800 (PST) From: Katherine Cox-Buday To: guix-patches@gnu.org Subject: [PATCH 00/25] gnu: golang: Add gopls Date: Tue, 17 Jan 2023 18:44:45 -0700 Message-Id: <20230118014510.19320-1-cox.katherine.e@gmail.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::12c; envelope-from=cox.katherine.e@gmail.com; helo=mail-il1-x12c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Katherine Cox-Buday X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a patch series to add the gopls package. I haven't contributed to many projects which use the e-mail flow, so hopefully I'm doing this correctly. Please feel free to make suggestions if not! Some of the diffs are a little busier than I'd like for version bumps. This is due to running `guix style` over everything. For all of the packages I have: . Run guix style . Run guix lint . Built 2x . Checked that the change is in the correct branch . Built all dependencies . Built the repository Katherine Cox-Buday (25): gnu: go-golang-org-x-sync: Update to 0.1.0-1.8fcdb60. gnu: go-golang-org-x-mod: Update to 0.7.0. gnu: Add go-golang-org-x-exp. gnu: Add go-github-com-jba-printsrc. gnu: Add go-github-com-google-safehtml. gnu: Add go-github-com-jba-templatecheck. gnu: go-github-com-google-go-cmp-cmp: Update to 0.5.9. gnu: go-github-com-pkg-diff: Update to 0.0.0-20210226163009-20ebb0f2a09e. gnu: go-github-com-rogpeppe-go-internal: Update to 1.9.0. gnu: gopkg-in-errgo-fmt-errors: Rename package to go-gopkg-in-errgo-fmt-errors. gnu: go-golang-org-x-tools: Update to 0.5.0. gnu: Add xurls. gnu: Add go-mvdan-cc-xurls. gnu: Add misspell. gnu: Add go-github-com-client9-misspell. gnu: Add go-github-com-google-go-cmdtest. gnu: Add unparam. gnu: Add go-mvdan-cc-unparam. gnu: Add govulncheck. gnu: Add go-golang-org-x-vuln. gnu: go-github-com-burntsushi-toml: Update to 1.2.1. gnu: go-honnef-co-go-tools: Update to 0.3.3. gnu: Add gofumpt. gnu: Add go-mvdan-cc-gofumpt. gnu: Add gopls. gnu/packages/configuration-management.scm | 2 +- gnu/packages/golang.scm | 695 ++++++++++++++++++---- 2 files changed, 578 insertions(+), 119 deletions(-) base-commit: 5c921977179489caef4a9e54ada6696fc86d2f0b -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 17 20:46:18 2023 Received: (at submit) by debbugs.gnu.org; 18 Jan 2023 01:46:18 +0000 Received: from localhost ([127.0.0.1]:38704 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHxWs-0007ee-9F for submit@debbugs.gnu.org; Tue, 17 Jan 2023 20:46:18 -0500 Received: from lists.gnu.org ([209.51.188.17]:60254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHxWB-0007WH-Bi for submit@debbugs.gnu.org; Tue, 17 Jan 2023 20:45:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHxW9-0002DI-8j for guix-patches@gnu.org; Tue, 17 Jan 2023 20:45:33 -0500 Received: from mail-il1-x133.google.com ([2607:f8b0:4864:20::133]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pHxW7-0006wh-H9 for guix-patches@gnu.org; Tue, 17 Jan 2023 20:45:33 -0500 Received: by mail-il1-x133.google.com with SMTP id d10so16365907ilc.12 for ; Tue, 17 Jan 2023 17:45:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Jb2YZcfQTXgAKKqkTCSHsrnL1OBD0pNzJdDwP+D9tTw=; b=DiFNQJhmPkGOtb9AB43sOjjqrlkX45FYq9mtKuypIbG+2ieSEV5jgpjYP+o6wBmP99 btT8zPPikotWmE/hFD21twN5LFca1JtYSUo6FcaKmxW/eqsvL2W1kGOzbm88nuATy9U3 gW6BauT/UhTNi45gaHpH/412fxg5xZc35wCD7abOGdF3YcLBo6j+wjWl8+PxgCiOweD6 bg2c7mNKew6+VP3rDxKcCnDr0Q9OZWtds2vC2BrfvTOFt6olqGSZLN52JJMNGCu2JJSH +OXsyaMQc57uqRg96yoB+E2DYxNnSUEx5BvyBMWF4OC0EeMBsgznCp0gHGMXc1eSCQ4O N0UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Jb2YZcfQTXgAKKqkTCSHsrnL1OBD0pNzJdDwP+D9tTw=; b=NowRc9NMQ3bu6dEdIF93mYjsapFXgrBPOWMkJjA0qY2R04eNBW4GP4CvX9FLZ5N7Zm EzIUT3rJM/+i+U6K5WU6MEjd1BMtXlbih1gRDOCM4LsNQLN8U36gKVtAfPewhmSKZyIl o1cIDdEz/bfQq9Bwr41pKUIWCcMR6JqnoFmMKKIk9kHkJMDAC9leCTntculOLT0oe8oD fr2PgVz3ktP761bKff/WXqs33ES3Zs2rvILd1mvPMmjiM2o7uakwXXXsY1YeLd1J0TpF 4KI+Hs7Z238AF/kFrL+geLz6D0kIALkeHaozPS0FomFNjiIX4ZFKbulqtCRbqnzAGMMs Iauw== X-Gm-Message-State: AFqh2kouEw3SF29lgOZXZ99ozNBSzOuRChqjJcXI0PjTu6xPr1u4y4ud EZGddZj3DMmDfKWW9/V3BVW4kyEQt8k= X-Google-Smtp-Source: AMrXdXtxtKUTd7SXBNStZCtZ+kyE/ntwrSR9PFRPXdKCZMPK8J8/XDfKTKk1SNwTJfstWGeFKqW1mA== X-Received: by 2002:a05:6e02:d07:b0:30b:e56f:f2f7 with SMTP id g7-20020a056e020d0700b0030be56ff2f7mr4013301ilj.24.1674006330535; Tue, 17 Jan 2023 17:45:30 -0800 (PST) Received: from washu-v4.home.cox-buday.com (c-174-51-139-101.hsd1.co.comcast.net. [174.51.139.101]) by smtp.gmail.com with ESMTPSA id p32-20020a056638192000b0039e89ea68f9sm7889250jal.135.2023.01.17.17.45.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jan 2023 17:45:30 -0800 (PST) From: Katherine Cox-Buday To: guix-patches@gnu.org Subject: [PATCH 25/25] gnu: Add gopls. Date: Tue, 17 Jan 2023 18:45:10 -0700 Message-Id: <20230118014510.19320-26-cox.katherine.e@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230118014510.19320-1-cox.katherine.e@gmail.com> References: <20230118014510.19320-1-cox.katherine.e@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::133; envelope-from=cox.katherine.e@gmail.com; helo=mail-il1-x133.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Katherine Cox-Buday X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/golang.scm (gopls): New variable. --- gnu/packages/golang.scm | 45 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm index 3dcd97a8c1..faa6c61bc4 100644 --- a/gnu/packages/golang.scm +++ b/gnu/packages/golang.scm @@ -3021,6 +3021,51 @@ (define-public go-golang-org-x-vuln (native-inputs '()) (inputs '()))) +(define-public gopls + (package + (name "gopls") + (version "0.11.0") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://go.googlesource.com/tools") + (commit (string-append "gopls/v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1l9y1rp7x51s6dnjn227fhdlnz4z1h41jn3x1aq49qki241w7m73")))) + (build-system go-build-system) + (arguments + `(#:import-path "golang.org/x/tools/gopls" + #:unpack-path "golang.org/x/tools" + #:install-source? #f + #:phases (modify-phases %standard-phases + (add-before 'unpack 'override-tools + (lambda _ + (delete-file-recursively "src/golang.org/x/tools")))))) + (propagated-inputs (list go-github-com-google-go-cmp-cmp + go-github-com-jba-printsrc + go-github-com-jba-templatecheck + go-github-com-sergi-go-diff + go-golang-org-x-mod + go-golang-org-x-sync + go-golang-org-x-sys + go-golang-org-x-text + go-gopkg-in-yaml-v3 + go-honnef-co-go-tools + go-github-com-burntsushi-toml + go-github-com-google-safehtml + go-golang-org-x-exp + go-mvdan-cc-gofumpt + go-golang-org-x-vuln + go-mvdan-cc-xurls)) + (home-page "https://golang.org/x/tools/gopls") + (synopsis "Official language server for the Go language") + (description + "Pronounced \"Go please\", this is the official Go language server developed by +the Go team. It provides IDE features to any LSP-compatible editor.") + (license license:bsd-3))) + (define-public go-github-com-protonmail-go-crypto (package (name "go-github-com-protonmail-go-crypto") -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 18 05:57:05 2023 Received: (at control) by debbugs.gnu.org; 18 Jan 2023 10:57:05 +0000 Received: from localhost ([127.0.0.1]:39432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pI67s-0005fA-QG for submit@debbugs.gnu.org; Wed, 18 Jan 2023 05:57:05 -0500 Received: from tobias.gr ([80.241.217.52]:40786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pI67q-0005ej-1Q for control@debbugs.gnu.org; Wed, 18 Jan 2023 05:57:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=rZG272GorEjW1 DJ1ueTJCIxQKBgNqS4r2UeoWjljfNg=; h=to:from:date; d=tobias.gr; b=pJ8xGE 4xKTFxDGXTu8JJIxdTXzjHjKQHMPpzOLdDgTsKfydcYwE7eg++d4WhW4FvCCVuGv7neHuY doO2M+tWHslHkbqZPPB+ZequmKLRDsNc/QFfVC4KpDELKtkW9Q6ctxINWpQGJe2JzLXwaA RXt1hnoV0zUiSxmZXf6jp+B5IpHHn6CYT9xaIjeH34RSUNbyuEiIT1+57owCZhuUTnYlQh lK0c2ja5PyBKUu/tVp3CtE9SNY4fUc0Q4ge2kajMRhEyMUCCZMwjE4Ovvsy0rMfIS0qhUw 73tRxdOCEgy5V0Q/MaQ4XJMvrn5QvE7Rgo2lgWS/aXWhkF0KedtpqCRQ== Received: by submission.tobias.gr (OpenSMTPD) with ESMTP id 457c9cdf for ; Wed, 18 Jan 2023 10:56:54 +0000 (UTC) MIME-Version: 1.0 Date: Wed, 18 Jan 2023 11:56:54 +0100 From: Tobias Geerinckx-Rice To: control@debbugs.gnu.org Message-ID: <542e82bcc0f385c117ba662c7dcf1dbf@tobias.gr> Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: merge 60898 60899 60900 60901 60902 merge 60898 60903 60904 60905 60906 merge 60898 60907 60908 60909 60910 merge 60898 60911 60912 60913 60914 merge 60898 60915 60916 60917 60918 merge 60898 60919 60 [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) merge 60898 60899 60900 60901 60902 merge 60898 60903 60904 60905 60906 merge 60898 60907 60908 60909 60910 merge 60898 60911 60912 60913 60914 merge 60898 60915 60916 60917 60918 merge 60898 60919 60920 From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 18 06:43:42 2023 Received: (at control) by debbugs.gnu.org; 18 Jan 2023 11:43:42 +0000 Received: from localhost ([127.0.0.1]:39609 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pI6qz-0003Hz-Oc for submit@debbugs.gnu.org; Wed, 18 Jan 2023 06:43:41 -0500 Received: from tobias.gr ([80.241.217.52]:49144) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pI6qy-0003Ho-68 for control@debbugs.gnu.org; Wed, 18 Jan 2023 06:43:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=hJBWTcXaRHm8s 6Gzva/WF37fY4EhLgcXTE0kSZi4SIY=; h=to:from:date; d=tobias.gr; b=HQFR0l g232sKUrFQwAVl4bjkp37vlXJXu0nDv8lsOWDXnNgP5ATDyo7kPUr9jnAW1ldk87kyMTEC 12cfNk3mR15PuObZZWmeKSauoBlV3ofDwl4YIGk4qMms8hxenZPKyp5uQbxG3B4jtQWPpF MQmkwm3oUpr/R7chlpif5MeJO8VFKXW5ENk1ceuOE78c3EAVjtT34hIC0Kyf05uzzmzSQd tCJL8D5IvcQ82V/VDkEu8zMICLfcI2C+aCgQhhuMy5eNBkRnSN7h25ZHcfR22/XMYopKkD cQMgdz3Ylfx6CY1L3ldAEWkgVZM9FX7lR4sn09qIEO+1/CyVj/cfbwHQ== Received: by submission.tobias.gr (OpenSMTPD) with ESMTP id 2b6b07ef for ; Wed, 18 Jan 2023 11:43:32 +0000 (UTC) MIME-Version: 1.0 Date: Wed, 18 Jan 2023 12:43:32 +0100 From: Tobias Geerinckx-Rice To: control@debbugs.gnu.org Message-ID: <37de5823441633151229c783f2acfca3@tobias.gr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: merge 60898 60921 60922 thanks Weird: I got ‘Unknown command or malformed arguments to command.’ for this obviously correct line. Let's try again. Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) merge 60898 60921 60922 thanks Weird: I got ‘Unknown command or malformed arguments to command.’ for this obviously correct line. Let's try again. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 18 12:07:56 2023 Received: (at control) by debbugs.gnu.org; 18 Jan 2023 17:07:56 +0000 Received: from localhost ([127.0.0.1]:41657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIBum-00052f-22 for submit@debbugs.gnu.org; Wed, 18 Jan 2023 12:07:56 -0500 Received: from mail-il1-f179.google.com ([209.85.166.179]:35657) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIBuk-00052N-3J for control@debbugs.gnu.org; Wed, 18 Jan 2023 12:07:54 -0500 Received: by mail-il1-f179.google.com with SMTP id m15so17345356ilq.2 for ; Wed, 18 Jan 2023 09:07:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=GnPyPOAEGseCgs8OJ4qt7L8AUjlESU5rgqB6ZX0fDs0=; b=LFc833U6GocnaK3CTzP8F10nC3++Vy5+t7udHD0zAniYWoiVnZ/CxyjIOF9jFgpA4I ZA6AV+Z/czz9E+0wWs3U8bXKtRxjKNRpZqMTJThVHfgQFy8b/s7VrueLAudPRevBHxkh elhgr78nM6GT6M57cPJHsgzTyV+AvKUXL2LqJOBEwLKsVhugV/s9htj6B34cdGeRonzt YOZzatJWqPZCdJT8HqCA7ugA6U4+lAx7n5pOllBG8OcvGAckQi2ahM7Hq4x/W5+qJ5H3 w53lLre8p4xicsfjn8wqKwdTK8MNyxaAF6PB3EM4Tf1SfV/hhcRJedI15ADa1TIXQXYB maPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GnPyPOAEGseCgs8OJ4qt7L8AUjlESU5rgqB6ZX0fDs0=; b=z/xGFPzjRDHF07dbpdIL600PFBZdk2JeBCNWkMxjggAjGzwChJzvktmZ4oTsERu1Fd 1UzS3vOJ3o/JSFglvENF/4ltPnCrmV64zf4xYZvm9ImYCpiCZy4Cp9YJkwGvnhAL1WpO GVyThIgYKBQtZJ4QG83kkg+t0yHE0amueeuAlZeUlx0TKK+qpLV7uT1bgSGz9P5iRc7T SHaljdUEx/r9+1mIYRXsS5YdVXlqXOpqM/u8sSM6ptj2OGzTR6y847UJ55Nf26xh4hA6 dUsEiXp1eQBMjCN4xpmq09Jf3aa44LvhJCkdC7p/BYKf4FLo1Akd9NEmVZb9FZjZZYSt YBIw== X-Gm-Message-State: AFqh2koIjhmCxdmvdFQXNHwrPYNAVxh8iC6kt9sORWzy5R5OfGH5gOn9 tlMJMWMKrZ38RNsm1HHhAyo4ck+Hv5o= X-Google-Smtp-Source: AMrXdXvaRHz+POjae6teUiGpxX3dJBg3wg2WSO/lFqXAakcCttq0sg+7+68zm1nB7edoXAVgUfP4wg== X-Received: by 2002:a05:6e02:1a67:b0:30f:333a:7b53 with SMTP id w7-20020a056e021a6700b0030f333a7b53mr2146367ilv.9.1674061668208; Wed, 18 Jan 2023 09:07:48 -0800 (PST) Received: from washu-v4 (c-174-51-139-101.hsd1.co.comcast.net. [174.51.139.101]) by smtp.gmail.com with ESMTPSA id o32-20020a027420000000b0038a5b8d79basm10753904jac.106.2023.01.18.09.07.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Jan 2023 09:07:47 -0800 (PST) From: Katherine Cox-Buday To: control@debbugs.gnu.org Subject: Merging erroneously opened bugs Date: Wed, 18 Jan 2023 10:07:46 -0700 Message-ID: <87zgafrct9.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) merge 60899 60904 60907 60908 60917 60920 60921 60919 60910 60903 60915 60914 60922 60909 60918 60913 60900 60899 60905 60901 60912 60898 60906 60902 60916 60911 -- Katherine From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 30 11:53:19 2023 Received: (at 60899) by debbugs.gnu.org; 30 Jan 2023 16:53:19 +0000 Received: from localhost ([127.0.0.1]:50218 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMXPD-0005xB-5J for submit@debbugs.gnu.org; Mon, 30 Jan 2023 11:53:19 -0500 Received: from mail-il1-f178.google.com ([209.85.166.178]:35353) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMXPB-0005wy-2Y for 60899@debbugs.gnu.org; Mon, 30 Jan 2023 11:53:17 -0500 Received: by mail-il1-f178.google.com with SMTP id z2so4787009ilq.2 for <60899@debbugs.gnu.org>; Mon, 30 Jan 2023 08:53:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:to:from:from:to:cc:subject:date:message-id:reply-to; bh=WbXo3TFSVR4wF+hVElztRysd0+Dlvl/ig1bgj6TiCMw=; b=qyP0FkWd+H2AOonLgg4YkRTsAtMB2RYKv/yA8VAWyKpjBnSHwECGZK6BFwi1t5h7eL 6fFq+QwHBmqjfHZPGoPU2gzypc1cCgfzBj4pIY2NOr8n7NAM91H3F/5xyl6p+4ukY17g P8MT4chBssBC3rFQA9QZSPuc/PyAMh2ZLJlySLwksf15kQq3P+xyA3Yybe+zOX8KzvCR XfZ/ca9EE3BXlTX5n/xpUXmFfygZRSqXwhq7JvnRtvczHwvnBdZuvs0K1ady4r8xzYcw xDvTJzYkOL3KPTeA2qVX9EZTs63kb2SU8DO++Frzw7ipuhez4SfpvOq1cTaxe3dMKDzd FnmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WbXo3TFSVR4wF+hVElztRysd0+Dlvl/ig1bgj6TiCMw=; b=Us7kUmXVZf0/5KLQoTY63zAImRWTer4GL/8kJuxzOvoVIB60zzn1KUw6Alwi2NBT9U I7Te/sc56UVp77nNOjHVHabl/09VHZM1P5/mrzXrU15762uJXt3wrrtJ2MuB6o8sNCW5 +4xBVCIt0jnl53ZN53D4TIYJPIBMxpoiv9DHIQbV684hAmGzfLe2SFPJWM8Znl78jHxd /bZDjTcgN7UMdT1hAjXFR7VCuNpbsTyIubPFiAcyAQQzV9oxpltcrCH4Lz49HS1rQ++1 sSQ/Qodgm+s6TdudhYTYFK80ixb/HwjA+TgvaXADjEJVvCm/INXJwtML+waQAqF80AtA 3lgw== X-Gm-Message-State: AO0yUKXSebkvTUf5pXngRaDPdTpaZYcrbyvqmGPnnJdJbf7iXR8EKQLj znq++MHJmjEZeTTlegnLIgc= X-Google-Smtp-Source: AK7set9ZPyvVbr49WEQ05rUS/d1D44jZqN3pGk8Jvt+yqahYYZwwesjtcRN06RKkrqzVNuD+o5HQcw== X-Received: by 2002:a05:6e02:17c6:b0:310:bab8:34cf with SMTP id z6-20020a056e0217c600b00310bab834cfmr14260575ilu.19.1675097591505; Mon, 30 Jan 2023 08:53:11 -0800 (PST) Received: from washu-v4 (c-174-51-139-101.hsd1.co.comcast.net. [174.51.139.101]) by smtp.gmail.com with ESMTPSA id k4-20020a056e02156400b0030f3441de17sm4108393ilu.59.2023.01.30.08.53.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jan 2023 08:53:10 -0800 (PST) From: Katherine Cox-Buday To: 60899@debbugs.gnu.org, Guix Devel Subject: Request for review of: [bug#60899] [PATCH 00/25] gnu: golang: Add gopls References: <20230118014510.19320-1-cox.katherine.e@gmail.com> Date: Mon, 30 Jan 2023 09:53:09 -0700 In-Reply-To: <20230118014510.19320-1-cox.katherine.e@gmail.com> (Katherine Cox-Buday's message of "Tue, 17 Jan 2023 18:44:45 -0700") Message-ID: <878rhkyney.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60899 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Katherine Cox-Buday writes: > This is a patch series to add the gopls package. > > I haven't contributed to many projects which use the e-mail flow, so > hopefully I'm doing this correctly. Please feel free to make > suggestions if not! > > Some of the diffs are a little busier than I'd like for version bumps. > This is due to running `guix style` over everything. > > For all of the packages I have: > > . Run guix style > . Run guix lint > . Built 2x > . Checked that the change is in the correct branch > . Built all dependencies > . Built the repository > > Katherine Cox-Buday (25): > gnu: go-golang-org-x-sync: Update to 0.1.0-1.8fcdb60. > gnu: go-golang-org-x-mod: Update to 0.7.0. > gnu: Add go-golang-org-x-exp. > gnu: Add go-github-com-jba-printsrc. > gnu: Add go-github-com-google-safehtml. > gnu: Add go-github-com-jba-templatecheck. > gnu: go-github-com-google-go-cmp-cmp: Update to 0.5.9. > gnu: go-github-com-pkg-diff: Update to > 0.0.0-20210226163009-20ebb0f2a09e. > gnu: go-github-com-rogpeppe-go-internal: Update to 1.9.0. > gnu: gopkg-in-errgo-fmt-errors: Rename package to > go-gopkg-in-errgo-fmt-errors. > gnu: go-golang-org-x-tools: Update to 0.5.0. > gnu: Add xurls. > gnu: Add go-mvdan-cc-xurls. > gnu: Add misspell. > gnu: Add go-github-com-client9-misspell. > gnu: Add go-github-com-google-go-cmdtest. > gnu: Add unparam. > gnu: Add go-mvdan-cc-unparam. > gnu: Add govulncheck. > gnu: Add go-golang-org-x-vuln. > gnu: go-github-com-burntsushi-toml: Update to 1.2.1. > gnu: go-honnef-co-go-tools: Update to 0.3.3. > gnu: Add gofumpt. > gnu: Add go-mvdan-cc-gofumpt. > gnu: Add gopls. > > gnu/packages/configuration-management.scm | 2 +- > gnu/packages/golang.scm | 695 ++++++++++++++++++---- > 2 files changed, 578 insertions(+), 119 deletions(-) > > > base-commit: 5c921977179489caef4a9e54ada6696fc86d2f0b Hello Guix! Acknowledging that everyone are volunteers, and busy (guilty myself), this is a humble request for a review of this patch-series I made two weeks ago so that it doesn't bit-rot. I have a `gopls` home service[1] waiting to be proposed after this patch-series is merged. Thank you very much! [1] https://github.com/kat-co/guix-channels/blob/upstream-staging/upstream/home/services/gopls.scm P.S. I think I am following etiquette for review reminders (i.e. waiting long enough, bringing this over to guix-devel), but I was having trouble finding examples. If I haven't waited long enough, or have reminded in the wrong way, please give me feedback. -- Katherine From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 06 11:53:56 2023 Received: (at 60899) by debbugs.gnu.org; 6 Feb 2023 16:53:56 +0000 Received: from localhost ([127.0.0.1]:49738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pP4kd-0005rS-RW for submit@debbugs.gnu.org; Mon, 06 Feb 2023 11:53:56 -0500 Received: from mail-io1-f49.google.com ([209.85.166.49]:39762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pP4kb-0005rG-Tc for 60899@debbugs.gnu.org; Mon, 06 Feb 2023 11:53:54 -0500 Received: by mail-io1-f49.google.com with SMTP id y7so4661227iob.6 for <60899@debbugs.gnu.org>; Mon, 06 Feb 2023 08:53:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=iG2Fts2asHD+qwXTfLCeAde2rG99eTPoF5JeF02ozH4=; b=LG4p9ASAaFB7S6yBM7VxRNB2w2mgrcE4DY/1/hqFWVDIFvgn9p2KT3YERDiGCf+/9r VFrdTkXSdMcfC6SMhj5kztpG2uB/6YoRGV8reIdJtZF8XppwWvkgNp5o2qj9SFbc3yPz ogZxc9N1SrAay6M73mCIrwO7dPaqMYcuxBnYTH4Qk+ed9XFsff/PIj4WYJyK28D6OYan eig7Su0cKAXigQTR9N3kbPev1hgIUG01gtB5GXgi5tVywsfpwl21sEh+vg95fQj4KHpA tvn0neGDuTEjkntZwKgDSJDPpXNwaAyjOlkPDHH5GeJee9P6vOi8Br5PQWoIBGIfhgFF L15w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iG2Fts2asHD+qwXTfLCeAde2rG99eTPoF5JeF02ozH4=; b=dFRIIC+FUboI+NkSAaXBguTHrG6f/+1T1n9CpWJc0OTIOZoie/B4iyUsEny+W5VOn6 VEBDnsu5ZcdW5hVZtx6f2GLo+x0jZzrKER6DJ180Wnj3Oift32lVGG5lmP0PYAOmR/Bg ce9rCkMni0scEO3MjYLFpG13RXIGkWgjLW3kZ0jb81KF4F9+Sbxo0ANsBOBJJ0/hH46z 1uz0ec6oFSq8kIC25by+wUOpK2Hgr0dWL49wJ8kcuQR/wyaGRYtnQxKgpIUQFF0yXeF0 XQvOYe206RPgDWq7qt7y9Ve7P0GGTHSrN/6qM8aVHIhmlJtUOJPd9s9Y86GRqXb1MWNH OYrg== X-Gm-Message-State: AO0yUKVd6BRPdp5CayEbzELEcjVxJ2t730i/uzJ8dL9P8bO0662XmQu4 ca1Se5JlwliPzXZdvu44tNoQQW6ESU3K5A== X-Google-Smtp-Source: AK7set8GnonB8f9JYmYbfAA0eUFvJS3Y+Vm5ww+g0wEovdmTuOb4ogyvQz8WFe2NKCJp2z2soxp/Fw== X-Received: by 2002:a05:6602:2253:b0:712:8099:bdfe with SMTP id o19-20020a056602225300b007128099bdfemr14157190ioo.13.1675702428219; Mon, 06 Feb 2023 08:53:48 -0800 (PST) Received: from washu-v4 (c-174-51-139-101.hsd1.co.comcast.net. [174.51.139.101]) by smtp.gmail.com with ESMTPSA id y15-20020a6bd80f000000b00704c767ead9sm3278517iob.28.2023.02.06.08.53.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Feb 2023 08:53:47 -0800 (PST) From: Katherine Cox-Buday To: 60899@debbugs.gnu.org Subject: Re: Request for review of: [bug#60899] [PATCH 00/25] gnu: golang: Add gopls References: <20230118014510.19320-1-cox.katherine.e@gmail.com> <878rhkyney.fsf@gmail.com> Date: Mon, 06 Feb 2023 09:53:46 -0700 In-Reply-To: <878rhkyney.fsf@gmail.com> (Katherine Cox-Buday's message of "Mon, 30 Jan 2023 09:53:09 -0700") Message-ID: <87edr2zqed.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60899 Cc: Guix Devel X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Katherine Cox-Buday writes: > Katherine Cox-Buday writes: > >> This is a patch series to add the gopls package. >> >> I haven't contributed to many projects which use the e-mail flow, so >> hopefully I'm doing this correctly. Please feel free to make >> suggestions if not! >> >> Some of the diffs are a little busier than I'd like for version bumps. >> This is due to running `guix style` over everything. >> >> For all of the packages I have: >> >> . Run guix style >> . Run guix lint >> . Built 2x >> . Checked that the change is in the correct branch >> . Built all dependencies >> . Built the repository >> >> Katherine Cox-Buday (25): >> gnu: go-golang-org-x-sync: Update to 0.1.0-1.8fcdb60. >> gnu: go-golang-org-x-mod: Update to 0.7.0. >> gnu: Add go-golang-org-x-exp. >> gnu: Add go-github-com-jba-printsrc. >> gnu: Add go-github-com-google-safehtml. >> gnu: Add go-github-com-jba-templatecheck. >> gnu: go-github-com-google-go-cmp-cmp: Update to 0.5.9. >> gnu: go-github-com-pkg-diff: Update to >> 0.0.0-20210226163009-20ebb0f2a09e. >> gnu: go-github-com-rogpeppe-go-internal: Update to 1.9.0. >> gnu: gopkg-in-errgo-fmt-errors: Rename package to >> go-gopkg-in-errgo-fmt-errors. >> gnu: go-golang-org-x-tools: Update to 0.5.0. >> gnu: Add xurls. >> gnu: Add go-mvdan-cc-xurls. >> gnu: Add misspell. >> gnu: Add go-github-com-client9-misspell. >> gnu: Add go-github-com-google-go-cmdtest. >> gnu: Add unparam. >> gnu: Add go-mvdan-cc-unparam. >> gnu: Add govulncheck. >> gnu: Add go-golang-org-x-vuln. >> gnu: go-github-com-burntsushi-toml: Update to 1.2.1. >> gnu: go-honnef-co-go-tools: Update to 0.3.3. >> gnu: Add gofumpt. >> gnu: Add go-mvdan-cc-gofumpt. >> gnu: Add gopls. >> >> gnu/packages/configuration-management.scm | 2 +- >> gnu/packages/golang.scm | 695 ++++++++++++++++++---- >> 2 files changed, 578 insertions(+), 119 deletions(-) >> >> >> base-commit: 5c921977179489caef4a9e54ada6696fc86d2f0b > > Hello Guix! Acknowledging that everyone are volunteers, and busy (guilty > myself), this is a humble request for a review of this patch-series I > made two weeks ago so that it doesn't bit-rot. > > I have a `gopls` home service[1] waiting to be proposed after this > patch-series is merged. > > Thank you very much! > > [1] > https://github.com/kat-co/guix-channels/blob/upstream-staging/upstream/home/services/gopls.scm > > P.S. I think I am following etiquette for review reminders (i.e. waiting > long enough, bringing this over to guix-devel), but I was having trouble > finding examples. If I haven't waited long enough, or have reminded in > the wrong way, please give me feedback. Hello, this is another humble request for review :) It looks like QA is passing, and I think I did a pretty thorough job of making sure things follow standards and will apply cleanly. -- Katherine From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 06 18:15:17 2023 Received: (at submit) by debbugs.gnu.org; 6 Feb 2023 23:15:17 +0000 Received: from localhost ([127.0.0.1]:50277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPAhh-0000Jh-3x for submit@debbugs.gnu.org; Mon, 06 Feb 2023 18:15:17 -0500 Received: from lists.gnu.org ([209.51.188.17]:34500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPAhd-0000JH-Si for submit@debbugs.gnu.org; Mon, 06 Feb 2023 18:15:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPAhd-00031z-0u for guix-patches@gnu.org; Mon, 06 Feb 2023 18:15:13 -0500 Received: from mira.cbaines.net ([212.71.252.8]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPAha-0002mW-8P for guix-patches@gnu.org; Mon, 06 Feb 2023 18:15:12 -0500 Received: from localhost (unknown [IPv6:2a02:1808:200:8622:f055:17e:cfb4:2]) by mira.cbaines.net (Postfix) with ESMTPSA id 4999827BBE9; Mon, 6 Feb 2023 23:15:08 +0000 (GMT) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id ae4bb3ce; Mon, 6 Feb 2023 23:15:07 +0000 (UTC) References: <20230118014510.19320-1-cox.katherine.e@gmail.com> User-agent: mu4e 1.8.11; emacs 28.2 From: Christopher Baines To: Katherine Cox-Buday Subject: Re: [bug#60899] [PATCH 00/25] gnu: golang: Add gopls Date: Tue, 07 Feb 2023 00:14:14 +0100 In-reply-to: <20230118014510.19320-1-cox.katherine.e@gmail.com> Message-ID: <87cz6mcrnq.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=212.71.252.8; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: 60899-done@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Katherine Cox-Buday writes: > This is a patch series to add the gopls package. > > I haven't contributed to many projects which use the e-mail flow, so hopefully > I'm doing this correctly. Please feel free to make suggestions if not! > > Some of the diffs are a little busier than I'd like for version bumps. This is > due to running `guix style` over everything. > > For all of the packages I have: > > . Run guix style > . Run guix lint > . Built 2x > . Checked that the change is in the correct branch > . Built all dependencies > . Built the repository > > Katherine Cox-Buday (25): > gnu: go-golang-org-x-sync: Update to 0.1.0-1.8fcdb60. > gnu: go-golang-org-x-mod: Update to 0.7.0. > gnu: Add go-golang-org-x-exp. > gnu: Add go-github-com-jba-printsrc. > gnu: Add go-github-com-google-safehtml. > gnu: Add go-github-com-jba-templatecheck. > gnu: go-github-com-google-go-cmp-cmp: Update to 0.5.9. > gnu: go-github-com-pkg-diff: Update to > 0.0.0-20210226163009-20ebb0f2a09e. > gnu: go-github-com-rogpeppe-go-internal: Update to 1.9.0. > gnu: gopkg-in-errgo-fmt-errors: Rename package to > go-gopkg-in-errgo-fmt-errors. > gnu: go-golang-org-x-tools: Update to 0.5.0. > gnu: Add xurls. > gnu: Add go-mvdan-cc-xurls. > gnu: Add misspell. > gnu: Add go-github-com-client9-misspell. > gnu: Add go-github-com-google-go-cmdtest. > gnu: Add unparam. > gnu: Add go-mvdan-cc-unparam. > gnu: Add govulncheck. > gnu: Add go-golang-org-x-vuln. > gnu: go-github-com-burntsushi-toml: Update to 1.2.1. > gnu: go-honnef-co-go-tools: Update to 0.3.3. > gnu: Add gofumpt. > gnu: Add go-mvdan-cc-gofumpt. > gnu: Add gopls. > > gnu/packages/configuration-management.scm | 2 +- > gnu/packages/golang.scm | 695 ++++++++++++++++++---- > 2 files changed, 578 insertions(+), 119 deletions(-) I've made a few tweaks and pushed this to master as f3ab5888a0bc6446104ddbba41a413a86eb298e2. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmPhiflfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xfhig//YSPLrs7Avr27xXjqeKZFwOVPHnrKcIPO LfG5EXjG+AiRQ1bR3vmV3+N6fN/Z3e9p3N9NE9T04ZZCWpSPW+A0d87gEdL3hfz6 a5fIXW05SYr8cFYaxjqk81W3pT9ADWOoXHVq8yMDPOA/yLUH4NUUj0HCK1CNwHs4 elbKi6o6LErFeuSjBk9xIVhjtrQWtFW25Mobx66yjyZ4IdRK5jHcTLr0vFSXLTAp 6r04cKhQxLGlz1GAce5AO4hgDXXyjYSKuRjyrGD2/q2QBJFTH08XIs7GUNpH1E8u yOqv+/kch/3GGKl8UN5SU1Dyg76uB7nLGqhKD13ZFpqoasfdOfY+O5pF1GBjYT1b 1zDBO1E3MqDGMC4nQ5HZBAMu/zwtCPfhOgjCQPHQVNaENdwwcNVvO7uMB4YMFLd/ da/ZoYgd39GvPQl3ciUqr2tO7B5NaiTzKyC5RdiS9nM+pidZ52pbLfxyE/ZNDkhU 5bQDwoApnhp2ZWLW/gJr/RIVefSAk4PrH9r4rbblNsNQe1tNHPP9pMcYZSTAeyLq aWDPRjNYUMay93LqmmIyUu0Ve0OB9Fmy/jb5BmpvuqfOviprazJQtbyl9Wcpf1Ws 1qIAIG9Wr20k+dd8YFf/EsieNvFaOAb7NY06KM8dEK30yN3wZjrk7qXpe7QWModp /slginLeq+4= =3TGe -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 06 18:28:48 2023 Received: (at submit) by debbugs.gnu.org; 6 Feb 2023 23:28:48 +0000 Received: from localhost ([127.0.0.1]:50402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPAum-0000lk-Lc for submit@debbugs.gnu.org; Mon, 06 Feb 2023 18:28:48 -0500 Received: from lists.gnu.org ([209.51.188.17]:34168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPAul-0000lc-8w for submit@debbugs.gnu.org; Mon, 06 Feb 2023 18:28:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPAuk-0007hx-QZ for guix-patches@gnu.org; Mon, 06 Feb 2023 18:28:47 -0500 Received: from knopi.disroot.org ([178.21.23.139]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPAuj-0005AF-AQ for guix-patches@gnu.org; Mon, 06 Feb 2023 18:28:46 -0500 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id B38C641275; Tue, 7 Feb 2023 00:28:42 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 83hlsCSXdZy9; Tue, 7 Feb 2023 00:28:41 +0100 (CET) Content-Type: multipart/signed; boundary=e94b9dc08b5ff27e82fc6772c72f9ede45ed47a74fdca85a52017cc9d18a; micalg=pgp-sha512; protocol="application/pgp-signature" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1675726121; bh=FjSkNFhV/j4ek75BoXQh47qVPc9/1jheLcAUCV2zBTk=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=hFAiodct/fckwpbJkkUzhM5hrOf+00SuFn4t9yMvQdlvuV+TE/yJkFGWuYFKhC4Hh Hu+Z+q5gfAkiyhqGc5hC3ZNEbu8NHiKM0WjVRv64OwxpUuiOQJWo2VWNpSDyw1z4ML DKMjffXrTvFezSfvn8K8Wooeto8gSYcUvUBbAluJjduiraH08PLvH4uM7RrPF7uHPd onqC8DhUFCv0qCJdI1xjAT3VrZsQoc7a2d4BZ6IjH9PraOsl6mfnpiOKtjjro704Om Fl16uVk9+g1AYfCy4v4bVVTW/bcJBd2w/G7ZQllWVRU+i6jROnxzMp+a284tFOYTgH ylcX6Ay083VZw== Date: Mon, 06 Feb 2023 23:28:40 +0000 Message-Id: From: "(" To: "Christopher Baines" , "Katherine Cox-Buday" Subject: Re: bug#60899: [PATCH 00/25] gnu: golang: Add gopls References: <20230118014510.19320-1-cox.katherine.e@gmail.com> <87cz6mcrnq.fsf@cbaines.net> In-Reply-To: <87cz6mcrnq.fsf@cbaines.net> Received-SPF: pass client-ip=178.21.23.139; envelope-from=paren@disroot.org; helo=knopi.disroot.org X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MIME_HEADER_CTYPE_ONLY=0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: 60899-done@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --e94b9dc08b5ff27e82fc6772c72f9ede45ed47a74fdca85a52017cc9d18a Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Mon Feb 6, 2023 at 11:14 PM GMT, Christopher Baines wrote: > I've made a few tweaks and pushed this to master as > f3ab5888a0bc6446104ddbba41a413a86eb298e2. Nooo, my review was too slow :P -- ( --e94b9dc08b5ff27e82fc6772c72f9ede45ed47a74fdca85a52017cc9d18a Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEE6Vh10NblKE5doNlW7ImHg/nqI20FAmPhjSkACgkQ7ImHg/nq I22LMwv/eep45UWbi+nB+9l5sK80FwF4lb633EwCvBrGOk57w6VPYDQmm7kQHQZr 03GD7DnIWzhaGdcJBb+B2DwfJJxgSpQTfNWPhuKAOeQJcwV/UskFpIMYlJc79M19 QLlR8zFIF5TIZXS6LKeEucpav/5YC+vdLkKrdTkpDUOfUCqYaDB19AQ/eooatH80 /Vw52iEFVGepybS1rUdqTvM5wiwP7gOQ+06pw0j1zspqUXVchRfvSEM62LCFGjNZ Vzm+uQgQAx71xblG5Up5lA5S14402tSjJv1+k6UKFfbauzWQM6ohrguzmRVSys54 VqtiXoa6i13oVBZN3l7xrNmNTCH7HbMIXHp8SLEhWdwcgKhhnxT3d2RaI5snnmGK wvwt0ua7hHctT4PHdakytHB7saEoA+covc6YC6+s+0PSPRS5ivzrLkmLYmkiviql k2s9HH66La3933AvKO8GYKeV87XnT4JwLddjKVKHHQVWHImNL28LVZsgS4pRdOvH wG0UxBc7 =pUv8 -----END PGP SIGNATURE----- --e94b9dc08b5ff27e82fc6772c72f9ede45ed47a74fdca85a52017cc9d18a-- From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 06 18:28:34 2023 Received: (at 60899) by debbugs.gnu.org; 6 Feb 2023 23:28:34 +0000 Received: from localhost ([127.0.0.1]:50396 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPAuX-0000l3-1f for submit@debbugs.gnu.org; Mon, 06 Feb 2023 18:28:34 -0500 Received: from knopi.disroot.org ([178.21.23.139]:39358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPAuG-0000kg-M8 for 60899@debbugs.gnu.org; Mon, 06 Feb 2023 18:28:31 -0500 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 0ADFB4131A; Tue, 7 Feb 2023 00:28:15 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BPup6aVx-Jqe; Tue, 7 Feb 2023 00:28:13 +0100 (CET) Content-Type: multipart/signed; boundary=eb16bf50b381a37de881c48df44bc918b5c0d65b0e50a4731314cb7912f3; micalg=pgp-sha512; protocol="application/pgp-signature" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1675726093; bh=qw706WIdCbIJYo3K4CgkH2XFtYvMxvCWLjxa8+csIx4=; h=Date:Subject:From:To:References:In-Reply-To; b=XeAWW7Tzd5KGOGYCws5LIqxR56j+80V9QpbdC7sRdJmqPg/TgJ6dupHK5inEQ0Izc doLo1W1tZIvVL1ZWWfTq9mn11tmDbGbh3uX1kwPMPKiZoEZaR4uVJ9lj07UlJmF6bX 0t/nUSMwvrvzilU+RnH3SnJ231fNGssiiFYQE5r3ADMIRPlAPrry7LT0k5rz+atwKy 8bx3npWJ5Lc90ZkCGr9Ik0cVveAbjd0Zs136u2XgVA9DfCJ4H3dFq2ojSc+0N50/VU JwbLcKHprDsa0lyqL7Ny+zkrY86Ew4bc08+kjp8JQ4bsekvbjXs1L210DmUIGTWZQh q7S7rhTsMPBOA== Date: Mon, 06 Feb 2023 23:28:13 +0000 Message-Id: Subject: Re: [bug#60899] [PATCH 25/25] gnu: Add gopls. From: "(" To: "Katherine Cox-Buday" , <60899@debbugs.gnu.org> References: <20230118014510.19320-1-cox.katherine.e@gmail.com> <20230118014510.19320-26-cox.katherine.e@gmail.com> In-Reply-To: <20230118014510.19320-26-cox.katherine.e@gmail.com> X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 60899 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) --eb16bf50b381a37de881c48df44bc918b5c0d65b0e50a4731314cb7912f3 Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 * gnu/packages/golang.scm (gopls): New variable. > --- a/gnu/packages/golang.scm > +++ b/gnu/packages/golang.scm > @@ -3021,6 +3021,51 @@ (define-public go-golang-org-x-vuln > + (arguments > + `(#:import-path "golang.org/x/tools/gopls" > + #:unpack-path "golang.org/x/tools" > + #:install-source? #f > + #:phases (modify-phases %standard-phases > + (add-before 'unpack 'override-tools > + (lambda _ > + (delete-file-recursively "src/golang.org/x/tools")= ))))) s/override/remove-other/, perhaps? > + (propagated-inputs (list go-github-com-google-go-cmp-cmp > + go-github-com-jba-printsrc > + go-github-com-jba-templatecheck > + go-github-com-sergi-go-diff > + go-golang-org-x-mod > + go-golang-org-x-sync > + go-golang-org-x-sys > + go-golang-org-x-text > + go-gopkg-in-yaml-v3 > + go-honnef-co-go-tools > + go-github-com-burntsushi-toml > + go-github-com-google-safehtml > + go-golang-org-x-exp > + go-mvdan-cc-gofumpt > + go-golang-org-x-vuln > + go-mvdan-cc-xurls)) Could this be changed to just ``inputs''? > + (description > + "Pronounced \"Go please\", this is the official Go language server = developed by > +the Go team. It provides IDE features to any LSP-compatible editor.") (description "This package provides the official @acronym{LSP, language server protoc= ol} server for the Go language, allowing LSP-compatible editors to automatica= lly support @acronym{IDE, integrated development environment}-like features."= ) -- ( --eb16bf50b381a37de881c48df44bc918b5c0d65b0e50a4731314cb7912f3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEE6Vh10NblKE5doNlW7ImHg/nqI20FAmPhjQ0ACgkQ7ImHg/nq I21Vcwv+PMfnUrn8tdLUvT1om7zBTvmrUUx7eUju4KxxGrfrpImt70a+uzQ4kClu g2DZWHAMWQI58+J6QRkeMlp4fTMqlX37FkrvRuVpQ/EooUfWeqAqEyDiSBlJSHuJ XldmRGwDzQ3/zoTuklBtHtdkWYfEXbDpjSW6YjUAGRK9oP498FFY/UTJa5m6jZIl VQdiv1hhgqsV139zqdgsx9UAGeEfrNDKXf9CnqSx6OL1yceqPsoG6RjMW6K4MDb9 X/5IuebNCbVcAgQ8ArW+5FnUUf2b8QjR+3fFEIAVRhRp1u7Q5Ueh33HWi66iOC8Z mh6wj/M+4PYo+J9/nPXD9IBp1OjzkMud08CWetKjJSiVBPqdKi8xEjpZHNHQcykE 2B6D3Dq91bpBs91SLbkpBPL4bnYvAabuoK0GsCOeT/qSX8bI3Bg7PvW8JjX8JmJo 9jVAUw46WzGyuNJOUjuVQe159BlniXvBaGptiecBoUsWqSuACAdKDYrHlIxZ52XH MZpwWfNS =UbOc -----END PGP SIGNATURE----- --eb16bf50b381a37de881c48df44bc918b5c0d65b0e50a4731314cb7912f3-- From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 07 02:50:25 2023 Received: (at submit) by debbugs.gnu.org; 7 Feb 2023 07:50:26 +0000 Received: from localhost ([127.0.0.1]:50897 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPIkD-00067z-LC for submit@debbugs.gnu.org; Tue, 07 Feb 2023 02:50:25 -0500 Received: from lists.gnu.org ([209.51.188.17]:49096) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPIkB-00067q-4U for submit@debbugs.gnu.org; Tue, 07 Feb 2023 02:50:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPIk9-0002zk-SN for guix-patches@gnu.org; Tue, 07 Feb 2023 02:50:21 -0500 Received: from mira.cbaines.net ([212.71.252.8]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPIk7-0000bX-Dx for guix-patches@gnu.org; Tue, 07 Feb 2023 02:50:20 -0500 Received: from localhost (unknown [IPv6:2a02:1808:280:b109:f055:17e:cfb4:2]) by mira.cbaines.net (Postfix) with ESMTPSA id 776CC27BBE9; Tue, 7 Feb 2023 07:50:17 +0000 (GMT) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 5f31f13d; Tue, 7 Feb 2023 07:50:16 +0000 (UTC) References: <20230118014510.19320-1-cox.katherine.e@gmail.com> <87cz6mcrnq.fsf@cbaines.net> User-agent: mu4e 1.8.11; emacs 28.2 From: Christopher Baines To: "(" Subject: Re: bug#60899: [PATCH 00/25] gnu: golang: Add gopls Date: Tue, 07 Feb 2023 08:42:51 +0100 In-reply-to: Message-ID: <878rh9didm.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=212.71.252.8; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: 60899-done@debbugs.gnu.org, Katherine Cox-Buday , guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain "(" writes: > [[PGP Signed Part:Undecided]] > On Mon Feb 6, 2023 at 11:14 PM GMT, Christopher Baines wrote: >> I've made a few tweaks and pushed this to master as >> f3ab5888a0bc6446104ddbba41a413a86eb298e2. > > Nooo, my review was too slow :P I think reviewing changes/sending feedback after things have been merged is fine (and important). If more people get involved in reviewing things, this is probably something that'll happen more, so I think for now it's good to embrace it. Hopefully we can continue the discussion around these changes and perhaps further improve things with some additional patches. Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmPiArVfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xfnlg/7BLYjj1+bj2Y3TP4Kww7t4Ley4VpeQEjL jdElYggdSLiYNlc5QKuSrcWsaCLWHUdE2lDCQGZ20m5Wt8iyjwEaRcWw/S5TwFmk UDDg3zDHD2WIfW/Xm71ShNjCtAE28MNqE9/fUIXGaSdO1rxEBsnLIPpeSWtbwjPb P21p+6uoX8KwdO+PCC/jKUBoL2XraXD6RKJDyzJfKqv2qb6fOP0tyz4w8j57t8HO DGNwNAtuKNNHRvekCQyQrq2heuibrJiFy27yuf+926xicKnGpzWtF7r//lEvSeIj Msq5AJ9myq50Oq7sLBBwDt4C1r80YTYxIC/pdjeaWa8PclhtqiTJ9DQn+cjvHR0I bViD3pwoVOqIpMo+ppOdcU700YCBzkW3sfEbB2WDFmh55HcL6NJZbHaHyrLcFNiD dRUwcBDWaNE6P/sPQAHy4iYz8kaNAP1n1rKSDA7DXnYp3FTIk321YN0Y/mqntlld 5Df/LYaVFtxJnQ1tmRUTBsUKKvtZNy1E6+/AnvC4dPCL+WEybCPjqjkPRwbe3y24 veJ+gqDPJqGhTAp9ZHj3og+IoaCx3RT6ikDD8MNIgjwrLK5+bLBxsyePZjy4zNvF 2c3YWHHXL3T07iRQOYnoWYBN3mz0FoXABbPXcSBR+FV/sZwAt9WPvKstvAR7ROh+ 8Ie5UK+uCYA= =6aGL -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 07 11:00:04 2023 Received: (at 60899) by debbugs.gnu.org; 7 Feb 2023 16:00:04 +0000 Received: from localhost ([127.0.0.1]:53832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPQO3-0000A4-Oh for submit@debbugs.gnu.org; Tue, 07 Feb 2023 11:00:04 -0500 Received: from mail-il1-f180.google.com ([209.85.166.180]:36742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPQO1-000092-Ga for 60899@debbugs.gnu.org; Tue, 07 Feb 2023 11:00:01 -0500 Received: by mail-il1-f180.google.com with SMTP id w13so6195207ilv.3 for <60899@debbugs.gnu.org>; Tue, 07 Feb 2023 08:00:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=w9YVCS4o2T3nq1v91cyVKescX1+TxlBEG8S04MaGDF8=; b=XyTPzVTl8a5KKq6Z4hGc0d+svbUBLArhgyj7pyW9OAluKTHSLKKlQPlnX9iyz/lG4Y AZTTZZH2vuIuYjivAqyrw1p1cgZ8bXWpFJHps9OWGi6lQJamq0koDaMz7hEz+Al4n6jP T1wQZwu3vLxqJ3qru4Ib9PdxII6LEGyT7AVEI3vu6LHpQWfHNzruf6Ueco3jUH6qjbB5 C8vTZebN9uTGATfNLQNZDMd7YzTXVDwQ7GAQHxCSOWKdGUO66JUAjKwMliNaFZIh5hUR 75lndvrGR6MWmQUcTYoZKwj/fvI5Zd23EegAR7PCvzmk3w2+SgZcOf1yp53a5qzN0mZc hP2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=w9YVCS4o2T3nq1v91cyVKescX1+TxlBEG8S04MaGDF8=; b=Ts0HD5FXmYNeKL7GQHDPly1iBAoWSSEuILpWL35oudDthL4Zz8JLySMtxXOkMACpkz +fkZyE45zBFoW5kpZYAFIOEjfcsElSTQwbS33b+B8ZHbsY4cSnmPG+tkZ9+SlYf+3M5+ qBpr5E++m7YDNMbcUCHDUVLpfhxqkcRoEQf7f/rKLuHKdddeWck37rOTCIut1uQ3GG8P YGcj/+WjzPyXYU5uiFzJ0WAxuYGyASxJNkQWDx+47CulrjtumvkNtM+VoddV0uj7B3pu y062pP1TVHInwHmc/ysHQ54p4pKx2VbMsz9w/N+EzlCmDj/a71EFEhQRyqrM4O8QlEVb lKVA== X-Gm-Message-State: AO0yUKX43QfWmveAJMzmOzWdjjRZU9eyOPCIA/dHpi132HskXvrcEGrF f0epbBM15juwSqTbEMDxtY3p5QDh0Nt8lw== X-Google-Smtp-Source: AK7set9rUsK5PFEAq+2jpd8VpAlyCxrCciVX0qvC8WjPxhE6Ax2YMaw7qeIrysEEIn0Brq/FsowmzA== X-Received: by 2002:a92:c541:0:b0:310:e889:c53e with SMTP id a1-20020a92c541000000b00310e889c53emr4459496ilj.5.1675785595683; Tue, 07 Feb 2023 07:59:55 -0800 (PST) Received: from washu-v4 (c-174-51-139-101.hsd1.co.comcast.net. [174.51.139.101]) by smtp.gmail.com with ESMTPSA id l7-20020a056e021aa700b00310ff93629dsm4204797ilv.4.2023.02.07.07.59.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 07:59:55 -0800 (PST) From: Katherine Cox-Buday To: 60899@debbugs.gnu.org Subject: Re: bug#60899: [PATCH 00/25] gnu: golang: Add gopls References: <20230118014510.19320-1-cox.katherine.e@gmail.com> <87cz6mcrnq.fsf@cbaines.net> Date: Tue, 07 Feb 2023 08:59:53 -0700 In-Reply-To: <87cz6mcrnq.fsf@cbaines.net> (Christopher Baines's message of "Tue, 07 Feb 2023 00:14:14 +0100") Message-ID: <87a61pzcsm.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60899 Cc: mail@cbaines.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Christopher Baines writes: > I've made a few tweaks and pushed this to master as > f3ab5888a0bc6446104ddbba41a413a86eb298e2. > > Thanks, > > Chris Thank you so much! I'm going to review the changes (and the reviews from open-paren) to try and incorporate that going forward. -- Katherine From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 07 11:02:21 2023 Received: (at 60899) by debbugs.gnu.org; 7 Feb 2023 16:02:21 +0000 Received: from localhost ([127.0.0.1]:53836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPQQH-0000Ep-92 for submit@debbugs.gnu.org; Tue, 07 Feb 2023 11:02:21 -0500 Received: from mail-il1-f182.google.com ([209.85.166.182]:37795) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPQQF-0000Ea-4K; Tue, 07 Feb 2023 11:02:19 -0500 Received: by mail-il1-f182.google.com with SMTP id o13so2364502ilt.4; Tue, 07 Feb 2023 08:02:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=sb7F1hLRqML2iE/6vbvzM+JvzaarSoxOu+yN56vZPwM=; b=D5DWaAXxt9x5JH/jgyUtGD9fjJr8MtLl+fPnqtT8Ag3fkNWRziaBInq4/pdLsr1NlT xhHgjWuv/xe14u+ec5+GHTayc11Vhee/5xX+3TCaOq9NbTpNUzOklc+lXLHVds+XeIa+ tYIeZ64jymMWlXIRsWZO3KLQXkp0BAKUNyO7RvkrsY2Bn/tJYdwDL+NHPSzGB0gJ7wtJ 22lRQpFIojgBv3cCq1zOVOHHcre4qtOe2NBx5R5nluihlIdK1DevuayAm8zmDz3CiFKG FHIF6pInilSO2xu0IGzzq/kst1O46ewlq8JMSuXrLxB5+0ShYhqJ61ssJt6AIrAzgSa+ 0vKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sb7F1hLRqML2iE/6vbvzM+JvzaarSoxOu+yN56vZPwM=; b=B5T7m675TOZ66+zmdli+QM5+PMRWWGGnrpO7MTji2FRb65mJ3dm+zNDlzrhqRDI62s qobaqq4+4DjY7B91eU6yRgZhKf0Se7PYUdTowDcCZJIotwV915MBC53LYV49kmpj0QuM 5lYkzPdoK+tk/zX6DAKVJP3SMaEClo9tJKhvs7WQ9tP0V/8PuX00JhOH+CZR6UY4kwTH zk11UN4RwN8A6UGQFZDPmi5p1vvB9vvgjZfJHvFWT0PWRKjWWAyBeXjXrhbO0BOAqiAY PNPPGrDdG7zMgBrp22G90NtL5W6EdaG1VGjbkD6QI0qt/QSiflJGkPSTQpn7hQ0LIfyy K3kw== X-Gm-Message-State: AO0yUKVPqAJsporFQjZ+duOup064QUb92ODc8qJVW/szU9oMuUupqaTm TBROO+wTrw+SwdBVO76ZkK0Mg/VP1getHg== X-Google-Smtp-Source: AK7set+wR3zPTg7pdKpP3Qqvwrk5fEqtsWMrXVEl9RkFqae+rfdAoc6kHrnk7C6/GyK5EVAqGQScOA== X-Received: by 2002:a05:6e02:1947:b0:313:b8b6:a05d with SMTP id x7-20020a056e02194700b00313b8b6a05dmr4590651ilu.2.1675785733649; Tue, 07 Feb 2023 08:02:13 -0800 (PST) Received: from washu-v4 (c-174-51-139-101.hsd1.co.comcast.net. [174.51.139.101]) by smtp.gmail.com with ESMTPSA id o3-20020a02cc23000000b0039d724c2416sm4372223jap.134.2023.02.07.08.02.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 08:02:13 -0800 (PST) From: Katherine Cox-Buday To: Christopher Baines Subject: Re: [bug#60899] [PATCH 00/25] gnu: golang: Add gopls References: <20230118014510.19320-1-cox.katherine.e@gmail.com> <87cz6mcrnq.fsf@cbaines.net> <878rh9didm.fsf@cbaines.net> Date: Tue, 07 Feb 2023 09:02:12 -0700 In-Reply-To: <878rh9didm.fsf@cbaines.net> (Christopher Baines's message of "Tue, 07 Feb 2023 08:42:51 +0100") Message-ID: <875ycdzcor.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60899 Cc: "\(" , 60899@debbugs.gnu.org, 60899-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Christopher Baines writes: > "(" writes: > >> [[PGP Signed Part:Undecided]] >> On Mon Feb 6, 2023 at 11:14 PM GMT, Christopher Baines wrote: >>> I've made a few tweaks and pushed this to master as >>> f3ab5888a0bc6446104ddbba41a413a86eb298e2. >> >> Nooo, my review was too slow :P > > I think reviewing changes/sending feedback after things have been merged > is fine (and important). If more people get involved in reviewing > things, this is probably something that'll happen more, so I think for > now it's good to embrace it. > > Hopefully we can continue the discussion around these changes and > perhaps further improve things with some additional patches. > > Chris I responded to Chris's original message, but: +1 to what Chris says. I'm still going to look at your feedback, paren, and maybe send some more patches. Personally, I prefer always moving forward, so long as it doesn't break anything. Thank you very much for the reviews! -- Katherine From unknown Fri Aug 15 15:35:54 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 08 Mar 2023 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator