GNU bug report logs - #60858
[PATCH] src/w32fns.c: Quotes around w32-register-hot-key

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60858 in the body.
You can then email your comments to 60858 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: emacs-bugs <bug-gnu-emacs <at> gnu.org>
Subject: [PATCH] src/w32fns.c: Quotes around w32-register-hot-key
Date: Mon, 16 Jan 2023 12:47:24 +0100

Hi all,

is there a reason why the quotes around the above mentioned function are
like this:

  `w32-register-hot-key`

instead of the usual

  `w32-register-hot-key'

?  If this is a copy-paste issue, the following patch against the
release branch fixes it:

--8<---------------cut here---------------start------------->8---
diff --git a/src/w32fns.c b/src/w32fns.c
index 192d3ddf27a..7b1ffc6a6be 100644
--- a/src/w32fns.c
+++ b/src/w32fns.c
@@ -10664,7 +10664,7 @@ syms_of_w32fns (void)
 Properties" dialog, etc.  On Windows 10, no \"Windows\" key
 combinations are normally handed to applications.  To enable Emacs to
 process \"Windows\" key combinations, use the function
-`w32-register-hot-key`.
+`w32-register-hot-key'.

 For Windows 98/ME, see the doc string of `w32-phantom-key-code'.  */);
   Vw32_pass_lwindow_to_system = Qt;
@@ -10683,7 +10683,7 @@ syms_of_w32fns (void)
 Properties" dialog, etc.  On Windows 10, no \"Windows\" key
 combinations are normally handed to applications.  To enable Emacs to
 process \"Windows\" key combinations, use the function
-`w32-register-hot-key`.
+`w32-register-hot-key'.

 For Windows 98/ME, see the doc string of `w32-phantom-key-code'.  */);
   Vw32_pass_rwindow_to_system = Qt;
@@ -10698,7 +10698,7 @@ syms_of_w32fns (void)
 `w32-pass-rwindow-to-system' is nil.

 This variable is only used on Windows 98 and ME.  For other Windows
-versions, see the documentation of the `w32-register-hot-key`
+versions, see the documentation of the `w32-register-hot-key'
 function.  */);
   /* Although 255 is technically not a valid key code, it works and
      means that this hack won't interfere with any real key code.  */
@@ -10732,7 +10732,7 @@ syms_of_w32fns (void)
 respective modifier, or nil to appear as the `lwindow' key.
 Any other value will cause the key to be ignored.

-Also see the documentation of the `w32-register-hot-key` function.  */);
+Also see the documentation of the `w32-register-hot-key' function.  */);
   Vw32_lwindow_modifier = Qnil;

   DEFVAR_LISP ("w32-rwindow-modifier",
@@ -10742,7 +10742,7 @@ syms_of_w32fns (void)
 respective modifier, or nil to appear as the `rwindow' key.
 Any other value will cause the key to be ignored.

-Also see the documentation of the `w32-register-hot-key` function.  */);
+Also see the documentation of the `w32-register-hot-key' function.  */);
   Vw32_rwindow_modifier = Qnil;

   DEFVAR_LISP ("w32-apps-modifier",
--8<---------------cut here---------------end--------------->8---

Best, Arash

Message #10 received at 60858-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Arash Esbati <arash <at> gnu.org>
Cc: 60858-done <at> debbugs.gnu.org
Subject: Re: bug#60858: [PATCH] src/w32fns.c: Quotes around
 w32-register-hot-key
Date: Mon, 16 Jan 2023 16:02:22 +0200

> From: Arash Esbati <arash <at> gnu.org>
> Date: Mon, 16 Jan 2023 12:47:24 +0100
> is there a reason why the quotes around the above mentioned function are
> like this:
> 
>   `w32-register-hot-key`
> 
> instead of the usual
> 
>   `w32-register-hot-key'
> 
> ?

It's the MD madness, sigh...

> If this is a copy-paste issue, the following patch against the
> release branch fixes it:

Thanks, installed.

Message #13 received at 60858 <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 60858 <at> debbugs.gnu.org
Subject: Re: bug#60858: [PATCH] src/w32fns.c: Quotes around
 w32-register-hot-key
Date: Mon, 16 Jan 2023 15:47:09 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:

> Thanks, installed.

Thanks.  Did you exclude these 2 (lines 10667 & 10686) intentionally?

--8<---------------cut here---------------start------------->8---
diff --git a/src/w32fns.c b/src/w32fns.c
index 71206b8874c..b4192a5ffa6 100644
--- a/src/w32fns.c
+++ b/src/w32fns.c
@@ -10664,7 +10664,7 @@ syms_of_w32fns (void)
 Properties" dialog, etc.  On Windows 10, no \"Windows\" key
 combinations are normally handed to applications.  To enable Emacs to
 process \"Windows\" key combinations, use the function
-`w32-register-hot-key`.
+`w32-register-hot-key'.

 For Windows 98/ME, see the doc string of `w32-phantom-key-code'.  */);
   Vw32_pass_lwindow_to_system = Qt;
@@ -10683,7 +10683,7 @@ syms_of_w32fns (void)
 Properties" dialog, etc.  On Windows 10, no \"Windows\" key
 combinations are normally handed to applications.  To enable Emacs to
 process \"Windows\" key combinations, use the function
-`w32-register-hot-key`.
+`w32-register-hot-key'.

 For Windows 98/ME, see the doc string of `w32-phantom-key-code'.  */);
   Vw32_pass_rwindow_to_system = Qt;
--8<---------------cut here---------------end--------------->8---

Best, Arash

Message #16 received at 60858 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Arash Esbati <arash <at> gnu.org>
Cc: 60858 <at> debbugs.gnu.org
Subject: Re: bug#60858: [PATCH] src/w32fns.c: Quotes around
 w32-register-hot-key
Date: Mon, 16 Jan 2023 16:56:14 +0200

> From: Arash Esbati <arash <at> gnu.org>
> Cc: 60858 <at> debbugs.gnu.org
> Date: Mon, 16 Jan 2023 15:47:09 +0100
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > Thanks, installed.
> 
> Thanks.  Did you exclude these 2 (lines 10667 & 10686) intentionally?

No, of course not.  Fixed.

Message #19 received at 60858 <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 60858 <at> debbugs.gnu.org
Subject: Re: bug#60858: [PATCH] src/w32fns.c: Quotes around
 w32-register-hot-key
Date: Mon, 16 Jan 2023 16:00:57 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:

> No, of course not.  Fixed.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.