GNU bug report logs - #60845
30.0.50; [PATCH] Add tests for Eshell interactive completion (and fix a bug in it)

Previous Next

Package: emacs;

Reported by: Jim Porter <jporterbugs <at> gmail.com>

Date: Mon, 16 Jan 2023 01:51:02 UTC

Severity: normal

Tags: patch

Found in version 30.0.50

Done: Jim Porter <jporterbugs <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #34 received at 60845-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 60845-done <at> debbugs.gnu.org, Daniel Mendler <mail <at> daniel-mendler.de>,
 Gregory Heytings <gregory <at> heytings.org>, arstoffel <at> gmail.com,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#60845: 30.0.50; [PATCH] Add tests for Eshell interactive
 completion (and fix a bug in it)
Date: Tue, 10 Oct 2023 13:07:50 -0700
On 9/5/2023 6:37 PM, Jim Porter wrote:
> Attached is a patch to revert the Emacs 29 workarounds. I *believe* I've 
> fixed this on the Eshell side by always providing Pcomplete with the 
> arguments in their string form. Could everyone try the patch out to make 
> sure things still work?
> 
> In particular, see the cases in the following bugs: bug#60464, 
> bug#60021, and bug#59956.

Since there have been no further comments in the last month, I've now 
merged my patch to the master branch as 239db5d5162. If anyone sees any 
issues resulting from this, feel free to back it out, file a bug, and/or 
let me know directly.




This bug report was last modified 1 year and 219 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.