GNU bug report logs - #60845
30.0.50; [PATCH] Add tests for Eshell interactive completion (and fix a bug in it)

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jim Porter <jporterbugs <at> gmail.com>
Subject: bug#60845: closed (Re: bug#60845: 30.0.50; [PATCH] Add tests for
 Eshell interactive completion (and fix a bug in it))
Date: Tue, 10 Oct 2023 20:09:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#60845: 30.0.50; [PATCH] Add tests for Eshell interactive completion (and fix a bug in it)

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 60845 <at> debbugs.gnu.org.

-- 
60845: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60845
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jim Porter <jporterbugs <at> gmail.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 60845-done <at> debbugs.gnu.org, Daniel Mendler <mail <at> daniel-mendler.de>,
 Gregory Heytings <gregory <at> heytings.org>, arstoffel <at> gmail.com,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#60845: 30.0.50; [PATCH] Add tests for Eshell interactive
 completion (and fix a bug in it)
Date: Tue, 10 Oct 2023 13:07:50 -0700

On 9/5/2023 6:37 PM, Jim Porter wrote:
> Attached is a patch to revert the Emacs 29 workarounds. I *believe* I've 
> fixed this on the Eshell side by always providing Pcomplete with the 
> arguments in their string form. Could everyone try the patch out to make 
> sure things still work?
> 
> In particular, see the cases in the following bugs: bug#60464, 
> bug#60021, and bug#59956.

Since there have been no further comments in the last month, I've now 
merged my patch to the master branch as 239db5d5162. If anyone sees any 
issues resulting from this, feel free to back it out, file a bug, and/or 
let me know directly.

[Message part 3 (message/rfc822, inline)]

From: Jim Porter <jporterbugs <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; [PATCH] Add tests for Eshell interactive completion (and fix
 a bug in it)
Date: Sun, 15 Jan 2023 17:50:10 -0800

[Message part 4 (text/plain, inline)]

This is a followup from bug#60464 and friends. Over there, we discussed 
problems with Pcomplete when used from Eshell, namely that Eshell 
sometimes gives Pcomplete non-string arguments. I mentioned that we 
should probably have automated tests for the Eshell side so that we can 
make further improvements to Pcomplete without causing regressions, so 
here are some tests.

I also fixed an edge case in 'eshell-complete-parse-arguments' where it 
wasn't correctly handling the new variable-splicing syntax in Eshell. 
That's patch 0002.

Of course, these tests are just a start, and there are probably lots of 
others that we could add.

[0001-Add-regression-tests-for-Eshell-completions.patch (text/plain, attachment)]

[0002-Properly-parse-Eshell-variable-splices-for-interacti.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.