From unknown Sat Jun 14 03:51:24 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#60845 <60845@debbugs.gnu.org> To: bug#60845 <60845@debbugs.gnu.org> Subject: Status: 30.0.50; [PATCH] Add tests for Eshell interactive completion (and fix a bug in it) Reply-To: bug#60845 <60845@debbugs.gnu.org> Date: Sat, 14 Jun 2025 10:51:24 +0000 retitle 60845 30.0.50; [PATCH] Add tests for Eshell interactive completion = (and fix a bug in it) reassign 60845 emacs submitter 60845 Jim Porter severity 60845 normal tag 60845 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 15 20:50:18 2023 Received: (at submit) by debbugs.gnu.org; 16 Jan 2023 01:50:18 +0000 Received: from localhost ([127.0.0.1]:59983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHEdd-0005WB-JO for submit@debbugs.gnu.org; Sun, 15 Jan 2023 20:50:18 -0500 Received: from lists.gnu.org ([209.51.188.17]:53990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHEdb-0005W3-Ox for submit@debbugs.gnu.org; Sun, 15 Jan 2023 20:50:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHEdb-000773-E9 for bug-gnu-emacs@gnu.org; Sun, 15 Jan 2023 20:50:15 -0500 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pHEdZ-0007V2-3V for bug-gnu-emacs@gnu.org; Sun, 15 Jan 2023 20:50:15 -0500 Received: by mail-pf1-x434.google.com with SMTP id i1so4873671pfk.3 for ; Sun, 15 Jan 2023 17:50:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:from:content-language:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=yZYxv5VWIUj6lZcd6cPoRwvDWjrEtbH/lz79QnbwlBE=; b=RrYpIGydusaebe48FWAh3Gl0tFMixnqzHKsI+GyndXCfWi7DoeyLc6UzHHlacTHMie T7c1quF2DQ4HljLfU5JN7STDEylunTPZyMZQSL5V0Ra5Y50vQrKM6xwQm0EuxSpQANX7 SpBCQPCXaxY0iaDbLYLI919vEnzOXfZVsECKiKniTt1vVXic54y/tV+TPRB9KROfBrXE p7iL/LmYYfXCUDe848flTGB35wz+aYWlUyLcxEr1II42zZvPku4BlbxmBQOvAZwUTFwV F+WLAcS96X2C7EHflFUrbeT/wtaLoO+pTF4pu8szw/ZFQqNf6NQ+LYf91j8NLFjQtDCT wH+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:from:content-language:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yZYxv5VWIUj6lZcd6cPoRwvDWjrEtbH/lz79QnbwlBE=; b=3067xLPv7yoM9dsok8jus1VSy9iyMe8BoEo2cQjtD3hc/nY1mGA8WGCTGmy9r3SBxW FluSiXTmwwB2YcPllARpwC7Mkx4UF6+Y+LuQlDXF0Ipizm/CE2lWyJwAz/wVHF6ipYaB WJyCgAubLAZPs9zc9X7P4gwLwbf67380CyLHV7NsNykcsEv+5ShbPZfcl+6KnbA+skPS 5HwGIgC9I8qxDVDmUdAERDc2BpFOR5Fa3nd/xbx9+1a20XdDm9LE4a2xyO8WpqSfsIu7 zhiQJT0pOb2ovAuMGsycimPwm6E7SZa2BTJEDdnlAKqGFzkQUD5ZtCUporvHwxxAzS4V GsPA== X-Gm-Message-State: AFqh2koRmxK8zMX3vnyJamfbXHWNDg/Sx+IYq7CxiZksUSGt++HPNRI+ yfMiUB5UELxjKkASmJMvVDsJQj+gl+2fvA== X-Google-Smtp-Source: AMrXdXtm5lpBOFWx0mx+AR5HucUlG7dggXB0jbHNvxwXB+7Meu+AIkRb8gQKx/z/r1HHNfqJ9kn/wQ== X-Received: by 2002:aa7:924d:0:b0:57e:866d:c095 with SMTP id 13-20020aa7924d000000b0057e866dc095mr82007504pfp.25.1673833811208; Sun, 15 Jan 2023 17:50:11 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id 63-20020a621942000000b0056d98e359a5sm17010160pfz.165.2023.01.15.17.50.10 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 15 Jan 2023 17:50:10 -0800 (PST) Content-Type: multipart/mixed; boundary="------------3NHyFLoZKjOLzx6bQAC8DzLw" Message-ID: <2b75d4d4-0533-2182-6da8-413391577bf5@gmail.com> Date: Sun, 15 Jan 2023 17:50:10 -0800 MIME-Version: 1.0 X-Mozilla-News-Host: news://news.gmane.io:119 Content-Language: en-US From: Jim Porter Subject: 30.0.50; [PATCH] Add tests for Eshell interactive completion (and fix a bug in it) To: bug-gnu-emacs@gnu.org Received-SPF: pass client-ip=2607:f8b0:4864:20::434; envelope-from=jporterbugs@gmail.com; helo=mail-pf1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------3NHyFLoZKjOLzx6bQAC8DzLw Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit This is a followup from bug#60464 and friends. Over there, we discussed problems with Pcomplete when used from Eshell, namely that Eshell sometimes gives Pcomplete non-string arguments. I mentioned that we should probably have automated tests for the Eshell side so that we can make further improvements to Pcomplete without causing regressions, so here are some tests. I also fixed an edge case in 'eshell-complete-parse-arguments' where it wasn't correctly handling the new variable-splicing syntax in Eshell. That's patch 0002. Of course, these tests are just a start, and there are probably lots of others that we could add. --------------3NHyFLoZKjOLzx6bQAC8DzLw Content-Type: text/plain; charset=UTF-8; name="0001-Add-regression-tests-for-Eshell-completions.patch" Content-Disposition: attachment; filename="0001-Add-regression-tests-for-Eshell-completions.patch" Content-Transfer-Encoding: base64 RnJvbSBiZGVmMzdmNmNjMTAxODIwZjA2MGM3MThmNDAxNmEyOTIwNmM1MWQxIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgMTUgSmFuIDIwMjMgMTY6NDQ6MTcgLTA4MDAKU3ViamVjdDogW1BB VENIIDEvMl0gQWRkIHJlZ3Jlc3Npb24gdGVzdHMgZm9yIEVzaGVsbCBjb21wbGV0aW9ucwoK KiBsaXNwL2VzaGVsbC9lc2gtY21kLmVsIChlc2hlbGwtY29tcGxldGUtbGlzcC1zeW1ib2xz KTogRml4CmRvY3N0cmluZy4KCiogdGVzdC9saXNwL2VzaGVsbC9lbS1jbXBsLXRlc3RzLmVs OiBOZXcgZmlsZS4KLS0tCiBsaXNwL2VzaGVsbC9lc2gtY21kLmVsICAgICAgICAgICAgfCAg IDIgKy0KIHRlc3QvbGlzcC9lc2hlbGwvZW0tY21wbC10ZXN0cy5lbCB8IDE0NyArKysrKysr KysrKysrKysrKysrKysrKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMTQ4IGluc2VydGlv bnMoKyksIDEgZGVsZXRpb24oLSkKIGNyZWF0ZSBtb2RlIDEwMDY0NCB0ZXN0L2xpc3AvZXNo ZWxsL2VtLWNtcGwtdGVzdHMuZWwKCmRpZmYgLS1naXQgYS9saXNwL2VzaGVsbC9lc2gtY21k LmVsIGIvbGlzcC9lc2hlbGwvZXNoLWNtZC5lbAppbmRleCA5OWMzZDdmNjI3ZC4uYjVmMWQ2 MGZmMTggMTAwNjQ0Ci0tLSBhL2xpc3AvZXNoZWxsL2VzaC1jbWQuZWwKKysrIGIvbGlzcC9l c2hlbGwvZXNoLWNtZC5lbApAQCAtMzQzLDcgKzM0Myw3IEBAIGVzaGVsbC1jbWQtaW5pdGlh bGl6ZQogCSAgICAgICMnZXNoZWxsLWNvbXBsZXRlLWxpc3Atc3ltYm9scyBuaWwgdCkpKQog CiAoZGVmdW4gZXNoZWxsLWNvbXBsZXRlLWxpc3Atc3ltYm9scyAoKQotICAiSWYgdGhlcmUg aXMgYSB1c2VyIHJlZmVyZW5jZSwgY29tcGxldGUgaXQuIgorICAiSWYgdGhlcmUgaXMgYSBM aXNwIHN5bWJvbCwgY29tcGxldGUgaXQuIgogICAobGV0ICgoYXJnIChwY29tcGxldGUtYWN0 dWFsLWFyZykpKQogICAgICh3aGVuIChzdHJpbmctbWF0Y2ggKGNvbmNhdCAiXFxgIiBlc2hl bGwtbGlzcC1yZWdleHApIGFyZykKICAgICAgIChzZXRxIHBjb21wbGV0ZS1zdHViIChzdWJz dHJpbmcgYXJnIChtYXRjaC1lbmQgMCkpCmRpZmYgLS1naXQgYS90ZXN0L2xpc3AvZXNoZWxs L2VtLWNtcGwtdGVzdHMuZWwgYi90ZXN0L2xpc3AvZXNoZWxsL2VtLWNtcGwtdGVzdHMuZWwK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAuLjgzN2FmOWQxMDYxCi0t LSAvZGV2L251bGwKKysrIGIvdGVzdC9saXNwL2VzaGVsbC9lbS1jbXBsLXRlc3RzLmVsCkBA IC0wLDAgKzEsMTQ3IEBACis7OzsgZW0tY21wbC10ZXN0cy5lbCAtLS0gZW0tY21wbCB0ZXN0 IHN1aXRlICAtKi0gbGV4aWNhbC1iaW5kaW5nOnQgLSotCisKKzs7IENvcHlyaWdodCAoQykg MjAyMyBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4KKworOzsgVGhpcyBmaWxlIGlz IHBhcnQgb2YgR05VIEVtYWNzLgorCis7OyBHTlUgRW1hY3MgaXMgZnJlZSBzb2Z0d2FyZTog eW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yIG1vZGlmeQorOzsgaXQgdW5kZXIgdGhl IHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBhcyBwdWJsaXNoZWQg YnkKKzs7IHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIGVpdGhlciB2ZXJzaW9uIDMg b2YgdGhlIExpY2Vuc2UsIG9yCis7OyAoYXQgeW91ciBvcHRpb24pIGFueSBsYXRlciB2ZXJz aW9uLgorCis7OyBHTlUgRW1hY3MgaXMgZGlzdHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBp dCB3aWxsIGJlIHVzZWZ1bCwKKzs7IGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91 dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mCis7OyBNRVJDSEFOVEFCSUxJVFkgb3Ig RklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlCis7OyBHTlUgR2Vu ZXJhbCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgorCis7OyBZb3Ugc2hvdWxk IGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5z ZQorOzsgYWxvbmcgd2l0aCBHTlUgRW1hY3MuICBJZiBub3QsIHNlZSA8aHR0cHM6Ly93d3cu Z251Lm9yZy9saWNlbnNlcy8+LgorCis7OzsgQ29tbWVudGFyeToKKworOzsgVGVzdHMgZm9y IEVzaGVsbCdzIGludGVyYWN0aXZlIGNvbXBsZXRpb24uCisKKzs7OyBDb2RlOgorCisocmVx dWlyZSAnZXJ0KQorKHJlcXVpcmUgJ2VzaGVsbCkKKyhyZXF1aXJlICdlbS1jbXBsKQorKHJl cXVpcmUgJ2VtLWRpcnMpCisocmVxdWlyZSAnZW0taGlzdCkKKyhyZXF1aXJlICdlbS10cmFt cCkKKyhyZXF1aXJlICdlbS11bml4KQorCisocmVxdWlyZSAnZXNoZWxsLXRlc3RzLWhlbHBl cnMKKyAgICAgICAgIChleHBhbmQtZmlsZS1uYW1lICJlc2hlbGwtdGVzdHMtaGVscGVycyIK KyAgICAgICAgICAgICAgICAgICAgICAgICAgIChmaWxlLW5hbWUtZGlyZWN0b3J5IChvciBs b2FkLWZpbGUtbmFtZQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGRlZmF1bHQtZGlyZWN0b3J5KSkpKQorCisoZGVmdmFyIGVzaGVsbC10 ZXN0LXZhbHVlIG5pbCkKKworKGRlZnVuIGVzaGVsbC1pbnNlcnQtYW5kLWNvbXBsZXRlIChp bnB1dCkKKyAgIkluc2VydCBJTlBVVCBhbmQgaW52b2tlIGNvbXBsZXRpb24sIHJldHVybmlu ZyB0aGUgcmVzdWx0LiIKKyAgKGluc2VydCBpbnB1dCkKKyAgKGNvbXBsZXRpb24tYXQtcG9p bnQpCisgIChlc2hlbGwtZ2V0LW9sZC1pbnB1dCkpCisKKzs7OyBUZXN0czoKKworKGVydC1k ZWZ0ZXN0IGVtLWNtcGwtdGVzdC9wYXJzZS1hcmd1bWVudHMvcGlwZWxpbmUgKCkKKyAgIlRl c3QgdGhhdCBwYXJzaW5nIGFyZ3VtZW50cyBmb3IgY29tcGxldGlvbiBkaXNjYXJkcyBlYXJs aWVyIGNvbW1hbmRzLiIKKyAgKHdpdGgtdGVtcC1lc2hlbGwKKyAgIChsZXQgKChlc2hlbGwt dGVzdC12YWx1ZSAnKCJmb28iICJiYXIiKSkpCisgICAgIChpbnNlcnQgImVjaG8gaGkgfCBj YXQiKQorICAgICAoc2hvdWxkIChlcXVhbCAoY2FyIChlc2hlbGwtY29tcGxldGUtcGFyc2Ut YXJndW1lbnRzKSkKKyAgICAgICAgICAgICAgICAgICAgYCgiY2F0IikpKSkpKQorCisoZXJ0 LWRlZnRlc3QgZW0tY21wbC10ZXN0L3BhcnNlLWFyZ3VtZW50cy92YXJpYWJsZSAoKQorICAi VGVzdCBwYXJzaW5nIGFyZ3VtZW50cyB3aXRoIGEgdmFyaWFibGUgaW50ZXJwb2xhdGlvbi4i CisgICh3aXRoLXRlbXAtZXNoZWxsCisgICAobGV0ICgoZXNoZWxsLXRlc3QtdmFsdWUgJygi Zm9vIiAiYmFyIikpKQorICAgICAoaW5zZXJ0ICJlY2hvICRlc2hlbGwtdGVzdC12YWx1ZSIp CisgICAgIChzaG91bGQgKGVxdWFsIChjYXIgKGVzaGVsbC1jb21wbGV0ZS1wYXJzZS1hcmd1 bWVudHMpKQorICAgICAgICAgICAgICAgICAgICBgKCJlY2hvIiAoImZvbyIgImJhciIpKSkp KSkpCisKKyhlcnQtZGVmdGVzdCBlbS1jbXBsLXRlc3QvZmlsZS1jb21wbGV0aW9uL3VuaXF1 ZSAoKQorICAiVGVzdCBjb21wbGV0aW9uIG9mIGZpbGUgbmFtZXMgd2hlbiB0aGVyZSdzIGEg dW5pcXVlIHJlc3VsdC4iCisgICh3aXRoLXRlbXAtZXNoZWxsCisgICAoZXJ0LXdpdGgtdGVt cC1kaXJlY3RvcnkgZGVmYXVsdC1kaXJlY3RvcnkKKyAgICAgKHdyaXRlLXJlZ2lvbiBuaWwg bmlsIChleHBhbmQtZmlsZS1uYW1lICJmaWxlLnR4dCIpKQorICAgICAoc2hvdWxkIChlcXVh bCAoZXNoZWxsLWluc2VydC1hbmQtY29tcGxldGUgImVjaG8gZmkiKQorICAgICAgICAgICAg ICAgICAgICAiZWNobyBmaWxlLnR4dCAiKSkpKSkKKworKGVydC1kZWZ0ZXN0IGVtLWNtcGwt dGVzdC9maWxlLWNvbXBsZXRpb24vbm9uLXVuaXF1ZSAoKQorICAiVGVzdCBjb21wbGV0aW9u IG9mIGZpbGUgbmFtZXMgd2hlbiB0aGVyZSBhcmUgbXVsdGlwbGUgcmVzdWx0cy4iCisgICh3 aXRoLXRlbXAtZXNoZWxsCisgICAoZXJ0LXdpdGgtdGVtcC1kaXJlY3RvcnkgZGVmYXVsdC1k aXJlY3RvcnkKKyAgICAgKHdyaXRlLXJlZ2lvbiBuaWwgbmlsIChleHBhbmQtZmlsZS1uYW1l ICJmaWxlLnR4dCIpKQorICAgICAod3JpdGUtcmVnaW9uIG5pbCBuaWwgKGV4cGFuZC1maWxl LW5hbWUgImZpbGUuZWwiKSkKKyAgICAgKHNob3VsZCAoZXF1YWwgKGVzaGVsbC1pbnNlcnQt YW5kLWNvbXBsZXRlICJlY2hvIGZpIikKKyAgICAgICAgICAgICAgICAgICAgImVjaG8gZmls ZS4iKSkKKyAgICAgOzsgTm93IHRyeSBjb21wbGV0aW5nIGFnYWluLgorICAgICAobGV0ICgo bWluaWJ1ZmZlci1tZXNzYWdlLXRpbWVvdXQgMCkKKyAgICAgICAgICAgKGluaGliaXQtbWVz c2FnZSB0KSkKKyAgICAgICAoY29tcGxldGlvbi1hdC1wb2ludCkpCisgICAgIDs7IEZJWE1F OiBXZSBjYW4ndCB1c2UgYGN1cnJlbnQtbWVzc2FnZScgaGVyZS4KKyAgICAgKHdpdGgtY3Vy cmVudC1idWZmZXIgKG1lc3NhZ2VzLWJ1ZmZlcikKKyAgICAgICAoc2F2ZS1leGN1cnNpb24K KyAgICAgICAgIChnb3RvLWNoYXIgKHBvaW50LW1heCkpCisgICAgICAgICAoZm9yd2FyZC1s aW5lIC0xKQorICAgICAgICAgKHNob3VsZCAobG9va2luZy1hdCAiQ29tcGxldGUsIGJ1dCBu b3QgdW5pcXVlIikpKSkpKSkKKworKGVydC1kZWZ0ZXN0IGVtLWNtcGwtdGVzdC9maWxlLWNv bXBsZXRpb24vYWZ0ZXItbGlzdCAoKQorICAiVGVzdCBjb21wbGV0aW9uIG9mIGZpbGUgbmFt ZXMgYWZ0ZXIgcHJldmlvdXMgbGlzdCBhcmd1bWVudHMuCitTZWUgYnVnIzU5OTU2LiIKKyAg KHdpdGgtdGVtcC1lc2hlbGwKKyAgIChlcnQtd2l0aC10ZW1wLWRpcmVjdG9yeSBkZWZhdWx0 LWRpcmVjdG9yeQorICAgICAod3JpdGUtcmVnaW9uIG5pbCBuaWwgKGV4cGFuZC1maWxlLW5h bWUgImZpbGUudHh0IikpCisgICAgIChzaG91bGQgKGVxdWFsIChlc2hlbGwtaW5zZXJ0LWFu ZC1jb21wbGV0ZSAiZWNobyAobGlzdCAxIDIpIGZpIikKKyAgICAgICAgICAgICAgICAgICAg ImVjaG8gKGxpc3QgMSAyKSBmaWxlLnR4dCAiKSkpKSkKKworKGVydC1kZWZ0ZXN0IGVtLWNt cGwtdGVzdC9saXNwLXN5bWJvbC1jb21wbGV0aW9uICgpCisgICJUZXN0IGNvbXBsZXRpb24g b2YgTGlzcCBmb3JtcyBsaWtlIFwiIydzeW1ib2xcIiBhbmQgXCJgc3ltYm9sXCIuCitTZWUg PGxpc3AvZXNoZWxsL2VzaC1jbWQuZWw+LiIKKyAgKHdpdGgtdGVtcC1lc2hlbGwKKyAgIChz aG91bGQgKGVxdWFsIChlc2hlbGwtaW5zZXJ0LWFuZC1jb21wbGV0ZSAiZWNobyAjJ3N5c3Rl bS1uYW0iKQorICAgICAgICAgICAgICAgICAgImVjaG8gIydzeXN0ZW0tbmFtZSAiKSkpCisg ICh3aXRoLXRlbXAtZXNoZWxsCisgICAoc2hvdWxkIChlcXVhbCAoZXNoZWxsLWluc2VydC1h bmQtY29tcGxldGUgImVjaG8gYHN5c3RlbS1uYW0iKQorICAgICAgICAgICAgICAgICAgImVj aG8gYHN5c3RlbS1uYW1lICIpKSkpCisKKyhlcnQtZGVmdGVzdCBlbS1jbXBsLXRlc3QvbGlz cC1mdW5jdGlvbi1jb21wbGV0aW9uICgpCisgICJUZXN0IGNvbXBsZXRpb24gb2YgTGlzcCBm b3JtcyBsaWtlIFwiKGZ1bmMpXCIuCitTZWUgPGxpc3AvZXNoZWxsL2VzaC1jbWQuZWw+LiIK KyAgKHdpdGgtdGVtcC1lc2hlbGwKKyAgIChzaG91bGQgKGVxdWFsIChlc2hlbGwtaW5zZXJ0 LWFuZC1jb21wbGV0ZSAiZWNobyAoZXNoZWxsL2VjaCIpCisgICAgICAgICAgICAgICAgICAi ZWNobyAoZXNoZWxsL2VjaG8iKSkpKQorCisoZXJ0LWRlZnRlc3QgZW0tY21wbC10ZXN0L3Zh cmlhYmxlLXJlZi1jb21wbGV0aW9uICgpCisgICJUZXN0IGNvbXBsZXRpb24gb2YgdmFyaWFi bGUgcmVmZXJlbmNlcyBsaWtlIFwiJHZhclwiLgorU2VlIDxsaXNwL2VzaGVsbC9lc2gtdmFy LmVsPi4iCisgICh3aXRoLXRlbXAtZXNoZWxsCisgICAoc2hvdWxkIChlcXVhbCAoZXNoZWxs LWluc2VydC1hbmQtY29tcGxldGUgImVjaG8gJHN5c3RlbS1uYW0iKQorICAgICAgICAgICAg ICAgICAgImVjaG8gJHN5c3RlbS1uYW1lICIpKSkpCisKKyhlcnQtZGVmdGVzdCBlbS1jbXBs LXRlc3QvdmFyaWFibGUtYXNzaWduLWNvbXBsZXRpb24gKCkKKyAgIlRlc3QgY29tcGxldGlv biBvZiB2YXJpYWJsZSBhc3NpZ25tZW50cyBsaWtlIFwidmFyPXZhbHVlXCIuCitTZWUgPGxp c3AvZXNoZWxsL2VzaC12YXIuZWw+LiIKKyAgKHdpdGgtdGVtcC1lc2hlbGwKKyAgIChlcnQt d2l0aC10ZW1wLWRpcmVjdG9yeSBkZWZhdWx0LWRpcmVjdG9yeQorICAgICAod3JpdGUtcmVn aW9uIG5pbCBuaWwgKGV4cGFuZC1maWxlLW5hbWUgImZpbGUudHh0IikpCisgICAgIChzaG91 bGQgKGVxdWFsIChlc2hlbGwtaW5zZXJ0LWFuZC1jb21wbGV0ZSAiVkFSPWYiKQorICAgICAg ICAgICAgICAgICAgICAiVkFSPWZpbGUudHh0ICIpKSkpKQorCisoZXJ0LWRlZnRlc3QgZW0t Y21wbC10ZXN0L3VzZXItcmVmLWNvbXBsZXRpb24gKCkKKyAgIlRlc3QgY29tcGxldGVpb24g b2YgdXNlciByZWZlcmVuY2VzIGxpa2UgXCJ+dXNlclwiLgorU2VlIDxsaXNwL2VzaGVsbC9l bS1kaXJzLmVsPi4iCisgICh1bndpbmQtcHJvdGVjdAorICAgICAgKHdpdGgtdGVtcC1lc2hl bGwKKyAgICAgICAoY2wtbGV0ZiAoKChzeW1ib2wtZnVuY3Rpb24gJ2VzaGVsbC1yZWFkLXVz ZXItbmFtZXMpCisgICAgICAgICAgICAgICAgICAobGFtYmRhICgpIChzZXRxIGVzaGVsbC11 c2VyLW5hbWVzICcoKDEyMzQgLiAidXNlciIpKSkpKSkKKyAgICAgICAgIDs7IEZJWE1FOiBT aG91bGQgdGhpcyByZWFsbHkgYWRkIGEgc3BhY2UgYXQgdGhlIGVuZD8KKyAgICAgICAgIChz aG91bGQgKGVxdWFsIChlc2hlbGwtaW5zZXJ0LWFuZC1jb21wbGV0ZSAiZWNobyB+dXMiKQor ICAgICAgICAgICAgICAgICAgICAgICAgImVjaG8gfnVzZXIvICIpKSkpCisgICAgOzsgQ2xl YXIgdGhlIGNhY2hlZCB1c2VyIG5hbWVzIHdlIHNldCBhYm92ZS4KKyAgICAoc2V0cSBlc2hl bGwtdXNlci1uYW1lcyBuaWwpKSkKKworOzs7IGVtLWNtcGwtdGVzdHMuZWwgZW5kcyBoZXJl Ci0tIAoyLjI1LjEKCg== --------------3NHyFLoZKjOLzx6bQAC8DzLw Content-Type: text/plain; charset=UTF-8; name="0002-Properly-parse-Eshell-variable-splices-for-interacti.patch" Content-Disposition: attachment; filename*0="0002-Properly-parse-Eshell-variable-splices-for-interacti.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAzOWZlMWYxNWYwODA0ZTYwODg5MWYxNThhZmM0OWU4MDZmOTY5ZTk4IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgMTUgSmFuIDIwMjMgMTY6NDQ6MjMgLTA4MDAKU3ViamVjdDogW1BB VENIIDIvMl0gUHJvcGVybHkgcGFyc2UgRXNoZWxsIHZhcmlhYmxlIHNwbGljZXMgZm9yIGlu dGVyYWN0aXZlCiBjb21wbGV0aW9uCgpQcmV2aW91c2x5LCB0aGUgY29kZSBzaW1wbHkgaWdu b3JlZCB0aGUgc3BsaWNlIG9wZXJhdG9yLCB3aGljaCB1c3VhbGx5CndvcmtlZCwgYnV0IGlz bid0IGFjdHVhbGx5IGNvcnJlY3QuCgoqIGxpc3AvZXNoZWxsL2VtLWNtcGwuZWwgKGVzaGVs bC1jb21wbGV0ZS1ldmFsLWFyZ3VtZW50LWZvcm0pOiBOZXcKZnVuY3Rpb24uCihlc2hlbGwt Y29tcGxldGUtcGFyc2UtYXJndW1lbnRzKTogUHJvcGVybHkgcGFyc2UgdmFyaWFibGUgc3Bs aWNlcy4KCiogdGVzdC9saXNwL2VzaGVsbC9lbS1jbXBsLXRlc3RzLmVsCihlbS1jbXBsLXRl c3QvcGFyc2UtYXJndW1lbnRzL3ZhcmlhYmxlLXNwbGljZSk6IE5ldyB0ZXN0LgotLS0KIGxp c3AvZXNoZWxsL2VtLWNtcGwuZWwgICAgICAgICAgICB8IDU2ICsrKysrKysrKysrKysrKysr KysrLS0tLS0tLS0tLS0KIHRlc3QvbGlzcC9lc2hlbGwvZW0tY21wbC10ZXN0cy5lbCB8ICA4 ICsrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDQ0IGluc2VydGlvbnMoKyksIDIwIGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvZXNoZWxsL2VtLWNtcGwuZWwgYi9saXNwL2VzaGVs bC9lbS1jbXBsLmVsCmluZGV4IDQyMDZhZDA0OGZhLi5hNjdmZTUzZWQ0NiAxMDA2NDQKLS0t IGEvbGlzcC9lc2hlbGwvZW0tY21wbC5lbAorKysgYi9saXNwL2VzaGVsbC9lbS1jbXBsLmVs CkBAIC0zMDYsNiArMzA2LDEyIEBAIGVzaGVsbC0tcGNvbXBsZXRlLWluc2VydC10YWIKICAg ICAoaW5zZXJ0LWFuZC1pbmhlcml0ICJcdCIpCiAgICAgKHRocm93ICdwY29tcGxldGVkIHQp KSkKIAorKGRlZnVuIGVzaGVsbC1jb21wbGV0ZS1ldmFsLWFyZ3VtZW50LWZvcm0gKGFyZykK KyAgIkV2YWx1YXRlIGEgc2luZ2xlIEVzaGVsbCBhcmd1bWVudCBmb3JtIEFSRyBmb3IgdGhl IHB1cnBvc2VzIG9mIGNvbXBsZXRpb24uIgorICAobGV0ICgocmVzdWx0IChlc2hlbGwtZG8t ZXZhbCBgKGVzaGVsbC1jb21tYW5kcyAsYXJnKSB0KSkpCisgICAgKGNsLWFzc2VydCAoZXEg KGNhciByZXN1bHQpICdxdW90ZSkpCisgICAgKGNhZHIgcmVzdWx0KSkpCisKIChkZWZ1biBl c2hlbGwtY29tcGxldGUtcGFyc2UtYXJndW1lbnRzICgpCiAgICJQYXJzZSB0aGUgY29tbWFu ZCBsaW5lIGFyZ3VtZW50cyBmb3IgYHBjb21wbGV0ZS1hcmd1bWVudCcuIgogICAod2hlbiAo YW5kIGVzaGVsbC1uby1jb21wbGV0aW9uLWR1cmluZy1qb2JzCkBAIC0zNDQsMTEgKzM1MCw2 IEBAIGVzaGVsbC1jb21wbGV0ZS1wYXJzZS1hcmd1bWVudHMKICAgICAoY2wtYXNzZXJ0ICg9 IChsZW5ndGggYXJncykgKGxlbmd0aCBwb3NucykpKQogICAgIChsZXQgKChhIGFyZ3MpIChp IDApIG5ldy1zdGFydCkKICAgICAgICh3aGlsZSBhCi0gICAgICAgIDs7IFJlbW92ZSBhbnkg dG9wLWxldmVsIGBlc2hlbGwtc3BsaWNlLWFyZ3MnIHNpZ2lscy4gIFRoZXNlCi0gICAgICAg IDs7IGFyZSBtZWFudCB0byBiZSByZXdyaXR0ZW4gYW5kIGNhbid0IGFjdHVhbGx5IGJlIGNh bGxlZC4KLSAgICAgICAgKHdoZW4gKGFuZCAoY29uc3AgKGNhciBhKSkKLSAgICAgICAgICAg ICAgICAgICAoZXEgKGNhYXIgYSkgJ2VzaGVsbC1zcGxpY2UtYXJncykpCi0gICAgICAgICAg KHNldGNhciBhIChjYWRhciBhKSkpCiAgICAgICAgIDs7IElmIHRoZXJlJ3MgYW4gdW5yZXBs YWNlZCBgZXNoZWxsLW9wZXJhdG9yJyBzaWdpbCwgY29uc2lkZXIKICAgICAgICAgOzsgdGhl IHRva2VuIGFmdGVyIGl0IHRoZSBuZXcgc3RhcnQgb2Ygb3VyIGFyZ3VtZW50cy4KICAgICAg ICAgKHdoZW4gKGFuZCAoY29uc3AgKGNhciBhKSkKQEAgLTM2NCwyMyArMzY1LDM4IEBAIGVz aGVsbC1jb21wbGV0ZS1wYXJzZS1hcmd1bWVudHMKIAkgICAgICAgKG5vdCAoZXEgKGNoYXIt YmVmb3JlICgxLSBlbmQpKSA/XFwpKSkKICAgICAgIChuY29uYyBhcmdzIChsaXN0ICIiKSkK ICAgICAgIChuY29uYyBwb3NucyAobGlzdCAocG9pbnQpKSkpCisgICAgOzsgRXZhbHVhdGUg YW5kIGV4cGFuZCBFc2hlbGwgZm9ybXMuCisgICAgKGxldCAoZXZhbGVkLWFyZ3MgZXZhbGVk LXBvc25zKQorICAgICAgKGNsLW1hcGMKKyAgICAgICAobGFtYmRhIChhcmcgcG9zbikKKyAg ICAgICAgIChwY2FzZSBhcmcKKyAgICAgICAgICAgKGAoZXNoZWxsLXNwbGljZS1hcmdzICx2 YWwpCisgICAgICAgICAgICAoZG9saXN0IChzdWJhcmcgKGVzaGVsbC1jb21wbGV0ZS1ldmFs LWFyZ3VtZW50LWZvcm0gdmFsKSkKKyAgICAgICAgICAgICAgKHB1c2ggc3ViYXJnIGV2YWxl ZC1hcmdzKQorICAgICAgICAgICAgICAocHVzaCBwb3NuIGV2YWxlZC1wb3NucykpKQorICAg ICAgICAgICAoKHByZWQgbGlzdHApCisgICAgICAgICAgICAocHVzaCAoZXNoZWxsLWNvbXBs ZXRlLWV2YWwtYXJndW1lbnQtZm9ybSBhcmcpIGV2YWxlZC1hcmdzKQorICAgICAgICAgICAg KHB1c2ggcG9zbiBldmFsZWQtcG9zbnMpKQorICAgICAgICAgICAoXworICAgICAgICAgICAg KHB1c2ggYXJnIGV2YWxlZC1hcmdzKQorICAgICAgICAgICAgKHB1c2ggcG9zbiBldmFsZWQt cG9zbnMpKSkpCisgICAgICAgYXJncyBwb3NucykKKyAgICAgIChzZXRxIGFyZ3MgKG5yZXZl cnNlIGV2YWxlZC1hcmdzKQorICAgICAgICAgICAgcG9zbnMgKG5yZXZlcnNlIGV2YWxlZC1w b3NucykpKQorICAgIDs7IENvbnZlcnQgYXJndW1lbnRzIHRvIGZvcm1zIHRoYXQgUGNvbXBs ZXRlIGNhbiB1bmRlcnN0YW5kLgogICAgIChjb25zIChtYXBjYXIKICAgICAgICAgICAgKGxh bWJkYSAoYXJnKQotICAgICAgICAgICAgIChsZXQgKCh2YWwKLSAgICAgICAgICAgICAgICAg ICAgKGlmIChsaXN0cCBhcmcpCi0gICAgICAgICAgICAgICAgICAgICAgICAobGV0ICgocmVz dWx0Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGVzaGVsbC1kby1ldmFsCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChsaXN0ICdlc2hlbGwtY29tbWFuZHMg YXJnKSB0KSkpCi0gICAgICAgICAgICAgICAgICAgICAgICAgIChjbC1hc3NlcnQgKGVxIChj YXIgcmVzdWx0KSAncXVvdGUpKQotICAgICAgICAgICAgICAgICAgICAgICAgICAoY2FkciBy ZXN1bHQpKQotICAgICAgICAgICAgICAgICAgICAgIGFyZykpKQotICAgICAgICAgICAgICAg KGNvbmQgKChudW1iZXJwIHZhbCkKLSAgICAgICAgICAgICAgICAgICAgICAoc2V0cSB2YWwg KG51bWJlci10by1zdHJpbmcgdmFsKSkpCi0gICAgICAgICAgICAgICAgICAgICA7OyBleHBh bmQgLi4uLyBldGMgdGhhdCBvbmx5IGVzaGVsbCB1bmRlcnN0YW5kcyB0bwotICAgICAgICAg ICAgICAgICAgICAgOzsgc3RhbmRhcmQgLi4vLi4vCi0gICAgICAgICAgICAgICAgICAgICAo KGFuZCAoc3RyaW5ncCB2YWwpKSAoc3RyaW5nLW1hdGNoICJcXC5cXC5cXC4rLyIgdmFsKQot ICAgICAgICAgICAgICAgICAgICAgIChzZXRxIHZhbCAoZXNoZWxsLWV4cGFuZC1tdWx0aXBs ZS1kb3RzIHZhbCkpKSkKLSAgICAgICAgICAgICAgIChvciB2YWwgIiIpKSkKKyAgICAgICAg ICAgICAoY29uZAorICAgICAgICAgICAgICAoKG51bWJlcnAgYXJnKQorICAgICAgICAgICAg ICAgKG51bWJlci10by1zdHJpbmcgYXJnKSkKKyAgICAgICAgICAgICAgOzsgRXhwYW5kICIu Li4vIiBldGMgdGhhdCBvbmx5IEVzaGVsbCB1bmRlcnN0YW5kcyB0byB0aGUKKyAgICAgICAg ICAgICAgOzsgc3RhbmRhcmQgIi4uLy4uLyIuCisgICAgICAgICAgICAgICgoYW5kIChzdHJp bmdwIGFyZykgKHN0cmluZy1tYXRjaCAiXFwuXFwuXFwuKy8iIGFyZykpCisgICAgICAgICAg ICAgICAoZXNoZWxsLWV4cGFuZC1tdWx0aXBsZS1kb3RzIGFyZykpCisgICAgICAgICAgICAg ICgobnVsbCBhcmcpCisgICAgICAgICAgICAgICAiIikKKyAgICAgICAgICAgICAgKHQKKyAg ICAgICAgICAgICAgIGFyZykpKQogCSAgIGFyZ3MpCiAJICBwb3NucykpKQogCmRpZmYgLS1n aXQgYS90ZXN0L2xpc3AvZXNoZWxsL2VtLWNtcGwtdGVzdHMuZWwgYi90ZXN0L2xpc3AvZXNo ZWxsL2VtLWNtcGwtdGVzdHMuZWwKaW5kZXggODM3YWY5ZDEwNjEuLjI0NjBmNThjMjVjIDEw MDY0NAotLS0gYS90ZXN0L2xpc3AvZXNoZWxsL2VtLWNtcGwtdGVzdHMuZWwKKysrIGIvdGVz dC9saXNwL2VzaGVsbC9lbS1jbXBsLXRlc3RzLmVsCkBAIC02Miw2ICs2MiwxNCBAQCBlbS1j bXBsLXRlc3QvcGFyc2UtYXJndW1lbnRzL3ZhcmlhYmxlCiAgICAgIChzaG91bGQgKGVxdWFs IChjYXIgKGVzaGVsbC1jb21wbGV0ZS1wYXJzZS1hcmd1bWVudHMpKQogICAgICAgICAgICAg ICAgICAgICBgKCJlY2hvIiAoImZvbyIgImJhciIpKSkpKSkpCiAKKyhlcnQtZGVmdGVzdCBl bS1jbXBsLXRlc3QvcGFyc2UtYXJndW1lbnRzL3ZhcmlhYmxlLXNwbGljZSAoKQorICAiVGVz dCBwYXJzaW5nIGFyZ3VtZW50cyB3aXRoIGEgc3BsaWNlZCB2YXJpYWJsZSBpbnRlcnBvbGF0 aW9uLiIKKyAgKHdpdGgtdGVtcC1lc2hlbGwKKyAgIChsZXQgKChlc2hlbGwtdGVzdC12YWx1 ZSAnKCJmb28iICJiYXIiKSkpCisgICAgIChpbnNlcnQgImVjaG8gJEBlc2hlbGwtdGVzdC12 YWx1ZSIpCisgICAgIChzaG91bGQgKGVxdWFsIChjYXIgKGVzaGVsbC1jb21wbGV0ZS1wYXJz ZS1hcmd1bWVudHMpKQorICAgICAgICAgICAgICAgICAgICBgKCJlY2hvIiAiZm9vIiAiYmFy IikpKSkpKQorCiAoZXJ0LWRlZnRlc3QgZW0tY21wbC10ZXN0L2ZpbGUtY29tcGxldGlvbi91 bmlxdWUgKCkKICAgIlRlc3QgY29tcGxldGlvbiBvZiBmaWxlIG5hbWVzIHdoZW4gdGhlcmUn cyBhIHVuaXF1ZSByZXN1bHQuIgogICAod2l0aC10ZW1wLWVzaGVsbAotLSAKMi4yNS4xCgo= --------------3NHyFLoZKjOLzx6bQAC8DzLw-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 22 16:34:57 2023 Received: (at 60845) by debbugs.gnu.org; 22 Jan 2023 21:34:57 +0000 Received: from localhost ([127.0.0.1]:52717 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJhzN-0007hk-81 for submit@debbugs.gnu.org; Sun, 22 Jan 2023 16:34:57 -0500 Received: from mail-pf1-f179.google.com ([209.85.210.179]:44913) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJhzH-0007hO-Is for 60845@debbugs.gnu.org; Sun, 22 Jan 2023 16:34:55 -0500 Received: by mail-pf1-f179.google.com with SMTP id w2so7451617pfc.11 for <60845@debbugs.gnu.org>; Sun, 22 Jan 2023 13:34:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=bSWjD9/YYS/D8aG7qObC/abTy04ZOStEUCrSxOYbLJc=; b=ALuimc7r0M/Qr58OT6uUMLWQYkFa1ebMrLwk+0ydMOTkahHM+lHr1yIPmeeMtUxsz4 yBr77xbAzCK7J0AYEqPv0f2HcVzF3R7NyYVUzJ5xh9ubNtZuEG3CKLsppGW3TU8kTDwI IhSIB2AiyzvP/B/upL3tJNagBgdDX+Tw+cXceR2gV7J4v5fK4Uk/MU9n6UkHCY0da8D5 Ia7ArriH5o1IszRBuB/fT+XAjAPhA6Dmqev5B7A5Od2SMlxTo0MDWcaS6FjF0yLXxZ3r Fgcg/igjx/8gI+lxwgBnJP8HLMfIw0/Vml1DpQNaCgk9qe09yBle6xfmVTQeXBzLl5S0 CMWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bSWjD9/YYS/D8aG7qObC/abTy04ZOStEUCrSxOYbLJc=; b=sabV+23ue4+nje9MWrqXnUkoPqH/CuPmhCoaDQFunG2FlzHyjPaSU4b3S6M1HkwiM3 Qg++qaDQ4ajIuWbwH7qPurN3k5Ck+V1B2PDkQn/XnitqezXQVVPZGh8TSNKvMnx5TvmD XZxZjl94XWVWi5fnfmpkbz/LXMPkxRHoN5ILJacDkYINQ9rYtejGVVC861KNBAzbl2qb cOIwuEE3R0R72Q7YFTbwSZ9epEOWNgbMMgWLCyns7Ex4rVCFgoU8OWNB67J5jiToG08O zG3RvZeW246Cncl/c7RNF/KyL9nVJ77svbFWSnESoXhzuLVJusr0BtyGpx8DkcmKLiM6 ADzQ== X-Gm-Message-State: AFqh2kp919/Le3yPn/Lg9jzruSaYGXBCENJe+31yyLCzFzRgvspPdmBR dpJZccLjdIY7kwdQasKOGQzAkG/R/e+UZQ== X-Google-Smtp-Source: AMrXdXv11+U4khVlbVhnyAle8LKS326iggeQ+0J6Xc8inj2xvf+PUs9oeC4N56TT53zj3t0z4nLZbw== X-Received: by 2002:a05:6a00:1496:b0:586:35dd:91c3 with SMTP id v22-20020a056a00149600b0058635dd91c3mr30785951pfu.29.1674423285609; Sun, 22 Jan 2023 13:34:45 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id x65-20020a623144000000b0058ba6f416besm17061404pfx.183.2023.01.22.13.34.44 for <60845@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Jan 2023 13:34:45 -0800 (PST) Message-ID: Date: Sun, 22 Jan 2023 13:34:44 -0800 MIME-Version: 1.0 Subject: Re: bug#60845: 30.0.50; [PATCH] Add tests for Eshell interactive completion (and fix a bug in it) Content-Language: en-US From: Jim Porter To: 60845@debbugs.gnu.org References: <2b75d4d4-0533-2182-6da8-413391577bf5@gmail.com> In-Reply-To: <2b75d4d4-0533-2182-6da8-413391577bf5@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60845 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) X-Debbugs-CC: gregory@heytings.org On 1/15/2023 5:50 PM, Jim Porter wrote: > This is a followup from bug#60464 and friends. Over there, we discussed > problems with Pcomplete when used from Eshell, namely that Eshell > sometimes gives Pcomplete non-string arguments. I mentioned that we > should probably have automated tests for the Eshell side so that we can > make further improvements to Pcomplete without causing regressions, so > here are some tests. After studying how Eshell interfaces with Pcomplete, I think I've convinced myself that Eshell should be the one responsible for converting all its arguments to strings. It already does this for some cases (nil becomes "", numbers are stringified, and ".../" forms become "../../"), so the fact that it doesn't do this universally is probably a bug. The third patch in this series fixes this for the Eshell side, so we could probably remove the workaround in pcomplete.el for Emacs 30. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 22 16:35:43 2023 Received: (at 60845) by debbugs.gnu.org; 22 Jan 2023 21:35:43 +0000 Received: from localhost ([127.0.0.1]:52722 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJi06-0007jJ-MI for submit@debbugs.gnu.org; Sun, 22 Jan 2023 16:35:43 -0500 Received: from mail-pj1-f52.google.com ([209.85.216.52]:43618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJi04-0007j5-3P for 60845@debbugs.gnu.org; Sun, 22 Jan 2023 16:35:41 -0500 Received: by mail-pj1-f52.google.com with SMTP id m3-20020a17090a414300b00229ef93c5b0so8751275pjg.2 for <60845@debbugs.gnu.org>; Sun, 22 Jan 2023 13:35:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:references:to:from:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=OWxSZ41S/9OIbYrUoUklB3i4UR49lV5FlkZ0UK1jgK4=; b=kqbRSbB+OOsJN6rOvdLpSOumWMiprM2yAR8iHEVHPrx8rKYcrj2gMfnHXdyYtRsvE3 TYghSI7PGuKpq0U6zHylkm5EmiLkOSH9T69AwZMvpU2PMetyubpjyr4PyJDLNa1HLfX8 YJykLPHCFBu7Jd9xfjtFIGKazwTJXFlvYU0GfEtK5ulss20twM5rZ9lPXbYkYh73+h1H LfsuIGEb+YTzQ5wHSEcIFA+3VjBq6DJ4ueeoiCxIMuth3GpAI+WUlzuCtrMSxyuWmMZO ZbOvUhw/uZeY8sxPjTQHXmgnGM6vZuo8Q2JpkhGruHN13buq0upBebJNV3qgu38TyWu8 4vqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:references:to:from:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=OWxSZ41S/9OIbYrUoUklB3i4UR49lV5FlkZ0UK1jgK4=; b=VDDOX1ir3HubTuylKSJOV50mXmHpTt1v0aetUHzKZFeHdKhEnNjPRnSwpioCNzfJT/ Jn48eD0CC/tCK8U60DVJY5qKIyzYpe4kC1tYDxDb25jWxUpBvQSZte1kMSonJ0wYHM0l rwYYCvcgqsr30A9Y5h4RtTl2xS/xeUX53DdfN3CIsKN1UJAu1TU/mnPRH8yzTtHP1cwv MFW2tWliS674jwU88asAyF8EyPrW4pqMGKChC4ZYYLP9hTmbz7pCNA5bNjn4pEGz4d3h 9wy0bOcsW2JP4XNxRNmLWXRWxc2RnbzSVmdicpMfGOhG67mtEKc90ut5qSRofdVUVa7C SWmw== X-Gm-Message-State: AFqh2kpD/PxaN5soRgmU5QPOUHO5D8FJxYctVO5VO1nIcLdASiuDOkMe VuvvfqeWDr5ij7TLU3ZQgQmr4Sh8ZcfjQA== X-Google-Smtp-Source: AMrXdXs5bWi11ibDXcfvrTZCI7AS4ngAiuUOdduyi5io/PL6PjPaS8IZxzFDwGsGw72bJwKJvjsB2g== X-Received: by 2002:a17:90a:460f:b0:227:23c3:5db1 with SMTP id w15-20020a17090a460f00b0022723c35db1mr23078874pjg.47.1674423334251; Sun, 22 Jan 2023 13:35:34 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id cp14-20020a17090afb8e00b0022bbad75af6sm13093673pjb.1.2023.01.22.13.35.33 for <60845@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Jan 2023 13:35:33 -0800 (PST) Content-Type: multipart/mixed; boundary="------------RTxSlcNOnrZgEDb0bwt2x00B" Message-ID: <40d31b3d-d429-5a48-02bc-a3c1e4a1d903@gmail.com> Date: Sun, 22 Jan 2023 13:35:33 -0800 MIME-Version: 1.0 Subject: Re: bug#60845: 30.0.50; [PATCH] Add tests for Eshell interactive completion (and fix a bug in it) Content-Language: en-US From: Jim Porter To: 60845@debbugs.gnu.org References: <2b75d4d4-0533-2182-6da8-413391577bf5@gmail.com> In-Reply-To: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60845 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------RTxSlcNOnrZgEDb0bwt2x00B Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/22/2023 1:34 PM, Jim Porter wrote: > The third patch in this series fixes this for the Eshell side, so we > could probably remove the workaround in pcomplete.el for Emacs 30. ... It would help if I actually attached the patches. --------------RTxSlcNOnrZgEDb0bwt2x00B Content-Type: text/plain; charset=UTF-8; name="0001-Add-regression-tests-for-Eshell-completions.patch" Content-Disposition: attachment; filename="0001-Add-regression-tests-for-Eshell-completions.patch" Content-Transfer-Encoding: base64 RnJvbSBhYWVmZTRhZWQ2Mjc2YjJhZjIxOWI1NGE5ZDE2MTA2YTk4NmVjOWViIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgMTUgSmFuIDIwMjMgMTY6NDQ6MTcgLTA4MDAKU3ViamVjdDogW1BB VENIIDEvM10gQWRkIHJlZ3Jlc3Npb24gdGVzdHMgZm9yIEVzaGVsbCBjb21wbGV0aW9ucwoK KiBsaXNwL2VzaGVsbC9lc2gtY21kLmVsIChlc2hlbGwtY29tcGxldGUtbGlzcC1zeW1ib2xz KTogRml4CmRvY3N0cmluZy4KCiogdGVzdC9saXNwL2VzaGVsbC9lbS1jbXBsLXRlc3RzLmVs OiBOZXcgZmlsZS4KLS0tCiBsaXNwL2VzaGVsbC9lc2gtY21kLmVsICAgICAgICAgICAgfCAg IDIgKy0KIHRlc3QvbGlzcC9lc2hlbGwvZW0tY21wbC10ZXN0cy5lbCB8IDE3MCArKysrKysr KysrKysrKysrKysrKysrKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMTcxIGluc2VydGlv bnMoKyksIDEgZGVsZXRpb24oLSkKIGNyZWF0ZSBtb2RlIDEwMDY0NCB0ZXN0L2xpc3AvZXNo ZWxsL2VtLWNtcGwtdGVzdHMuZWwKCmRpZmYgLS1naXQgYS9saXNwL2VzaGVsbC9lc2gtY21k LmVsIGIvbGlzcC9lc2hlbGwvZXNoLWNtZC5lbAppbmRleCA5OWMzZDdmNjI3ZC4uYjVmMWQ2 MGZmMTggMTAwNjQ0Ci0tLSBhL2xpc3AvZXNoZWxsL2VzaC1jbWQuZWwKKysrIGIvbGlzcC9l c2hlbGwvZXNoLWNtZC5lbApAQCAtMzQzLDcgKzM0Myw3IEBAIGVzaGVsbC1jbWQtaW5pdGlh bGl6ZQogCSAgICAgICMnZXNoZWxsLWNvbXBsZXRlLWxpc3Atc3ltYm9scyBuaWwgdCkpKQog CiAoZGVmdW4gZXNoZWxsLWNvbXBsZXRlLWxpc3Atc3ltYm9scyAoKQotICAiSWYgdGhlcmUg aXMgYSB1c2VyIHJlZmVyZW5jZSwgY29tcGxldGUgaXQuIgorICAiSWYgdGhlcmUgaXMgYSBM aXNwIHN5bWJvbCwgY29tcGxldGUgaXQuIgogICAobGV0ICgoYXJnIChwY29tcGxldGUtYWN0 dWFsLWFyZykpKQogICAgICh3aGVuIChzdHJpbmctbWF0Y2ggKGNvbmNhdCAiXFxgIiBlc2hl bGwtbGlzcC1yZWdleHApIGFyZykKICAgICAgIChzZXRxIHBjb21wbGV0ZS1zdHViIChzdWJz dHJpbmcgYXJnIChtYXRjaC1lbmQgMCkpCmRpZmYgLS1naXQgYS90ZXN0L2xpc3AvZXNoZWxs L2VtLWNtcGwtdGVzdHMuZWwgYi90ZXN0L2xpc3AvZXNoZWxsL2VtLWNtcGwtdGVzdHMuZWwK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAuLjMyYjA3ODFkZDc1Ci0t LSAvZGV2L251bGwKKysrIGIvdGVzdC9saXNwL2VzaGVsbC9lbS1jbXBsLXRlc3RzLmVsCkBA IC0wLDAgKzEsMTcwIEBACis7OzsgZW0tY21wbC10ZXN0cy5lbCAtLS0gZW0tY21wbCB0ZXN0 IHN1aXRlICAtKi0gbGV4aWNhbC1iaW5kaW5nOnQgLSotCisKKzs7IENvcHlyaWdodCAoQykg MjAyMyBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4KKworOzsgVGhpcyBmaWxlIGlz IHBhcnQgb2YgR05VIEVtYWNzLgorCis7OyBHTlUgRW1hY3MgaXMgZnJlZSBzb2Z0d2FyZTog eW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yIG1vZGlmeQorOzsgaXQgdW5kZXIgdGhl IHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBhcyBwdWJsaXNoZWQg YnkKKzs7IHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIGVpdGhlciB2ZXJzaW9uIDMg b2YgdGhlIExpY2Vuc2UsIG9yCis7OyAoYXQgeW91ciBvcHRpb24pIGFueSBsYXRlciB2ZXJz aW9uLgorCis7OyBHTlUgRW1hY3MgaXMgZGlzdHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBp dCB3aWxsIGJlIHVzZWZ1bCwKKzs7IGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91 dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mCis7OyBNRVJDSEFOVEFCSUxJVFkgb3Ig RklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlCis7OyBHTlUgR2Vu ZXJhbCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgorCis7OyBZb3Ugc2hvdWxk IGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5z ZQorOzsgYWxvbmcgd2l0aCBHTlUgRW1hY3MuICBJZiBub3QsIHNlZSA8aHR0cHM6Ly93d3cu Z251Lm9yZy9saWNlbnNlcy8+LgorCis7OzsgQ29tbWVudGFyeToKKworOzsgVGVzdHMgZm9y IEVzaGVsbCdzIGludGVyYWN0aXZlIGNvbXBsZXRpb24uCisKKzs7OyBDb2RlOgorCisocmVx dWlyZSAnZXJ0KQorKHJlcXVpcmUgJ2VzaGVsbCkKKyhyZXF1aXJlICdlbS1jbXBsKQorKHJl cXVpcmUgJ2VtLWRpcnMpCisocmVxdWlyZSAnZW0taGlzdCkKKyhyZXF1aXJlICdlbS10cmFt cCkKKyhyZXF1aXJlICdlbS11bml4KQorCisocmVxdWlyZSAnZXNoZWxsLXRlc3RzLWhlbHBl cnMKKyAgICAgICAgIChleHBhbmQtZmlsZS1uYW1lICJlc2hlbGwtdGVzdHMtaGVscGVycyIK KyAgICAgICAgICAgICAgICAgICAgICAgICAgIChmaWxlLW5hbWUtZGlyZWN0b3J5IChvciBs b2FkLWZpbGUtbmFtZQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGRlZmF1bHQtZGlyZWN0b3J5KSkpKQorCisoZGVmdmFyIGVzaGVsbC10 ZXN0LXZhbHVlIG5pbCkKKworKGRlZnVuIGVzaGVsbC1pbnNlcnQtYW5kLWNvbXBsZXRlIChp bnB1dCkKKyAgIkluc2VydCBJTlBVVCBhbmQgaW52b2tlIGNvbXBsZXRpb24sIHJldHVybmlu ZyB0aGUgcmVzdWx0LiIKKyAgKGluc2VydCBpbnB1dCkKKyAgKGNvbXBsZXRpb24tYXQtcG9p bnQpCisgIChlc2hlbGwtZ2V0LW9sZC1pbnB1dCkpCisKKzs7OyBUZXN0czoKKworKGVydC1k ZWZ0ZXN0IGVtLWNtcGwtdGVzdC9wYXJzZS1hcmd1bWVudHMvcGlwZWxpbmUgKCkKKyAgIlRl c3QgdGhhdCBwYXJzaW5nIGFyZ3VtZW50cyBmb3IgY29tcGxldGlvbiBkaXNjYXJkcyBlYXJs aWVyIGNvbW1hbmRzLiIKKyAgKHdpdGgtdGVtcC1lc2hlbGwKKyAgIChsZXQgKChlc2hlbGwt dGVzdC12YWx1ZSAnKCJmb28iICJiYXIiKSkpCisgICAgIChpbnNlcnQgImVjaG8gaGkgfCBj YXQiKQorICAgICAoc2hvdWxkIChlcXVhbCAoY2FyIChlc2hlbGwtY29tcGxldGUtcGFyc2Ut YXJndW1lbnRzKSkKKyAgICAgICAgICAgICAgICAgICAgJygiY2F0IikpKSkpKQorCisoZXJ0 LWRlZnRlc3QgZW0tY21wbC10ZXN0L3BhcnNlLWFyZ3VtZW50cy9tdWx0aXBsZS1kb3RzICgp CisgICJUZXN0IHBhcnNpbmcgYXJndW1lbnRzIHdpdGggbXVsdGlwbGUgZG90cyBsaWtlIFwi Li4uL1wiLiIKKyAgKHdpdGgtdGVtcC1lc2hlbGwKKyAgIChpbnNlcnQgImVjaG8gLi4uL2Zp bGUudHh0IikKKyAgIChzaG91bGQgKGVxdWFsIChjYXIgKGVzaGVsbC1jb21wbGV0ZS1wYXJz ZS1hcmd1bWVudHMpKQorICAgICAgICAgICAgICAgICAgJygiZWNobyIgIi4uLy4uL2ZpbGUu dHh0IikpKSkpCisKKyhlcnQtZGVmdGVzdCBlbS1jbXBsLXRlc3QvcGFyc2UtYXJndW1lbnRz L3ZhcmlhYmxlL251bWVyaWMgKCkKKyAgIlRlc3QgcGFyc2luZyBhcmd1bWVudHMgd2l0aCBh IG51bWVyaWMgdmFyaWFibGUgaW50ZXJwb2xhdGlvbi4iCisgICh3aXRoLXRlbXAtZXNoZWxs CisgICAobGV0ICgoZXNoZWxsLXRlc3QtdmFsdWUgNDIpKQorICAgICAoaW5zZXJ0ICJlY2hv ICRlc2hlbGwtdGVzdC12YWx1ZSIpCisgICAgIChzaG91bGQgKGVxdWFsIChjYXIgKGVzaGVs bC1jb21wbGV0ZS1wYXJzZS1hcmd1bWVudHMpKQorICAgICAgICAgICAgICAgICAgICAnKCJl Y2hvIiAiNDIiKSkpKSkpCisKKyhlcnQtZGVmdGVzdCBlbS1jbXBsLXRlc3QvcGFyc2UtYXJn dW1lbnRzL3ZhcmlhYmxlL25pbCAoKQorICAiVGVzdCBwYXJzaW5nIGFyZ3VtZW50cyB3aXRo IGEgbmlsIHZhcmlhYmxlIGludGVycG9sYXRpb24uIgorICAod2l0aC10ZW1wLWVzaGVsbAor ICAgKGxldCAoKGVzaGVsbC10ZXN0LXZhbHVlIG5pbCkpCisgICAgIChpbnNlcnQgImVjaG8g JGVzaGVsbC10ZXN0LXZhbHVlIikKKyAgICAgKHNob3VsZCAoZXF1YWwgKGNhciAoZXNoZWxs LWNvbXBsZXRlLXBhcnNlLWFyZ3VtZW50cykpCisgICAgICAgICAgICAgICAgICAgICcoImVj aG8iICIiKSkpKSkpCisKKyhlcnQtZGVmdGVzdCBlbS1jbXBsLXRlc3QvcGFyc2UtYXJndW1l bnRzL3ZhcmlhYmxlL2xpc3QgKCkKKyAgIlRlc3QgcGFyc2luZyBhcmd1bWVudHMgd2l0aCBh IGxpc3QgdmFyaWFibGUgaW50ZXJwb2xhdGlvbi4iCisgICh3aXRoLXRlbXAtZXNoZWxsCisg ICAobGV0ICgoZXNoZWxsLXRlc3QtdmFsdWUgJygiZm9vIiAiYmFyIikpKQorICAgICAoaW5z ZXJ0ICJlY2hvICRlc2hlbGwtdGVzdC12YWx1ZSIpCisgICAgIChzaG91bGQgKGVxdWFsIChj YXIgKGVzaGVsbC1jb21wbGV0ZS1wYXJzZS1hcmd1bWVudHMpKQorICAgICAgICAgICAgICAg ICAgICAnKCJlY2hvIiAoImZvbyIgImJhciIpKSkpKSkpCisKKyhlcnQtZGVmdGVzdCBlbS1j bXBsLXRlc3QvZmlsZS1jb21wbGV0aW9uL3VuaXF1ZSAoKQorICAiVGVzdCBjb21wbGV0aW9u IG9mIGZpbGUgbmFtZXMgd2hlbiB0aGVyZSdzIGEgdW5pcXVlIHJlc3VsdC4iCisgICh3aXRo LXRlbXAtZXNoZWxsCisgICAoZXJ0LXdpdGgtdGVtcC1kaXJlY3RvcnkgZGVmYXVsdC1kaXJl Y3RvcnkKKyAgICAgKHdyaXRlLXJlZ2lvbiBuaWwgbmlsIChleHBhbmQtZmlsZS1uYW1lICJm aWxlLnR4dCIpKQorICAgICAoc2hvdWxkIChlcXVhbCAoZXNoZWxsLWluc2VydC1hbmQtY29t cGxldGUgImVjaG8gZmkiKQorICAgICAgICAgICAgICAgICAgICAiZWNobyBmaWxlLnR4dCAi KSkpKSkKKworKGVydC1kZWZ0ZXN0IGVtLWNtcGwtdGVzdC9maWxlLWNvbXBsZXRpb24vbm9u LXVuaXF1ZSAoKQorICAiVGVzdCBjb21wbGV0aW9uIG9mIGZpbGUgbmFtZXMgd2hlbiB0aGVy ZSBhcmUgbXVsdGlwbGUgcmVzdWx0cy4iCisgICh3aXRoLXRlbXAtZXNoZWxsCisgICAoZXJ0 LXdpdGgtdGVtcC1kaXJlY3RvcnkgZGVmYXVsdC1kaXJlY3RvcnkKKyAgICAgKHdyaXRlLXJl Z2lvbiBuaWwgbmlsIChleHBhbmQtZmlsZS1uYW1lICJmaWxlLnR4dCIpKQorICAgICAod3Jp dGUtcmVnaW9uIG5pbCBuaWwgKGV4cGFuZC1maWxlLW5hbWUgImZpbGUuZWwiKSkKKyAgICAg KHNob3VsZCAoZXF1YWwgKGVzaGVsbC1pbnNlcnQtYW5kLWNvbXBsZXRlICJlY2hvIGZpIikK KyAgICAgICAgICAgICAgICAgICAgImVjaG8gZmlsZS4iKSkKKyAgICAgOzsgTm93IHRyeSBj b21wbGV0aW5nIGFnYWluLgorICAgICAobGV0ICgobWluaWJ1ZmZlci1tZXNzYWdlLXRpbWVv dXQgMCkKKyAgICAgICAgICAgKGluaGliaXQtbWVzc2FnZSB0KSkKKyAgICAgICAoY29tcGxl dGlvbi1hdC1wb2ludCkpCisgICAgIDs7IEZJWE1FOiBXZSBjYW4ndCB1c2UgYGN1cnJlbnQt bWVzc2FnZScgaGVyZS4KKyAgICAgKHdpdGgtY3VycmVudC1idWZmZXIgKG1lc3NhZ2VzLWJ1 ZmZlcikKKyAgICAgICAoc2F2ZS1leGN1cnNpb24KKyAgICAgICAgIChnb3RvLWNoYXIgKHBv aW50LW1heCkpCisgICAgICAgICAoZm9yd2FyZC1saW5lIC0xKQorICAgICAgICAgKHNob3Vs ZCAobG9va2luZy1hdCAiQ29tcGxldGUsIGJ1dCBub3QgdW5pcXVlIikpKSkpKSkKKworKGVy dC1kZWZ0ZXN0IGVtLWNtcGwtdGVzdC9maWxlLWNvbXBsZXRpb24vYWZ0ZXItbGlzdCAoKQor ICAiVGVzdCBjb21wbGV0aW9uIG9mIGZpbGUgbmFtZXMgYWZ0ZXIgcHJldmlvdXMgbGlzdCBh cmd1bWVudHMuCitTZWUgYnVnIzU5OTU2LiIKKyAgKHdpdGgtdGVtcC1lc2hlbGwKKyAgIChl cnQtd2l0aC10ZW1wLWRpcmVjdG9yeSBkZWZhdWx0LWRpcmVjdG9yeQorICAgICAod3JpdGUt cmVnaW9uIG5pbCBuaWwgKGV4cGFuZC1maWxlLW5hbWUgImZpbGUudHh0IikpCisgICAgIChz aG91bGQgKGVxdWFsIChlc2hlbGwtaW5zZXJ0LWFuZC1jb21wbGV0ZSAiZWNobyAobGlzdCAx IDIpIGZpIikKKyAgICAgICAgICAgICAgICAgICAgImVjaG8gKGxpc3QgMSAyKSBmaWxlLnR4 dCAiKSkpKSkKKworKGVydC1kZWZ0ZXN0IGVtLWNtcGwtdGVzdC9saXNwLXN5bWJvbC1jb21w bGV0aW9uICgpCisgICJUZXN0IGNvbXBsZXRpb24gb2YgTGlzcCBmb3JtcyBsaWtlIFwiIydz eW1ib2xcIiBhbmQgXCJgc3ltYm9sXCIuCitTZWUgPGxpc3AvZXNoZWxsL2VzaC1jbWQuZWw+ LiIKKyAgKHdpdGgtdGVtcC1lc2hlbGwKKyAgIChzaG91bGQgKGVxdWFsIChlc2hlbGwtaW5z ZXJ0LWFuZC1jb21wbGV0ZSAiZWNobyAjJ3N5c3RlbS1uYW0iKQorICAgICAgICAgICAgICAg ICAgImVjaG8gIydzeXN0ZW0tbmFtZSAiKSkpCisgICh3aXRoLXRlbXAtZXNoZWxsCisgICAo c2hvdWxkIChlcXVhbCAoZXNoZWxsLWluc2VydC1hbmQtY29tcGxldGUgImVjaG8gYHN5c3Rl bS1uYW0iKQorICAgICAgICAgICAgICAgICAgImVjaG8gYHN5c3RlbS1uYW1lICIpKSkpCisK KyhlcnQtZGVmdGVzdCBlbS1jbXBsLXRlc3QvbGlzcC1mdW5jdGlvbi1jb21wbGV0aW9uICgp CisgICJUZXN0IGNvbXBsZXRpb24gb2YgTGlzcCBmb3JtcyBsaWtlIFwiKGZ1bmMpXCIuCitT ZWUgPGxpc3AvZXNoZWxsL2VzaC1jbWQuZWw+LiIKKyAgKHdpdGgtdGVtcC1lc2hlbGwKKyAg IChzaG91bGQgKGVxdWFsIChlc2hlbGwtaW5zZXJ0LWFuZC1jb21wbGV0ZSAiZWNobyAoZXNo ZWxsL2VjaCIpCisgICAgICAgICAgICAgICAgICAiZWNobyAoZXNoZWxsL2VjaG8iKSkpKQor CisoZXJ0LWRlZnRlc3QgZW0tY21wbC10ZXN0L3ZhcmlhYmxlLXJlZi1jb21wbGV0aW9uICgp CisgICJUZXN0IGNvbXBsZXRpb24gb2YgdmFyaWFibGUgcmVmZXJlbmNlcyBsaWtlIFwiJHZh clwiLgorU2VlIDxsaXNwL2VzaGVsbC9lc2gtdmFyLmVsPi4iCisgICh3aXRoLXRlbXAtZXNo ZWxsCisgICAoc2hvdWxkIChlcXVhbCAoZXNoZWxsLWluc2VydC1hbmQtY29tcGxldGUgImVj aG8gJHN5c3RlbS1uYW0iKQorICAgICAgICAgICAgICAgICAgImVjaG8gJHN5c3RlbS1uYW1l ICIpKSkpCisKKyhlcnQtZGVmdGVzdCBlbS1jbXBsLXRlc3QvdmFyaWFibGUtYXNzaWduLWNv bXBsZXRpb24gKCkKKyAgIlRlc3QgY29tcGxldGlvbiBvZiB2YXJpYWJsZSBhc3NpZ25tZW50 cyBsaWtlIFwidmFyPXZhbHVlXCIuCitTZWUgPGxpc3AvZXNoZWxsL2VzaC12YXIuZWw+LiIK KyAgKHdpdGgtdGVtcC1lc2hlbGwKKyAgIChlcnQtd2l0aC10ZW1wLWRpcmVjdG9yeSBkZWZh dWx0LWRpcmVjdG9yeQorICAgICAod3JpdGUtcmVnaW9uIG5pbCBuaWwgKGV4cGFuZC1maWxl LW5hbWUgImZpbGUudHh0IikpCisgICAgIChzaG91bGQgKGVxdWFsIChlc2hlbGwtaW5zZXJ0 LWFuZC1jb21wbGV0ZSAiVkFSPWYiKQorICAgICAgICAgICAgICAgICAgICAiVkFSPWZpbGUu dHh0ICIpKSkpKQorCisoZXJ0LWRlZnRlc3QgZW0tY21wbC10ZXN0L3VzZXItcmVmLWNvbXBs ZXRpb24gKCkKKyAgIlRlc3QgY29tcGxldGVpb24gb2YgdXNlciByZWZlcmVuY2VzIGxpa2Ug XCJ+dXNlclwiLgorU2VlIDxsaXNwL2VzaGVsbC9lbS1kaXJzLmVsPi4iCisgICh1bndpbmQt cHJvdGVjdAorICAgICAgKHdpdGgtdGVtcC1lc2hlbGwKKyAgICAgICAoY2wtbGV0ZiAoKChz eW1ib2wtZnVuY3Rpb24gJ2VzaGVsbC1yZWFkLXVzZXItbmFtZXMpCisgICAgICAgICAgICAg ICAgICAobGFtYmRhICgpIChzZXRxIGVzaGVsbC11c2VyLW5hbWVzICcoKDEyMzQgLiAidXNl ciIpKSkpKSkKKyAgICAgICAgIDs7IEZJWE1FOiBTaG91bGQgdGhpcyByZWFsbHkgYWRkIGEg c3BhY2UgYXQgdGhlIGVuZD8KKyAgICAgICAgIChzaG91bGQgKGVxdWFsIChlc2hlbGwtaW5z ZXJ0LWFuZC1jb21wbGV0ZSAiZWNobyB+dXMiKQorICAgICAgICAgICAgICAgICAgICAgICAg ImVjaG8gfnVzZXIvICIpKSkpCisgICAgOzsgQ2xlYXIgdGhlIGNhY2hlZCB1c2VyIG5hbWVz IHdlIHNldCBhYm92ZS4KKyAgICAoc2V0cSBlc2hlbGwtdXNlci1uYW1lcyBuaWwpKSkKKwor Ozs7IGVtLWNtcGwtdGVzdHMuZWwgZW5kcyBoZXJlCi0tIAoyLjI1LjEKCg== --------------RTxSlcNOnrZgEDb0bwt2x00B Content-Type: text/plain; charset=UTF-8; name="0002-Properly-parse-Eshell-variable-splices-for-interacti.patch" Content-Disposition: attachment; filename*0="0002-Properly-parse-Eshell-variable-splices-for-interacti.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAxZTJiYjBkZWMwNmViMDIxODQ5NmY4Nzc5NWFiMmI3NTA3NDkyY2ZjIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgMTUgSmFuIDIwMjMgMTY6NDQ6MjMgLTA4MDAKU3ViamVjdDogW1BB VENIIDIvM10gUHJvcGVybHkgcGFyc2UgRXNoZWxsIHZhcmlhYmxlIHNwbGljZXMgZm9yIGlu dGVyYWN0aXZlCiBjb21wbGV0aW9uCgpQcmV2aW91c2x5LCB0aGUgY29kZSBzaW1wbHkgaWdu b3JlZCB0aGUgc3BsaWNlIG9wZXJhdG9yLCB3aGljaCB1c3VhbGx5CndvcmtlZCwgYnV0IGlz bid0IGFjdHVhbGx5IGNvcnJlY3QuCgoqIGxpc3AvZXNoZWxsL2VtLWNtcGwuZWwgKGVzaGVs bC1jb21wbGV0ZS1ldmFsLWFyZ3VtZW50LWZvcm0pOiBOZXcKZnVuY3Rpb24uCihlc2hlbGwt Y29tcGxldGUtcGFyc2UtYXJndW1lbnRzKTogUHJvcGVybHkgcGFyc2UgdmFyaWFibGUgc3Bs aWNlcy4KCiogdGVzdC9saXNwL2VzaGVsbC9lbS1jbXBsLXRlc3RzLmVsCihlbS1jbXBsLXRl c3QvcGFyc2UtYXJndW1lbnRzL3ZhcmlhYmxlL3NwbGljZSk6IE5ldyB0ZXN0LgotLS0KIGxp c3AvZXNoZWxsL2VtLWNtcGwuZWwgICAgICAgICAgICB8IDU2ICsrKysrKysrKysrKysrKysr KysrLS0tLS0tLS0tLS0KIHRlc3QvbGlzcC9lc2hlbGwvZW0tY21wbC10ZXN0cy5lbCB8ICA4 ICsrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDQ0IGluc2VydGlvbnMoKyksIDIwIGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvZXNoZWxsL2VtLWNtcGwuZWwgYi9saXNwL2VzaGVs bC9lbS1jbXBsLmVsCmluZGV4IDQyMDZhZDA0OGZhLi5hNjdmZTUzZWQ0NiAxMDA2NDQKLS0t IGEvbGlzcC9lc2hlbGwvZW0tY21wbC5lbAorKysgYi9saXNwL2VzaGVsbC9lbS1jbXBsLmVs CkBAIC0zMDYsNiArMzA2LDEyIEBAIGVzaGVsbC0tcGNvbXBsZXRlLWluc2VydC10YWIKICAg ICAoaW5zZXJ0LWFuZC1pbmhlcml0ICJcdCIpCiAgICAgKHRocm93ICdwY29tcGxldGVkIHQp KSkKIAorKGRlZnVuIGVzaGVsbC1jb21wbGV0ZS1ldmFsLWFyZ3VtZW50LWZvcm0gKGFyZykK KyAgIkV2YWx1YXRlIGEgc2luZ2xlIEVzaGVsbCBhcmd1bWVudCBmb3JtIEFSRyBmb3IgdGhl IHB1cnBvc2VzIG9mIGNvbXBsZXRpb24uIgorICAobGV0ICgocmVzdWx0IChlc2hlbGwtZG8t ZXZhbCBgKGVzaGVsbC1jb21tYW5kcyAsYXJnKSB0KSkpCisgICAgKGNsLWFzc2VydCAoZXEg KGNhciByZXN1bHQpICdxdW90ZSkpCisgICAgKGNhZHIgcmVzdWx0KSkpCisKIChkZWZ1biBl c2hlbGwtY29tcGxldGUtcGFyc2UtYXJndW1lbnRzICgpCiAgICJQYXJzZSB0aGUgY29tbWFu ZCBsaW5lIGFyZ3VtZW50cyBmb3IgYHBjb21wbGV0ZS1hcmd1bWVudCcuIgogICAod2hlbiAo YW5kIGVzaGVsbC1uby1jb21wbGV0aW9uLWR1cmluZy1qb2JzCkBAIC0zNDQsMTEgKzM1MCw2 IEBAIGVzaGVsbC1jb21wbGV0ZS1wYXJzZS1hcmd1bWVudHMKICAgICAoY2wtYXNzZXJ0ICg9 IChsZW5ndGggYXJncykgKGxlbmd0aCBwb3NucykpKQogICAgIChsZXQgKChhIGFyZ3MpIChp IDApIG5ldy1zdGFydCkKICAgICAgICh3aGlsZSBhCi0gICAgICAgIDs7IFJlbW92ZSBhbnkg dG9wLWxldmVsIGBlc2hlbGwtc3BsaWNlLWFyZ3MnIHNpZ2lscy4gIFRoZXNlCi0gICAgICAg IDs7IGFyZSBtZWFudCB0byBiZSByZXdyaXR0ZW4gYW5kIGNhbid0IGFjdHVhbGx5IGJlIGNh bGxlZC4KLSAgICAgICAgKHdoZW4gKGFuZCAoY29uc3AgKGNhciBhKSkKLSAgICAgICAgICAg ICAgICAgICAoZXEgKGNhYXIgYSkgJ2VzaGVsbC1zcGxpY2UtYXJncykpCi0gICAgICAgICAg KHNldGNhciBhIChjYWRhciBhKSkpCiAgICAgICAgIDs7IElmIHRoZXJlJ3MgYW4gdW5yZXBs YWNlZCBgZXNoZWxsLW9wZXJhdG9yJyBzaWdpbCwgY29uc2lkZXIKICAgICAgICAgOzsgdGhl IHRva2VuIGFmdGVyIGl0IHRoZSBuZXcgc3RhcnQgb2Ygb3VyIGFyZ3VtZW50cy4KICAgICAg ICAgKHdoZW4gKGFuZCAoY29uc3AgKGNhciBhKSkKQEAgLTM2NCwyMyArMzY1LDM4IEBAIGVz aGVsbC1jb21wbGV0ZS1wYXJzZS1hcmd1bWVudHMKIAkgICAgICAgKG5vdCAoZXEgKGNoYXIt YmVmb3JlICgxLSBlbmQpKSA/XFwpKSkKICAgICAgIChuY29uYyBhcmdzIChsaXN0ICIiKSkK ICAgICAgIChuY29uYyBwb3NucyAobGlzdCAocG9pbnQpKSkpCisgICAgOzsgRXZhbHVhdGUg YW5kIGV4cGFuZCBFc2hlbGwgZm9ybXMuCisgICAgKGxldCAoZXZhbGVkLWFyZ3MgZXZhbGVk LXBvc25zKQorICAgICAgKGNsLW1hcGMKKyAgICAgICAobGFtYmRhIChhcmcgcG9zbikKKyAg ICAgICAgIChwY2FzZSBhcmcKKyAgICAgICAgICAgKGAoZXNoZWxsLXNwbGljZS1hcmdzICx2 YWwpCisgICAgICAgICAgICAoZG9saXN0IChzdWJhcmcgKGVzaGVsbC1jb21wbGV0ZS1ldmFs LWFyZ3VtZW50LWZvcm0gdmFsKSkKKyAgICAgICAgICAgICAgKHB1c2ggc3ViYXJnIGV2YWxl ZC1hcmdzKQorICAgICAgICAgICAgICAocHVzaCBwb3NuIGV2YWxlZC1wb3NucykpKQorICAg ICAgICAgICAoKHByZWQgbGlzdHApCisgICAgICAgICAgICAocHVzaCAoZXNoZWxsLWNvbXBs ZXRlLWV2YWwtYXJndW1lbnQtZm9ybSBhcmcpIGV2YWxlZC1hcmdzKQorICAgICAgICAgICAg KHB1c2ggcG9zbiBldmFsZWQtcG9zbnMpKQorICAgICAgICAgICAoXworICAgICAgICAgICAg KHB1c2ggYXJnIGV2YWxlZC1hcmdzKQorICAgICAgICAgICAgKHB1c2ggcG9zbiBldmFsZWQt cG9zbnMpKSkpCisgICAgICAgYXJncyBwb3NucykKKyAgICAgIChzZXRxIGFyZ3MgKG5yZXZl cnNlIGV2YWxlZC1hcmdzKQorICAgICAgICAgICAgcG9zbnMgKG5yZXZlcnNlIGV2YWxlZC1w b3NucykpKQorICAgIDs7IENvbnZlcnQgYXJndW1lbnRzIHRvIGZvcm1zIHRoYXQgUGNvbXBs ZXRlIGNhbiB1bmRlcnN0YW5kLgogICAgIChjb25zIChtYXBjYXIKICAgICAgICAgICAgKGxh bWJkYSAoYXJnKQotICAgICAgICAgICAgIChsZXQgKCh2YWwKLSAgICAgICAgICAgICAgICAg ICAgKGlmIChsaXN0cCBhcmcpCi0gICAgICAgICAgICAgICAgICAgICAgICAobGV0ICgocmVz dWx0Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGVzaGVsbC1kby1ldmFsCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChsaXN0ICdlc2hlbGwtY29tbWFuZHMg YXJnKSB0KSkpCi0gICAgICAgICAgICAgICAgICAgICAgICAgIChjbC1hc3NlcnQgKGVxIChj YXIgcmVzdWx0KSAncXVvdGUpKQotICAgICAgICAgICAgICAgICAgICAgICAgICAoY2FkciBy ZXN1bHQpKQotICAgICAgICAgICAgICAgICAgICAgIGFyZykpKQotICAgICAgICAgICAgICAg KGNvbmQgKChudW1iZXJwIHZhbCkKLSAgICAgICAgICAgICAgICAgICAgICAoc2V0cSB2YWwg KG51bWJlci10by1zdHJpbmcgdmFsKSkpCi0gICAgICAgICAgICAgICAgICAgICA7OyBleHBh bmQgLi4uLyBldGMgdGhhdCBvbmx5IGVzaGVsbCB1bmRlcnN0YW5kcyB0bwotICAgICAgICAg ICAgICAgICAgICAgOzsgc3RhbmRhcmQgLi4vLi4vCi0gICAgICAgICAgICAgICAgICAgICAo KGFuZCAoc3RyaW5ncCB2YWwpKSAoc3RyaW5nLW1hdGNoICJcXC5cXC5cXC4rLyIgdmFsKQot ICAgICAgICAgICAgICAgICAgICAgIChzZXRxIHZhbCAoZXNoZWxsLWV4cGFuZC1tdWx0aXBs ZS1kb3RzIHZhbCkpKSkKLSAgICAgICAgICAgICAgIChvciB2YWwgIiIpKSkKKyAgICAgICAg ICAgICAoY29uZAorICAgICAgICAgICAgICAoKG51bWJlcnAgYXJnKQorICAgICAgICAgICAg ICAgKG51bWJlci10by1zdHJpbmcgYXJnKSkKKyAgICAgICAgICAgICAgOzsgRXhwYW5kICIu Li4vIiBldGMgdGhhdCBvbmx5IEVzaGVsbCB1bmRlcnN0YW5kcyB0byB0aGUKKyAgICAgICAg ICAgICAgOzsgc3RhbmRhcmQgIi4uLy4uLyIuCisgICAgICAgICAgICAgICgoYW5kIChzdHJp bmdwIGFyZykgKHN0cmluZy1tYXRjaCAiXFwuXFwuXFwuKy8iIGFyZykpCisgICAgICAgICAg ICAgICAoZXNoZWxsLWV4cGFuZC1tdWx0aXBsZS1kb3RzIGFyZykpCisgICAgICAgICAgICAg ICgobnVsbCBhcmcpCisgICAgICAgICAgICAgICAiIikKKyAgICAgICAgICAgICAgKHQKKyAg ICAgICAgICAgICAgIGFyZykpKQogCSAgIGFyZ3MpCiAJICBwb3NucykpKQogCmRpZmYgLS1n aXQgYS90ZXN0L2xpc3AvZXNoZWxsL2VtLWNtcGwtdGVzdHMuZWwgYi90ZXN0L2xpc3AvZXNo ZWxsL2VtLWNtcGwtdGVzdHMuZWwKaW5kZXggMzJiMDc4MWRkNzUuLjNmOGY4OTBmNmU1IDEw MDY0NAotLS0gYS90ZXN0L2xpc3AvZXNoZWxsL2VtLWNtcGwtdGVzdHMuZWwKKysrIGIvdGVz dC9saXNwL2VzaGVsbC9lbS1jbXBsLXRlc3RzLmVsCkBAIC04NSw2ICs4NSwxNCBAQCBlbS1j bXBsLXRlc3QvcGFyc2UtYXJndW1lbnRzL3ZhcmlhYmxlL2xpc3QKICAgICAgKHNob3VsZCAo ZXF1YWwgKGNhciAoZXNoZWxsLWNvbXBsZXRlLXBhcnNlLWFyZ3VtZW50cykpCiAgICAgICAg ICAgICAgICAgICAgICcoImVjaG8iICgiZm9vIiAiYmFyIikpKSkpKSkKIAorKGVydC1kZWZ0 ZXN0IGVtLWNtcGwtdGVzdC9wYXJzZS1hcmd1bWVudHMvdmFyaWFibGUvc3BsaWNlICgpCisg ICJUZXN0IHBhcnNpbmcgYXJndW1lbnRzIHdpdGggYSBzcGxpY2VkIHZhcmlhYmxlIGludGVy cG9sYXRpb24uIgorICAod2l0aC10ZW1wLWVzaGVsbAorICAgKGxldCAoKGVzaGVsbC10ZXN0 LXZhbHVlICcoImZvbyIgImJhciIpKSkKKyAgICAgKGluc2VydCAiZWNobyAkQGVzaGVsbC10 ZXN0LXZhbHVlIikKKyAgICAgKHNob3VsZCAoZXF1YWwgKGNhciAoZXNoZWxsLWNvbXBsZXRl LXBhcnNlLWFyZ3VtZW50cykpCisgICAgICAgICAgICAgICAgICAgICcoImVjaG8iICJmb28i ICJiYXIiKSkpKSkpCisKIChlcnQtZGVmdGVzdCBlbS1jbXBsLXRlc3QvZmlsZS1jb21wbGV0 aW9uL3VuaXF1ZSAoKQogICAiVGVzdCBjb21wbGV0aW9uIG9mIGZpbGUgbmFtZXMgd2hlbiB0 aGVyZSdzIGEgdW5pcXVlIHJlc3VsdC4iCiAgICh3aXRoLXRlbXAtZXNoZWxsCi0tIAoyLjI1 LjEKCg== --------------RTxSlcNOnrZgEDb0bwt2x00B Content-Type: text/plain; charset=UTF-8; name="0003-During-completion-convert-all-Eshell-arguments-to-st.patch" Content-Disposition: attachment; filename*0="0003-During-completion-convert-all-Eshell-arguments-to-st.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA4MWQ4NTc1NzQwYjEyYmZhYzI3YzdkYjFjODEzZmJmYTU1ODZkZDlkIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgMjIgSmFuIDIwMjMgMTM6MjA6NDYgLTA4MDAKU3ViamVjdDogW1BB VENIIDMvM10gRHVyaW5nIGNvbXBsZXRpb24sIGNvbnZlcnQgYWxsIEVzaGVsbCBhcmd1bWVu dHMgdG8KIHN0cmluZ3MKCkVzaGVsbCB3YXMgYWxyZWFkeSBjb252ZXJ0aW5nIHNvbWUgdHlw ZXMgKG51bWJlcnMsIG5pbCkgdG8gc3RyaW5ncywgYXMKd2VsbCBhcyBmaXhpbmcgdXAgbXVs dGlwbGUtZG90IGZvcm1zIGxpa2UgIi4uLi8iLCBzbyB0aGlzIHdheSBpcyBtb3JlCmNvbnNp c3RlbnQgYW5kIHNob3VsZCBwcm9kdWNlIGZld2VyIHByb2JsZW1zIGZvciBQY29tcGxldGUg ZnVuY3Rpb25zLgoKKiBsaXNwL2VzaGVsbC9lbS1jbXBsLmVsIChlc2hlbGwtY29tcGxldGUt cGFyc2UtYXJndW1lbnRzKTogQWx3YXlzCmNvbnZlcnQgcGFyc2VkIGFyZ3VtZW50cyB0byBz dHJpbmdzLgoKKiB0ZXN0L2xpc3AvZXNoZWxsL2VtLWNtcGwtdGVzdHMuZWwgKGVzaGVsbC1h cmd1bWVudHMtZXF1YWwsCmVzaGVsbC1hcmd1bWVudHMtZXF1YWwtLWVxdWFsLWV4cGxhaW5l cik6IE5ldyBmdW5jdGlvbnMuCihlbS1jbXBsLXRlc3QvcGFyc2UtYXJndW1lbnRzL3BpcGVs aW5lKQooZW0tY21wbC10ZXN0L3BhcnNlLWFyZ3VtZW50cy9tdWx0aXBsZS1kb3RzKQooZW0t Y21wbC10ZXN0L3BhcnNlLWFyZ3VtZW50cy92YXJpYWJsZS9udW1lcmljKQooZW0tY21wbC10 ZXN0L3BhcnNlLWFyZ3VtZW50cy92YXJpYWJsZS9uaWwpCihlbS1jbXBsLXRlc3QvcGFyc2Ut YXJndW1lbnRzL3ZhcmlhYmxlL2xpc3QpCihlbS1jbXBsLXRlc3QvcGFyc2UtYXJndW1lbnRz L3ZhcmlhYmxlL3NwbGljZSk6IFVzZQonZXNoZWxsLWFyZ3VtZW50cy1lcXVhbCcuCi0tLQog bGlzcC9lc2hlbGwvZW0tY21wbC5lbCAgICAgICAgICAgIHwgMjQgKysrKysrKy0tLS0tLS0K IHRlc3QvbGlzcC9lc2hlbGwvZW0tY21wbC10ZXN0cy5lbCB8IDU0ICsrKysrKysrKysrKysr KysrKysrKysrKy0tLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgNTUgaW5zZXJ0aW9ucygrKSwg MjMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9lc2hlbGwvZW0tY21wbC5lbCBi L2xpc3AvZXNoZWxsL2VtLWNtcGwuZWwKaW5kZXggYTY3ZmU1M2VkNDYuLmYzYTYwNjRhNDgz IDEwMDY0NAotLS0gYS9saXNwL2VzaGVsbC9lbS1jbXBsLmVsCisrKyBiL2xpc3AvZXNoZWxs L2VtLWNtcGwuZWwKQEAgLTM4NiwxNyArMzg2LDE5IEBAIGVzaGVsbC1jb21wbGV0ZS1wYXJz ZS1hcmd1bWVudHMKICAgICA7OyBDb252ZXJ0IGFyZ3VtZW50cyB0byBmb3JtcyB0aGF0IFBj b21wbGV0ZSBjYW4gdW5kZXJzdGFuZC4KICAgICAoY29ucyAobWFwY2FyCiAgICAgICAgICAg IChsYW1iZGEgKGFyZykKLSAgICAgICAgICAgICAoY29uZAotICAgICAgICAgICAgICAoKG51 bWJlcnAgYXJnKQotICAgICAgICAgICAgICAgKG51bWJlci10by1zdHJpbmcgYXJnKSkKLSAg ICAgICAgICAgICAgOzsgRXhwYW5kICIuLi4vIiBldGMgdGhhdCBvbmx5IEVzaGVsbCB1bmRl cnN0YW5kcyB0byB0aGUKLSAgICAgICAgICAgICAgOzsgc3RhbmRhcmQgIi4uLy4uLyIuCi0g ICAgICAgICAgICAgICgoYW5kIChzdHJpbmdwIGFyZykgKHN0cmluZy1tYXRjaCAiXFwuXFwu XFwuKy8iIGFyZykpCi0gICAgICAgICAgICAgICAoZXNoZWxsLWV4cGFuZC1tdWx0aXBsZS1k b3RzIGFyZykpCi0gICAgICAgICAgICAgICgobnVsbCBhcmcpCi0gICAgICAgICAgICAgICAi IikKLSAgICAgICAgICAgICAgKHQKLSAgICAgICAgICAgICAgIGFyZykpKQorICAgICAgICAg ICAgIChwY2FzZSBhcmcKKyAgICAgICAgICAgICAgIDs7IEV4cGFuZCAiLi4uLyIgZXRjIHRo YXQgb25seSBFc2hlbGwgdW5kZXJzdGFuZHMgdG8KKyAgICAgICAgICAgICAgIDs7IHRoZSBz dGFuZGFyZCAiLi4vLi4vIi4KKyAgICAgICAgICAgICAgICgocnggIi4uIiAoKyAiLiIpICIv IikKKyAgICAgICAgICAgICAgICAocHJvcGVydGl6ZSAoZXNoZWxsLWV4cGFuZC1tdWx0aXBs ZS1kb3RzIGFyZykKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAncGNvbXBsZXRlLWFy Zy12YWx1ZSBhcmcpKQorICAgICAgICAgICAgICAgKChwcmVkIHN0cmluZ3ApCisgICAgICAg ICAgICAgICAgYXJnKQorICAgICAgICAgICAgICAgKCduaWwKKyAgICAgICAgICAgICAgICAo cHJvcGVydGl6ZSAiIiAncGNvbXBsZXRlLWFyZy12YWx1ZSBhcmcpKQorICAgICAgICAgICAg ICAgKF8KKyAgICAgICAgICAgICAgICAocHJvcGVydGl6ZSAoZXNoZWxsLXN0cmluZ2lmeSBh cmcpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ3Bjb21wbGV0ZS1hcmctdmFsdWUg YXJnKSkpKQogCSAgIGFyZ3MpCiAJICBwb3NucykpKQogCmRpZmYgLS1naXQgYS90ZXN0L2xp c3AvZXNoZWxsL2VtLWNtcGwtdGVzdHMuZWwgYi90ZXN0L2xpc3AvZXNoZWxsL2VtLWNtcGwt dGVzdHMuZWwKaW5kZXggM2Y4Zjg5MGY2ZTUuLjEyYTE1NmZiYjM4IDEwMDY0NAotLS0gYS90 ZXN0L2xpc3AvZXNoZWxsL2VtLWNtcGwtdGVzdHMuZWwKKysrIGIvdGVzdC9saXNwL2VzaGVs bC9lbS1jbXBsLXRlc3RzLmVsCkBAIC00NCw2ICs0NCwyNiBAQCBlc2hlbGwtaW5zZXJ0LWFu ZC1jb21wbGV0ZQogICAoY29tcGxldGlvbi1hdC1wb2ludCkKICAgKGVzaGVsbC1nZXQtb2xk LWlucHV0KSkKIAorKGRlZnVuIGVzaGVsbC1hcmd1bWVudHMtZXF1YWwgKGFjdHVhbCBleHBl Y3RlZCkKKyAgIlJldHVybiB0IGlmIEFDVFVBTCBhbmQgRVhQRUNURUQgYXJlIGVxdWFsLCBp bmNsdWRpbmcgcHJvcGVydGllcyBvZiBzdHJpbmdzLgorQUNUVUFMIGFuZCBFWFBFQ1RFRCBz aG91bGQgYm90aCBiZSBsaXN0cyBvZiBzdHJpbmdzLiIKKyAgKHdoZW4gKGxlbmd0aD0gYWN0 dWFsIChsZW5ndGggZXhwZWN0ZWQpKQorICAgIChjYXRjaCAnbm90LWVxdWFsCisgICAgICAo Y2wtbWFwYyAobGFtYmRhIChpIGopCisgICAgICAgICAgICAgICAgICh1bmxlc3MgKGVxdWFs LWluY2x1ZGluZy1wcm9wZXJ0aWVzIGkgaikKKyAgICAgICAgICAgICAgICAgICAodGhyb3cg J25vdC1lcXVhbCBuaWwpKSkKKyAgICAgICAgICAgICAgIGFjdHVhbCBleHBlY3RlZCkKKyAg ICAgIHQpKSkKKworKGRlZnVuIGVzaGVsbC1hcmd1bWVudHMtZXF1YWwtLWVxdWFsLWV4cGxh aW5lciAoYWN0dWFsIGV4cGVjdGVkKQorICAiRXhwbGFpbiB0aGUgcmVzdWx0IG9mIGBlc2hl bGwtYXJndW1lbnRzLWVxdWFsJy4iCisgIGAobm9uZXF1YWwtcmVzdWx0CisgICAgKGFjdHVh bCAsYWN0dWFsKQorICAgIChleHBlY3RlZCAsZXhwZWN0ZWQpKSkKKworKHB1dCAnZXNoZWxs LWFyZ3VtZW50cy1lcXVhbCAnZXJ0LWV4cGxhaW5lcgorICAgICAjJ2VzaGVsbC1hcmd1bWVu dHMtZXF1YWwtLWVxdWFsLWV4cGxhaW5lcikKKwogOzs7IFRlc3RzOgogCiAoZXJ0LWRlZnRl c3QgZW0tY21wbC10ZXN0L3BhcnNlLWFyZ3VtZW50cy9waXBlbGluZSAoKQpAQCAtNTEsNDcg KzcxLDU3IEBAIGVtLWNtcGwtdGVzdC9wYXJzZS1hcmd1bWVudHMvcGlwZWxpbmUKICAgKHdp dGgtdGVtcC1lc2hlbGwKICAgIChsZXQgKChlc2hlbGwtdGVzdC12YWx1ZSAnKCJmb28iICJi YXIiKSkpCiAgICAgIChpbnNlcnQgImVjaG8gaGkgfCBjYXQiKQotICAgICAoc2hvdWxkIChl cXVhbCAoY2FyIChlc2hlbGwtY29tcGxldGUtcGFyc2UtYXJndW1lbnRzKSkKLSAgICAgICAg ICAgICAgICAgICAgJygiY2F0IikpKSkpKQorICAgICAoc2hvdWxkIChlc2hlbGwtYXJndW1l bnRzLWVxdWFsCisgICAgICAgICAgICAgIChjYXIgKGVzaGVsbC1jb21wbGV0ZS1wYXJzZS1h cmd1bWVudHMpKQorICAgICAgICAgICAgICAnKCJjYXQiKSkpKSkpCiAKIChlcnQtZGVmdGVz dCBlbS1jbXBsLXRlc3QvcGFyc2UtYXJndW1lbnRzL211bHRpcGxlLWRvdHMgKCkKICAgIlRl c3QgcGFyc2luZyBhcmd1bWVudHMgd2l0aCBtdWx0aXBsZSBkb3RzIGxpa2UgXCIuLi4vXCIu IgogICAod2l0aC10ZW1wLWVzaGVsbAogICAgKGluc2VydCAiZWNobyAuLi4vZmlsZS50eHQi KQotICAgKHNob3VsZCAoZXF1YWwgKGNhciAoZXNoZWxsLWNvbXBsZXRlLXBhcnNlLWFyZ3Vt ZW50cykpCi0gICAgICAgICAgICAgICAgICAnKCJlY2hvIiAiLi4vLi4vZmlsZS50eHQiKSkp KSkKKyAgIChzaG91bGQgKGVzaGVsbC1hcmd1bWVudHMtZXF1YWwKKyAgICAgICAgICAgIChj YXIgKGVzaGVsbC1jb21wbGV0ZS1wYXJzZS1hcmd1bWVudHMpKQorICAgICAgICAgICAgYCgi ZWNobyIgLChwcm9wZXJ0aXplICIuLi8uLi9maWxlLnR4dCIKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAncGNvbXBsZXRlLWFyZy12YWx1ZQorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICIuLi4vZmlsZS50eHQiKSkpKSkpCiAKIChlcnQtZGVmdGVz dCBlbS1jbXBsLXRlc3QvcGFyc2UtYXJndW1lbnRzL3ZhcmlhYmxlL251bWVyaWMgKCkKICAg IlRlc3QgcGFyc2luZyBhcmd1bWVudHMgd2l0aCBhIG51bWVyaWMgdmFyaWFibGUgaW50ZXJw b2xhdGlvbi4iCiAgICh3aXRoLXRlbXAtZXNoZWxsCiAgICAobGV0ICgoZXNoZWxsLXRlc3Qt dmFsdWUgNDIpKQogICAgICAoaW5zZXJ0ICJlY2hvICRlc2hlbGwtdGVzdC12YWx1ZSIpCi0g ICAgIChzaG91bGQgKGVxdWFsIChjYXIgKGVzaGVsbC1jb21wbGV0ZS1wYXJzZS1hcmd1bWVu dHMpKQotICAgICAgICAgICAgICAgICAgICAnKCJlY2hvIiAiNDIiKSkpKSkpCisgICAgIChz aG91bGQgKGVzaGVsbC1hcmd1bWVudHMtZXF1YWwKKyAgICAgICAgICAgICAgKGNhciAoZXNo ZWxsLWNvbXBsZXRlLXBhcnNlLWFyZ3VtZW50cykpCisgICAgICAgICAgICAgIGAoImVjaG8i ICwocHJvcGVydGl6ZSAiNDIiICdwY29tcGxldGUtYXJnLXZhbHVlIDQyKSkpKSkpKQogCiAo ZXJ0LWRlZnRlc3QgZW0tY21wbC10ZXN0L3BhcnNlLWFyZ3VtZW50cy92YXJpYWJsZS9uaWwg KCkKICAgIlRlc3QgcGFyc2luZyBhcmd1bWVudHMgd2l0aCBhIG5pbCB2YXJpYWJsZSBpbnRl cnBvbGF0aW9uLiIKICAgKHdpdGgtdGVtcC1lc2hlbGwKICAgIChsZXQgKChlc2hlbGwtdGVz dC12YWx1ZSBuaWwpKQogICAgICAoaW5zZXJ0ICJlY2hvICRlc2hlbGwtdGVzdC12YWx1ZSIp Ci0gICAgIChzaG91bGQgKGVxdWFsIChjYXIgKGVzaGVsbC1jb21wbGV0ZS1wYXJzZS1hcmd1 bWVudHMpKQotICAgICAgICAgICAgICAgICAgICAnKCJlY2hvIiAiIikpKSkpKQorICAgICAo c2hvdWxkIChlc2hlbGwtYXJndW1lbnRzLWVxdWFsCisgICAgICAgICAgICAgIChjYXIgKGVz aGVsbC1jb21wbGV0ZS1wYXJzZS1hcmd1bWVudHMpKQorICAgICAgICAgICAgICBgKCJlY2hv IiAsKHByb3BlcnRpemUgIiIgJ3Bjb21wbGV0ZS1hcmctdmFsdWUgbmlsKSkpKSkpKQogCiAo ZXJ0LWRlZnRlc3QgZW0tY21wbC10ZXN0L3BhcnNlLWFyZ3VtZW50cy92YXJpYWJsZS9saXN0 ICgpCiAgICJUZXN0IHBhcnNpbmcgYXJndW1lbnRzIHdpdGggYSBsaXN0IHZhcmlhYmxlIGlu dGVycG9sYXRpb24uIgogICAod2l0aC10ZW1wLWVzaGVsbAogICAgKGxldCAoKGVzaGVsbC10 ZXN0LXZhbHVlICcoImZvbyIgImJhciIpKSkKICAgICAgKGluc2VydCAiZWNobyAkZXNoZWxs LXRlc3QtdmFsdWUiKQotICAgICAoc2hvdWxkIChlcXVhbCAoY2FyIChlc2hlbGwtY29tcGxl dGUtcGFyc2UtYXJndW1lbnRzKSkKLSAgICAgICAgICAgICAgICAgICAgJygiZWNobyIgKCJm b28iICJiYXIiKSkpKSkpKQorICAgICAoc2hvdWxkIChlc2hlbGwtYXJndW1lbnRzLWVxdWFs CisgICAgICAgICAgICAgIChjYXIgKGVzaGVsbC1jb21wbGV0ZS1wYXJzZS1hcmd1bWVudHMp KQorICAgICAgICAgICAgICBgKCJlY2hvIiAsKHByb3BlcnRpemUgIihcImZvb1wiIFwiYmFy XCIpIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ3Bjb21wbGV0ZS1h cmctdmFsdWUKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGVzaGVsbC10 ZXN0LXZhbHVlKSkpKSkpKQogCiAoZXJ0LWRlZnRlc3QgZW0tY21wbC10ZXN0L3BhcnNlLWFy Z3VtZW50cy92YXJpYWJsZS9zcGxpY2UgKCkKICAgIlRlc3QgcGFyc2luZyBhcmd1bWVudHMg d2l0aCBhIHNwbGljZWQgdmFyaWFibGUgaW50ZXJwb2xhdGlvbi4iCiAgICh3aXRoLXRlbXAt ZXNoZWxsCiAgICAobGV0ICgoZXNoZWxsLXRlc3QtdmFsdWUgJygiZm9vIiAiYmFyIikpKQog ICAgICAoaW5zZXJ0ICJlY2hvICRAZXNoZWxsLXRlc3QtdmFsdWUiKQotICAgICAoc2hvdWxk IChlcXVhbCAoY2FyIChlc2hlbGwtY29tcGxldGUtcGFyc2UtYXJndW1lbnRzKSkKLSAgICAg ICAgICAgICAgICAgICAgJygiZWNobyIgImZvbyIgImJhciIpKSkpKSkKKyAgICAgKHNob3Vs ZCAoZXNoZWxsLWFyZ3VtZW50cy1lcXVhbAorICAgICAgICAgICAgICAoY2FyIChlc2hlbGwt Y29tcGxldGUtcGFyc2UtYXJndW1lbnRzKSkKKyAgICAgICAgICAgICAgJygiZWNobyIgImZv byIgImJhciIpKSkpKSkKIAogKGVydC1kZWZ0ZXN0IGVtLWNtcGwtdGVzdC9maWxlLWNvbXBs ZXRpb24vdW5pcXVlICgpCiAgICJUZXN0IGNvbXBsZXRpb24gb2YgZmlsZSBuYW1lcyB3aGVu IHRoZXJlJ3MgYSB1bmlxdWUgcmVzdWx0LiIKLS0gCjIuMjUuMQoK --------------RTxSlcNOnrZgEDb0bwt2x00B-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 30 02:14:59 2023 Received: (at 60845) by debbugs.gnu.org; 30 Jan 2023 07:14:59 +0000 Received: from localhost ([127.0.0.1]:46187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMONX-0001RF-7Q for submit@debbugs.gnu.org; Mon, 30 Jan 2023 02:14:59 -0500 Received: from mail-pj1-f44.google.com ([209.85.216.44]:33356) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMONT-0001Qx-U1 for 60845@debbugs.gnu.org; Mon, 30 Jan 2023 02:14:57 -0500 Received: by mail-pj1-f44.google.com with SMTP id v6-20020a17090ad58600b00229eec90a7fso12936310pju.0 for <60845@debbugs.gnu.org>; Sun, 29 Jan 2023 23:14:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=R/I9RMag2VQ05muD4bDRZ1tNy2ZNydrlwb9XPBUDtQo=; b=WmNlzN3s6gPR4ZeMlSR8RNhkaIRg6NqK75h5iipgibOxAmU/rbEGJddESl78bCz+SU DlzDoniJlX9v2M4T3OqP1nRVUTZYDDqN6hPylOBgknsmFxDsYVMxqGunshPTtZrvl9iL siB/5GeQOs3roxlHzZuaqbcOZ6HkNh+H0G9jzypldXVqj2/SWdPjXAJyJOSjLwghisCi L4EK1cfjlqXwiA3ut+5tG+1LXLi0HNw2opoapCTbdZ5WOp4fQmtWTGVGKp6jZG59cuBs JAh8NU7bF3bFRrUuVE4qYa03whSJ4JojD2xgGjd3O2M0FZEpmxZSn7xrRXtahcXmfMxc T4Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=R/I9RMag2VQ05muD4bDRZ1tNy2ZNydrlwb9XPBUDtQo=; b=fdVa2GmiqcVsjGcD+eI8hcXYmOcpWzgZHJKRdgUcVvWK0Bs+pdjEnIaS0VpSf1qHV0 4grtfHMXTODPFnbQoqVjB26Qpci03apRsX6T1lcyeXdTTAHJO1s6djvJnKMBzyFQKbSN dBic/CcCkHU+XoaQJF3q7ZsDtNExT/F31/RcyzsQu3vvWvAUQHqNmctzCKzOoh1f+lCl zmYMBltDqH5xgYME/u2Zp26TZxtiG1VEqTvnOADrP0zm1CoWov7XmG8mvFj49WbrH/h1 ydaDv2m+GE9LlGDln1SGwfMyr0AMQOGSrPjipwoKU/Dqn6YfcBRIZlV82Q2ELpluhw1r uj1A== X-Gm-Message-State: AO0yUKUUaAIw3gT2Vxo3C4ll1E87WKgubbuNsRdHopT8v4LnxrsbrciB NH5F3r+YrjaThpPtF2Of3ucnq3mc8kvjSQ== X-Google-Smtp-Source: AK7set9zy7AkWVX+Bh/Z2X3KABm2zCtyfMqvnFWl0KEf0BRPALHCM8jl/eNN9l4ELeqkqTu9LNFUYQ== X-Received: by 2002:a17:90b:1c02:b0:22c:1bd4:1814 with SMTP id oc2-20020a17090b1c0200b0022c1bd41814mr17462158pjb.37.1675062890039; Sun, 29 Jan 2023 23:14:50 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id i130-20020a636d88000000b00477def759cbsm6173503pgc.58.2023.01.29.23.14.49 for <60845@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 Jan 2023 23:14:49 -0800 (PST) Message-ID: <8f725450-1158-67de-7a0f-d550d867e084@gmail.com> Date: Sun, 29 Jan 2023 23:14:49 -0800 MIME-Version: 1.0 Subject: Re: bug#60845: 30.0.50; [PATCH] Add tests for Eshell interactive completion (and fix a bug in it) Content-Language: en-US From: Jim Porter To: 60845@debbugs.gnu.org References: <2b75d4d4-0533-2182-6da8-413391577bf5@gmail.com> <40d31b3d-d429-5a48-02bc-a3c1e4a1d903@gmail.com> In-Reply-To: <40d31b3d-d429-5a48-02bc-a3c1e4a1d903@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60845 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) X-Debbugs-Cc: monnier@iro.umontreal.ca On 1/22/2023 1:35 PM, Jim Porter wrote: > On 1/22/2023 1:34 PM, Jim Porter wrote: >> The third patch in this series fixes this for the Eshell side, so we >> could probably remove the workaround in pcomplete.el for Emacs 30. Stefan, do you have any thoughts on these changes, especially the third patch? I did a bit of tinkering with pcomplete functions, and I think it should be ok for the Eshell side of things. Eshell-specific pcomplete functions can get the real value if they need by examining the 'pcomplete-arg-value' string property. For pcomplete functions that aren't Eshell-specific, they'll always get the string form of arguments by default, so things should Just Work there. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 30 09:54:21 2023 Received: (at 60845) by debbugs.gnu.org; 30 Jan 2023 14:54:21 +0000 Received: from localhost ([127.0.0.1]:46853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMVY4-0005Wc-U0 for submit@debbugs.gnu.org; Mon, 30 Jan 2023 09:54:21 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:50623) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMVY3-0005WQ-Gw for 60845@debbugs.gnu.org; Mon, 30 Jan 2023 09:54:20 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 7111F808F0; Mon, 30 Jan 2023 09:54:13 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A42A0803B4; Mon, 30 Jan 2023 09:54:11 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1675090451; bh=fMakV2cggqyapjPthiFiYC9ja1+plSnogK0JRBNZBrg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=XaR+jQpQeBOigc5jDikKWnZCG7b91tF6xUz9FE/+Yvlw4FOKlYZq0TmWAxIJPzfky fTqJUrYNHtgec//hCnf2QTA4rFcsjkbOqXaRJmL9O2inLB+lXko+/zgkOvTME2mDQE MoJRhf6mgkS5vZXLIDNfZMFJXFJnK8M6/9K5LQiYXXclckud9owIvtFd9jkpzsXQNX DhH3HDaq+UQi9U9BEjv8I55czoThDQowxNqjw6ifNnFdvfM+awUrgZKXtlgDHzdEZL lxHnjMRZusPKz3g5yHYN966RSpcPe91C3JO4zz4JaVwfrK4s2SwOMQUKuvU+/TMeyS hMb5O/y9N0ADA== Received: from pastel (69-165-135-136.dsl.teksavvy.com [69.165.135.136]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2C609122501; Mon, 30 Jan 2023 09:54:11 -0500 (EST) From: Stefan Monnier To: Jim Porter Subject: Re: bug#60845: 30.0.50; [PATCH] Add tests for Eshell interactive completion (and fix a bug in it) In-Reply-To: <8f725450-1158-67de-7a0f-d550d867e084@gmail.com> (Jim Porter's message of "Sun, 29 Jan 2023 23:14:49 -0800") Message-ID: References: <2b75d4d4-0533-2182-6da8-413391577bf5@gmail.com> <40d31b3d-d429-5a48-02bc-a3c1e4a1d903@gmail.com> <8f725450-1158-67de-7a0f-d550d867e084@gmail.com> Date: Mon, 30 Jan 2023 09:54:09 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60845 Cc: 60845@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >>> The third patch in this series fixes this for the Eshell side, so we >>> could probably remove the workaround in pcomplete.el for Emacs 30. > > Stefan, do you have any thoughts on these changes, especially the third > patch? I did a bit of tinkering with pcomplete functions, and I think it > should be ok for the Eshell side of things. Eshell-specific pcomplete > functions can get the real value if they need by examining the > 'pcomplete-arg-value' string property. > > For pcomplete functions that aren't Eshell-specific, they'll always get the > string form of arguments by default, so things should Just Work there. It sounds good to me, but I'm definitely not well versed in this aspect of the interaction between Eshell and Pcomplete (more specifically, this is a part of their interaction which I find quite tricky), so it's good that you add corresponding regression tests. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 30 21:00:42 2023 Received: (at 60845) by debbugs.gnu.org; 31 Jan 2023 02:00:42 +0000 Received: from localhost ([127.0.0.1]:51010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMfww-0006G2-C1 for submit@debbugs.gnu.org; Mon, 30 Jan 2023 21:00:42 -0500 Received: from mail-pj1-f45.google.com ([209.85.216.45]:50804) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMfwt-0006Fn-RF for 60845@debbugs.gnu.org; Mon, 30 Jan 2023 21:00:40 -0500 Received: by mail-pj1-f45.google.com with SMTP id m11so12885749pji.0 for <60845@debbugs.gnu.org>; Mon, 30 Jan 2023 18:00:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=IMsNww2HH2TrjOvMQ2bJrP0/8WyfoY6H75hmPsgNOlQ=; b=AIrm0xtyGt8/3uSafcO0v4CxE4FTIGmzhbVf/oKL942V9SXniBmCI0MFZBuKy6p1V3 K8AD8ooCsmsLAXEOYn9pyq8nPUPvhpZ/aoEqOsFDL8TxlIc4nKWSTGGhToRX8cdfPRGX 6hDWQxpQ3W4kbx2OpSe2gYbvgxUDt59cJpI+hikgTM3OiENcbnCBoMECVqsnrYTKYBku 1HRd/0r5ZHQxgCnH7dZGF+w1WUO3VJadsgf1m0H46hcNKOzO7pNtvD90nKnNvKXwEY+D /ShF+SFPXqRpjrV6QxYleP6Lxt1h11bz8tPgAwsMl6s+dNkBDNg6lcQVAnfSMlTElZvQ eARA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IMsNww2HH2TrjOvMQ2bJrP0/8WyfoY6H75hmPsgNOlQ=; b=44b5MEtYb1gfv6nQn2u9VloBZhTeOJYL4GcegYQs0oggNxU7QyBrKa/gDTyKJ5AmmY hNGO+Ng1LHbfUsYqYzvdNY5d+HP0Siaih2Vjyk+MejK5kpI1evj9GD5261Kvs6PKrIBI 6XXKKo1EGpnshfmaq71E7WTi4G/8bQE1PV+jmCMJGIhMvfsHNSsW2/5r3W3miwxqv7g1 qaRG3lJ7zxyniJ+DovUQuoZFQEsKrZup9CJG1rV4ii6NDzivb6TnvLBdm6BlMvKPUqiw zVUtu91APJLGypzZxu+/W+pT2C2O/sqwPAO4F0Chnd2QMnYZppzDRx2lSqVWxwCLuRB7 s7sg== X-Gm-Message-State: AO0yUKV/2/1bGIOwVusCeyqNYT7jsD4s0Rq0OnKvtQpDpeGNvEXPOpRL pyA46vK4ic7e8M07CqZUicM= X-Google-Smtp-Source: AK7set8TvVFb1x2TXd5KbQ89BGbadNJajuAYZ9/Y8vqhdKzPA8lYI9ffgzsLRjDNpzMywohDLJyIHA== X-Received: by 2002:a05:6a20:9387:b0:b0:3329:c395 with SMTP id x7-20020a056a20938700b000b03329c395mr14963009pzh.30.1675130433844; Mon, 30 Jan 2023 18:00:33 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id by12-20020a056a00400c00b00593baab06dcsm3084423pfb.198.2023.01.30.18.00.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jan 2023 18:00:33 -0800 (PST) Message-ID: <990abf69-d2f9-7582-c4dd-fd6bdebf04b3@gmail.com> Date: Mon, 30 Jan 2023 18:00:33 -0800 MIME-Version: 1.0 Subject: Re: bug#60845: 30.0.50; [PATCH] Add tests for Eshell interactive completion (and fix a bug in it) Content-Language: en-US To: Stefan Monnier References: <2b75d4d4-0533-2182-6da8-413391577bf5@gmail.com> <40d31b3d-d429-5a48-02bc-a3c1e4a1d903@gmail.com> <8f725450-1158-67de-7a0f-d550d867e084@gmail.com> From: Jim Porter In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60845 Cc: 60845@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 1/30/2023 6:54 AM, Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > It sounds good to me, but I'm definitely not well versed in this aspect > of the interaction between Eshell and Pcomplete (more specifically, > this is a part of their interaction which I find quite tricky), so it's > good that you add corresponding regression tests. Thanks for taking a look. I've merged my patches as e7d0aa248e. We can leave this open though to discuss what to do about the Pcomplete side of things. I think we can remove the workaround for Emacs 29, but maybe we want some additional changes. (It would also be nice to add some more Pcomplete support on the Eshell side. For example, when completing arguments to 'echo', Pcomplete shows options for the real /bin/echo, instead of showing options for the built-in function 'eshell/echo'.) From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 05 19:37:08 2023 Received: (at 60845) by debbugs.gnu.org; 5 Sep 2023 23:37:08 +0000 Received: from localhost ([127.0.0.1]:59829 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdfbY-0002Mf-FH for submit@debbugs.gnu.org; Tue, 05 Sep 2023 19:37:08 -0400 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]:56823) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdfbW-0002Lw-MO for 60845@debbugs.gnu.org; Tue, 05 Sep 2023 19:37:07 -0400 Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-50098cc8967so4843017e87.1 for <60845@debbugs.gnu.org>; Tue, 05 Sep 2023 16:37:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693957020; x=1694561820; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=mQMqb+sWGsiHF5FmvKkqU3moOyY6XS77mEhPfzXTtO4=; b=Phq8WUWefvjpOPI/GGTUFWBJCXuBztmXn/mgiw+ccBt59gE8RD8Xp42CKKSvUjuprt CDaXlSbUza1LfyarORnuHPDiCPD4O49jpLtM4wOOaVx0aXGpd1LITMcqT2fJsu06T/0V Bnsf02sGhek77EvbiqhtLOorHMmdHapCHuYRvBSy364SYg59KRu5QDQMXH5VACym58i9 C/8SxMXgmm4gkZqgHuvLo0AuOg7TPpAuFeSevxT15JGiuLFeJGaQHe92ZZJHhOfJv3dO EZS8pCMltxHxKRMFRyw10upog2I27VfLnEbrNP9+dqX7SgGoc4edWPQozis0DAHBUou2 8t/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693957020; x=1694561820; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mQMqb+sWGsiHF5FmvKkqU3moOyY6XS77mEhPfzXTtO4=; b=L4qHDmoUzuONq1lljQq5kCSJTIzCAb9es3fchqC5Gm8vKY8ZV1vGCQM2wnfauOGBzW my62sfuInrJQcv58Mu+GoreCdB3Yg+a5bP+zYzwl5ao6rLw2j0Vh2OyJBGViwpAPXb06 LmRF7bWwtBow8nZBAQrxs8XDqITYKulH2tsObhPDVWZ4YMEOYKTvt4gXhkyab/++CCL7 ym9Aq0JL/Aby6Aj3GMIOS8zwZNDPOg82twcUR0fGS5tS50waVhKL6jRYpMNs9zSVzcXq q7EOu8i5GApLVUPePSLxvpbklKuuInInBOc139KAdX/fP4fBz4KTiqr98MrG4aitTAJw xSWw== X-Gm-Message-State: AOJu0YzEtttrhqAvioRXEF17nwS7fyz6z6leGvg4V7cRVrV93s4gP+C5 YyRsvNRDTL/Bzy37S0lI0MOPdSeN2u0fltV0Q+4= X-Google-Smtp-Source: AGHT+IEAGxWZIvR261//VV++cRIcSGyKL0MVNjdAbnq05ltwGAzCjveu9csUg+J90igqU1Ff8EPfqf1R5TQ6xSuySNI= X-Received: by 2002:a19:750f:0:b0:4fb:7b4c:d38c with SMTP id y15-20020a19750f000000b004fb7b4cd38cmr754831lfe.60.1693957019885; Tue, 05 Sep 2023 16:36:59 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 5 Sep 2023 16:36:59 -0700 From: Stefan Kangas In-Reply-To: <990abf69-d2f9-7582-c4dd-fd6bdebf04b3@gmail.com> (Jim Porter's message of "Mon, 30 Jan 2023 18:00:33 -0800") References: <2b75d4d4-0533-2182-6da8-413391577bf5@gmail.com> <40d31b3d-d429-5a48-02bc-a3c1e4a1d903@gmail.com> <8f725450-1158-67de-7a0f-d550d867e084@gmail.com> <990abf69-d2f9-7582-c4dd-fd6bdebf04b3@gmail.com> MIME-Version: 1.0 Date: Tue, 5 Sep 2023 16:36:59 -0700 Message-ID: Subject: Re: bug#60845: 30.0.50; [PATCH] Add tests for Eshell interactive completion (and fix a bug in it) To: Jim Porter Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60845 Cc: 60845@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jim Porter writes: > On 1/30/2023 6:54 AM, Stefan Monnier via Bug reports for GNU Emacs, the Swiss > army knife of text editors wrote: >> It sounds good to me, but I'm definitely not well versed in this aspect >> of the interaction between Eshell and Pcomplete (more specifically, >> this is a part of their interaction which I find quite tricky), so it's >> good that you add corresponding regression tests. > > Thanks for taking a look. I've merged my patches as e7d0aa248e. We can leave > this open though to discuss what to do about the Pcomplete side of things. I > think we can remove the workaround for Emacs 29, but maybe we want some > additional changes. That was 9 months ago. Is it still relevant to keep this bug open? > (It would also be nice to add some more Pcomplete support on the Eshell > side. For example, when completing arguments to 'echo', Pcomplete shows options > for the real /bin/echo, instead of showing options for the built-in function > 'eshell/echo'.) From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 05 20:47:16 2023 Received: (at 60845) by debbugs.gnu.org; 6 Sep 2023 00:47:16 +0000 Received: from localhost ([127.0.0.1]:60083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdghQ-0003zD-0l for submit@debbugs.gnu.org; Tue, 05 Sep 2023 20:47:16 -0400 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]:45400) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdghN-0003yz-PY for 60845@debbugs.gnu.org; Tue, 05 Sep 2023 20:47:14 -0400 Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-68a41031768so2020721b3a.3 for <60845@debbugs.gnu.org>; Tue, 05 Sep 2023 17:47:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693961227; x=1694566027; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=jXumc14ktdfE0zEuogrNKkcfaJr/RaVfektbcVXwHlE=; b=G048GpeAK3rzWF7jMcfr39JQ3q+nQTvwGI06QmzNK7l6fHt2qV63/dYnsVQ6yW3Rhg GHx7H3ivs5Dmi55P6/1u0wlu5RwfAqms+iNlYF/IAor8nV9TIaC8+8mwnOQ3F7CeEDod JuOw29+ZzAy4A/uVFJRremTlHydXJ0yLar8aAXgu80yN1LXm1Y0PO32E/Om/3S2ANUuN twEpIcu0yf511OGrdbEQsqgVWtF7SCpCRdvgb3W08CUWXrFk6tIIwOtnKwVqd+X4Nbgb BbSMtFraTT6thrVs0fsaMvKTzRFbfqOEyrnvuJSjaOqrgAqPW6yuwJ3Fl/FevmDpD+M3 pivA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693961227; x=1694566027; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jXumc14ktdfE0zEuogrNKkcfaJr/RaVfektbcVXwHlE=; b=AhpQ31eXt8v4/EhpmCDxBKhXWTeyxyqHNA7MYfcM1cUY5zvW1NKtfL/LrvPkkyPily 77Gx0bo2a6lHZJ8J/8AaUjLInG8HwTej55ErVbK6xKQQ1OxXH70Foxi9uspkbeVaK8UL p1Rj3ZOMD/9GH4WbamKF2luRTFlhTNxsDIku63LFGHPuZ5B+dbmPmgro9+wwhEGj2geo UBsi8fsiqIldbcFOfAfQMBWoObbE3INftfDKgjdvKA9xAyW5U5CEs/ZOONvYGGmW2JvX VFOe27LzGnBiKqeFxkUdZ2/RLaAXjdR5Cciz+zs2W1X3kcPYf74cdb1t+sheEVSG4y1U joyg== X-Gm-Message-State: AOJu0YwD9A2wnGAtQi+SqF0qzMVyutC0iWBqFDOwHQYzGpD4qkwHN9EW 2SM7wuS6vXXRjDHFmOkYVOM= X-Google-Smtp-Source: AGHT+IGN8eZIp3B0vkZIN8N/3RkpT7OFNbR1bl9GJIizF0HVRZ+D1EpmiR7OTPaCqx9QYELkRxurTw== X-Received: by 2002:a05:6a00:1821:b0:68b:eb5a:644 with SMTP id y33-20020a056a00182100b0068beb5a0644mr16122918pfa.5.1693961227094; Tue, 05 Sep 2023 17:47:07 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id h28-20020a63385c000000b00553b9e0510esm10021787pgn.60.2023.09.05.17.47.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Sep 2023 17:47:06 -0700 (PDT) Message-ID: <46c56cb6-deff-bc8f-7d29-9401b7d261b1@gmail.com> Date: Tue, 5 Sep 2023 17:47:06 -0700 MIME-Version: 1.0 Subject: Re: bug#60845: 30.0.50; [PATCH] Add tests for Eshell interactive completion (and fix a bug in it) Content-Language: en-US To: Stefan Kangas References: <2b75d4d4-0533-2182-6da8-413391577bf5@gmail.com> <40d31b3d-d429-5a48-02bc-a3c1e4a1d903@gmail.com> <8f725450-1158-67de-7a0f-d550d867e084@gmail.com> <990abf69-d2f9-7582-c4dd-fd6bdebf04b3@gmail.com> From: Jim Porter In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60845 Cc: 60845@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 9/5/2023 4:36 PM, Stefan Kangas wrote: > Jim Porter writes: > >> On 1/30/2023 6:54 AM, Stefan Monnier via Bug reports for GNU Emacs, the Swiss >> army knife of text editors wrote: >>> It sounds good to me, but I'm definitely not well versed in this aspect >>> of the interaction between Eshell and Pcomplete (more specifically, >>> this is a part of their interaction which I find quite tricky), so it's >>> good that you add corresponding regression tests. >> >> Thanks for taking a look. I've merged my patches as e7d0aa248e. We can leave >> this open though to discuss what to do about the Pcomplete side of things. I >> think we can remove the workaround for Emacs 29, but maybe we want some >> additional changes. > > That was 9 months ago. Is it still relevant to keep this bug open? Yes, I believe so. I was planning to wait until Emacs 29.1 was released before pinging people on this, but then forgot all about it. We should probably use this time to fix the FIXME in 'pcomplete-arg', since (I think) the current behavior in Eshell no longer requires the FIXME bit: ;; FIXME: 'last' is handled specially in Emacs 29, because ;; 'pcomplete-parse-arguments' accepts a list of strings ;; (which are completion candidates) as return value for ;; (pcomplete-arg 'last). See below: "it means it's a ;; list of completions computed during parsing, ;; e.g. Eshell uses that to turn globs into lists of ;; completions". This special case will be dealt with ;; differently in Emacs 30: the pcomplete-arg-value ;; property will be used by 'pcomplete-parse-arguments'. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 05 21:37:58 2023 Received: (at 60845) by debbugs.gnu.org; 6 Sep 2023 01:37:58 +0000 Received: from localhost ([127.0.0.1]:60217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdhUT-0005SI-O4 for submit@debbugs.gnu.org; Tue, 05 Sep 2023 21:37:58 -0400 Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]:57399) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdhUS-0005S6-2k for 60845@debbugs.gnu.org; Tue, 05 Sep 2023 21:37:56 -0400 Received: by mail-pg1-x530.google.com with SMTP id 41be03b00d2f7-573e0d471ceso883865a12.2 for <60845@debbugs.gnu.org>; Tue, 05 Sep 2023 18:37:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693964269; x=1694569069; darn=debbugs.gnu.org; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=UFIMMpU8FeoM01A9l0FMURXuiA63xTNxodESPaiiuYo=; b=dAFc61ByJ07updKHBLcoVohe9/EfcdbcedkRGj655tdwGOIBxKoS972N8p1tR5FV/V aOxo8ld69ucWtOQr5yjbQ5xrgBt4GnPSXGWDgmky73/xpVq9aXeaeco0scoawX/lROxo g3dtMwM/0QRpGZ5HEDAwHVMzH8XpQe6yVo9UyK2YDMJolCAGHnxYB0/2gaLHn/H1I543 dCrTIFAEZWA9LAJAtlZKNwm2CqOC0ErWQol5dxTZJdl+kcJWZSgbuXEnWtILgfpKS9JV LV+RuyDtWhJOqvtU+5cR0yi1R6B2qQf5zp8tEDrUTbmj7jt2LudccsA2NqMxx4VHqP4a 50Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693964269; x=1694569069; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=UFIMMpU8FeoM01A9l0FMURXuiA63xTNxodESPaiiuYo=; b=eYRDc9ctAYMRWjnoVW0390/ioMClwx9tkIMrFe1Jdhkfz81YCTVRWLfF4NSY6mDYZR 5fji0deDAYct7KwfMlfICURhbL/gOwuchsTAyiDnM/XyTyN/CE0Q7mO1NzPA1bER+t0c jQSbbqGqrBRBANRW6QP5TlNqcirQP3NsA4wy/qc+6flKL0Z29Qm0yUZWiYbppiWNtPxc /v1JwFzHYIlHhScKsWVXya4QAWW2t3M6uh995koMeGg1vo3h7e7SY72GKqwHyUEtn6rG d4WKWsA3vnmH4JSca9wozMTnjUwQXiL2NlUiTUhQ96HXO0e6Ef5o0ne6oJfPPNgYO5e0 otqA== X-Gm-Message-State: AOJu0YxOCFX5AyxRumA2ZsiYtVca7DpdsE+31Rj/9ZlOf3DaVmZ6xy97 gcMRRohG8reP2naQ8kUur74= X-Google-Smtp-Source: AGHT+IHVH+8wH9sn7OlUd2jl9utJsX1VVKxRg5Vap0mSEVRxNZwSYg3kmwRLsxrI7P44vRl1yvdjwg== X-Received: by 2002:a05:6a21:35c9:b0:14c:c393:fce with SMTP id ba9-20020a056a2135c900b0014cc3930fcemr11722195pzc.23.1693964268977; Tue, 05 Sep 2023 18:37:48 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id t20-20020a63b254000000b0054fa8539681sm2702564pgo.34.2023.09.05.18.37.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Sep 2023 18:37:48 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------Xb71NCtwA7nzOOD8QP5HgA5E" Message-ID: <488af1f4-f075-09e8-3b45-1d1a65266c68@gmail.com> Date: Tue, 5 Sep 2023 18:37:47 -0700 MIME-Version: 1.0 Subject: Re: bug#60845: 30.0.50; [PATCH] Add tests for Eshell interactive completion (and fix a bug in it) Content-Language: en-US From: Jim Porter To: Stefan Kangas References: <2b75d4d4-0533-2182-6da8-413391577bf5@gmail.com> <40d31b3d-d429-5a48-02bc-a3c1e4a1d903@gmail.com> <8f725450-1158-67de-7a0f-d550d867e084@gmail.com> <990abf69-d2f9-7582-c4dd-fd6bdebf04b3@gmail.com> <46c56cb6-deff-bc8f-7d29-9401b7d261b1@gmail.com> In-Reply-To: <46c56cb6-deff-bc8f-7d29-9401b7d261b1@gmail.com> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60845 Cc: 60845@debbugs.gnu.org, Daniel Mendler , Gregory Heytings , arstoffel@gmail.com, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------Xb71NCtwA7nzOOD8QP5HgA5E Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 9/5/2023 5:47 PM, Jim Porter wrote: > On 9/5/2023 4:36 PM, Stefan Kangas wrote: >> Jim Porter writes: >> >>> On 1/30/2023 6:54 AM, Stefan Monnier via Bug reports for GNU Emacs, >>> the Swiss >>> army knife of text editors wrote: >>>> It sounds good to me, but I'm definitely not well versed in this aspect >>>> of the interaction between Eshell and Pcomplete (more specifically, >>>> this is a part of their interaction which I find quite tricky), so it's >>>> good that you add corresponding regression tests. >>> >>> Thanks for taking a look. I've merged my patches as e7d0aa248e. We >>> can leave >>> this open though to discuss what to do about the Pcomplete side of >>> things. I >>> think we can remove the workaround for Emacs 29, but maybe we want some >>> additional changes. >> >> That was 9 months ago.  Is it still relevant to keep this bug open? > > Yes, I believe so. I was planning to wait until Emacs 29.1 was released > before pinging people on this, but then forgot all about it. We should > probably use this time to fix the FIXME in 'pcomplete-arg', since (I > think) the current behavior in Eshell no longer requires the FIXME bit: > >             ;; FIXME: 'last' is handled specially in Emacs 29, because >             ;; 'pcomplete-parse-arguments' accepts a list of strings >             ;; (which are completion candidates) as return value for >             ;; (pcomplete-arg 'last).  See below: "it means it's a >             ;; list of completions computed during parsing, >             ;; e.g. Eshell uses that to turn globs into lists of >             ;; completions".  This special case will be dealt with >             ;; differently in Emacs 30: the pcomplete-arg-value >             ;; property will be used by 'pcomplete-parse-arguments'. Attached is a patch to revert the Emacs 29 workarounds. I *believe* I've fixed this on the Eshell side by always providing Pcomplete with the arguments in their string form. Could everyone try the patch out to make sure things still work? In particular, see the cases in the following bugs: bug#60464, bug#60021, and bug#59956. --------------Xb71NCtwA7nzOOD8QP5HgA5E Content-Type: text/plain; charset=UTF-8; name="0001-Revert-commits-dafa6d6badd6-and-72c45fa9109a.patch" Content-Disposition: attachment; filename="0001-Revert-commits-dafa6d6badd6-and-72c45fa9109a.patch" Content-Transfer-Encoding: base64 RnJvbSBiMDdiNWEzN2JjMGY0OTRhNGE5M2M5YTU0YWQ3ZTMwMmFjNzRjOTNkIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFR1ZSwgNSBTZXAgMjAyMyAxODoyNzoyMSAtMDcwMApTdWJqZWN0OiBbUEFU Q0hdIFJldmVydCBjb21taXRzIGRhZmE2ZDZiYWRkNiBhbmQgNzJjNDVmYTkxMDlhCgpUaGVz ZSB3ZXJlIHRoZXJlIHRvIHdvcmsgYXJvdW5kIGRlZmljaWVuY2llcyBpbiBob3cgRXNoZWxs IHByb2R1Y2VzCmNvbXBsZXRpb25zIGZvciAncGNvbXBsZXRlLWFyZ3VtZW50JyAoRXNoZWxs IHBhc3NlZCB2YXJpb3VzIG5vbi1zdHJpbmcKb2JqZWN0cyB0byBQY29tcGxldGUsIHdoaWNo IGJyb2tlIHRoaW5ncykuICBOb3csIEVzaGVsbCBhbHdheXMgcmV0dXJucwphIHN0cmluZ2lm aWVkIGZvcm0gb2YgdGhlIGFyZ3VtZW50LCB3aXRoIHRoZSBvcmlnaW5hbCB2YWx1ZSBzdG9y ZWQgdmlhCnRoZSB0ZXh0IHByb3BlcnR5ICdwY29tcGxldGUtYXJnLXZhbHVlJy4KCiogbGlz cC9wY29tcGxldGUuZWwgKHBjb21wbGV0ZS1hcmcpOiBSZXZlcnQgY2hhbmdlcyBiYWNrIHRv IGEgc2ltcGxlcgpmb3JtLgotLS0KIGxpc3AvcGNvbXBsZXRlLmVsIHwgMzYgKysrKysrKy0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgNyBpbnNlcnRp b25zKCspLCAyOSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL3Bjb21wbGV0ZS5l bCBiL2xpc3AvcGNvbXBsZXRlLmVsCmluZGV4IDE1MTYxMWY5NGI3Li5hYzhlZGNmZjlmMSAx MDA2NDQKLS0tIGEvbGlzcC9wY29tcGxldGUuZWwKKysrIGIvbGlzcC9wY29tcGxldGUuZWwK QEAgLTY3NSwzNSArNjc1LDEzIEBAIHBjb21wbGV0ZS1hcmcKIAogVGhlIE9GRlNFVCBhcmd1 bWVudCBpcyBhZGRlZCB0by90YWtlbiBhd2F5IGZyb20gdGhlIGluZGV4IHRoYXQgd2lsbCBi ZQogdXNlZC4gIFRoaXMgaXMgcmVhbGx5IG9ubHkgdXNlZnVsIHdpdGggYGZpcnN0JyBhbmQg YGxhc3QnLCBmb3IKLWFjY2Vzc2luZyBhYnNvbHV0ZSBhcmd1bWVudCBwb3NpdGlvbnMuCi0K LVdoZW4gdGhlIGFyZ3VtZW50IGhhcyBiZWVuIHRyYW5zZm9ybWVkIGludG8gc29tZXRoaW5n IHRoYXQgaXMgbm90Ci1hIHN0cmluZyBieSBgcGNvbXBsZXRlLXBhcnNlLWFyZ3VtZW50cy1m dW5jdGlvbicsIHRoZSB0ZXh0Ci1yZXByZXNlbnRhdGlvbiBvZiB0aGUgYXJndW1lbnQsIG5h bWVseSB3aGF0IHRoZSB1c2VyIGFjdHVhbGx5Ci10eXBlZCBpbiwgaXMgcmV0dXJuZWQsIGFu ZCB0aGUgdmFsdWUgb2YgdGhlIGFyZ3VtZW50IGlzIHN0b3JlZCBpbgotdGhlIHBjb21wbGV0 ZS1hcmctdmFsdWUgdGV4dCBwcm9wZXJ0eSBvZiB0aGF0IHN0cmluZy4iCi0gIChsZXQgKChh cmcKLSAgICAgICAgIChudGggKCsgKHBjYXNlIGluZGV4Ci0JICAgICAgICAgICAoJ2ZpcnN0 IDApCi0JICAgICAgICAgICAoJ2xhc3QgIHBjb21wbGV0ZS1sYXN0KQotCSAgICAgICAgICAg KF8gICAgICAoLSBwY29tcGxldGUtaW5kZXggKG9yIGluZGV4IDApKSkpCi0JICAgICAgICAg KG9yIG9mZnNldCAwKSkKLSAgICAgICAgICAgICAgcGNvbXBsZXRlLWFyZ3MpKSkKLSAgICAo aWYgKG9yIChzdHJpbmdwIGFyZykKLSAgICAgICAgICAgIDs7IEZJWE1FOiAnbGFzdCcgaXMg aGFuZGxlZCBzcGVjaWFsbHkgaW4gRW1hY3MgMjksIGJlY2F1c2UKLSAgICAgICAgICAgIDs7 ICdwY29tcGxldGUtcGFyc2UtYXJndW1lbnRzJyBhY2NlcHRzIGEgbGlzdCBvZiBzdHJpbmdz Ci0gICAgICAgICAgICA7OyAod2hpY2ggYXJlIGNvbXBsZXRpb24gY2FuZGlkYXRlcykgYXMg cmV0dXJuIHZhbHVlIGZvcgotICAgICAgICAgICAgOzsgKHBjb21wbGV0ZS1hcmcgJ2xhc3Qp LiAgU2VlIGJlbG93OiAiaXQgbWVhbnMgaXQncyBhCi0gICAgICAgICAgICA7OyBsaXN0IG9m IGNvbXBsZXRpb25zIGNvbXB1dGVkIGR1cmluZyBwYXJzaW5nLAotICAgICAgICAgICAgOzsg ZS5nLiBFc2hlbGwgdXNlcyB0aGF0IHRvIHR1cm4gZ2xvYnMgaW50byBsaXN0cyBvZgotICAg ICAgICAgICAgOzsgY29tcGxldGlvbnMiLiAgVGhpcyBzcGVjaWFsIGNhc2Ugd2lsbCBiZSBk ZWFsdCB3aXRoCi0gICAgICAgICAgICA7OyBkaWZmZXJlbnRseSBpbiBFbWFjcyAzMDogdGhl IHBjb21wbGV0ZS1hcmctdmFsdWUKLSAgICAgICAgICAgIDs7IHByb3BlcnR5IHdpbGwgYmUg dXNlZCBieSAncGNvbXBsZXRlLXBhcnNlLWFyZ3VtZW50cycuCi0gICAgICAgICAgICAoZXEg aW5kZXggJ2xhc3QpKQotICAgICAgICBhcmcKLSAgICAgIChwcm9wZXJ0aXplCi0gICAgICAg KGNhciAoc3BsaXQtc3RyaW5nIChwY29tcGxldGUtYWN0dWFsLWFyZyBpbmRleCBvZmZzZXQp KSkKLSAgICAgICAncGNvbXBsZXRlLWFyZy12YWx1ZSBhcmcpKSkpCithY2Nlc3NpbmcgYWJz b2x1dGUgYXJndW1lbnQgcG9zaXRpb25zLiIKKyAgKG50aCAoKyAocGNhc2UgaW5kZXgKKyAg ICAgICAgICAgICgnZmlyc3QgMCkKKyAgICAgICAgICAgICgnbGFzdCAgcGNvbXBsZXRlLWxh c3QpCisgICAgICAgICAgICAoXyAgICAgICgtIHBjb21wbGV0ZS1pbmRleCAob3IgaW5kZXgg MCkpKSkKKyAgICAgICAgICAob3Igb2Zmc2V0IDApKQorICAgICAgIHBjb21wbGV0ZS1hcmdz KSkKIAogKGRlZnVuIHBjb21wbGV0ZS1iZWdpbiAoJm9wdGlvbmFsIGluZGV4IG9mZnNldCkK ICAgIlJldHVybiB0aGUgYmVnaW5uaW5nIHBvc2l0aW9uIG9mIHRoZSBJTkRFWHRoIGFyZ3Vt ZW50LgotLSAKMi4yNS4xCgo= --------------Xb71NCtwA7nzOOD8QP5HgA5E-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 10 16:08:21 2023 Received: (at 60845-done) by debbugs.gnu.org; 10 Oct 2023 20:08:21 +0000 Received: from localhost ([127.0.0.1]:36976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqJ1h-0001Fo-JW for submit@debbugs.gnu.org; Tue, 10 Oct 2023 16:08:21 -0400 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]:47449) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqJ1f-0001FZ-F0 for 60845-done@debbugs.gnu.org; Tue, 10 Oct 2023 16:08:20 -0400 Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1c434c33ec0so38204645ad.3 for <60845-done@debbugs.gnu.org>; Tue, 10 Oct 2023 13:07:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696968472; x=1697573272; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=gCLJlLr+ZzUJRUdzfYLAujlMXVi27ZZ5uMB/qG+FTWc=; b=j4T1c1vozTebtVv1E96iVFjsBBoQaJzKqJfUMI2cKJcljisHzy8HUNQIvwDUPmMnv8 a8eYDxyCDNDCV7qzwZjILdwsbGYotJMFxVOObJp+mDnQKE5Gasj5Rv1vpFHGy58eUlH5 ZK7S26z9boWlaJdX3FjkgjCDUUQzrD/P8CdAH5DtyYobh/7QL0WD5DISDopwTWGKRjRB T3TbArYlJKKCnadOKAqsjdRTk6zubtwrwZfOrzewSpCQ+UFhCGDCO8wRawBIFTOjnQzh iLF4vH+X4MB75rG4nTSfGXh5aVJbIuAmNb553oq/jf4nQAXv6rRJVKEvI5mn7+V8HLff dRqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696968472; x=1697573272; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gCLJlLr+ZzUJRUdzfYLAujlMXVi27ZZ5uMB/qG+FTWc=; b=bCuBvZZp3Wl1DusmrfJmp/t65tvUahvmKT3WPKp60iatPrkiYJBPaCa+IR9bE8dsSz xlxitZwEHcLOgjhmyaOagkuOG3M1P8yGXQg9ZjOCVN/A89BoXvsQ+saGGJYQ5uKGyHkD //cF6Q+AYCdOdYJ03T93t2utY4hpT5K+mqE7ZqCEV33GhNk7ZmL+Iwb3ChioeiZhOZBs O/hhNGgOeRKZRacdtXJSbTRFJZd+iwrTTt/M4yiBxrySmZxsn2P24PpVO/XYBlCFfZIW LPbsqx1yNYt0yz8m+PxJndNJPVQgFPd8zwpBoJpBDaBQ4iQbkEl0MLCffqpI28yPtrk5 KNqA== X-Gm-Message-State: AOJu0Ywk6xMv1x+wSCdtB4rmY11/2p9An64vk6O3oWCNNSPczIQK6k2X YKCEIi5ZEDPYzcV0mRVqkvU= X-Google-Smtp-Source: AGHT+IEjcrnMc0oXn0Wl+YN+VrfHPVNGBhq9ypeDwxP5GflefDIZUHCCFaSgV/+8HA9gFY07GHfaig== X-Received: by 2002:a17:902:ea8d:b0:1c0:c640:3f3e with SMTP id x13-20020a170902ea8d00b001c0c6403f3emr17099099plb.42.1696968472161; Tue, 10 Oct 2023 13:07:52 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id 19-20020a17090a1a1300b00273744e6eccsm11577883pjk.12.2023.10.10.13.07.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Oct 2023 13:07:51 -0700 (PDT) Message-ID: <5c5c40d0-34f4-34ff-6cdd-9a2852ee97b4@gmail.com> Date: Tue, 10 Oct 2023 13:07:50 -0700 MIME-Version: 1.0 Subject: Re: bug#60845: 30.0.50; [PATCH] Add tests for Eshell interactive completion (and fix a bug in it) Content-Language: en-US From: Jim Porter To: Stefan Kangas References: <2b75d4d4-0533-2182-6da8-413391577bf5@gmail.com> <40d31b3d-d429-5a48-02bc-a3c1e4a1d903@gmail.com> <8f725450-1158-67de-7a0f-d550d867e084@gmail.com> <990abf69-d2f9-7582-c4dd-fd6bdebf04b3@gmail.com> <46c56cb6-deff-bc8f-7d29-9401b7d261b1@gmail.com> <488af1f4-f075-09e8-3b45-1d1a65266c68@gmail.com> In-Reply-To: <488af1f4-f075-09e8-3b45-1d1a65266c68@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60845-done Cc: 60845-done@debbugs.gnu.org, Daniel Mendler , Gregory Heytings , arstoffel@gmail.com, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 9/5/2023 6:37 PM, Jim Porter wrote: > Attached is a patch to revert the Emacs 29 workarounds. I *believe* I've > fixed this on the Eshell side by always providing Pcomplete with the > arguments in their string form. Could everyone try the patch out to make > sure things still work? > > In particular, see the cases in the following bugs: bug#60464, > bug#60021, and bug#59956. Since there have been no further comments in the last month, I've now merged my patch to the master branch as 239db5d5162. If anyone sees any issues resulting from this, feel free to back it out, file a bug, and/or let me know directly. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 10 17:26:04 2023 Received: (at 60845-done) by debbugs.gnu.org; 10 Oct 2023 21:26:04 +0000 Received: from localhost ([127.0.0.1]:37011 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqKEu-0004GS-BH for submit@debbugs.gnu.org; Tue, 10 Oct 2023 17:26:04 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:16372) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqKEq-0004Fu-Ib for 60845-done@debbugs.gnu.org; Tue, 10 Oct 2023 17:26:03 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id EAB591000AD; Tue, 10 Oct 2023 17:25:32 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1696973131; bh=yoUQ6XcySzLsk4rDzopOlL6qXxCYbTJPrCWc+W3be+c=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=G36XlcQ2t6t6IEJwhxBuasGPlRwjPWVF0ymye48EzR7Kj7NdohKgYqoB/W4s6dx8z gujZZCUf0GLzBZv6CwgASKusFGOQIpAvb7a7YGOkhmA6aG4f0UYmrUUvyXsF465I4A Muh0FAEO92jN4gQAImCISSmvVRF9zuBDgrZBy152bk+5fd8PRvEpwMPwJb87otRiyf jEwjrss9APgh0edGDvWIDVKwPJrnyIj9n0PPylqags/IPXVyAFWnk8M7x0aMpZuwuZ u7kp6+hH0TuUGV9FeViTJgeSJeDrd7rS2UjBUC/4EhSGMOKR8UVPyhRKFjip1JLoUg zLAyQq2HjZRmg== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D121B100033; Tue, 10 Oct 2023 17:25:31 -0400 (EDT) Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BAC061201CB; Tue, 10 Oct 2023 17:25:31 -0400 (EDT) From: Stefan Monnier To: Jim Porter Subject: Re: bug#60845: 30.0.50; [PATCH] Add tests for Eshell interactive completion (and fix a bug in it) In-Reply-To: <5c5c40d0-34f4-34ff-6cdd-9a2852ee97b4@gmail.com> (Jim Porter's message of "Tue, 10 Oct 2023 13:07:50 -0700") Message-ID: References: <2b75d4d4-0533-2182-6da8-413391577bf5@gmail.com> <40d31b3d-d429-5a48-02bc-a3c1e4a1d903@gmail.com> <8f725450-1158-67de-7a0f-d550d867e084@gmail.com> <990abf69-d2f9-7582-c4dd-fd6bdebf04b3@gmail.com> <46c56cb6-deff-bc8f-7d29-9401b7d261b1@gmail.com> <488af1f4-f075-09e8-3b45-1d1a65266c68@gmail.com> <5c5c40d0-34f4-34ff-6cdd-9a2852ee97b4@gmail.com> Date: Tue, 10 Oct 2023 17:23:42 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.070 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60845-done Cc: 60845-done@debbugs.gnu.org, Daniel Mendler , Gregory Heytings , arstoffel@gmail.com, Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> Attached is a patch to revert the Emacs 29 workarounds. I *believe* I've >> fixed this on the Eshell side by always providing Pcomplete with the >> arguments in their string form. Could everyone try the patch out to make >> sure things still work? >> In particular, see the cases in the following bugs: bug#60464, bug#60021, >> and bug#59956. > > Since there have been no further comments in the last month, I've now merged > my patch to the master branch as 239db5d5162. If anyone sees any issues > resulting from this, feel free to back it out, file a bug, and/or let me > know directly. Thanks Jim, Stefan From unknown Sat Jun 14 03:51:24 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 08 Nov 2023 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator