GNU bug report logs - #60840
[PATCH 0/3] gnu: volctl: Update to 0.9.3.

Previous Next

Full log

View this message in rfc822 format

From: Sergiu Ivanov <sivanov <at> colimite.fr>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 60840 <at> debbugs.gnu.org
Subject: [bug#60840] [PATCH 0/3] gnu: volctl: Update to 0.9.3.
Date: Sat, 21 Jan 2023 23:20:31 +0100

[Message part 1 (text/plain, inline)]

Hi Maxim,

Thank you very much for the review!

And sorry for the delay: day job :D


Maxim Cournoyer <maxim.cournoyer <at> gmail.com> [2023-01-16T17:56:51+0100]:
> Hi Sergiu,
>
> Sergiu Ivanov <sivanov <at> colimite.fr> writes:
>
>>>From e0c69ddefe7367e4b4417db70c86eacbfc6e3eae Mon Sep 17 00:00:00 2001
>> From: Sergiu Ivanov <sivanov <at> colimite.fr>
>> Date: Sun, 4 Dec 2022 13:27:13 +0100
>> Subject: [PATCH 1/3] gnu: volctl: Make the synopsis line shorter.
>>
>> * gnu/packages/gtk.scm (volctl): Make the synopsis line shorter.
>
> I'd reword this as "Re-indent the synopsis line", or alternatively make
> it really shorter, perhaps dropping the last "for graphical
> applications" bit, which get repeated the description anyway.

I chose the second option and made the synopsis shorter as you suggest.

>>  gnu/packages/gtk.scm | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
>> index de82b9e55f..c8ae855cfa 100644
>> --- a/gnu/packages/gtk.scm
>> +++ b/gnu/packages/gtk.scm
>> @@ -33,6 +33,7 @@
>>  ;;; Copyright © 2022 Benjamin Slade <slade <at> lambda-y.net>
>>  ;;; Copyright © 2022 Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
>>  ;;; Copyright © 2022 Petr Hodina <phodina <at> protonmail.com>
>> +;;; Copyright © 2022 Sergiu Ivanov <sivanov <at> colimite.fr>
>
> When changes are not substantial (< 10 new additions/changes) they are
> not protected by copyright, so you can drop the above hunk.

Ah, good know!  I dropped the hunk.

-
Sergiu

[0001-gnu-volctl-Make-the-synopsis-line-shorter.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.