Subject: Re: bug#60838: [PATCH 0/8] Add datasette and python-sqlite-utils.

From: Maxim Cournoyer <[email-masked]>
Date: Tue, 21 Mar 2023 21:04:22 -0400

Hi,

Felix Gruber <[email-masked]> writes:

> * gnu/packages/python-xyz.scm (python-click-default-group-wheel): New
>   variable.
> ---
>  gnu/packages/python-xyz.scm | 26 +++++++++++++++++++++++++-
>  1 file changed, 25 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index c91561e787..1dbe9d611f 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -108,7 +108,7 @@
>  ;;; Copyright © 2021 Simon Streit <[email-masked]>
>  ;;; Copyright © 2021 Daniel Meißner <[email-masked]>
>  ;;; Copyright © 2021, 2022 Pradana Aumars <[email-masked]>
> -;;; Copyright © 2021, 2022 Felix Gruber <[email-masked]>
> +;;; Copyright © 2021, 2022, 2023 Felix Gruber <[email-masked]>
>  ;;; Copyright © 2021 Sébastien Lerique <[email-masked]>
>  ;;; Copyright © 2021 Raphaël Mélotte <[email-masked]>
>  ;;; Copyright © 2021 ZmnSCPxj <[email-masked]>
> @@ -14769,6 +14769,30 @@ (define-public python-click-default-group
>      (home-page "https://github.com/click-contrib/click-default-group")
>      (license license:bsd-3)))
>  
> +(define-public python-click-default-group-wheel
> +  ;; Fork of python-click-default-group used by sqlite-utils and datasette.
> +  ;; See https://github.com/click-contrib/click-default-group/issues/21
> +  (package
> +    (name "python-click-default-group-wheel")
> +    (version "1.2.2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (pypi-uri "click-default-group-wheel" version))
> +              (sha256
> +               (base32
> +                "0ivpdng2391v8afd5j1xdv9vbbr9iafbdh6h5shqhgn0j8ns83g9"))))
> +    (build-system python-build-system)
> +    (arguments
> +      '(#:tests? #f)) ; no tests in pypi package
> +    (propagated-inputs (list python-click))
> +    (home-page "https://github.com/sublee/click-default-group/")
> +    (synopsis
> +     "Extends click.Group to invoke a command without explicit subcommand name")

I'd try to make the synopsis read more like a synthesized version of
what this package *is*; it currently reads almost as a complete
sentence.  Perhaps something like: "Python extension for the
@code{click.Group} class".

> +    (description
> +      "This package provides click-default-group with an additional pure
> +Python wheel package, compatible with Pyodide.")

"additional pure Python wheel package" doesn't add mean/add much in my
opinion.  Based on the README.md content I'd use instead: "DefaultGroup
is a subclass of code{click.Group}, which invokes a default sub-command
instead of showing a help message when a sub-command is not passed."

-- 
Thanks,
Maxim