GNU bug report logs - #60837
[PATCH] gnu: Add emacs-auto-compile

Previous Next

Full log

Message #17 received at 60837 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 60837 <at> debbugs.gnu.org, Cayetano Santos <csantosb <at> inventati.org>
Subject: Re: bug#60837: [PATCH] gnu: Add emacs-auto-compile
Date: Mon, 16 Jan 2023 11:47:15 -0500

Hi,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> Am Montag, dem 16.01.2023 um 13:38 +0100 schrieb Cayetano Santos:
>> * gnu/packages/emacs-xyz.scm (emacs-auto-compile): New variable.
>> ---
>>  gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
>>  1 file changed, 22 insertions(+)
>> 
>> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
>> index 5f60d82ad5..ea97cb09a2 100644
>> --- a/gnu/packages/emacs-xyz.scm
>> +++ b/gnu/packages/emacs-xyz.scm
>> @@ -259,6 +259,28 @@ (define-module (gnu packages emacs-xyz)
>>  ;;; Emacs hacking.
>>  ;;;
>>  
>> +(define-public emacs-auto-compile
>> +  (package
>> +    (name "emacs-auto-compile")
>> +    (version "1.7.2")
>> +    (source (origin
>> +              (method git-fetch)
>> +              (uri (git-reference
>> +                    (url
>> "https://github.com/emacscollective/auto-compile.git")
>> +                    (commit version)))
>> +              (sha256
>> +               (base32
>> +               
>> "1njnyilv6lxnbvi6yrgzg6qjhf6vgh4fpag4hav1j45718y6kd31"))))
>> +    (build-system emacs-build-system)
>> +    (propagated-inputs (list emacs-compat emacs-packed))
>> +    (home-page "https://github.com/emacscollective/auto-compile")
>> +    (synopsis "Automatically compile Emacs Lisp libraries")
>> +    (description
>> +     "This package provides two minor modes which automatically
>> recompile Emacs Lisp
> Note how you're exceeding fill-column.
>> +source files. Together these modes guarantee that Emacs never loads 
> Use two spaces at the end of sentences.
>> outdated
>> +byte code files.")
>> +    (license license:gpl3+)))
>> +
> I also moved this before emacs-auto-sudoedit.  Placing packages
> directly at the start or end f files makes it mildly harder to rebase.
>
> The package appears to build fine with both emacs and emacs-minimal, so
> if there's no objection, I'll push this (with some fixes re the above
> points) on the 29th.

Make sure to use two spaces between sentences.  Other than that, LGTM
too, so feel free to push it already.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.