From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 15 09:13:39 2023 Received: (at submit) by debbugs.gnu.org; 15 Jan 2023 14:13:39 +0000 Received: from localhost ([127.0.0.1]:56421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pH3lS-0001VI-Kl for submit@debbugs.gnu.org; Sun, 15 Jan 2023 09:13:39 -0500 Received: from lists.gnu.org ([209.51.188.17]:58410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pH33h-00009i-Dp for submit@debbugs.gnu.org; Sun, 15 Jan 2023 08:28:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pH33f-0007CT-HC for bug-gnu-emacs@gnu.org; Sun, 15 Jan 2023 08:28:24 -0500 Received: from mail-vs1-xe2f.google.com ([2607:f8b0:4864:20::e2f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pH33d-0008Id-LN for bug-gnu-emacs@gnu.org; Sun, 15 Jan 2023 08:28:23 -0500 Received: by mail-vs1-xe2f.google.com with SMTP id 186so21386531vsz.13 for ; Sun, 15 Jan 2023 05:28:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=uRVXrtWruVhG7yLkTaqQzuq6zzTeafVQu+U86BkS9ag=; b=oO3ZMLwn7KErMMzfAaeEHegzDradiCegtxiaq7E8jFl13GfDL/VM6fY8PUj+GRcByU /a8ORAo+y917QvY/MHnRnJvw9a+5BrQlRUhi/vfls5b0q5X+oDckF/kNnlK++QlBTM5x EVIDE1ceNTCF44gX+ciVWLkimhVtpTIXKq0ecLfjFXfrTIqxXsQYDmYNYsXnQkwaWpi0 PNgWo/jKAUmfqsw26ZkLyvySwFdgUVc2oY5iy8GspXoCGkAVy1n2OfRHtAWFWjJpgUWU KyKFA7kfp4VYwAok4VNv5yH5/Be+aHfWIfjz5RtGP7WX/WJUI1XlB/buaKWWzc9ziDr3 p5fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=uRVXrtWruVhG7yLkTaqQzuq6zzTeafVQu+U86BkS9ag=; b=4ZYML0I3SSjGFMRGktOHRPBEzvNjWW80ScLPdb2L97zMa6ty0tz+gouM2jqyxZkG5j WkbKGZQ26S5YQI+uqRZ5EEBRm1p35K0dp2BXKt4Kl6EkH20meBxONoZ2BFEb7JyJBpSx lPh9m7UCF0OJlWfBE+TetrBfiHdd/XMAW/rebpSPhRA6w4AOMfAHB+TL6WK0yyyvybAz VCnn4A6OqHV8nuIG8ccto87NQZ7z956G/rhpcYtyzar8lky/oAQrFFDrrWoRFuSsc3y5 R0QWRTjIr3Q+pi6DLcnEod0NSajnRzbeOXvzaAzObX1n/OrJbReRKaR8r+MziKY307os Qm4g== X-Gm-Message-State: AFqh2kr7jzRyhLF19itr6OYAbWgUbg4aYTi0H9Z3a3CM0vckYAwDtDYm bqZ1uwkO+MDmNTA3CIohM01gAT2p47Y+6+4gVBgt4XEB X-Google-Smtp-Source: AMrXdXufQhjD63bWHhi9AUdFUmBn9MmV+bMp6RcrbmWI1LS0rl0xc+iQTubs2oPIi3z6IyQGX7QNqrNJyoCqWC6KLIU= X-Received: by 2002:a05:6102:819:b0:3b5:f9a:7fae with SMTP id g25-20020a056102081900b003b50f9a7faemr12010741vsb.81.1673789299520; Sun, 15 Jan 2023 05:28:19 -0800 (PST) MIME-Version: 1.0 From: Philippe Altherr Date: Sun, 15 Jan 2023 14:28:08 +0100 Message-ID: Subject: [PATCH] sh-script.el: Add support for Zsh's case branches ;|. To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="000000000000a0b7b405f24d70e3" Received-SPF: pass client-ip=2607:f8b0:4864:20::e2f; envelope-from=philippe.altherr@gmail.com; helo=mail-vs1-xe2f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 15 Jan 2023 09:13:36 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --000000000000a0b7b405f24d70e3 Content-Type: multipart/alternative; boundary="000000000000a0b7b205f24d70e1" --000000000000a0b7b205f24d70e1 Content-Type: text/plain; charset="UTF-8" In shell scripts, case branches traditionally end with ;;. Bash additionally supports case branches ending with ;& and ;;&. Zsh similarly supports case branches ending with ;& and ;|. Currently sh-script.el supports case branches ending with ;;, ;&, and ;;&, but not with ;|. The attached patch adds support for case branches ending with ;|. I have tested the patch by defining all the modified functions (sh-smie-sh-rules, sh-font-lock-paren) and constants (sh-smie-sh-grammar, sh-smie-rc-grammar, sh-smie--sh-operators, sh-smie--sh-operators-re, sh-smie--sh-operators-back-re) in my .emacs (in a (with-eval-after-load 'sh-script ...) statement). Here is an example indented without the patch: case $input in *a* ) echo A;; *b* ) echo B;& *c* ) echo C;;& *d* ) echo D;| *e* ) echo E;; esac and with the (simulated) patch: case $input in *a* ) echo A;; *b* ) echo B;& *c* ) echo C;;& *d* ) echo D;| *e* ) echo E;; esac The first change in the patch replaces an (eq (char-before) ?|) with (and (eq (char-before) ?|) (not (eq (char-before (1- (point))) ?\;))). It is needed to avoid confusing ;| tokens with plain | tokens. I wonder however whether there would be a cleaner way of expressing the same. The second change replaces a (looking-at ";[;&]\\|\\_ with (looking-at ";\\(?:;&?\\|[&|]\\)\\|\\_
In shell scripts, case branches traditionally end wit= h ;;. Bash additionally supports case branches ending with ;& and ;;&am= p;. Zsh similarly supports case branches ending with ;& and ;|. Current= ly sh-script.el supports case branches ending with ;;, ;&, and ;;&,= but not with ;|. The attached patch adds support for case branches ending = with ;|.

I have tested the patch by defining all t= he modified functions (sh-smie-sh-rules, sh-font-lock-paren) and constants = (sh-smie-sh-grammar, sh-smie-rc-grammar, sh-smie--sh-operators, sh-smie--sh= -operators-re, sh-smie--sh-operators-back-re) in my .emacs (in a=C2=A0(with= -eval-after-load 'sh-script ...) statement).

H= ere is an example indented without the patch:

case $inp= ut in
=C2=A0 =C2=A0 *a* ) echo A;;
=C2=A0 =C2=A0 *b* ) echo B;&=C2=A0 =C2=A0 *c* ) echo C;;&
=C2=A0 =C2=A0 *d* ) echo D;|
*e* = ) echo E;;
esac

and with the (simulated) patch:

case $input in
=C2=A0 =C2=A0 *a* ) echo A;;
= =C2=A0 =C2=A0 *b* ) echo B;&
=C2=A0 =C2=A0 *c* ) echo C;;&
= =C2=A0 =C2=A0 *d* ) echo D;|
=C2=A0 =C2=A0 *e* ) echo E;;
esac

The first change in the patch replaces=C2=A0an (eq (ch= ar-before) ?|)=C2=A0with (and (eq (char-before) ?|) (not (eq (char-befo= re (1- (point))) ?\;))). It is needed to avoid confusing ;| tokens with pla= in | tokens. I wonder however whether there would be a cleaner way of expre= ssing the same.

The second change replaces a=C2=A0= (l= ooking-at ";[;&]\\|\\_<in") with=C2=A0(looking-at &quo= t;;\\(?:;&?\\|[&|]\\)\\|\\_<in"). The original expression i= s looking for ;; and ;& tokens but not for ;;& tokens, which looks = like an oversight to me. That's why I have changed it to look for ;;, ;= &, ;| but also ;;&.

The other changes simp= ly add support for ;| where there was previously support for ;;, ;&, an= d ;;&.

Philippe

--000000000000a0b7b205f24d70e1-- --000000000000a0b7b405f24d70e3 Content-Type: application/x-patch; name="0001-Add-support-for-Zsh-s-case-branches.patch" Content-Disposition: attachment; filename="0001-Add-support-for-Zsh-s-case-branches.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lcxd7lyz0 RnJvbSA5YWUxNWUxODU3NzRlNWZiMzc2YzJlODczNDUzNDg1OTI3MjNhMmM5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBBbHRoZXJyIDxwaGlsaXBwZS5hbHRoZXJyQGdt YWlsLmNvbT4KRGF0ZTogU3VuLCAxNSBKYW4gMjAyMyAxMzozNzowMCArMDEwMApTdWJqZWN0OiBb UEFUQ0hdIEFkZCBzdXBwb3J0IGZvciBac2gncyBjYXNlIGJyYW5jaGVzIDt8LgoKLS0tCiBsaXNw L3Byb2dtb2Rlcy9zaC1zY3JpcHQuZWwgfCAxOCArKysrKysrKysrKy0tLS0tLS0KIDEgZmlsZSBj aGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xp c3AvcHJvZ21vZGVzL3NoLXNjcmlwdC5lbCBiL2xpc3AvcHJvZ21vZGVzL3NoLXNjcmlwdC5lbApp bmRleCAxN2MyMmZmNDc1Li4yOTgyYmIzZjM0IDEwMDY0NAotLS0gYS9saXNwL3Byb2dtb2Rlcy9z aC1zY3JpcHQuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvc2gtc2NyaXB0LmVsCkBAIC0xMDQyLDcg KzEwNDIsOSBAQCBzdWJzaGVsbHMgY2FuIG5lc3QuIgogICAgICAgICAgICAgICAgICAgICAgICA7 OyBNYXliZSB3ZSd2ZSBidW1wZWQgaW50byBhbiBlc2NhcGVkIG5ld2xpbmUuCiAgICAgICAgICAg ICAgICAgICAgICAgIChzaC1pcy1xdW90ZWQtcCAocG9pbnQpKSkKICAgICAgICAgICAgICAgICAo YmFja3dhcmQtY2hhciAxKSkKLSAgICAgICAgICAgICAgKHdoZW4gKGVxIChjaGFyLWJlZm9yZSkg P3wpCisgICAgICAgICAgICAgICh3aGVuIChhbmQKKyAgICAgICAgICAgICAgICAgICAgIChlcSAo Y2hhci1iZWZvcmUpID98KQorICAgICAgICAgICAgICAgICAgICAgKG5vdCAoZXEgKGNoYXItYmVm b3JlICgxLSAocG9pbnQpKSkgP1w7KSkpCiAgICAgICAgICAgICAgICAgKGJhY2t3YXJkLWNoYXIg MSkgdCkpKQogICAgICAgICAoYW5kICg+IChwb2ludCkgKDErIChwb2ludC1taW4pKSkKICAgICAg ICAgICAgICAocHJvZ24gKGJhY2t3YXJkLWNoYXIgMikKQEAgLTEwNTMsNyArMTA1NSw3IEBAIHN1 YnNoZWxscyBjYW4gbmVzdC4iCiAgICAgICAgICAgICAgICAgICAgIDs7IGEgbm9ybWFsIGNvbW1h bmQgcmF0aGVyIHRoYW4gdGhlIHJlYWwgYGluJyBrZXl3b3JkLgogICAgICAgICAgICAgICAgICAg ICA7OyBJLmUuIHdlIHNob3VsZCBsb29rIGJhY2sgdG8gdHJ5IGFuZCBmaW5kIHRoZQogICAgICAg ICAgICAgICAgICAgICA7OyBjb3JyZXNwb25kaW5nIGBjYXNlJy4KLSAgICAgICAgICAgICAgICAg ICAgKGFuZCAobG9va2luZy1hdCAiO1s7Jl1cXHxcXF88aW4iKQorICAgICAgICAgICAgICAgICAg ICAoYW5kIChsb29raW5nLWF0ICI7XFwoPzo7Jj9cXHxbJnxdXFwpXFx8XFxfPGluIikKICAgICAg ICAgICAgICAgICAgICAgICAgICA7OyAiOzsgZXNhYyApIiBpcyBhIGNhc2UgdGhhdCBsb29rcwog ICAgICAgICAgICAgICAgICAgICAgICAgIDs7IGxpa2UgYSBjYXNlLXBhdHRlcm4gYnV0IGl0J3Mg cmVhbGx5IGp1c3QgYSBjbG9zZQogICAgICAgICAgICAgICAgICAgICAgICAgIDs7IHBhcmVuIGFm dGVyIGEgY2FzZSBzdGF0ZW1lbnQuICBJLmUuIGlmIHdlIHNraXBwZWQKQEAgLTE3ODQsOCArMTc4 Niw5IEBAIGJlZm9yZSB0aGUgbmV3bGluZSBhbmQgaW4gdGhhdCBjYXNlIHBvaW50IHNob3VsZCBi ZSBqdXN0IGJlZm9yZSB0aGUgdG9rZW4uIgogICAgICAgKHBhdHRlcm4gKHJwYXR0ZXJuKSAoImNh c2UtKCIgcnBhdHRlcm4pKQogICAgICAgKGJyYW5jaGVzIChicmFuY2hlcyAiOzsiIGJyYW5jaGVz KQogICAgICAgICAgICAgICAgIChicmFuY2hlcyAiOyYiIGJyYW5jaGVzKSAoYnJhbmNoZXMgIjs7 JiIgYnJhbmNoZXMpIDtiYXNoLgorICAgICAgICAgICAgICAgIChicmFuY2hlcyAiO3wiIGJyYW5j aGVzKSA7enNoLgogICAgICAgICAgICAgICAgIChwYXR0ZXJuICJjYXNlLSkiIGNtZCkpKQotICAg ICcoKGFzc29jICI7OyIgIjsmIiAiOzsmIikpCisgICAgJygoYXNzb2MgIjs7IiAiOyYiICI7OyYi ICI7fCIpKQogICAgICcoKGFzc29jICI7IiAiJiIpIChhc3NvYyAiJiYiICJ8fCIpIChhc3NvYyAi fCIgInwmIikpKSkpCiAKIChkZWZjb25zdCBzaC1zbWllLS1zaC1vcGVyYXRvcnMKQEAgLTIwNTUs MTEgKzIwNTgsMTEgQEAgTWF5IHJldHVybiBuaWwgaWYgdGhlIGxpbmUgc2hvdWxkIG5vdCBiZSB0 cmVhdGVkIGFzIGNvbnRpbnVlZC4iCiAJIGAoY29sdW1uIC4gLChzbWllLWluZGVudC12aXJ0dWFs KSkpKSkpCiAgICAgOzsgRklYTUU6IE1heWJlIHRoaXMgaGFuZGxpbmcgb2YgOzsgc2hvdWxkIGJl IG1hZGUgaW50bwogICAgIDs7IGEgc21pZS1ydWxlLXRlcm1pbmF0b3IgZnVuY3Rpb24gdGhhdCB0 YWtlcyB0aGUgc3Vic3RpdHV0ZSAiOyIgYXMgYXJnLgotICAgIChgKDpiZWZvcmUgLiAsKG9yICI7 OyIgIjsmIiAiOzsmIikpCi0gICAgIChpZiAoYW5kIChzbWllLXJ1bGUtYm9scCkgKGxvb2tpbmct YXQgIjs7PyY/WyBcdF0qXFwoI1xcfCRcXCkiKSkKKyAgICAoYCg6YmVmb3JlIC4gLChvciAiOzsi ICI7JiIgIjs7JiIgIjt8IikpCisgICAgIChpZiAoYW5kIChzbWllLXJ1bGUtYm9scCkgKGxvb2tp bmctYXQgIjtcXCg/OjsmP1xcfFsmfF1cXCk/WyBcdF0qXFwoI1xcfCRcXCkiKSkKICAgICAgICAg IChjb25zICdjb2x1bW4gKHNtaWUtaW5kZW50LWtleXdvcmQgIjsiKSkKICAgICAgICAoc21pZS1y dWxlLXNlcGFyYXRvciBraW5kKSkpCi0gICAgKGAoOmFmdGVyIC4gLChvciAiOzsiICI7JiIgIjs7 JiIpKQorICAgIChgKDphZnRlciAuICwob3IgIjs7IiAiOyYiICI7OyYiICI7fCIpKQogICAgICAo d2l0aC1kZW1vdGVkLWVycm9ycyAiU01JRSBydWxlIGVycm9yOiAlUyIKICAgICAgICAoc21pZS1i YWNrd2FyZC1zZXhwIHRva2VuKQogICAgICAgIChjb25zICdjb2x1bW4KQEAgLTIxNDgsOCArMjE1 MSw5IEBAIE1heSByZXR1cm4gbmlsIGlmIHRoZSBsaW5lIHNob3VsZCBub3QgYmUgdHJlYXRlZCBh cyBjb250aW51ZWQuIgogICAgICAgKHBhdHRlcm4gKHBhdHRlcm4gInwiIHBhdHRlcm4pKQogICAg ICAgKGJyYW5jaGVzIChicmFuY2hlcyAiOzsiIGJyYW5jaGVzKQogICAgICAgICAgICAgICAgIChi cmFuY2hlcyAiOyYiIGJyYW5jaGVzKSAoYnJhbmNoZXMgIjs7JiIgYnJhbmNoZXMpIDtiYXNoLgor ICAgICAgICAgICAgICAgIChicmFuY2hlcyAiO3wiIGJyYW5jaGVzKSA7enNoLgogICAgICAgICAg ICAgICAgIChwYXR0ZXJuICJjYXNlLSkiIGNtZCkpKQotICAgICcoKGFzc29jICI7OyIgIjsmIiAi OzsmIikpCisgICAgJygoYXNzb2MgIjs7IiAiOyYiICI7OyYiICI7fCIpKQogICAgICcoKGFzc29j ICJjYXNlIikgKGFzc29jICI7IiAiJiIpIChhc3NvYyAiJiYiICJ8fCIpIChhc3NvYyAifCIgInwm IikpKSkpCiAKIChkZWZ1biBzaC1zbWllLS1yYy1hZnRlci1zcGVjaWFsLWFyZy1wICgpCi0tIAoy LjM5LjAKCg== --000000000000a0b7b405f24d70e3-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 21 02:33:18 2023 Received: (at 60833) by debbugs.gnu.org; 21 Jan 2023 07:33:18 +0000 Received: from localhost ([127.0.0.1]:47850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJ8NK-0001HL-He for submit@debbugs.gnu.org; Sat, 21 Jan 2023 02:33:18 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJ8NI-0001H7-9p for 60833@debbugs.gnu.org; Sat, 21 Jan 2023 02:33:16 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJ8NC-000147-K7; Sat, 21 Jan 2023 02:33:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=v2/4MJgpIy9r9bNYogHi1fh6A4KivYp9tyhwE7HoZBU=; b=iDtda68g6Z2o FksT2aZs5zcJbIm+PPw1DKMH4N+1ZUdBpSrBxletPISKEpYhsjn87qigU/COdnEthcen4P94tmNw6 P0Cwk5t+9Ooa69bXvg3ghXYFRtejXm/7esXxU7fDgoXDNXvMdFEGAZqNAZSfLfXtXMtAXzwr2eVVO Y7yuI2DKnsaOn3r/vi/n8TAyDlt9xSUbS9/ra96rquJBgEFDgG3C0lLSp4VMHcDsT/6jzMGJ8N12N fMPxYcBEJE336jfiiR2jdQ58/ZbyXYBwkYZRlRrFhdIXHj41QemyxEtVIgDVEaZ++vW1cLZ4+78UJ yMpxCBYalZ9wW50vXSfXGQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJ8NB-00052Q-QV; Sat, 21 Jan 2023 02:33:10 -0500 Date: Sat, 21 Jan 2023 09:33:12 +0200 Message-Id: <837cxgmjev.fsf@gnu.org> From: Eli Zaretskii To: Philippe Altherr In-Reply-To: (message from Philippe Altherr on Sun, 15 Jan 2023 14:28:08 +0100) Subject: Re: bug#60833: [PATCH] sh-script.el: Add support for Zsh's case branches ; |. References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60833 Cc: 60833@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philippe Altherr > Date: Sun, 15 Jan 2023 14:28:08 +0100 > > In shell scripts, case branches traditionally end with ;;. Bash additionally supports case branches ending with > ;& and ;;&. Zsh similarly supports case branches ending with ;& and ;|. Currently sh-script.el supports case > branches ending with ;;, ;&, and ;;&, but not with ;|. The attached patch adds support for case branches > ending with ;|. > > I have tested the patch by defining all the modified functions (sh-smie-sh-rules, sh-font-lock-paren) and > constants (sh-smie-sh-grammar, sh-smie-rc-grammar, sh-smie--sh-operators, sh-smie--sh-operators-re, > sh-smie--sh-operators-back-re) in my .emacs (in a (with-eval-after-load 'sh-script ...) statement). > > Here is an example indented without the patch: > > case $input in > *a* ) echo A;; > *b* ) echo B;& > *c* ) echo C;;& > *d* ) echo D;| > *e* ) echo E;; > esac > > and with the (simulated) patch: > > case $input in > *a* ) echo A;; > *b* ) echo B;& > *c* ) echo C;;& > *d* ) echo D;| > *e* ) echo E;; > esac Thanks. First, would it be possible to add tests for these situations? And second, your contributions (this and the other one) are larger than we can accept without your assigning the copyright to the FSF. Would you like to start your legal paperwork at this time, so that we could accept the changes after it is completed? If so, I will send you the form to fill. Thanks again for your interest in Emacs. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 23 00:52:27 2023 Received: (at 60833) by debbugs.gnu.org; 23 Jan 2023 05:52:27 +0000 Received: from localhost ([127.0.0.1]:53067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJpko-0000Pc-Po for submit@debbugs.gnu.org; Mon, 23 Jan 2023 00:52:27 -0500 Received: from mail-vs1-f50.google.com ([209.85.217.50]:37808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJoDR-000666-Ka for 60833@debbugs.gnu.org; Sun, 22 Jan 2023 23:13:58 -0500 Received: by mail-vs1-f50.google.com with SMTP id k4so11619374vsc.4 for <60833@debbugs.gnu.org>; Sun, 22 Jan 2023 20:13:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=I1c42Hy/ANFCvUsrVEEU+h54g4yzMeSLkUiqEaHyHto=; b=CIqn3HMVgWgXEuhY36HIbbdDIzu8p2aDu72agsC5VQakDr45BW6YEVd6YLZ+XmZOR2 vyBtw3xDsz55oqcQ9Tw6Vw4ZzVBqboqv63uf9Jk5/SS3V8paU9h6WvkXIP6HuXjpMvV9 M5Ntp8mHVHmR0TnO/tOXsCn/SMwLeR20dvtAm8vEtRtp3ErdNMmyMGwkNOhXRFGONnUq 0696+aFin5VlFm1FQlOm0okil8xXSEb7LDjfZJGqEGNDe7XSG/NMoHxv1UUnH3gaVLQs +GqGJm8oPLwatHKJJk00IuoiSiVKLI1Y6jcygEGLmtAmC3vs91QMBoAy8iaqVDOTC3nV d0kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=I1c42Hy/ANFCvUsrVEEU+h54g4yzMeSLkUiqEaHyHto=; b=KjSFfQuwEras3Y/PsMwr7fQHhZwmkLP7eKtrMmITo077FL4aedKll/1OT8RG4F3g8/ 9vQyhOclhtRayr6pc45DW+vzSPeflDQBn8vN6B2WEjeGWuMtZVG2W9a3BJXj4y75k9Dn HPWDuEE62I0tZm7rispv0pautdv3JymLWSOIOtSGm+BwHTwiHSd0qrn/AwSIu9zPzyl+ Gur5VWlABp0FHaXd9vaQRirufKEvx/uAC8CK8LdMibTPT4S/iKtjmz6kMLf5Y8ly2/Dd wipmfh2gFg9WOGqO6sp2/+rgKIp3MTJ+6KHaGitR7uuyRfUZMzYb9EDJT8hJ/AAzyGXN FHAw== X-Gm-Message-State: AFqh2krH3YKnRnoHuA44jV4gkHcVcWdPIzGoiFBS5tCIE9XyF2zNXFUs MEnqxc8re0KhsaNWBLjpR7e7wGKUB6hinDEJtxdG4WDC X-Google-Smtp-Source: AMrXdXsiJ7BSs3bhPsdCYTL5LpesbPsJ9mdcUC/Aoi93sApvrFpygeoCO7poJ7//p6eSm2/fUYDJTve73Yqb0ptYEc4= X-Received: by 2002:a05:6102:274b:b0:3cf:7a92:b1f with SMTP id p11-20020a056102274b00b003cf7a920b1fmr2992444vsu.67.1674447227949; Sun, 22 Jan 2023 20:13:47 -0800 (PST) MIME-Version: 1.0 References: <837cxgmjev.fsf@gnu.org> In-Reply-To: <837cxgmjev.fsf@gnu.org> From: Philippe Altherr Date: Mon, 23 Jan 2023 05:13:36 +0100 Message-ID: Subject: Re: bug#60833: [PATCH] sh-script.el: Add support for Zsh's case branches ; |. To: Eli Zaretskii Content-Type: multipart/mixed; boundary="00000000000038303a05f2e6a012" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60833 X-Mailman-Approved-At: Mon, 23 Jan 2023 00:52:20 -0500 Cc: 60833@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000038303a05f2e6a012 Content-Type: multipart/alternative; boundary="00000000000038303805f2e6a010" --00000000000038303805f2e6a010 Content-Type: text/plain; charset="UTF-8" > > Thanks. First, would it be possible to add tests for these > situations? > I added a test case in the attached updated patch. I wasn't able to test it though. Please make sure it works as expected. > And second, your contributions (this and the other one) are larger > than we can accept without your assigning the copyright to the FSF. > Would you like to start your legal paperwork at this time, so that we > could accept the changes after it is completed? If so, I will send > you the form to fill. > Sure --00000000000038303805f2e6a010 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks.=C2=A0 First, would it be possible to add tests f= or these
situations?

I added a test case in the = attached updated patch. I wasn't able to test it though. Please make su= re it works as expected.
=C2=A0
And second, your contributions (this and the other one) are larger
than we can accept without your assigning the copyright to the FSF.
Would you like to start your legal paperwork at this time, so that we
could accept the changes after it is completed?=C2=A0 If so, I will send you the form to fill.

Sure
--00000000000038303805f2e6a010-- --00000000000038303a05f2e6a012 Content-Type: application/octet-stream; name="0001-Add-support-for-Zsh-s-case-branches.patch" Content-Disposition: attachment; filename="0001-Add-support-for-Zsh-s-case-branches.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_ld8akcfb0 RnJvbSA3ZDM5NjM5ZjBjMWNkYWU0Njg3NTBiMDEyYTc3M2I2YjU0OTc1M2FjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBBbHRoZXJyIDxwaGlsaXBwZS5hbHRoZXJyQGdt YWlsLmNvbT4KRGF0ZTogU3VuLCAxNSBKYW4gMjAyMyAxMzozNzowMCArMDEwMApTdWJqZWN0OiBb UEFUQ0hdIEFkZCBzdXBwb3J0IGZvciBac2gncyBjYXNlIGJyYW5jaGVzIDt8LgoKLS0tCiBsaXNw L3Byb2dtb2Rlcy9zaC1zY3JpcHQuZWwgfCAxOCArKysrKysrKysrKy0tLS0tLS0KIHRlc3QvbWFu dWFsL2luZGVudC9zaGVsbC5zaCB8ICAxICsKIDIgZmlsZXMgY2hhbmdlZCwgMTIgaW5zZXJ0aW9u cygrKSwgNyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL3Byb2dtb2Rlcy9zaC1zY3Jp cHQuZWwgYi9saXNwL3Byb2dtb2Rlcy9zaC1zY3JpcHQuZWwKaW5kZXggMTdjMjJmZjQ3NS4uMjk4 MmJiM2YzNCAxMDA2NDQKLS0tIGEvbGlzcC9wcm9nbW9kZXMvc2gtc2NyaXB0LmVsCisrKyBiL2xp c3AvcHJvZ21vZGVzL3NoLXNjcmlwdC5lbApAQCAtMTA0Miw3ICsxMDQyLDkgQEAgc2gtZm9udC1s b2NrLXBhcmVuCiAgICAgICAgICAgICAgICAgICAgICAgIDs7IE1heWJlIHdlJ3ZlIGJ1bXBlZCBp bnRvIGFuIGVzY2FwZWQgbmV3bGluZS4KICAgICAgICAgICAgICAgICAgICAgICAgKHNoLWlzLXF1 b3RlZC1wIChwb2ludCkpKQogICAgICAgICAgICAgICAgIChiYWNrd2FyZC1jaGFyIDEpKQotICAg ICAgICAgICAgICAod2hlbiAoZXEgKGNoYXItYmVmb3JlKSA/fCkKKyAgICAgICAgICAgICAgKHdo ZW4gKGFuZAorICAgICAgICAgICAgICAgICAgICAgKGVxIChjaGFyLWJlZm9yZSkgP3wpCisgICAg ICAgICAgICAgICAgICAgICAobm90IChlcSAoY2hhci1iZWZvcmUgKDEtIChwb2ludCkpKSA/XDsp KSkKICAgICAgICAgICAgICAgICAoYmFja3dhcmQtY2hhciAxKSB0KSkpCiAgICAgICAgIChhbmQg KD4gKHBvaW50KSAoMSsgKHBvaW50LW1pbikpKQogICAgICAgICAgICAgIChwcm9nbiAoYmFja3dh cmQtY2hhciAyKQpAQCAtMTA1Myw3ICsxMDU1LDcgQEAgc2gtZm9udC1sb2NrLXBhcmVuCiAgICAg ICAgICAgICAgICAgICAgIDs7IGEgbm9ybWFsIGNvbW1hbmQgcmF0aGVyIHRoYW4gdGhlIHJlYWwg YGluJyBrZXl3b3JkLgogICAgICAgICAgICAgICAgICAgICA7OyBJLmUuIHdlIHNob3VsZCBsb29r IGJhY2sgdG8gdHJ5IGFuZCBmaW5kIHRoZQogICAgICAgICAgICAgICAgICAgICA7OyBjb3JyZXNw b25kaW5nIGBjYXNlJy4KLSAgICAgICAgICAgICAgICAgICAgKGFuZCAobG9va2luZy1hdCAiO1s7 Jl1cXHxcXF88aW4iKQorICAgICAgICAgICAgICAgICAgICAoYW5kIChsb29raW5nLWF0ICI7XFwo Pzo7Jj9cXHxbJnxdXFwpXFx8XFxfPGluIikKICAgICAgICAgICAgICAgICAgICAgICAgICA7OyAi OzsgZXNhYyApIiBpcyBhIGNhc2UgdGhhdCBsb29rcwogICAgICAgICAgICAgICAgICAgICAgICAg IDs7IGxpa2UgYSBjYXNlLXBhdHRlcm4gYnV0IGl0J3MgcmVhbGx5IGp1c3QgYSBjbG9zZQogICAg ICAgICAgICAgICAgICAgICAgICAgIDs7IHBhcmVuIGFmdGVyIGEgY2FzZSBzdGF0ZW1lbnQuICBJ LmUuIGlmIHdlIHNraXBwZWQKQEAgLTE3ODQsOCArMTc4Niw5IEBAIHNoLXNtaWUtc2gtZ3JhbW1h cgogICAgICAgKHBhdHRlcm4gKHJwYXR0ZXJuKSAoImNhc2UtKCIgcnBhdHRlcm4pKQogICAgICAg KGJyYW5jaGVzIChicmFuY2hlcyAiOzsiIGJyYW5jaGVzKQogICAgICAgICAgICAgICAgIChicmFu Y2hlcyAiOyYiIGJyYW5jaGVzKSAoYnJhbmNoZXMgIjs7JiIgYnJhbmNoZXMpIDtiYXNoLgorICAg ICAgICAgICAgICAgIChicmFuY2hlcyAiO3wiIGJyYW5jaGVzKSA7enNoLgogICAgICAgICAgICAg ICAgIChwYXR0ZXJuICJjYXNlLSkiIGNtZCkpKQotICAgICcoKGFzc29jICI7OyIgIjsmIiAiOzsm IikpCisgICAgJygoYXNzb2MgIjs7IiAiOyYiICI7OyYiICI7fCIpKQogICAgICcoKGFzc29jICI7 IiAiJiIpIChhc3NvYyAiJiYiICJ8fCIpIChhc3NvYyAifCIgInwmIikpKSkpCiAKIChkZWZjb25z dCBzaC1zbWllLS1zaC1vcGVyYXRvcnMKQEAgLTIwNTUsMTEgKzIwNTgsMTEgQEAgc2gtc21pZS1z aC1ydWxlcwogCSBgKGNvbHVtbiAuICwoc21pZS1pbmRlbnQtdmlydHVhbCkpKSkpKQogICAgIDs7 IEZJWE1FOiBNYXliZSB0aGlzIGhhbmRsaW5nIG9mIDs7IHNob3VsZCBiZSBtYWRlIGludG8KICAg ICA7OyBhIHNtaWUtcnVsZS10ZXJtaW5hdG9yIGZ1bmN0aW9uIHRoYXQgdGFrZXMgdGhlIHN1YnN0 aXR1dGUgIjsiIGFzIGFyZy4KLSAgICAoYCg6YmVmb3JlIC4gLChvciAiOzsiICI7JiIgIjs7JiIp KQotICAgICAoaWYgKGFuZCAoc21pZS1ydWxlLWJvbHApIChsb29raW5nLWF0ICI7Oz8mP1sgXHRd KlxcKCNcXHwkXFwpIikpCisgICAgKGAoOmJlZm9yZSAuICwob3IgIjs7IiAiOyYiICI7OyYiICI7 fCIpKQorICAgICAoaWYgKGFuZCAoc21pZS1ydWxlLWJvbHApIChsb29raW5nLWF0ICI7XFwoPzo7 Jj9cXHxbJnxdXFwpP1sgXHRdKlxcKCNcXHwkXFwpIikpCiAgICAgICAgICAoY29ucyAnY29sdW1u IChzbWllLWluZGVudC1rZXl3b3JkICI7IikpCiAgICAgICAgKHNtaWUtcnVsZS1zZXBhcmF0b3Ig a2luZCkpKQotICAgIChgKDphZnRlciAuICwob3IgIjs7IiAiOyYiICI7OyYiKSkKKyAgICAoYCg6 YWZ0ZXIgLiAsKG9yICI7OyIgIjsmIiAiOzsmIiAiO3wiKSkKICAgICAgKHdpdGgtZGVtb3RlZC1l cnJvcnMgIlNNSUUgcnVsZSBlcnJvcjogJVMiCiAgICAgICAgKHNtaWUtYmFja3dhcmQtc2V4cCB0 b2tlbikKICAgICAgICAoY29ucyAnY29sdW1uCkBAIC0yMTQ4LDggKzIxNTEsOSBAQCBzaC1zbWll LXJjLWdyYW1tYXIKICAgICAgIChwYXR0ZXJuIChwYXR0ZXJuICJ8IiBwYXR0ZXJuKSkKICAgICAg IChicmFuY2hlcyAoYnJhbmNoZXMgIjs7IiBicmFuY2hlcykKICAgICAgICAgICAgICAgICAoYnJh bmNoZXMgIjsmIiBicmFuY2hlcykgKGJyYW5jaGVzICI7OyYiIGJyYW5jaGVzKSA7YmFzaC4KKyAg ICAgICAgICAgICAgICAoYnJhbmNoZXMgIjt8IiBicmFuY2hlcykgO3pzaC4KICAgICAgICAgICAg ICAgICAocGF0dGVybiAiY2FzZS0pIiBjbWQpKSkKLSAgICAnKChhc3NvYyAiOzsiICI7JiIgIjs7 JiIpKQorICAgICcoKGFzc29jICI7OyIgIjsmIiAiOzsmIiAiO3wiKSkKICAgICAnKChhc3NvYyAi Y2FzZSIpIChhc3NvYyAiOyIgIiYiKSAoYXNzb2MgIiYmIiAifHwiKSAoYXNzb2MgInwiICJ8JiIp KSkpKQogCiAoZGVmdW4gc2gtc21pZS0tcmMtYWZ0ZXItc3BlY2lhbC1hcmctcCAoKQpkaWZmIC0t Z2l0IGEvdGVzdC9tYW51YWwvaW5kZW50L3NoZWxsLnNoIGIvdGVzdC9tYW51YWwvaW5kZW50L3No ZWxsLnNoCmluZGV4IGJkNGE3NGY3MDUuLjViM2ZiMGU2NmYgMTAwNzU1Ci0tLSBhL3Rlc3QvbWFu dWFsL2luZGVudC9zaGVsbC5zaAorKysgYi90ZXN0L21hbnVhbC9pbmRlbnQvc2hlbGwuc2gKQEAg LTE0MCw2ICsxNDAsNyBAQCAgICAgYmFyICgpCiAgICAgICAgIDUpIGhlbGxvIDs7CiAgICAgICAg IDQpIGhlbGxvIDsmCiAgICAgICAgIDQpIGhlbGxvIDs7JgorICAgICAgICA0KSBoZWxsbyA7fAog ICAgICAgICA1KSBoZWxsbyA7OwogICAgICAgICA1KSBoZWxsbyA7OwogICAgIGVzYWMKLS0gCjIu MzkuMQoK --00000000000038303a05f2e6a012-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 23 10:16:47 2023 Received: (at 60833) by debbugs.gnu.org; 23 Jan 2023 15:16:47 +0000 Received: from localhost ([127.0.0.1]:55078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJyYw-0003wR-Ui for submit@debbugs.gnu.org; Mon, 23 Jan 2023 10:16:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39804) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJyYv-0003wF-82 for 60833@debbugs.gnu.org; Mon, 23 Jan 2023 10:16:46 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJyYq-0008Gi-1J; Mon, 23 Jan 2023 10:16:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=hvab9mJb65OXNj1GZP76jx7DDdtx4cHEopsq3kRBNSI=; b=qpaoMw/v7GlX rZhc2IaZoCYGFKGl//oZ03pDzG4bQ77xdfTwTgYhw6rq98G0uCnjhkJxjsq19m3e8FYvbMqJURWmC qme9MlLLbWkPEV/PoxCiOte3GZmwHReCj5S443HJ1K+Isa4FNs5GeLYCL07XF+uVMuv3qjxWdhiJl iYj07ipnPCpVSI+XJcA08OC3k2kdT8Ltb2FIFGEZofjUB0mUFGAqA9RDIo8j1Mi6xkb5aQKJlqAhD aLrluyel5o4DRStGThMjxwodvev4OBJ7g1VWiognnvViZQBxSCu+Jb5S1U9R/TIiIucGPnoM+fS+I eD8RFhgs7zu5i5o+pL8/CQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJyYo-0004JB-Dw; Mon, 23 Jan 2023 10:16:39 -0500 Date: Mon, 23 Jan 2023 17:16:46 +0200 Message-Id: <83o7qpi8m9.fsf@gnu.org> From: Eli Zaretskii To: Philippe Altherr In-Reply-To: (message from Philippe Altherr on Mon, 23 Jan 2023 05:13:36 +0100) Subject: Re: bug#60833: [PATCH] sh-script.el: Add support for Zsh's case branches ; |. References: <837cxgmjev.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60833 Cc: 60833@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philippe Altherr > Date: Mon, 23 Jan 2023 05:13:36 +0100 > Cc: 60833@debbugs.gnu.org > > And second, your contributions (this and the other one) are larger > than we can accept without your assigning the copyright to the FSF. > Would you like to start your legal paperwork at this time, so that we > could accept the changes after it is completed? If so, I will send > you the form to fill. > > Sure Form sent off-list. (I will review the patch soon.) From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 17 10:21:18 2023 Received: (at 60833) by debbugs.gnu.org; 17 Feb 2023 15:21:18 +0000 Received: from localhost ([127.0.0.1]:41027 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pT2Y2-0004uw-3x for submit@debbugs.gnu.org; Fri, 17 Feb 2023 10:21:18 -0500 Received: from mail-vs1-f42.google.com ([209.85.217.42]:35744) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pT2Y1-0004uk-2A for 60833@debbugs.gnu.org; Fri, 17 Feb 2023 10:21:17 -0500 Received: by mail-vs1-f42.google.com with SMTP id i125so245821vsi.2 for <60833@debbugs.gnu.org>; Fri, 17 Feb 2023 07:21:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1676647271; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=IupcVV1U354amIzz6zHFeDyxYqc4r5Sy8V0ghaHeD5A=; b=p+6bHy2Qc8c9i0F4JfhZ8xG2ALFFBTbNqSDjEg5bKwfELLiHfuVYvI9JPflayd60pQ Lpm/xBnN6Rw0IANnwGjejsuTx/vFlPjxncC87aZD8CPL3bQa+JkKzpdazD+VIBUZdNeN 5vi27bhIJ8cYjn1A9pM6dfiA/XxHhr48wOfBG2J9KHEQ5zCVR2jW5Jls4rFmLY0WwyCt zxnpiBxDSb0m1Wn80QSZ7LoExxcliM7dqwePxsrRUseiY5kOue5A6twuPdI3GVqPYGpa ka7/XQu9P3rgevzGb4DglPvZYPkgTZh8An4vDlO1E0bn5vjSPgadPeQKN4cKKNVv2V3u n79g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1676647271; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IupcVV1U354amIzz6zHFeDyxYqc4r5Sy8V0ghaHeD5A=; b=PuwsB8vcnxdd6AI7LnO9JAjQ77Iobqh14MLGvOBhEiQMbotA2wuFQcc4pwhJOVW/Od yt0vYcRh4NNrjA1oon0+l0lKyz9VkQ3NXPVriSFE/43x0/j5MuwUAlSJYi6sRhZMHWG5 FvojZz1NExnLEaJP5iiO58Gzke9jd47IeyhFUnL4+XPBWxrha9Qz9XBjAtOyYKT+Welm LPRNK0oVdYTk4FkazClBE7oSQDtqjJ62TCywTPWz8hMrEl6/Kj0OQO/KuYlgdsi4B1K8 gRgvLV0bMd6HjH+skDnbsltxYXR7S50NQIC7aqKg/PgqM7EomoJxOm2hMLer8um/p64K sVBw== X-Gm-Message-State: AO0yUKUy7OAY4xavrngnryYjSKEUiwtp15fIKaU88J+AWDMyglQqSI7e yWy6mm3YR66uVqfkjVvnhqOmCs9FmzbsCjhGBSwil8gRzks= X-Google-Smtp-Source: AK7set9UlBjC8RBm0hJ6xnbEco2nau77lPx+eSsisgV+2Xpj69Q9g+PUVfGVOBOdHR+9AfgCscsfgMlhDiYW7gOKNrU= X-Received: by 2002:a67:fbc3:0:b0:411:7639:78f with SMTP id o3-20020a67fbc3000000b004117639078fmr72096vsr.16.1676647270785; Fri, 17 Feb 2023 07:21:10 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Philippe Altherr Date: Fri, 17 Feb 2023 16:20:59 +0100 Message-ID: Subject: Re: bug#60833: Acknowledgement ([PATCH] sh-script.el: Add support for Zsh's case branches ;|.) To: 60833@debbugs.gnu.org Content-Type: multipart/mixed; boundary="000000000000fdd35005f4e6dcb1" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60833 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000fdd35005f4e6dcb1 Content-Type: multipart/alternative; boundary="000000000000fdd34e05f4e6dcaf" --000000000000fdd34e05f4e6dcaf Content-Type: text/plain; charset="UTF-8" Here is an updated patch against the current master branch. On Sun, Jan 15, 2023 at 3:14 PM GNU bug Tracking System < help-debbugs@gnu.org> wrote: > Thank you for filing a new bug report with debbugs.gnu.org. > > This is an automatically generated reply to let you know your message > has been received. > > Your message is being forwarded to the package maintainers and other > interested parties for their attention; they will reply in due course. > > Your message has been sent to the package maintainer(s): > bug-gnu-emacs@gnu.org > > If you wish to submit further information on this problem, please > send it to 60833@debbugs.gnu.org. > > Please do not send mail to help-debbugs@gnu.org unless you wish > to report a problem with the Bug-tracking system. > > -- > 60833: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60833 > GNU Bug Tracking System > Contact help-debbugs@gnu.org with problems > --000000000000fdd34e05f4e6dcaf Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Here is an updated patch=C2=A0against the current master b= ranch.

On Sun, Jan 15, 2023 at 3:14 PM GNU bug Tracking System <help-debbugs@gnu.org> wrote:
Thank you for filing a= new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
=C2=A0bug-gnu-em= acs@gnu.org

If you wish to submit further information on this problem, please
send it to 60833= @debbugs.gnu.org.

Please do not send mail to help-debbugs@gnu.org unless you wish
to report a problem with the Bug-tracking system.

--
60833: https://debbugs.gnu.org/cgi/bugreport.cg= i?bug=3D60833
GNU Bug Tracking System
Contact help-debb= ugs@gnu.org with problems
--000000000000fdd34e05f4e6dcaf-- --000000000000fdd35005f4e6dcb1 Content-Type: application/octet-stream; name="0001-Add-support-for-Zsh-s-case-branches.patch" Content-Disposition: attachment; filename="0001-Add-support-for-Zsh-s-case-branches.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_le8ohgb10 RnJvbSBmNWM1MDBiZTExYTJhNzdmMmE5ZTQ1ZjY4YTYwMTA5MjRkODZlOTQ1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBBbHRoZXJyIDxwaGlsaXBwZS5hbHRoZXJyQGdt YWlsLmNvbT4KRGF0ZTogU3VuLCAxNSBKYW4gMjAyMyAxMzozNzowMCArMDEwMApTdWJqZWN0OiBb UEFUQ0hdIEFkZCBzdXBwb3J0IGZvciBac2gncyBjYXNlIGJyYW5jaGVzIDt8LgoKLS0tCiBsaXNw L3Byb2dtb2Rlcy9zaC1zY3JpcHQuZWwgfCAxOCArKysrKysrKysrKy0tLS0tLS0KIHRlc3QvbWFu dWFsL2luZGVudC9zaGVsbC5zaCB8ICAxICsKIDIgZmlsZXMgY2hhbmdlZCwgMTIgaW5zZXJ0aW9u cygrKSwgNyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL3Byb2dtb2Rlcy9zaC1zY3Jp cHQuZWwgYi9saXNwL3Byb2dtb2Rlcy9zaC1zY3JpcHQuZWwKaW5kZXggMTdjMjJmZjQ3NTEuLjI5 ODJiYjNmMzQ1IDEwMDY0NAotLS0gYS9saXNwL3Byb2dtb2Rlcy9zaC1zY3JpcHQuZWwKKysrIGIv bGlzcC9wcm9nbW9kZXMvc2gtc2NyaXB0LmVsCkBAIC0xMDQyLDcgKzEwNDIsOSBAQCBzaC1mb250 LWxvY2stcGFyZW4KICAgICAgICAgICAgICAgICAgICAgICAgOzsgTWF5YmUgd2UndmUgYnVtcGVk IGludG8gYW4gZXNjYXBlZCBuZXdsaW5lLgogICAgICAgICAgICAgICAgICAgICAgICAoc2gtaXMt cXVvdGVkLXAgKHBvaW50KSkpCiAgICAgICAgICAgICAgICAgKGJhY2t3YXJkLWNoYXIgMSkpCi0g ICAgICAgICAgICAgICh3aGVuIChlcSAoY2hhci1iZWZvcmUpID98KQorICAgICAgICAgICAgICAo d2hlbiAoYW5kCisgICAgICAgICAgICAgICAgICAgICAoZXEgKGNoYXItYmVmb3JlKSA/fCkKKyAg ICAgICAgICAgICAgICAgICAgIChub3QgKGVxIChjaGFyLWJlZm9yZSAoMS0gKHBvaW50KSkpID9c OykpKQogICAgICAgICAgICAgICAgIChiYWNrd2FyZC1jaGFyIDEpIHQpKSkKICAgICAgICAgKGFu ZCAoPiAocG9pbnQpICgxKyAocG9pbnQtbWluKSkpCiAgICAgICAgICAgICAgKHByb2duIChiYWNr d2FyZC1jaGFyIDIpCkBAIC0xMDUzLDcgKzEwNTUsNyBAQCBzaC1mb250LWxvY2stcGFyZW4KICAg ICAgICAgICAgICAgICAgICAgOzsgYSBub3JtYWwgY29tbWFuZCByYXRoZXIgdGhhbiB0aGUgcmVh bCBgaW4nIGtleXdvcmQuCiAgICAgICAgICAgICAgICAgICAgIDs7IEkuZS4gd2Ugc2hvdWxkIGxv b2sgYmFjayB0byB0cnkgYW5kIGZpbmQgdGhlCiAgICAgICAgICAgICAgICAgICAgIDs7IGNvcnJl c3BvbmRpbmcgYGNhc2UnLgotICAgICAgICAgICAgICAgICAgICAoYW5kIChsb29raW5nLWF0ICI7 WzsmXVxcfFxcXzxpbiIpCisgICAgICAgICAgICAgICAgICAgIChhbmQgKGxvb2tpbmctYXQgIjtc XCg/OjsmP1xcfFsmfF1cXClcXHxcXF88aW4iKQogICAgICAgICAgICAgICAgICAgICAgICAgIDs7 ICI7OyBlc2FjICkiIGlzIGEgY2FzZSB0aGF0IGxvb2tzCiAgICAgICAgICAgICAgICAgICAgICAg ICAgOzsgbGlrZSBhIGNhc2UtcGF0dGVybiBidXQgaXQncyByZWFsbHkganVzdCBhIGNsb3NlCiAg ICAgICAgICAgICAgICAgICAgICAgICAgOzsgcGFyZW4gYWZ0ZXIgYSBjYXNlIHN0YXRlbWVudC4g IEkuZS4gaWYgd2Ugc2tpcHBlZApAQCAtMTc4NCw4ICsxNzg2LDkgQEAgc2gtc21pZS1zaC1ncmFt bWFyCiAgICAgICAocGF0dGVybiAocnBhdHRlcm4pICgiY2FzZS0oIiBycGF0dGVybikpCiAgICAg ICAoYnJhbmNoZXMgKGJyYW5jaGVzICI7OyIgYnJhbmNoZXMpCiAgICAgICAgICAgICAgICAgKGJy YW5jaGVzICI7JiIgYnJhbmNoZXMpIChicmFuY2hlcyAiOzsmIiBicmFuY2hlcykgO2Jhc2guCisg ICAgICAgICAgICAgICAgKGJyYW5jaGVzICI7fCIgYnJhbmNoZXMpIDt6c2guCiAgICAgICAgICAg ICAgICAgKHBhdHRlcm4gImNhc2UtKSIgY21kKSkpCi0gICAgJygoYXNzb2MgIjs7IiAiOyYiICI7 OyYiKSkKKyAgICAnKChhc3NvYyAiOzsiICI7JiIgIjs7JiIgIjt8IikpCiAgICAgJygoYXNzb2Mg IjsiICImIikgKGFzc29jICImJiIgInx8IikgKGFzc29jICJ8IiAifCYiKSkpKSkKIAogKGRlZmNv bnN0IHNoLXNtaWUtLXNoLW9wZXJhdG9ycwpAQCAtMjA1NSwxMSArMjA1OCwxMSBAQCBzaC1zbWll LXNoLXJ1bGVzCiAJIGAoY29sdW1uIC4gLChzbWllLWluZGVudC12aXJ0dWFsKSkpKSkpCiAgICAg OzsgRklYTUU6IE1heWJlIHRoaXMgaGFuZGxpbmcgb2YgOzsgc2hvdWxkIGJlIG1hZGUgaW50bwog ICAgIDs7IGEgc21pZS1ydWxlLXRlcm1pbmF0b3IgZnVuY3Rpb24gdGhhdCB0YWtlcyB0aGUgc3Vi c3RpdHV0ZSAiOyIgYXMgYXJnLgotICAgIChgKDpiZWZvcmUgLiAsKG9yICI7OyIgIjsmIiAiOzsm IikpCi0gICAgIChpZiAoYW5kIChzbWllLXJ1bGUtYm9scCkgKGxvb2tpbmctYXQgIjs7PyY/WyBc dF0qXFwoI1xcfCRcXCkiKSkKKyAgICAoYCg6YmVmb3JlIC4gLChvciAiOzsiICI7JiIgIjs7JiIg Ijt8IikpCisgICAgIChpZiAoYW5kIChzbWllLXJ1bGUtYm9scCkgKGxvb2tpbmctYXQgIjtcXCg/ OjsmP1xcfFsmfF1cXCk/WyBcdF0qXFwoI1xcfCRcXCkiKSkKICAgICAgICAgIChjb25zICdjb2x1 bW4gKHNtaWUtaW5kZW50LWtleXdvcmQgIjsiKSkKICAgICAgICAoc21pZS1ydWxlLXNlcGFyYXRv ciBraW5kKSkpCi0gICAgKGAoOmFmdGVyIC4gLChvciAiOzsiICI7JiIgIjs7JiIpKQorICAgIChg KDphZnRlciAuICwob3IgIjs7IiAiOyYiICI7OyYiICI7fCIpKQogICAgICAod2l0aC1kZW1vdGVk LWVycm9ycyAiU01JRSBydWxlIGVycm9yOiAlUyIKICAgICAgICAoc21pZS1iYWNrd2FyZC1zZXhw IHRva2VuKQogICAgICAgIChjb25zICdjb2x1bW4KQEAgLTIxNDgsOCArMjE1MSw5IEBAIHNoLXNt aWUtcmMtZ3JhbW1hcgogICAgICAgKHBhdHRlcm4gKHBhdHRlcm4gInwiIHBhdHRlcm4pKQogICAg ICAgKGJyYW5jaGVzIChicmFuY2hlcyAiOzsiIGJyYW5jaGVzKQogICAgICAgICAgICAgICAgIChi cmFuY2hlcyAiOyYiIGJyYW5jaGVzKSAoYnJhbmNoZXMgIjs7JiIgYnJhbmNoZXMpIDtiYXNoLgor ICAgICAgICAgICAgICAgIChicmFuY2hlcyAiO3wiIGJyYW5jaGVzKSA7enNoLgogICAgICAgICAg ICAgICAgIChwYXR0ZXJuICJjYXNlLSkiIGNtZCkpKQotICAgICcoKGFzc29jICI7OyIgIjsmIiAi OzsmIikpCisgICAgJygoYXNzb2MgIjs7IiAiOyYiICI7OyYiICI7fCIpKQogICAgICcoKGFzc29j ICJjYXNlIikgKGFzc29jICI7IiAiJiIpIChhc3NvYyAiJiYiICJ8fCIpIChhc3NvYyAifCIgInwm IikpKSkpCiAKIChkZWZ1biBzaC1zbWllLS1yYy1hZnRlci1zcGVjaWFsLWFyZy1wICgpCmRpZmYg LS1naXQgYS90ZXN0L21hbnVhbC9pbmRlbnQvc2hlbGwuc2ggYi90ZXN0L21hbnVhbC9pbmRlbnQv c2hlbGwuc2gKaW5kZXggYmQ0YTc0ZjcwNTQuLjViM2ZiMGU2NmZiIDEwMDc1NQotLS0gYS90ZXN0 L21hbnVhbC9pbmRlbnQvc2hlbGwuc2gKKysrIGIvdGVzdC9tYW51YWwvaW5kZW50L3NoZWxsLnNo CkBAIC0xNDAsNiArMTQwLDcgQEAgICAgIGJhciAoKQogICAgICAgICA1KSBoZWxsbyA7OwogICAg ICAgICA0KSBoZWxsbyA7JgogICAgICAgICA0KSBoZWxsbyA7OyYKKyAgICAgICAgNCkgaGVsbG8g O3wKICAgICAgICAgNSkgaGVsbG8gOzsKICAgICAgICAgNSkgaGVsbG8gOzsKICAgICBlc2FjCi0t IAoyLjM5LjEKCg== --000000000000fdd35005f4e6dcb1-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 02 05:50:44 2023 Received: (at 60833-done) by debbugs.gnu.org; 2 Mar 2023 10:50:44 +0000 Received: from localhost ([127.0.0.1]:55924 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXgWK-0001Pe-FM for submit@debbugs.gnu.org; Thu, 02 Mar 2023 05:50:44 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXgWH-0001PQ-Ph for 60833-done@debbugs.gnu.org; Thu, 02 Mar 2023 05:50:42 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXgWC-0002dl-Ev; Thu, 02 Mar 2023 05:50:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=NsvLOlTXFgba1pPPcgfWAmJGG5o73iaoo1cnR9KcEk0=; b=oS6WDBtDr/xA p/cA/+wlg8yNHo/Utya/nd5QWlqTrhZG5Bthpi5c+YiZ9QPEz2TXZbJS96XA0J8/r50omDkBFLDTV W1dNvHtXhqMNnGxAATSMMJMXeyeBAc8sm0jjfTIiqsuvfRSp4qacXAm/tcPAAPCVrpUrQp3V+MaCW IT/u6uFsBGBds6NUhxjONnzVcACmKGxo++np19NXyIX14TbEb/fPFlTzk0zs25aNCvZnRf//PaV8b i2snuJt17Q8BMh3wOX4uD6dKeeDOdfqo3Vt/XCqhj+lbXSQoaOZEJNGW3lNtTt17Z/RwqtkVaj8iQ kGv17RW8G1IlM36bMtLLIg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXgWA-0004th-W3; Thu, 02 Mar 2023 05:50:36 -0500 Date: Thu, 02 Mar 2023 12:50:27 +0200 Message-Id: <83h6v3e8b0.fsf@gnu.org> From: Eli Zaretskii To: Philippe Altherr In-Reply-To: (message from Philippe Altherr on Fri, 17 Feb 2023 16:20:59 +0100) Subject: Re: bug#60833: Acknowledgement ([PATCH] sh-script.el: Add support for Zsh's case branches ; |.) References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60833-done Cc: 60833-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philippe Altherr > Date: Fri, 17 Feb 2023 16:20:59 +0100 > > Here is an updated patch against the current master branch. Thanks, installed on master, and closing the bug. From unknown Sun Aug 10 00:26:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 30 Mar 2023 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator