GNU bug report logs - #60830
30.0.50; The *Compilation* buffer does not recognize Lua errors

Previous Next

Full log

Message #85 received at 60830 <at> debbugs.gnu.org (full text, mbox):

From: Rudolf Adamkovič <salutis <at> me.com>
To: Mattias Engdegård <mattias.engdegard <at> gmail.com>
Cc: 60830 <at> debbugs.gnu.org, Stefan Kangas <stefankangas <at> gmail.com>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#60830: 30.0.50; The *Compilation* buffer does not recognize
 Lua errors
Date: Sun, 10 Dec 2023 23:53:28 +0100

[Message part 1 (text/plain, inline)]

Mattias Engdegård <mattias.engdegard <at> gmail.com> writes:

> [...] Windows file names [...] tests [...] give us no indication.

Good catch!

I added more tests and updated the code to handle DOS/Windows paths.

>> How do false positives and performance tie to "beauty"?
>
> It's a figure of speech.

I see.

> [...] precisely what versions of Lua [...] information should go into
> the entry of compilation.txt (and the comments describing the new
> entries in compilation-error-regexp-alist-alist).

So that we can be 100% sure, today I compiled and tested the patch
against the last four versions of Lua, as well as, the famously speedy
fork LuaJIT.  It works correctly in all cases.  I added the version
information to the appropriate places.

I am attaching a new version of the patch.

Thank you!

Rudy

[0001-Make-the-Compilation-mode-recognize-Lua-errors.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
"Be especially critical of any statement following the word
'obviously.'"
-- Anna Pell Wheeler, 1883-1966

Rudolf Adamkovič <salutis <at> me.com> [he/him]
Studenohorská 25
84103 Bratislava
Slovakia

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.