GNU bug report logs - #60830
30.0.50; The *Compilation* buffer does not recognize Lua errors

Previous Next

Package: emacs;

Reported by: Rudolf Adamkovič <salutis <at> me.com>

Date: Sun, 15 Jan 2023 11:35:01 UTC

Severity: wishlist

Found in version 30.0.50

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Rudolf Adamkovič <salutis <at> me.com>
To: Mattias Engdegård <mattias.engdegard <at> gmail.com>
Cc: 60830 <at> debbugs.gnu.org, Stefan Kangas <stefankangas <at> gmail.com>, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors
Date: Thu, 05 Oct 2023 18:21:02 +0200
[Message part 1 (text/plain, inline)]
Mattias Engdegård <mattias.engdegard <at> gmail.com> writes:

> This pattern matches some lines normally matched by the `gnu` rule
> which comes later in the rule list. I don't know if it's a big problem
> -- it may cause misclassification of some messages which should be of
> 'warning' or 'info' type.

Good to know!  So, I studied 'luaL_traceback' in 'lauxlib.c' in Lua and
made the regular expression more precise.  No more mis-classification!

> I'm actually slightly more bothered by this message because it would
> conflict with possible future (re-)relaxation of the `gnu` rule with
> respect to leading whitespace. The matter does come up from time to
> time, and it would be nice to at least have the option to do that.

Ditto; I made other expression more precise as well!

> The 'omake' rule has now been disabled by default for other reasons
> (it's something that has been discussed in the past), so there is at
> least precedence for doing this.

/Note:/ I rebased on top of 'master' (and so the 'omake' patch).

See the new patch, with more precise regular expressions, attached
below.  While on it, I also added support for stack frames with no line
number, as per Lua source code.  Lastly, I added a NEWS entry, as well
as, improved the commit message a bit.

How about now? :)

Rudy
[0001-Make-the-Compilation-mode-recognize-Lua-errors.patch (text/x-patch, attachment)]
[Message part 3 (text/plain, inline)]
-- 
"If you're thinking without writing, you only think you're thinking."
--- Leslie Lamport

Rudolf Adamkovič <salutis <at> me.com> [he/him]
Studenohorská 25
84103 Bratislava
Slovakia

This bug report was last modified 1 year and 211 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.