GNU bug report logs - #60830
30.0.50; The *Compilation* buffer does not recognize Lua errors

Previous Next

Full log

View this message in rfc822 format

From: Rudolf Adamkovič <salutis <at> me.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: Mattias Engdegård <mattiase <at> acm.org>, 60830 <at> debbugs.gnu.org
Subject: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors
Date: Tue, 03 Oct 2023 10:12:05 +0200

[Message part 1 (text/plain, inline)]

Stefan Kangas <stefankangas <at> gmail.com> writes:

> [...], all that is needed is to fix the formatting you describe in
> (1). That will give the desired behavior. [...] Regarding (2), I think
> compilation-mode already detects those as file locations, with no
> changes.  At least it does on current master.

As for (2), I recompiled Emacs from 'master' (498d31e9f05) to verify
your claim, but it does seem to hold.  I can reproduce the bug under
'emacs -Q' by following the reproduction steps.

However!  I did some thinking and realized two important facts:

(A) Even if the GNU standard supported tab-indented errors, as per (2),
it would not help, as Lua stack frames are not errors.

(B) People use older Lua versions, which will work forever, as they are
written in ANSI C, and so even if (1) is fixed upstream, we must support
the current error format as well.

After I realized that (A) and (B) are true, I used my morning to write a
patch that solves the problem properly.  I am attaching the patch to
this message.  Do you think the patch could be merged upstream?

Thank you for your time!

Rudy

[0001-Make-the-Compilation-mode-recognize-Lua-errors.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
"Chop your own wood and it will warm you twice."
-- Henry Ford; Francis Kinloch, 1819; Henry David Thoreau, 1854

Rudolf Adamkovič <salutis <at> me.com> [he/him]
Studenohorská 25
84103 Bratislava
Slovakia

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.