From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 15 06:34:04 2023 Received: (at submit) by debbugs.gnu.org; 15 Jan 2023 11:34:04 +0000 Received: from localhost ([127.0.0.1]:56310 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pH1H1-00011N-Cr for submit@debbugs.gnu.org; Sun, 15 Jan 2023 06:34:03 -0500 Received: from lists.gnu.org ([209.51.188.17]:50210) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pH1Gx-00010w-Qj for submit@debbugs.gnu.org; Sun, 15 Jan 2023 06:34:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pH1Gx-0007WK-HA for bug-gnu-emacs@gnu.org; Sun, 15 Jan 2023 06:33:59 -0500 Received: from pv50p00im-ztdg10012101.me.com ([17.58.6.49]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pH1Gv-0000cq-GT for bug-gnu-emacs@gnu.org; Sun, 15 Jan 2023 06:33:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1673782431; bh=BX1upI/3+yPS6S+AFIK3mQ3NL33+bUQ62217EgGUU48=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=R42EoJtpxDNdr1wi0jCotpsHamm6WhWGzkDvcxksTqywbpsKU8LgAAF4ZhA27voK7 ftw+fTpqjsEFtVZdnHIqU4x6dhBU24TmsoFKRffvcCYoR/Y8oJPaGHVCHfO7yB3xZB 8BUzoMDLqDiBbbt8Epggb/zbSHC8sjxDIQsvX6MaWB/EOlYGUQ6SqsNMhdz0OZ9aex 0GZOGPjFxjwmMpnU+0iH7PFjHAx4WbjzQL+hE2kWNhNxIOQNNiGiBjbdnx7kNBo1T4 q1t5rRCBHYzlMeY39mIiYsj6m+LQUZdoVlWSDSJgiHG3gA2IumufBPdI3DIlj5gF4W /KosQhHeUR88Q== Received: from Rudolfs-MacBook-Air.local (pv50p00im-dlb-asmtp-mailmevip.me.com [17.56.9.10]) by pv50p00im-ztdg10012101.me.com (Postfix) with ESMTPSA id 9CD4E74022D for ; Sun, 15 Jan 2023 11:33:50 +0000 (UTC) From: =?utf-8?Q?Rudolf_Adamkovi=C4=8D?= To: bug-gnu-emacs@gnu.org Subject: 30.0.50; The *Compilation* buffer does not recognize Lua errors Date: Sun, 15 Jan 2023 12:33:47 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: idbi7GxUSmnl4y6q3q9SV6F-i5hg5nKM X-Proofpoint-GUID: idbi7GxUSmnl4y6q3q9SV6F-i5hg5nKM X-Proofpoint-Virus-Version: =?UTF-8?Q?vendor=3Dfsecure_engine=3D1.1.170-22c6f66c430a71ce266a39bfe25bc?= =?UTF-8?Q?2903e8d5c8f:6.0.517,18.0.883,17.11.64.514.0000000_definitions?= =?UTF-8?Q?=3D2022-06-21=5F08:2022-06-21=5F01,2022-06-21=5F08,2022-02-23?= =?UTF-8?Q?=5F01_signatures=3D0?= X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 mlxlogscore=999 bulkscore=0 mlxscore=0 malwarescore=0 spamscore=0 phishscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2301150088 Received-SPF: pass client-ip=17.58.6.49; envelope-from=salutis@me.com; helo=pv50p00im-ztdg10012101.me.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) REPRODUCTION STEPS: 1. Write the following in some buffer: /usr/bin/lua: database.lua:31: assertion failed! stack traceback: [C]: in function 'assert' database.lua:31: in field 'statement' database.lua:42: in field 'table' database.lua:55: in field 'row' database.lua:63: in field 'value' database.lua:68: in main chunk [C]: in ? 2. Enable the `compilation-mode'. EXPECTED: The Compilation mode recognizes the following as error loci: =20=20 - database.lua:31: (twice) - database.lua:42: - database.lua:55: - database.lua:63: - database.lua:68: ACTUAL: The Compilation mode finds no error loci. NOTES: The source files can any extension, such as `fnl' for Fennel. Rudy In GNU Emacs 30.0.50 (build 19, aarch64-apple-darwin22.1.0, NS appkit-2299.= 00 Version 13.0.1 (Build 22A400)) of 2023-01-11 built on Rudolfs-MacBook-Air.= local Repository revision: c51bfef34a6bdefad048444c279ea5b63a6aada1 Repository branch: master Windowing system distributor 'Apple', version 10.3.2299 System Description: macOS 13.0.1 Configured features: ACL GLIB GNUTLS JSON LCMS2 LIBXML2 MODULES NOTIFY KQUEUE NS PDUMPER PNG RSVG SQLITE3 THREADS TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM ZLIB Important settings: value of $LC_ALL: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: notmuch-hello Minor modes in effect: global-hi-lock-mode: t hi-lock-mode: t global-hl-todo-mode: t global-diff-hl-mode: t savehist-mode: t shell-dirtrack-mode: t sly-symbol-completion-mode: t pixel-scroll-precision-mode: t delete-selection-mode: t global-goto-address-mode: t goto-address-mode: t global-subword-mode: t subword-mode: t save-place-mode: t global-auto-revert-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t context-menu-mode: t global-font-lock-mode: t font-lock-mode: t size-indication-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /Users/salutis/.emacs.d/elpa/modus-themes-20230112.503/theme-loaddefs hides= /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/theme-= loaddefs /Users/salutis/.emacs.d/elpa/transient-20230107.1528/transient hides /Users= /salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/transient Features: (shadow sort tempo mail-extr emacsbug notmuch notmuch-tree notmuch-jump notmuch-hello notmuch-show notmuch-print notmuch-crypto notmuch-mua notmuch-message notmuch-draft notmuch-maildir-fcc notmuch-address notmuch-company notmuch-parser notmuch-wash coolj icalendar diary-lib diary-loaddefs notmuch-tag crm notmuch-lib notmuch-version notmuch-compat message yank-media rfc822 mml mailabbrev gmm-utils mailheader mm-view mml-s= mime mml-sec epa epg rfc6068 epg-config gnus-util smime gnutls puny dig mm-decode mm-bodies mm-encode mail-parse rfc2231 em-unix em-term term disp-table ehelp em-script em-prompt em-ls em-hist em-pred em-glob em-extpipe em-cmpl em-dirs esh-var em-basic em-banner em-alias esh-mode eshell esh-cmd esh-ext esh-opt esh-proc esh-io esh-arg esh-module esh-groups esh-util cl-print misearch multi-isearch dired-aux hl-line dired-x ls-lisp dired dired-loaddefs make-m= ode fennel-mode fennel-eldoc inf-lisp files-x vc-svn vc-git lua-mode advice char-fold paredit edmacro kmacro hi-lock hl-todo compat diff-hl log-view pcvs-util vc-dir ewoc cus-start vc vc-dispatcher diff-mode orderless pdf-lo= ader finder-inf savehist org-clock ob-makefile ob-latex ob-scheme geiser-impl help-fns radix-tree geiser-custom geiser-base geiser ob-dot ob-R ob-C cc-mo= de cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-= defs ob-shell shell ob-java ob-sqlite ob-sql ob-org ob-lisp modus-operandi-theme modus-themes sly easy-mmode sly-completion sly-buttons sly-messages sly-com= mon apropos etags fileloop generator xref arc-mode archive-mode hyperspec white= space display-fill-column-indicator display-line-numbers flyspell ispell fortune flymake-proc flymake project compile text-property-search pixel-scroll cua-= base comp derived comp-cstr pcase warnings cl-extra help-mode delsel goto-addr thingatpt cap-words superword subword saveplace cus-edit pp cus-load wid-ed= it bug-reference autorevert filenotify org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete pcomplete comint ansi-osc ansi-color ring org-list org-footnote org-faces org-entities time-date nout= line outline icons ob-emacs-lisp ob-core ob-eval org-cycle org-table ol rx org-f= old org-fold-core org-keys oc org-loaddefs find-func cal-menu calendar cal-load= defs org-version org-compat org-macs format-spec sendmail rfc2047 rfc2045 ietf-d= rums mm-util mail-prsvr mail-utils mmm-mode-autoloads org-drill-autoloads bbdb-autoloads diff-hl-autoloads paredit-autoloads markdown-mode-autoloads vterm-autoloads swift-mode-autoloads lua-mode-autoloads htmlize-autoloads yaml-mode-autoloads auctex-autoloads tex-site kotlin-mode-autoloads hl-todo-autoloads geiser-guile-autoloads modus-themes-autoloads flymake-grammarly-autoloads grammarly-autoloads emms-autoloads bnf-mode-autoloads fennel-mode-autoloads rainbow-mode-autoloads request-autoloads magit-autoloads magit-section-autoloads git-commit-autolo= ads transient-autoloads geiser-autoloads telega-autoloads rainbow-identifiers-autoloads pdf-tools-autoloads sql-indent-autoloads citar-autoloads citeproc-autoloads queue-autoloads tablist-autoloads cape-autoloads hide-mode-line-autoloads orderless-autoloads elfeed-tube-mpv-autoloads mpv-autoloads string-inflection-autoloads visual-fill-column-autoloads parsebib-autoloads mentor-autoloads url-scgi-autoloads async-autoloads xml-rpc-autoloads ebnf-mode-autoloads graphviz-dot-mode-autoloads f-autoloads dash-autoloads sly-autoloads persist-autoloads ess-autoloads websocket-autoloads sqlup-mode-autoloads elfeed-tube-autoloads aio-autoloads elfeed-autoloads password-store-autoloa= ds with-editor-autoloads info compat-autoloads s-autoloads package browse-url = url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-= type elisp-mode mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomm= ent text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow is= earch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-v= iet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech eur= opean ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom w= idget keymap hashtable-print-readable backquote threads kqueue cocoa ns lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 705152 30738) (symbols 48 37553 37) (strings 32 201806 6173) (string-bytes 1 5391755) (vectors 16 61253) (vector-slots 8 827501 35559) (floats 8 220 464) (intervals 56 7615 148) (buffers 984 24)) --=20 "Be especially critical of any statement following the word 'obviously.'" -- Anna Pell Wheeler, 1883-1966 Rudolf Adamkovi=C4=8D [he/him] Studenohorsk=C3=A1 25 84103 Bratislava Slovakia From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 04 05:16:09 2023 Received: (at control) by debbugs.gnu.org; 4 Sep 2023 09:16:09 +0000 Received: from localhost ([127.0.0.1]:48718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qd5gn-0000r3-8d for submit@debbugs.gnu.org; Mon, 04 Sep 2023 05:16:09 -0400 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]:58632) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qd5gl-0000el-F9 for control@debbugs.gnu.org; Mon, 04 Sep 2023 05:16:07 -0400 Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-4ff8cf11b90so1959656e87.1 for ; Mon, 04 Sep 2023 02:16:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693818961; x=1694423761; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=2Yb9M7Nikn1EvPgF5Jyp5ZSnRZsO5eOjqstfc1XNrcw=; b=JLj1JGGbbFq//WxYFc5xmBQ/ZwFY7y+7LvM6BWDS/+ax1FZ6Lx8gwat1kQEqmN6+h2 qlfOf+vA/FfpyoUJHMc0pBvoYIvwGg4s1yVOPAgHp5K+VIYwt0uOkSmOf1l00mJ2zjlz fyBOJUZ4d/ZbymUhA9rxq2iDFTcQEpKV4teFrbWbFfk8AeCH2m05EdGfBiO5HfCYEjO/ bG5gHLOxIbcMj6I9o6ARTnA0cftNON93XKnDHNl/pF5o+bKZ9GPG1LKt75J6Uz5rjq9p sjhUmkAyJgz6O5PK7lCntU1bDwVmtTMkGn3dOM8o3sUY026WrV6+QdyFpTrGHzc41LOo Dpog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693818961; x=1694423761; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=2Yb9M7Nikn1EvPgF5Jyp5ZSnRZsO5eOjqstfc1XNrcw=; b=A/EkroxuPO4T4J1F1WUXkMd4ZbmZFKYVetfv5doMdf50YK25CCF/oUKSY7uduCPnxf yzegXNIyR/2ADLlKfjwRc7++BVTxh+yFeUozO+7kv71kINj3Q1mVRdC4gvyziRqS9Xph vojoWMXvIccrNi/I6un8H0Ej0U22/rdP/7GnZKxMoE113tJQ1zjOXOQWZNO3GZygxtrr oYEx8f1cLdEcqA6IQy0k4L5ozU6pPSRYQN2A+PlCYZDYCxxmXA6EFfFrdxYYWnuICGx9 EluxfbMOkZWUr8ZhqI+IJaHGXc5G2Iz0W31kq180cp8xx8DYYZdMhQQ+MUtDfsnZMUDf BuQA== X-Gm-Message-State: AOJu0YxuqXCgQZz3Xs395gyWmWkxoeMgoM27kLLIo93NTovS9gaE2W09 JqevLN5HMP23Ez8m4hJgu7fB8bL79FkD0pYCkK+X1GecOos= X-Google-Smtp-Source: AGHT+IGonPqBbLhaDH8Dp4fYhs62e8k5C9OlftTl/USO+hwdTHhBYmnk8VtKIOo35CwI7NXwxDd//vPCvAR9AsKsAPE= X-Received: by 2002:a05:6512:3049:b0:500:9b7d:ee3c with SMTP id b9-20020a056512304900b005009b7dee3cmr7730116lfb.7.1693818961471; Mon, 04 Sep 2023 02:16:01 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 4 Sep 2023 02:16:01 -0700 From: Stefan Kangas MIME-Version: 1.0 Date: Mon, 4 Sep 2023 02:16:01 -0700 Message-ID: Subject: control message for bug #60830 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 60830 wishlist quit From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 13 10:55:48 2023 Received: (at 60830) by debbugs.gnu.org; 13 Sep 2023 14:55:48 +0000 Received: from localhost ([127.0.0.1]:35628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qgRHP-0002GF-UZ for submit@debbugs.gnu.org; Wed, 13 Sep 2023 10:55:48 -0400 Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]:55543) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qgRHL-0002Fz-9B for 60830@debbugs.gnu.org; Wed, 13 Sep 2023 10:55:47 -0400 Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2b9338e4695so113637321fa.2 for <60830@debbugs.gnu.org>; Wed, 13 Sep 2023 07:55:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694616931; x=1695221731; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=AYG0LGIAOINhHqGj9qG5KiwjgSEv+SOFnkzYibpdFhc=; b=cSDKstWoIBYfDvMD+q3ak+HaG0LR8Au9mbjzW00SuTjlYiJTAaT1UaPG26fOhsN34h XCO4Taqd9R2vxv3U4UpTKgm+BlCwWeXP+4xRP4EzT2kEae4goSXmYIya166vk/lgNdgY 5SWtuADCtpwHyXmR1wgJ5fFUm6sSs2NNVLqPiY359tlI4nkiEhQvk69UH/4H517XVmbv ubwHt/xfp3JYipL8cJIpHOLnF9CFx5mrbp/ulsuI5Y0jeItJj3gAZxOcH8RdDx5F6axZ q5WlgHFSt40RgyDKHAJuzuznHJ+/X0VLo07QqQWE0xe+uQIMsx354wvxHL9qM5bfeakS 3tog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694616931; x=1695221731; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=AYG0LGIAOINhHqGj9qG5KiwjgSEv+SOFnkzYibpdFhc=; b=lZ6jhhHKTyrFuftNDD5RxumfEhXPKiJA4wInmrvXAuiYEKgxQHse5OcQGDieU6fAVG DEA5gCTxsvnBLs+Gt3Q4rjINiXhaDSnSs9/69xdzRHEcRkRtGIAt1z5+laAB+LH/kmYz dA+O0ESiK+kq5xDBqrcOX367ALuV4LxSUCpJIZ8gC40UT1kzsA3Z8APFOiNXO59gDX5L DdWj18DkTxMSUgA/CP+jdocIq7OoUozIlH3KDst8BeXUlSD+yzZfi21vvU4Ic9PHgkMK fV6S6VZwS26vWT249h9rbym17XJqBaa32Zeg1ZQpYncGs3LOqA0B1L2/WwLmwMi6IHwD vNaw== X-Gm-Message-State: AOJu0YylunpxWrKX892rgvWrCqPW8YbyLXETwKSZqn4p1Mck4esPbtyr xPHcYhZN/JPY1PpwKKMRSm+0Sd/QNrKX536sJRZxoqFW X-Google-Smtp-Source: AGHT+IEM7jmxl6mB+Rfb7Ql+72IadiHGLkZLF5ExjiPlJ2v++lhB7DS+PiPaWETOZWoDOtj7kZfWgMmcjoDBHeURwIU= X-Received: by 2002:a2e:9815:0:b0:2bc:b46b:686b with SMTP id a21-20020a2e9815000000b002bcb46b686bmr2544945ljj.34.1694616931215; Wed, 13 Sep 2023 07:55:31 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 13 Sep 2023 07:55:30 -0700 From: Stefan Kangas In-Reply-To: =?UTF-8?B?PG0ydHUwczZuaGcuZnNmQG1lLmNvbT4gKCJSdWRvbGYgQWRhbWtvdmnEjSIncyBt?= =?UTF-8?B?ZXNzYWdlIG9mICJTdW4sIDE1IEphbiAyMDIzIDEyOjMzOjQ3ICswMTAwIik=?= References: MIME-Version: 1.0 Date: Wed, 13 Sep 2023 07:55:30 -0700 Message-ID: Subject: Re: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors To: =?UTF-8?Q?Rudolf_Adamkovi=C4=8D?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60830 Cc: =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= , 60830@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Rudolf Adamkovi=C4=8D writes: > REPRODUCTION STEPS: > > 1. Write the following in some buffer: > > /usr/bin/lua: database.lua:31: assertion failed! > stack traceback: > [C]: in function 'assert' > database.lua:31: in field 'statement' > database.lua:42: in field 'table' > database.lua:55: in field 'row' > database.lua:63: in field 'value' > database.lua:68: in main chunk > [C]: in ? > > 2. Enable the `compilation-mode'. > > EXPECTED: > > The Compilation mode recognizes the following as error loci: > > - database.lua:31: (twice) > - database.lua:42: > - database.lua:55: > - database.lua:63: > - database.lua:68: > > ACTUAL: > > The Compilation mode finds no error loci. > > NOTES: > > The source files can any extension, such as `fnl' for Fennel. This breaks because it doesn't follow the GNU standard's [PROGRAM:]FILE:LINE: MESSAGE Any chance we could get the lua developers to follow that format, instead? See also: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D58984#26 From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 02 08:04:32 2023 Received: (at 60830) by debbugs.gnu.org; 2 Oct 2023 12:04:32 +0000 Received: from localhost ([127.0.0.1]:36183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnHf5-0003P0-N9 for submit@debbugs.gnu.org; Mon, 02 Oct 2023 08:04:31 -0400 Received: from mr85p00im-ztdg06011901.me.com ([17.58.23.198]:43784) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnHf2-0003Oj-Ko for 60830@debbugs.gnu.org; Mon, 02 Oct 2023 08:04:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1696248246; bh=41FEYqRfjgAZ5TGwnm9yBI/zvUA72ZO4vD0ooZQSbao=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=qFKgsoqM/pSH8h4rbSfHqi+AZsMI6IHOFeve9UGeXcmKErP3WBluz2I2DOyFEPDBC ZiJIrWXt6UT3/5qR5H3b5nOHQ1Rg9hL9DRcJyOHRzChLlj93ppDevEAfgTrQCovLdI mkDtwCX1Sp5Wi6jzDnt/QVRG95Ym6cKxfs2sn18e7l4+JUf793ohRNT1znSZHdZYm7 OzxefgI578l2sVv6ztOOgDVjgrPDQbnfA254UtCGrwkR5GcS9tbMYfgVE9Hp/VQqCj w+D/GIVH5qnVgkcH4qtxDIrrt6vVfeUIPfg1D/5l2PxLPu3fcpQe13ZBDPaCXOIWGD EGc+s4HzSRXtQ== Received: from Rudolfs-MacBook-Air.local (mr38p00im-dlb-asmtp-mailmevip.me.com [17.57.152.18]) by mr85p00im-ztdg06011901.me.com (Postfix) with ESMTPSA id 22078900166; Mon, 2 Oct 2023 12:04:04 +0000 (UTC) From: Rudolf =?utf-8?Q?Adamkovi=C4=8D?= To: Stefan Kangas Subject: Re: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors In-Reply-To: References: Date: Mon, 02 Oct 2023 14:04:01 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: NlHU0hdWpNc6Ys9uP2v9VsQc6IDFvs5F X-Proofpoint-ORIG-GUID: NlHU0hdWpNc6Ys9uP2v9VsQc6IDFvs5F X-Proofpoint-Virus-Version: =?UTF-8?Q?vendor=3Dfsecure_engine=3D1.1.170-22c6f66c430a71ce266a39bfe25bc?= =?UTF-8?Q?2903e8d5c8f:6.0.425,18.0.572,17.0.605.474.0000000_definitions?= =?UTF-8?Q?=3D2022-01-14=5F01:2022-01-14=5F01,2020-02-14=5F11,2020-01-23?= =?UTF-8?Q?=5F02_signatures=3D0?= X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 mlxlogscore=720 adultscore=0 malwarescore=0 spamscore=0 bulkscore=0 clxscore=1011 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2310020088 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60830 Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= , 60830@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Stefan Kangas writes: > This breaks because it doesn't follow the GNU standard's > > [PROGRAM:]FILE:LINE: MESSAGE > > Any chance we could get the lua developers to follow that format, > instead? Thank you for the reply, Stefan. So, we seem to have 2 problems here: (1) the first line contains a space character after the 'PROGRAM:' segment, which Lua developers might be willing to change perhaps, and (2) the stack trace lines are indented, which I doubt Lua developers would want to change. Would it make sense to ask Lua developers about fixing (1) only, or would fixing (2) in Emacs also "magically" fix (1), if Emacs has to handle Lua specifically anyway? Rudy --=20 "Mathematics takes us still further from what is human into the region of absolute necessity, to which not only the actual world, but every possible world, must conform." -- Bertrand Russell, 1902 Rudolf Adamkovi=C4=8D [he/him] Studenohorsk=C3=A1 25 84103 Bratislava Slovakia From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 02 14:38:03 2023 Received: (at 60830) by debbugs.gnu.org; 2 Oct 2023 18:38:03 +0000 Received: from localhost ([127.0.0.1]:37925 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnNnv-00039l-Ax for submit@debbugs.gnu.org; Mon, 02 Oct 2023 14:38:03 -0400 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]:58606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnNns-00039F-Lu for 60830@debbugs.gnu.org; Mon, 02 Oct 2023 14:38:01 -0400 Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-50325ce89e9so28751e87.0 for <60830@debbugs.gnu.org>; Mon, 02 Oct 2023 11:37:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696271858; x=1696876658; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=vHFJNo379F/ZbOP5xLMBns1ekLa4rGorEGu4nQfxaGk=; b=ElotvJOlDqh4xN7HU8ohCePbqvttTw4OtUMPs6kHA8SzEY88aXhekGh4d+cAz/yUw4 xjvkMRdy8oRQ7tbUzgcg6rkFXffGaln4yyE3NfSaCDzgkF7EKjqWlfXsrd4UzK66YLMP OjB9e4PG/VdRnCSW7b5ls496GwwKDeA9R8HBeMouS9DmIv8Qp+pBgidPxrEBJkhqxkO+ tvn4vsJkb0LRfAJpbQfeC6h10dQZjm+OFCVLK2WKW4b7+QqviojSUPkODzjmOn+OSW29 fsZUUB0r0QmhoAOUSCmwSNZ2i4DkbQQDNivMax06bnEVOZex3bktqAJYky8PumROUzbt VbFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696271858; x=1696876658; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=vHFJNo379F/ZbOP5xLMBns1ekLa4rGorEGu4nQfxaGk=; b=Wr+lObHu1RpSo97kw+4eq4sM0ZAq+OEVb2I1o4r1ATFnw1DezqqBnl6esGkn2603P5 zMHP9Qb53PtqNHDfh490UDxJTwRdzMs72y0tPYi36pUJcL++QUNqT9ncK8v2WwXKHgwO +MQs3cXxgj0qBawyP+gTBLN5bovK2jm+RG7EnvMlpbKjfo0XQBaaPuRufT9AMKwGzjJP 9tccSiltFwd6TT06/n9y2Aql0l/sfvlbznoHL5f1YS/FHBgbAL5/FdUmh07RHc3QrdMl FfjBqhymzXOxmcRFnR1Lpmft91zNZUBL3ZF5jIKvROpafejI0bWmkNLpWWzM17eISZAw w1/g== X-Gm-Message-State: AOJu0Yw5k3qIYrc3osxEyc9tfr9TEqKvmnaPdSV0TNuf+/q3/0NK5/cB SORR87Pj5FtlR3xzF/uBF8j7mKf6l6KO8BVFDk8= X-Google-Smtp-Source: AGHT+IE/N2zMPL9yd6Ar7fkZBGsL1o1xmV3yz0ZzlRBTitCe0o4xS7qojQ8NvA+wWry+2fkheSLJ+VmMau8Qxdt7IsI= X-Received: by 2002:a19:7110:0:b0:502:9fce:b6da with SMTP id m16-20020a197110000000b005029fceb6damr8602231lfc.21.1696271857822; Mon, 02 Oct 2023 11:37:37 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 2 Oct 2023 11:37:37 -0700 From: Stefan Kangas In-Reply-To: References: MIME-Version: 1.0 Date: Mon, 2 Oct 2023 11:37:37 -0700 Message-ID: Subject: Re: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors To: =?UTF-8?Q?Rudolf_Adamkovi=C4=8D?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60830 Cc: =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= , 60830@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Rudolf Adamkovi=C4=8D writes: > Stefan Kangas writes: > >> This breaks because it doesn't follow the GNU standard's >> >> [PROGRAM:]FILE:LINE: MESSAGE >> >> Any chance we could get the lua developers to follow that format, >> instead? > > Thank you for the reply, Stefan. > > So, we seem to have 2 problems here: > > (1) the first line contains a space character after the 'PROGRAM:' > segment, which Lua developers might be willing to change perhaps, > > and > > (2) the stack trace lines are indented, which I doubt Lua developers > would want to change. > > Would it make sense to ask Lua developers about fixing (1) only, or > would fixing (2) in Emacs also "magically" fix (1), if Emacs has to > handle Lua specifically anyway? AFAICT, all that is needed is to fix the formatting you describe in (1). That will give the desired behavior. Regarding (2), I think compilation-mode already detects those as file locations, with no changes. At least it does on current master. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 03 04:12:35 2023 Received: (at 60830) by debbugs.gnu.org; 3 Oct 2023 08:12:35 +0000 Received: from localhost ([127.0.0.1]:38666 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnaWA-0001Tl-PW for submit@debbugs.gnu.org; Tue, 03 Oct 2023 04:12:35 -0400 Received: from mr85p00im-zteg06022001.me.com ([17.58.23.193]:33680) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnaW8-0001TV-Uq for 60830@debbugs.gnu.org; Tue, 03 Oct 2023 04:12:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1696320730; bh=Bz9nBbGkR2f45VsJg94R4FQhhJ+0fY9EANDZyBVeLyY=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=JvdvGkuVZgusc/720yMMBN6YpqcfXsZ9enrXkV7BxqAXKRv+fgv5BEEgEiQgiosg1 8ZU5IBYoVDsTafsShmNJWSCks9UhIH+inJ+cgpPLEq9NMEnamsW20LV3OmiXAF8nXI 34Qf3gc32i2DCMmbnxC8Y5nfeDx2vQHiyNQXdbFAyu1m4qpqShemn8xRMdzG0mJXZE u4TYGJKwubZPmYjl9Ur2XnpHZrlNryk4nwdTzhhOhezmokOzPck0jIIh1J8zxVl2/f wWKGnLwK0JHifVf0Xg1XB9yROLpfFnI22aiQYjxwvOzAP0eA1+cEWILutAdIppZbeT wSF7ZGWpnsgGA== Received: from Rudolfs-MacBook-Air.local (mr38p00im-dlb-asmtp-mailmevip.me.com [17.57.152.18]) by mr85p00im-zteg06022001.me.com (Postfix) with ESMTPSA id 085698001E3; Tue, 3 Oct 2023 08:12:08 +0000 (UTC) From: Rudolf =?utf-8?Q?Adamkovi=C4=8D?= To: Stefan Kangas Subject: Re: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors In-Reply-To: References: Date: Tue, 03 Oct 2023 10:12:05 +0200 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Proofpoint-ORIG-GUID: WYK5RfAiNCBZIKpaQ5UYRzfBmwE97JBE X-Proofpoint-GUID: WYK5RfAiNCBZIKpaQ5UYRzfBmwE97JBE X-Proofpoint-Virus-Version: =?UTF-8?Q?vendor=3Dfsecure_engine=3D1.1.170-22c6f66c430a71ce266a39bfe25bc?= =?UTF-8?Q?2903e8d5c8f:6.0.425,18.0.572,17.0.605.474.0000000_definitions?= =?UTF-8?Q?=3D2022-01-14=5F01:2022-01-14=5F01,2020-02-14=5F11,2020-01-23?= =?UTF-8?Q?=5F02_signatures=3D0?= X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 mlxlogscore=915 phishscore=0 clxscore=1015 mlxscore=0 malwarescore=0 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2310030056 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60830 Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= , 60830@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Stefan Kangas writes: > [...], all that is needed is to fix the formatting you describe in > (1). That will give the desired behavior. [...] Regarding (2), I think > compilation-mode already detects those as file locations, with no > changes. At least it does on current master. As for (2), I recompiled Emacs from 'master' (498d31e9f05) to verify your claim, but it does seem to hold. I can reproduce the bug under 'emacs -Q' by following the reproduction steps. However! I did some thinking and realized two important facts: (A) Even if the GNU standard supported tab-indented errors, as per (2), it would not help, as Lua stack frames are not errors. (B) People use older Lua versions, which will work forever, as they are written in ANSI C, and so even if (1) is fixed upstream, we must support the current error format as well. After I realized that (A) and (B) are true, I used my morning to write a patch that solves the problem properly. I am attaching the patch to this message. Do you think the patch could be merged upstream? Thank you for your time! Rudy --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Make-the-Compilation-mode-recognize-Lua-errors.patch >From 3bbf4019df45548d1286ba9b0dffe8fadad2bdf1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rudolf=20Adamkovi=C4=8D?= Date: Tue, 3 Oct 2023 09:07:40 +0200 Subject: [PATCH] Make the Compilation mode recognize Lua errors Emacs comes with built-in support for the Lua programming language in the form of the Lua mode and now also the Lua Tree-sitter mode. But, Lua support in Emacs is incomplete in that the Compilation mode does not recognize Lua errors, which is what this patch fixes. Reported as bug#60830. * lisp/progmodes/compile.el (compilation-error-regexp-alist-alist): Add regexps to aid Lua development, namely the 'lua' regexp that matches Lua errors and the 'lua-stack' regexp that matches Lua stack frames. * test/lisp/progmodes/compile-tests.el (compile-tests--test-regexps-data): (compile-test-error-regexps): Test the new 'lua' and 'lua-stack' regexps added to the 'compilation-error-regexp-alist-alist'. --- lisp/progmodes/compile.el | 5 +++++ test/lisp/progmodes/compile-tests.el | 13 +++++++++++-- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index f85cc0909dd..82f8280d76d 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -362,6 +362,11 @@ compilation-error-regexp-alist-alist (ruby-Test::Unit "^ [[ ]?\\([^ (].*\\):\\([1-9][0-9]*\\)\\(\\]\\)?:in " 1 2) + (lua + "^[^: \n\t]+: \\([^: \n\t]+\\):\\([0-9]+\\): " 1 2 nil 2 1) + (lua-stack + "^\t\\([^: \n\t]+\\):\\([0-9]+\\): " 1 2 nil 0 1) + (gmake ;; Set GNU make error messages as INFO level. ;; It starts with the name of the make program which is variable, diff --git a/test/lisp/progmodes/compile-tests.el b/test/lisp/progmodes/compile-tests.el index 078eef36774..889b3443993 100644 --- a/test/lisp/progmodes/compile-tests.el +++ b/test/lisp/progmodes/compile-tests.el @@ -208,6 +208,15 @@ compile-tests--test-regexps-data 1 0 31 "/usr/include/c++/3.3/backward/iostream.h") (gcc-include " from test_clt.cc:1:" 1 nil 1 "test_clt.cc") + ;; Lua + (lua "lua: database.lua:10: assertion failed!" + 6 nil 10 "database.lua") + (lua "/usr/local/bin/lua: core/database.lua:20: assertion failed!" + 21 nil 20 "core/database.lua") + (lua-stack " database.lua:10: in field 'statement'" + 2 nil 10 "database.lua" 0) + (lua-stack " core/database.lua:20: in field 'statement'" + 2 nil 20 "core/database.lua" 0) ;; gmake (gmake "make: *** [Makefile:20: all] Error 2" 12 nil 20 "Makefile" 0) (gmake "make[4]: *** [sub/make.mk:19: all] Error 127" 15 nil 19 @@ -499,9 +508,9 @@ compile-test-error-regexps (compilation-num-warnings-found 0) (compilation-num-infos-found 0)) (mapc #'compile--test-error-line compile-tests--test-regexps-data) - (should (eq compilation-num-errors-found 100)) + (should (eq compilation-num-errors-found 102)) (should (eq compilation-num-warnings-found 35)) - (should (eq compilation-num-infos-found 28))))) + (should (eq compilation-num-infos-found 30))))) (ert-deftest compile-test-grep-regexps () "Test the `grep-regexp-alist' regexps. -- 2.37.1 (Apple Git-137.1) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable --=20 "Chop your own wood and it will warm you twice." -- Henry Ford; Francis Kinloch, 1819; Henry David Thoreau, 1854 Rudolf Adamkovi=C4=8D [he/him] Studenohorsk=C3=A1 25 84103 Bratislava Slovakia --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 03 05:38:02 2023 Received: (at 60830) by debbugs.gnu.org; 3 Oct 2023 09:38:02 +0000 Received: from localhost ([127.0.0.1]:38845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnbqs-0006ah-07 for submit@debbugs.gnu.org; Tue, 03 Oct 2023 05:38:02 -0400 Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]:49632) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnbqp-0006aP-Sl for 60830@debbugs.gnu.org; Tue, 03 Oct 2023 05:38:00 -0400 Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2b9d07a8d84so8375961fa.3 for <60830@debbugs.gnu.org>; Tue, 03 Oct 2023 02:37:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696325857; x=1696930657; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=q8kl4ix/0ybSx70lUa8iLlgpVD1sQapL4WUf7O9EDAA=; b=BeZQR+2L/hMFQMC+Ddsigxj5RQfKXIeAF1YZAMPzKV8FFFIMxfHvzo3bZn+N3Yr+lx f0/p088X+2/xpZ2VwKSpNa2KggW604kPCGmBTZI8Gp7sJ3U5hxbCr6tAWMqeMG/OATtY 69ZU2/qyS9Rjici9rhBF4TlLOyjyISCwEM2vz/9bVPapRpVNE4S14AYo5F4mj/oXILBu vIcFcVmRuc/mr+VEPke9MicKDqHpJBodw2I1KpOI/7U+vBfkyBNycwjuKlFBX8USEZ2x QP7A8VVp7Vuxt2nn6onY0TOpWiTQcw+1qe7KLtaN+MrDR2J1L/EUHbzlqD5nUrdTyLjn D2IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696325857; x=1696930657; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=q8kl4ix/0ybSx70lUa8iLlgpVD1sQapL4WUf7O9EDAA=; b=Y7vmXrbSFjIDVOlMwGQeEw7ySectSKy/uiKOBQeFt7xlrBTzE3JX9N4OdnnJ0tWXbI 3sEq1ZeTuzeov2e2vKP73C0QsOCm6B1hIQqe6xL3iM2ZeJHsCoHB2AImJXYqWn8Gxsp9 weEU/JPHvglY5Dp/N2yL2RXB1gj/kDlbVPtb7SUba2k4/4qxkEfyt5gCdcb8lfJeq2bv tK+c/Mp4oXBDyjQPV8t6dOP18I7P+JQZP0XrXCatQYF5ov91bSCuj48kpnmAeW3bhUxO /sGxW1Vo8wZ794f9drw2dGLoTYvgvdNncyWNDWSMP803cST1QypSTp3bofDWp9VQCwGF ccZw== X-Gm-Message-State: AOJu0Yw7oksVnzf6//1Wo7JUw5kDagWdLSxwTO2fmKkimX5lDUzunYZC Mai9NkWaYo9DD6518MDJ5C8HFTLrz3CIhyM7u1WTRLUB/4R8YA== X-Google-Smtp-Source: AGHT+IFNAw6geONG7uHyOdH+kTfVeGvIPOeBOQRpfhZ7ApY3b8isvd6Qe40pUjFI/UqrmqYDl1AFwr6BtumtayLOS3Q= X-Received: by 2002:a2e:b0c9:0:b0:2bc:e221:676c with SMTP id g9-20020a2eb0c9000000b002bce221676cmr10539952ljl.0.1696325856573; Tue, 03 Oct 2023 02:37:36 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 3 Oct 2023 02:37:36 -0700 From: Stefan Kangas In-Reply-To: References: MIME-Version: 1.0 Date: Tue, 3 Oct 2023 02:37:36 -0700 Message-ID: Subject: Re: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors To: =?UTF-8?Q?Rudolf_Adamkovi=C4=8D?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60830 Cc: =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= , 60830@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Rudolf Adamkovi=C4=8D writes: > As for (2), I recompiled Emacs from 'master' (498d31e9f05) to verify > your claim, but it does seem to hold. I can reproduce the bug under > 'emacs -Q' by following the reproduction steps. > > However! I did some thinking and realized two important facts: > > (A) Even if the GNU standard supported tab-indented errors, as per (2), > it would not help, as Lua stack frames are not errors. Yes, I noticed that too. Is it a regression with regards to earlier versions of Emacs? > (B) People use older Lua versions, which will work forever, as they are > written in ANSI C, and so even if (1) is fixed upstream, we must support > the current error format as well. I see the benefit of doing that, but I wouldn't say it so strongly that we "must" do it. We could also just say that people that want these errors detected should upgrade lua. Note that people would also need to upgrade Emacs, to get this support. > After I realized that (A) and (B) are true, I used my morning to write a > patch that solves the problem properly. I am attaching the patch to > this message. Do you think the patch could be merged upstream? Mattias, what do you think of the below patch? > Thank you for your time! Thanks for working on this. > From 3bbf4019df45548d1286ba9b0dffe8fadad2bdf1 Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Rudolf=3D20Adamkovi=3DC4=3D8D?=3D > Date: Tue, 3 Oct 2023 09:07:40 +0200 > Subject: [PATCH] Make the Compilation mode recognize Lua errors > > Emacs comes with built-in support for the Lua programming language in > the form of the Lua mode and now also the Lua Tree-sitter mode. But, > Lua support in Emacs is incomplete in that the Compilation mode does > not recognize Lua errors, which is what this patch fixes. > > Reported as bug#60830. > > * lisp/progmodes/compile.el (compilation-error-regexp-alist-alist): > Add regexps to aid Lua development, namely the 'lua' regexp that > matches Lua errors and the 'lua-stack' regexp that matches Lua stack > frames. > > * test/lisp/progmodes/compile-tests.el (compile-tests--test-regexps-data)= : > (compile-test-error-regexps): Test the new 'lua' and 'lua-stack' > regexps added to the 'compilation-error-regexp-alist-alist'. > --- > lisp/progmodes/compile.el | 5 +++++ > test/lisp/progmodes/compile-tests.el | 13 +++++++++++-- > 2 files changed, 16 insertions(+), 2 deletions(-) > > diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el > index f85cc0909dd..82f8280d76d 100644 > --- a/lisp/progmodes/compile.el > +++ b/lisp/progmodes/compile.el > @@ -362,6 +362,11 @@ compilation-error-regexp-alist-alist > (ruby-Test::Unit > "^ [[ ]?\\([^ (].*\\):\\([1-9][0-9]*\\)\\(\\]\\)?:in " 1 2) > > + (lua > + "^[^: \n\t]+: \\([^: \n\t]+\\):\\([0-9]+\\): " 1 2 nil 2 1) > + (lua-stack > + "^\t\\([^: \n\t]+\\):\\([0-9]+\\): " 1 2 nil 0 1) > + > (gmake > ;; Set GNU make error messages as INFO level. > ;; It starts with the name of the make program which is variable, > diff --git a/test/lisp/progmodes/compile-tests.el b/test/lisp/progmodes/c= ompile-tests.el > index 078eef36774..889b3443993 100644 > --- a/test/lisp/progmodes/compile-tests.el > +++ b/test/lisp/progmodes/compile-tests.el > @@ -208,6 +208,15 @@ compile-tests--test-regexps-data > 1 0 31 "/usr/include/c++/3.3/backward/iostream.h") > (gcc-include " from test_clt.cc:1:" > 1 nil 1 "test_clt.cc") > + ;; Lua > + (lua "lua: database.lua:10: assertion failed!" > + 6 nil 10 "database.lua") > + (lua "/usr/local/bin/lua: core/database.lua:20: assertion failed!" > + 21 nil 20 "core/database.lua") > + (lua-stack " database.lua:10: in field 'statement'" > + 2 nil 10 "database.lua" 0) > + (lua-stack " core/database.lua:20: in field 'statement'" > + 2 nil 20 "core/database.lua" 0) > ;; gmake > (gmake "make: *** [Makefile:20: all] Error 2" 12 nil 20 "Makefile" 0= ) > (gmake "make[4]: *** [sub/make.mk:19: all] Error 127" 15 nil 19 > @@ -499,9 +508,9 @@ compile-test-error-regexps > (compilation-num-warnings-found 0) > (compilation-num-infos-found 0)) > (mapc #'compile--test-error-line compile-tests--test-regexps-data) > - (should (eq compilation-num-errors-found 100)) > + (should (eq compilation-num-errors-found 102)) > (should (eq compilation-num-warnings-found 35)) > - (should (eq compilation-num-infos-found 28))))) > + (should (eq compilation-num-infos-found 30))))) > > (ert-deftest compile-test-grep-regexps () > "Test the `grep-regexp-alist' regexps. > -- > 2.37.1 (Apple Git-137.1) From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 03 16:03:40 2023 Received: (at 60830) by debbugs.gnu.org; 3 Oct 2023 20:03:40 +0000 Received: from localhost ([127.0.0.1]:40746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnlcK-0004M2-0q for submit@debbugs.gnu.org; Tue, 03 Oct 2023 16:03:40 -0400 Received: from qs51p00im-qukt01071902.me.com ([17.57.155.9]:10675) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnlcI-0004Lo-0g for 60830@debbugs.gnu.org; Tue, 03 Oct 2023 16:03:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1696363395; bh=cNURo4Qa+xUBeAU/sWV+rG40iRJULSiPoPPa8Vz+mO8=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=Il0EM7JNBHlSeR7nmwnR+mFHv9dnBYhVeIh8FdM92XE/RPSxn4HMv+SL8O96l+Vxb PN1OJSiij2bS2JrBd7/iis/GQJrwEpYyM8CHXTTtol4y0YbDBOBwxwHrSqbtQgMY8o s8UFIQo+WrhBzvSlM7YOdID2CMeNrwz3hMelvRV2vxAOv0+JpFUa4Li9XfiNt/btKL Xxsq2Q8KtT2q32LHfgKVi6n4cgIhlUW0nP/pIloBvlCQFQWwiefa1Z4wix9IkJdn/m YQ2M/VzmYkXYOlGQPJcjNcr6Kn9K0m5S/Q9jIFbtoZLjeOYOh3EthzWav8sRAXH8G2 7+jcGrgWczv7Q== Received: from Rudolfs-MacBook-Air.local (qs51p00im-dlb-asmtp-mailmevip.me.com [17.57.155.28]) by qs51p00im-qukt01071902.me.com (Postfix) with ESMTPSA id 25ADA5EC045D; Tue, 3 Oct 2023 20:03:13 +0000 (UTC) From: Rudolf =?utf-8?Q?Adamkovi=C4=8D?= To: Stefan Kangas Subject: Re: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors In-Reply-To: References: Date: Tue, 03 Oct 2023 22:03:10 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: GaFcBOSDmP_LcBewiyA_L2Sg_6ORPxUF X-Proofpoint-GUID: GaFcBOSDmP_LcBewiyA_L2Sg_6ORPxUF X-Proofpoint-Virus-Version: =?UTF-8?Q?vendor=3Dfsecure_engine=3D1.1.170-22c6f66c430a71ce266a39bfe25bc?= =?UTF-8?Q?2903e8d5c8f:6.0.425,18.0.790,17.0.605.474.0000000_definitions?= =?UTF-8?Q?=3D2022-01-12=5F03:2022-01-11=5F01,2022-01-12=5F03,2020-01-23?= =?UTF-8?Q?=5F02_signatures=3D0?= X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 adultscore=0 bulkscore=0 mlxscore=0 mlxlogscore=746 malwarescore=0 phishscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2310030150 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60830 Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= , 60830@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Stefan Kangas writes: >> (A) Even if the GNU standard supported tab-indented errors, as per (2), >> it would not help, as Lua stack frames are not errors. > > Yes, I noticed that too. Is it a regression with regards to earlier > versions of Emacs? I was unclear in what I wrote. Let me clarify. What I meant is that every Lua error is followed by a stack trace indented with a tab character. From the point of view of a Compilation buffer, each such Lua error consists of exactly one *error* and sequence of stack frames, each of which is an *info*. Note that my patch handles all this correctly, and the tests exercise both cases, errors and stack frames, and they exercise each case twice, once with different data, to make sure all works now and in the future. > I see the benefit of doing that, but I wouldn't say it so strongly that > we "must" do it. We could also just say that people that want these > errors detected should upgrade lua. Note that people would also need to > upgrade Emacs, to get this support. It was a "mathematical" must, as in "we must find X such that..." :) As for upgrading Lua, please know that Lua is different from other languages in that it introduces breaking changes even between minor versions. This does not break all Lua projects because the language is nothing but a single ANSI C compilation unit [*] that will work forever. In practice, if a Lua project has zero dependencies, or perhaps only a few, the maintainers do not ever need to upgrade Lua. This is a key feature of Lua, not a bug. Thus, if Emacs wants to serve Lua developers well, it must recognize errors from older Lua versions as well. [*] When compiled via the 'one.c', otherwise it is multiple files. Rudy --=20 "Programming reliably -- must be an activity of an undeniably mathematical nature [=E2=80=A6] You see, mathematics is about thinking, and doing mathematics is always trying to think as well as possible." -- Edsger W. Dijkstra, 1981 Rudolf Adamkovi=C4=8D [he/him] Studenohorsk=C3=A1 25 84103 Bratislava Slovakia From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 05 07:27:52 2023 Received: (at 60830) by debbugs.gnu.org; 5 Oct 2023 11:27:52 +0000 Received: from localhost ([127.0.0.1]:46137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qoMWF-0003Qx-Lt for submit@debbugs.gnu.org; Thu, 05 Oct 2023 07:27:51 -0400 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]:55697) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qoMWC-0003Qi-NA for 60830@debbugs.gnu.org; Thu, 05 Oct 2023 07:27:50 -0400 Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-50573e85ee0so1067510e87.3 for <60830@debbugs.gnu.org>; Thu, 05 Oct 2023 04:27:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696505244; x=1697110044; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=+U1ZDvd6gPLFxVS6LvGCe/e6wLzbizvjNKBS2wJyhPY=; b=WQSODHd19Em0KSGX7mItRVDqQYMBSfjtJXDKYg91WR+O5sLoEcC3vTlJzwYWC1IOFc LWS7JOQJgE4aoBL4jJYGAa6I1RdmbBxPyY22BMkPC1q3A6bQtJKLUVH1Lr3R0DUhmhlA fGRI0hKV6g1Vp52LAg8FKhqZX/LfCjk+rNlzxaZUDJWTwgCUAihug2fyfmjHf1uffX+N MyXrjDwWgf0Uv2pU597uw5bjNsIZAHnDDCfCEFk0h7Bea97HNzt/otJFFtRniyCKeQPR DjJe1m68votgC9f1s8zfSBxEmfzq45KqzAXpuapN0K2pvifaMTx3X/jXfQcj4yRYqjsb co0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696505244; x=1697110044; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=+U1ZDvd6gPLFxVS6LvGCe/e6wLzbizvjNKBS2wJyhPY=; b=YjrP/SwsC52IFP35e1QPnApwPLgoSt8BSKYUBLhBeZSEJS1SdYAxtFkv7agWIkk+9o xC4gTdW0DjWRAqYeGhq7TYxitQ6t86/xnfuLvHmKY2+z8yInn6jHGL9VevcopfB8iTmI EXi4CKhyM/toYIJT9+m1MPrUiyNdhgZiPRFN0ImER5kcgEMzERAp+YIWlg+OqMGvPdS2 0Wu5HRAkj7c+rR9zDCDWgHTbI8GBMOqPxVGqenVwLOaK8/IjrUitec/NNveFyJpevvJf 32r5K5aFqPd6Nk18rS2NxelSNsNt7wKybGxQ7Wr5V9ROuA+8fAAH+DL+s3ahelXAFPMb ikwg== X-Gm-Message-State: AOJu0Yxut9u3NimCNML1wB/IhJ1h9R6QY4UkfOvGnXIgchCKP40OGc9I VMT1O28k4epbwtB6hNdGLLU= X-Google-Smtp-Source: AGHT+IF8kt46kdpg/hf9JQ4ieVBaoEumX7jkpHz2qsCf2UAn0SINn+crYJY23FAQuU60wvszhgIK+Q== X-Received: by 2002:a05:6512:2512:b0:4fb:740a:81ae with SMTP id be18-20020a056512251200b004fb740a81aemr5374211lfb.16.1696505244003; Thu, 05 Oct 2023 04:27:24 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id w11-20020a05651204cb00b004fe3bd81278sm258659lfq.70.2023.10.05.04.27.23 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Oct 2023 04:27:23 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: Date: Thu, 5 Oct 2023 13:27:23 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <909EF5E1-6F30-4A35-84E8-2EF4333115FD@gmail.com> References: To: =?utf-8?Q?Rudolf_Adamkovi=C4=8D?= X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60830 Cc: 60830@debbugs.gnu.org, Stefan Kangas , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 3 okt. 2023 kl. 10.12 skrev Rudolf Adamkovi=C4=8D : > + (lua > + "^[^: \n\t]+: \\([^: \n\t]+\\):\\([0-9]+\\): " 1 2 nil 2 1) This pattern matches some lines normally matched by the `gnu` rule which = comes later in the rule list. I don't know if it's a big problem -- it = may cause misclassification of some messages which should be of = 'warning' or 'info' type. > + (lua-stack > + "^\t\\([^: \n\t]+\\):\\([0-9]+\\): " 1 2 nil 0 1) I'm actually slightly more bothered by this message because it would = conflict with possible future (re-)relaxation of the `gnu` rule with = respect to leading whitespace. The matter does come up from time to = time, and it would be nice to at least have the option to do that. In addition, there's this: > (B) People use older Lua versions, which will work forever, as they = are > written in ANSI C, and so even if (1) is fixed upstream, we must = support > the current error format as well. This also means that we may need to support an open set of Lua message = types. What about adding these rules but not enabling them by default? Is that = too onerous? The 'omake' rule has now been disabled by default for other reasons = (it's something that has been discussed in the past), so there is at = least precedence for doing this. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 05 12:22:00 2023 Received: (at 60830) by debbugs.gnu.org; 5 Oct 2023 16:22:00 +0000 Received: from localhost ([127.0.0.1]:48353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qoR6u-00059e-3G for submit@debbugs.gnu.org; Thu, 05 Oct 2023 12:22:00 -0400 Received: from ms11p00im-qufo17291601.me.com ([17.58.38.45]:34330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qoR6r-00059N-9a for 60830@debbugs.gnu.org; Thu, 05 Oct 2023 12:21:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1696522893; bh=UJ/uuTjZ/YdHvT1ENfMUk2VPTCVKVkNVT0aZhHoUuqE=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=b++6jeEO979GeuuNGPNsxtPT93XaDokmEGdogqK0yGcAkBggDVpHpiCopeEx8GPB8 gdl676oyPB5lWY2zk67hiIPVIJcMG/enWwV9WG9XBOTXBbqay9aZ3AzMmpyiBtgF/9 qygzbMDuD3cnIJW2V6kvzUfZQl5oty5CsjnrJSI/chzdfqrPc6z1VRmG3ia1DGOFUx ppgXk6sr3YUVvnAkED9AjBfucY9hgE6zf7uPIsjufEHjnYSy2mCm3lZn4E5zFh+WjA kd1Cb6btZJz+qN3whw1ez0efHU8D1g0yOXWzVZIVt3CzMdV2B4FFhJybtDBg+s+7Ht Esb4qHmBzESJQ== Received: from Rudolfs-MacBook-Air.local (ms11p00im-dlb-asmtpmailmevip.me.com [17.57.154.19]) by ms11p00im-qufo17291601.me.com (Postfix) with ESMTPSA id 058CB3A0506; Thu, 5 Oct 2023 16:21:21 +0000 (UTC) From: Rudolf =?utf-8?Q?Adamkovi=C4=8D?= To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Subject: Re: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors In-Reply-To: <909EF5E1-6F30-4A35-84E8-2EF4333115FD@gmail.com> References: <909EF5E1-6F30-4A35-84E8-2EF4333115FD@gmail.com> Date: Thu, 05 Oct 2023 18:21:02 +0200 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Proofpoint-GUID: GBYi0yaVXpkyjvshrVGqlG8DXLDaJunQ X-Proofpoint-ORIG-GUID: GBYi0yaVXpkyjvshrVGqlG8DXLDaJunQ X-Proofpoint-Virus-Version: =?UTF-8?Q?vendor=3Dfsecure_engine=3D1.1.170-22c6f66c430a71ce266a39bfe25bc?= =?UTF-8?Q?2903e8d5c8f:6.0.425,18.0.572,17.0.605.474.0000000_definitions?= =?UTF-8?Q?=3D2022-01-14=5F01:2022-01-14=5F01,2020-02-14=5F11,2020-01-23?= =?UTF-8?Q?=5F02_signatures=3D0?= X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=963 bulkscore=0 spamscore=0 adultscore=0 suspectscore=0 malwarescore=0 clxscore=1011 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2310050128 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60830 Cc: 60830@debbugs.gnu.org, Stefan Kangas , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mattias Engdeg=C3=A5rd writes: > This pattern matches some lines normally matched by the `gnu` rule > which comes later in the rule list. I don't know if it's a big problem > -- it may cause misclassification of some messages which should be of > 'warning' or 'info' type. Good to know! So, I studied 'luaL_traceback' in 'lauxlib.c' in Lua and made the regular expression more precise. No more mis-classification! > I'm actually slightly more bothered by this message because it would > conflict with possible future (re-)relaxation of the `gnu` rule with > respect to leading whitespace. The matter does come up from time to > time, and it would be nice to at least have the option to do that. Ditto; I made other expression more precise as well! > The 'omake' rule has now been disabled by default for other reasons > (it's something that has been discussed in the past), so there is at > least precedence for doing this. /Note:/ I rebased on top of 'master' (and so the 'omake' patch). See the new patch, with more precise regular expressions, attached below. While on it, I also added support for stack frames with no line number, as per Lua source code. Lastly, I added a NEWS entry, as well as, improved the commit message a bit. How about now? :) Rudy --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Make-the-Compilation-mode-recognize-Lua-errors.patch >From a267051c042b89b650e2a15597d226fe26579826 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rudolf=20Adamkovi=C4=8D?= Date: Tue, 3 Oct 2023 09:07:40 +0200 Subject: [PATCH] Make the Compilation mode recognize Lua errors Emacs comes with built-in support for the Lua programming language in the form of the Lua mode and now also the Lua Tree-sitter mode. This patch further improves Lua support in Emacs by making the Compilation mode recognize Lua errors and stack traces. Reported as bug#60830. * lisp/progmodes/compile.el (compilation-error-regexp-alist-alist): Add regexps to aid Lua development, namely the 'lua' regexp that matches Lua errors and the 'lua-stack' regexp that matches Lua stack frames. * test/lisp/progmodes/compile-tests.el (compile-tests--test-regexps-data): (compile-test-error-regexps): Test the new 'lua' and 'lua-stack' regexps added to the 'compilation-error-regexp-alist-alist'. --- etc/NEWS | 5 +++++ lisp/progmodes/compile.el | 7 +++++++ test/lisp/progmodes/compile-tests.el | 15 +++++++++++++-- 3 files changed, 25 insertions(+), 2 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index 12c2d52a4ab..cf98e8d6f43 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -307,6 +307,11 @@ This is because it partly acts by modifying other rules which may occasionally be surprising. It can be re-enabled by adding 'omake' to 'compilation-error-regexp-alist'. +*** Lua errors and stack traces are now recognized. +The compilation mode now recognizes Lua language errors and stack +traces. Every Lua error is recognized as a compilation error, and +every Lua stack frame is recognized as a compilation info. + ** VC --- diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index 9e441dbfcf7..97d4be52286 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -362,6 +362,13 @@ compilation-error-regexp-alist-alist (ruby-Test::Unit "^ [[ ]?\\([^ (].*\\):\\([1-9][0-9]*\\)\\(\\]\\)?:in " 1 2) + (lua + "^[^:\n\t]+: \\([^: \n\t]+\\):\\([0-9]+\\): .*?\nstack traceback:\n\t" + 1 2 nil 2 1) + (lua-stack + "^\t\\([^:\n\t]+\\):\\(\\([0-9]+\\):\\)? in " + 1 3 nil 0 1) + (gmake ;; Set GNU make error messages as INFO level. ;; It starts with the name of the make program which is variable, diff --git a/test/lisp/progmodes/compile-tests.el b/test/lisp/progmodes/compile-tests.el index d497644c389..18c422a5afe 100644 --- a/test/lisp/progmodes/compile-tests.el +++ b/test/lisp/progmodes/compile-tests.el @@ -206,6 +206,17 @@ compile-tests--test-regexps-data 1 0 31 "/usr/include/c++/3.3/backward/iostream.h") (gcc-include " from test_clt.cc:1:" 1 nil 1 "test_clt.cc") + ;; Lua + (lua "lua: database.lua:10: assertion failed!\nstack traceback:\n\t" + 6 nil 10 "database.lua") + (lua "/usr/local/bin/lua: core/database.lua:20: assertion failed!\nstack traceback:\n\t" + 21 nil 20 "core/database.lua") + (lua-stack " database.lua: in field 'statement'" + 2 nil nil "database.lua" 0) + (lua-stack " database.lua:10: in field 'statement'" + 2 nil 10 "database.lua" 0) + (lua-stack " core/database.lua:20: in field 'statement'" + 2 nil 20 "core/database.lua" 0) ;; gmake (gmake "make: *** [Makefile:20: all] Error 2" 12 nil 20 "Makefile" 0) (gmake "make[4]: *** [sub/make.mk:19: all] Error 127" 15 nil 19 @@ -507,9 +518,9 @@ compile-test-error-regexps 1 15 5 "alpha.c"))) (compile--test-error-line test)) - (should (eq compilation-num-errors-found 100)) + (should (eq compilation-num-errors-found 102)) (should (eq compilation-num-warnings-found 35)) - (should (eq compilation-num-infos-found 28))))) + (should (eq compilation-num-infos-found 31))))) (ert-deftest compile-test-grep-regexps () "Test the `grep-regexp-alist' regexps. -- 2.39.3 (Apple Git-145) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable --=20 "If you're thinking without writing, you only think you're thinking." --- Leslie Lamport Rudolf Adamkovi=C4=8D [he/him] Studenohorsk=C3=A1 25 84103 Bratislava Slovakia --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 06 07:39:12 2023 Received: (at 60830) by debbugs.gnu.org; 6 Oct 2023 11:39:12 +0000 Received: from localhost ([127.0.0.1]:49333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qojAm-0006po-5X for submit@debbugs.gnu.org; Fri, 06 Oct 2023 07:39:12 -0400 Received: from mail-lj1-x231.google.com ([2a00:1450:4864:20::231]:48233) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qojAe-0006pD-4j for 60830@debbugs.gnu.org; Fri, 06 Oct 2023 07:39:11 -0400 Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2c28e35752cso25351701fa.0 for <60830@debbugs.gnu.org>; Fri, 06 Oct 2023 04:38:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696592319; x=1697197119; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=TAixaPe7AuDo2fQLDHiEe5UyK4AFWVO/X8rmhfDqlxs=; b=I7kwAuwcexqiyt7wk+h/4RBfIOcuGM7tEE/vx6ksgh5X+ll7mm9sx4UJ02l4XWIVR5 17Y8F8gE86yY41+R602oO3bpeZ475VjtWOWSleiR1e4M3lq4n9M1B+aaXJ1ZLf1jXesC CEgDst2kMN7QyGw5e2B3d9hb5q9WgUKTGR38NZp5D+s6md0Pg0rBVk8o7bmyZsYv5Tz7 VEm8pqx+wmopy3HSZMNpxBBRJZWyX0hOl7nycE0w45X8mWJpjo/g13G0mNEezseEcQsB 8h/KcXY9BbnN59E1jupQeV16S2J4Pc0hPMpL6fMT7Gf0WynM3CgGUDfM09YPwLGXdbyZ Q4zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696592319; x=1697197119; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=TAixaPe7AuDo2fQLDHiEe5UyK4AFWVO/X8rmhfDqlxs=; b=BTEp136FouqWafPYspQ+9kJNbypx6zKJjCSMQQUHd/6patkXfb9wvHaqRYaUqi6FPI fCnlYnqEDYEtNmq1FGIpJOYDOYQ+R4wS6IZy+5sOacMb5u7iADrKyAlYsFQAILFEtfod iLEZpu3KYpJDWLIvdaBxUY3aqHm35BjEO7PQiefnswcFh6HSUjlarIuvEPA23ZrUev02 4xy3H18+kIyohJx5Vmyph8XxxgL8MEYaaCxzcGJVVKm2xhJzivO6vUOE2hg2YdCjmJur K59DQXn64zqYgm7WKSG039yy9GAe2yhf783leWM2ThScDR1aW6Vjc5x/ivVKXeML3Wyt 0TOw== X-Gm-Message-State: AOJu0YwSDEy+DduoQy9occ9TPP3H5RRoBA+ddw0S8qucOfxyMUnPdK5C owgwxD8VXXD/6cUqoczdtUw= X-Google-Smtp-Source: AGHT+IESOEmm4+Rs1zCbAhcoBtWEX5j8OLQM3JtayNq1mRyKH+SNAFhNhVU2h7IqAyG5wq57mpZtTw== X-Received: by 2002:a19:7b03:0:b0:500:aed0:cb1b with SMTP id w3-20020a197b03000000b00500aed0cb1bmr6632684lfc.24.1696592318896; Fri, 06 Oct 2023 04:38:38 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id z14-20020ac25dee000000b004f755ceafbcsm267430lfq.217.2023.10.06.04.38.37 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Oct 2023 04:38:37 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: Date: Fri, 6 Oct 2023 13:38:37 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <4996E536-72CE-4E6A-9C75-CF7307A82469@gmail.com> References: <909EF5E1-6F30-4A35-84E8-2EF4333115FD@gmail.com> To: =?utf-8?Q?Rudolf_Adamkovi=C4=8D?= X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60830 Cc: 60830@debbugs.gnu.org, Stefan Kangas , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 5 okt. 2023 kl. 18.21 skrev Rudolf Adamkovi=C4=8D : > So, I studied 'luaL_traceback' in 'lauxlib.c' in Lua and > made the regular expression more precise. No more mis-classification! That's the spirit! > /usr/bin/lua: database.lua:31: assertion failed! > stack traceback: > [C]: in function 'assert' > database.lua:31: in field 'statement' > database.lua:42: in field 'table' > database.lua:55: in field 'row' > database.lua:63: in field 'value' > database.lua:68: in main chunk > [C]: in ? Your rules incorrectly match "[C]" as a file name. This isn't just a = matter of aesthetics; the user must be able to step through matches = without tripping. As to your implementation: > (lua > "^[^:\n\t]+: \\([^: \n\t]+\\):\\([0-9]+\\): .*?\nstack = traceback:\n\t" > 1 2 nil 2 1) > (lua-stack > "^\t\\([^:\n\t]+\\):\\(\\([0-9]+\\):\\)? in " > 1 3 nil 0 1) I see no reason for the non-greedy match in the first regexp, do you? We try to make rules work with Windows file names (or names containing = spaces, which are also somewhat common on Windows) where relevant and = practical. Your patterns don't; can you argue that it's not useful for = Lua or not possible to do so? Don't keep capture groups that you don't use. (If you use rx then you = don't have to think about it. If you don't, I'm probably going to = translate your regexp to rx anyway.) I'm still erring on having these rules disabled by default because they = seem very close to unrelated compiler output. Would that be a major = inconvenience? > While on it, I also added support for stack frames with no line > number, as per Lua source code. That doesn't result in anything useful as far as I can tell. > Lastly, I added a NEWS entry, as well > as, improved the commit message a bit. Please include an addition to etc/compilation.txt as well. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 06 09:21:36 2023 Received: (at 60830) by debbugs.gnu.org; 6 Oct 2023 13:21:36 +0000 Received: from localhost ([127.0.0.1]:49458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qokls-0003vJ-Cq for submit@debbugs.gnu.org; Fri, 06 Oct 2023 09:21:36 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:18526) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qoklp-0003v5-VU for 60830@debbugs.gnu.org; Fri, 06 Oct 2023 09:21:34 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 6A17C800AD; Fri, 6 Oct 2023 09:21:08 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1696598467; bh=+Kq53XF3Zc1QL4n440j7v588AlE4FQ0lSdD+FEbUhO4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=pAK2P+y42SuAB+EyGxs2LQY8Px2H1e5K2obwfmV8XG1l6I7gvcgGtleZEe3O7p/3l cyb8bQfyQcqDCwNwCYsO/g5FDllEdXMu70rx4Yqj/l58+FUTRrA8huYYa/wY6gbbKA 7Kg+2rVnXQfvkxAykIzYGyw81/0smO1VnKSwPMUFFt0s2CVGwGkHJZtPOvuxq+Mg7x yw3YazqENLQRoPtSbYvJBSTgWOlWMbaAyigEu0zzTpSfMhq7s5NLr6YH48n/4vnTFb a3vucsvdWJYQ6WXHN4sX+YCQFznskClmkMiLz8HJ/KA0etQhgKk+b2jHZddWjd7X/j JDXwxIyW4nqaw== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 0E237805F9; Fri, 6 Oct 2023 09:21:07 -0400 (EDT) Received: from pastel (unknown [45.72.225.62]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A3953120250; Fri, 6 Oct 2023 09:21:06 -0400 (EDT) From: Stefan Monnier To: Mattias =?windows-1252?Q?Engdeg=E5rd?= Subject: Re: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors In-Reply-To: <4996E536-72CE-4E6A-9C75-CF7307A82469@gmail.com> ("Mattias =?windows-1252?Q?Engdeg=E5rd=22's?= message of "Fri, 6 Oct 2023 13:38:37 +0200") Message-ID: References: <909EF5E1-6F30-4A35-84E8-2EF4333115FD@gmail.com> <4996E536-72CE-4E6A-9C75-CF7307A82469@gmail.com> Date: Fri, 06 Oct 2023 09:21:04 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.013 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60830 Cc: 60830@debbugs.gnu.org, Rudolf =?utf-8?Q?Adamkovi=C4=8D?= , Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > I'm still erring on having these rules disabled by default because they seem > very close to unrelated compiler output. Would that be > a major inconvenience? Can we rely on the ordering in `compilation-error-regexp-alist` to give precedence to the other rules? Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 06 10:00:42 2023 Received: (at 60830) by debbugs.gnu.org; 6 Oct 2023 14:00:42 +0000 Received: from localhost ([127.0.0.1]:52329 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qolNi-0008L6-1q for submit@debbugs.gnu.org; Fri, 06 Oct 2023 10:00:42 -0400 Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]:59415) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qolNg-0008Kr-A5 for 60830@debbugs.gnu.org; Fri, 06 Oct 2023 10:00:40 -0400 Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2bffc55af02so25568711fa.2 for <60830@debbugs.gnu.org>; Fri, 06 Oct 2023 07:00:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696600815; x=1697205615; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=f5DRh7Y7rgYmqrNOr37VmeU9l8dqZ/dB4iGRkKKP8hY=; b=jHcPHzDLkUTyoZbs/tpab4Gf2A6rur7aUq8y0FuuS70vZULtlX5q0qA9FLYMJIsd5L Yimx5ef25/G/W2T+kGq60/tssXjcKoVlBjodZ3rn9WVWD0+CNhleter3FJ4LhX6mvGxq 0MmdnNtj/G/Zrd/Cs9LRaJuL9w2SbcCM2GnEBIM1FyczPB+MJvYxXpe4XpkB7/zImzhY uMbCTwc24uzAoowhS52K8tN8ZKbg6z2iiRdVtHhq6Mrwqwnt94piofyLDk7czNsFgJPN o2B4MlQYAee1+A10EGiucb2jJ5fSKIPKLZg/CaUbW47nrkJzd7MoJ/+109WG4G42aWg1 vang== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696600815; x=1697205615; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=f5DRh7Y7rgYmqrNOr37VmeU9l8dqZ/dB4iGRkKKP8hY=; b=E3TbDqAVxRyU00oQogD8orpsdLm3nwpEj/xKUwtdPT1hAFD4JjXBPNYZYFPVpiPmzk WChOEBt8L08gGuCY7x1PhlHGsq9TgZbILd+f6xBLRrn2TiP7MWYDOQLqJO7JeH+aAfp9 WINWYrCtJpkIcdHiKmTONgKJeOa5vOWPvF62kQiSWCoTVUrkA6HkfO0OHg+39TOi5sc7 K4IFmAF7cszDiNGZZsTNdc0wTa4yMfTTqgnD56IH5WRBxCU3gSeJ4evqsQbegdFeVIE9 gTnfvX8omGU/xJg/IHQa5o/uGpbQM9I/DrqsllQuctYoiZz0RssueUNigj7ufjaDN/3h C8fQ== X-Gm-Message-State: AOJu0YwHAHzUvbMRMw7J7yZSfG0PwKXxsdK2P/4yKwkcgEHSM1oxM/mv 4gZMWCEcuRT/mnmj74+9b40= X-Google-Smtp-Source: AGHT+IGelWG8OTqHAfisIKBo7mzYfYbnA/CS6jf7FDvxgvmxOi/Z3scfHdf9p522vaFu7C4JKLbUpA== X-Received: by 2002:a05:6512:1390:b0:500:a2d3:3e65 with SMTP id fc16-20020a056512139000b00500a2d33e65mr8359924lfb.23.1696600814594; Fri, 06 Oct 2023 07:00:14 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id h21-20020a197015000000b004edc72be17csm318730lfc.2.2023.10.06.07.00.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Oct 2023 07:00:13 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: Date: Fri, 6 Oct 2023 16:00:13 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <5CB2325C-0A1E-4AC6-B61E-DFA46F3CFC80@gmail.com> References: <909EF5E1-6F30-4A35-84E8-2EF4333115FD@gmail.com> <4996E536-72CE-4E6A-9C75-CF7307A82469@gmail.com> To: Stefan Monnier X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60830 Cc: 60830@debbugs.gnu.org, =?utf-8?Q?Rudolf_Adamkovi=C4=8D?= , Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 6 okt. 2023 kl. 15.21 skrev Stefan Monnier : > Can we rely on the ordering in `compilation-error-regexp-alist` to = give > precedence to the other rules? Currently the ordering in `compilation-error-regexp-alist` (CERA for = short) is the one used, but perhaps you mean the ordering in = `compilation-error-regexp-alist-alist` (CERAA)? I suppose we could compute a permutation of CERA that is consistent with = CERAA and cache it to avoid doing it for every call to = `compilation-parse-errors`, but what to do about non-symbol elements in = CERA? It's easiest to keep letting the user assume responsibility for ordering = CERA correctly if customised. That said, the customisation mechanism = doesn't work well for CERA. Perhaps it would be better to have a list of = desired changes. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 06 10:47:56 2023 Received: (at 60830) by debbugs.gnu.org; 6 Oct 2023 14:47:56 +0000 Received: from localhost ([127.0.0.1]:52367 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qom7Q-0001CE-JL for submit@debbugs.gnu.org; Fri, 06 Oct 2023 10:47:56 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:47443) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qom7O-0001BR-Ko for 60830@debbugs.gnu.org; Fri, 06 Oct 2023 10:47:55 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E5BCC805F9; Fri, 6 Oct 2023 10:47:28 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1696603647; bh=Ai7/28DMKzhcQ4oOuVdBfBzGZWVasxLN/PO4Ko39c+U=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=pn5epbJCi4F3wcKfbzcXJn9MMTCsmSth3p1vLTYK5oDehubCY4LwWv0ukdfjXXMGr 42aiSyJSyM5j4+ARxfI80RC2urQ0e9lhHmlUSAZskjZFXsdyAi1r//AOVey/V2VKMP vc09OJ9NVgf5FgXmzgYuriu57xqpp8ljuwcN3Ej+EWzmRSLLRNSW58Z3DcriIiboPl Sa3OUEU0fxZ8nM/sSvK68bCmgyVDk0kwGwXbW2DIJORXQcppV3sah/WEJFII5Uqsib 4QDkVNewKYDzkQ0Q10Fvhhj9dzvaYYO2BUTk0iDGSAQ9FuG1/8gtsjPuiIPMFDoR/P nZtd15rqGSBCg== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 6E0CD8025F; Fri, 6 Oct 2023 10:47:27 -0400 (EDT) Received: from alfajor (modemcable005.21-80-70.mc.videotron.ca [70.80.21.5]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 45D2C120338; Fri, 6 Oct 2023 10:47:27 -0400 (EDT) From: Stefan Monnier To: Mattias =?windows-1252?Q?Engdeg=E5rd?= Subject: Re: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors In-Reply-To: <5CB2325C-0A1E-4AC6-B61E-DFA46F3CFC80@gmail.com> ("Mattias =?windows-1252?Q?Engdeg=E5rd=22's?= message of "Fri, 6 Oct 2023 16:00:13 +0200") Message-ID: References: <909EF5E1-6F30-4A35-84E8-2EF4333115FD@gmail.com> <4996E536-72CE-4E6A-9C75-CF7307A82469@gmail.com> <5CB2325C-0A1E-4AC6-B61E-DFA46F3CFC80@gmail.com> Date: Fri, 06 Oct 2023 10:47:26 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.316 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60830 Cc: 60830@debbugs.gnu.org, Rudolf =?utf-8?Q?Adamkovi=C4=8D?= , Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> Can we rely on the ordering in `compilation-error-regexp-alist` to give >> precedence to the other rules? > Currently the ordering in `compilation-error-regexp-alist` (CERA for shor= t) > is the one used, but perhaps you mean the ordering in > `compilation-error-regexp-alist-alist` (CERAA)? No, I do mean the ordering in CERA: is there a reason not to use this ordering to lower the precedence of those Lua rules instead of disabling them? Admittedly, there is a performance cost to having all those big regexps active "just in case". Short of convincing tool authors to stop the madness and to settle on a standard format (seems the only accepted such standard format, nowadays, is LSP =F0=9F=99=81), I wonder is we could = come with a way to figure out tell tale signs that particular tools might be (or can't be) used. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 06 12:21:16 2023 Received: (at 60830) by debbugs.gnu.org; 6 Oct 2023 16:21:16 +0000 Received: from localhost ([127.0.0.1]:52502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qonZj-0006cc-LB for submit@debbugs.gnu.org; Fri, 06 Oct 2023 12:21:16 -0400 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]:48631) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qonZh-0006cN-Qk for 60830@debbugs.gnu.org; Fri, 06 Oct 2023 12:21:14 -0400 Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-5044dd5b561so2847115e87.1 for <60830@debbugs.gnu.org>; Fri, 06 Oct 2023 09:20:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696609248; x=1697214048; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=4qJPN/0p1f3qBXHp8t0WwJDbZWQJfxpFAK7cxffLDn0=; b=RWD0Py2VBqmtaWBgzM76XI7T7ks8DtOTCugUWTJTHNt7MAJeEfCxlG83xCOQS5BCpI Vj0GnlmJtrBu3xl1TP1BES3i53oc6IVTeZ1Q0e6a8OEXqVSLBvrlwdVhIXL/EVM1xRic 8nLb5X8RApWoJQYrcNcpKAC7xXHvRNZL4W0+7ntnweOIGl8Ql2Kw7bEOFUK383MNDfCd 03h+Vjp7ozpQT31EWpa9QGJaR3s/1E1Ep+D4gBSJD3llqHeKTjwoNVMHa2h58JJVvg/D 50z81qu0dRv4RV5ypSuWKLpkOOV+MIhz/AMxKDj2ZaGgofv6GV2Ze59FeC927k4H+mY2 6Swg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696609248; x=1697214048; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=4qJPN/0p1f3qBXHp8t0WwJDbZWQJfxpFAK7cxffLDn0=; b=teYwenIjejz4FyOqgySZnTNgm3DiC7gjCStZCJZRJWxznHfSzvdkuZfs00D2ZRtSpt HdB3RuLOGL0u6Z8hmZo97u2r3dLzRUONZXfgaYFncl25S34n++PS8TS8KBcbfYLE2DVX j/dWHM3J9DQfGOonDRilQ4c18YzTfBxSf4HUzLjKpiYe/DyY5Ozm4H/DnPCXnLMvZH7O fobUoS/GrTwmFuuT/p4TKdSLbfdOgFzo3oAs0dEedROmm4fa/T38yyi2etqKeY3QvpfI ye6Tpwlm6PJ5eFmHG0skwb/nt+pqTqoGxOu5ui/TAhdqGOvsSPckgMcvHFD6r7JxcvV4 hQKQ== X-Gm-Message-State: AOJu0YychO/Nws9nLu0vXlJckunp9iDUej0cb3+/yzKg3nf00/0A+txk un8QeI5YkFd+LZNuWsHPSWg= X-Google-Smtp-Source: AGHT+IEXV3xXtlTF5KLpNAliS2XkmDZQuVhVG37dhxwpTfaCSDhA22VVHi9MG7cq+5cgnOoYJFHDyA== X-Received: by 2002:ac2:5f64:0:b0:4fe:347d:7c4b with SMTP id c4-20020ac25f64000000b004fe347d7c4bmr7346074lfc.7.1696609247742; Fri, 06 Oct 2023 09:20:47 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id u13-20020ac248ad000000b00504818fcb07sm353762lfg.266.2023.10.06.09.20.47 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Oct 2023 09:20:47 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: Date: Fri, 6 Oct 2023 18:20:45 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <6F3E07C8-3E9E-481C-B89C-7045D1028A2A@gmail.com> References: <909EF5E1-6F30-4A35-84E8-2EF4333115FD@gmail.com> <4996E536-72CE-4E6A-9C75-CF7307A82469@gmail.com> <5CB2325C-0A1E-4AC6-B61E-DFA46F3CFC80@gmail.com> To: Stefan Monnier X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60830 Cc: 60830@debbugs.gnu.org, =?utf-8?Q?Rudolf_Adamkovi=C4=8D?= , Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 6 okt. 2023 kl. 16.47 skrev Stefan Monnier : > No, I do mean the ordering in CERA: is there a reason not to use this > ordering to lower the precedence of those Lua rules instead of > disabling them? I'd say keeping rules active but placed where they never or only = sometimes match can be seen as the worst of all choices: there is no = indication that they are essentially inactive but things don't work = right, and they still consume CPU. What about powering ahead in the other direction and disable a whole lot = of rarely-used rules? (No shortage of those.) Perhaps we could make a = nicer interface for discovery and selection of available rules. The = natural way is selecting a subset, not composing a list. The rule names aren't ideal either and tell the user very little. We = could augment each rule with a short description and an example of what = they match, and perhaps information about rules that conflict. > Admittedly, there is a performance cost to having all those big = regexps > active "just in case". =20 Yes, and the number keeps growing so unless we start removing or = disabling ones, it's only getting worse. > I wonder is we could come > with a way to figure out tell tale signs that particular tools might = be > (or can't be) used. I can think of some dodgy heuristics that will make nobody happy but = that's it. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 06 12:50:12 2023 Received: (at 60830) by debbugs.gnu.org; 6 Oct 2023 16:50:12 +0000 Received: from localhost ([127.0.0.1]:52535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qoo1j-0007iN-Va for submit@debbugs.gnu.org; Fri, 06 Oct 2023 12:50:12 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:10471) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qoo1e-0007hi-Tr for 60830@debbugs.gnu.org; Fri, 06 Oct 2023 12:50:10 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 0E48E4441EC; Fri, 6 Oct 2023 12:49:42 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1696610980; bh=NMxv0NEyzA1jLfqoX8p+5pDBhs+qI7TpUTQc5v8SEyc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=How9DeQU8DP7zQqBsLZMR9xzideVIhLar+rG5sMd8ejGGKCtN+ZJtUxTNAOeC0Et/ +G4T1iPcPfr7z1+QXOn1qahGoJ3NhDBsvzfqXe1WOZWX1UHhMBerMFpg4vB8wsOLoH oYwWFAUmzOiEzQWO010slRdvQCUrTu/feGXl38/Swo2OEflpbrD/VR7tKVNMsrmHL4 fp2iDTf7kuXER2xlpsPwax6osEROth2pv8RvYP2IL+KBLw328R6saeLVBAyMF67Ez1 tE/TPtSc4pfE8faAEkylDbs8VZHn0CNhKOZTcMKGGn4OPy4pnzE4r6yz8/5/wQGDlc KJjdW+1W/cTFA== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 94C634441EE; Fri, 6 Oct 2023 12:49:40 -0400 (EDT) Received: from alfajor (modemcable005.21-80-70.mc.videotron.ca [70.80.21.5]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7274C1201AF; Fri, 6 Oct 2023 12:49:40 -0400 (EDT) From: Stefan Monnier To: Mattias =?windows-1252?Q?Engdeg=E5rd?= Subject: Re: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors In-Reply-To: <6F3E07C8-3E9E-481C-B89C-7045D1028A2A@gmail.com> ("Mattias =?windows-1252?Q?Engdeg=E5rd=22's?= message of "Fri, 6 Oct 2023 18:20:45 +0200") Message-ID: References: <909EF5E1-6F30-4A35-84E8-2EF4333115FD@gmail.com> <4996E536-72CE-4E6A-9C75-CF7307A82469@gmail.com> <5CB2325C-0A1E-4AC6-B61E-DFA46F3CFC80@gmail.com> <6F3E07C8-3E9E-481C-B89C-7045D1028A2A@gmail.com> Date: Fri, 06 Oct 2023 12:49:39 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.213 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60830 Cc: 60830@debbugs.gnu.org, Rudolf =?utf-8?Q?Adamkovi=C4=8D?= , Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> I wonder is we could come with a way to figure out tell tale signs >> that particular tools might be (or can't be) used. > I can think of some dodgy heuristics that will make nobody happy but that's it. How 'bout we only activate a handful of rules, and then use a "low priority background" search for matches to the non-active rules and when we find such a match we bring it to the users' attention that maybe they should enable that extra rule? Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 07 07:19:20 2023 Received: (at 60830) by debbugs.gnu.org; 7 Oct 2023 11:19:20 +0000 Received: from localhost ([127.0.0.1]:53486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qp5L6-0002ER-Fj for submit@debbugs.gnu.org; Sat, 07 Oct 2023 07:19:20 -0400 Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]:53363) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qp5L4-0002ED-Ts for 60830@debbugs.gnu.org; Sat, 07 Oct 2023 07:19:19 -0400 Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-50435ad51bbso3667813e87.2 for <60830@debbugs.gnu.org>; Sat, 07 Oct 2023 04:18:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696677533; x=1697282333; darn=debbugs.gnu.org; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:sender:from:to:cc:subject:date:message-id:reply-to; bh=HE82fKsRqNui1lL85Tut5y5rEeddBFtWKXtw14M0LWA=; b=RYXBWXJLI7/cY0/dsmF5jqcPd/smAcGhCVIhZGzV+WZBQm7W5rww7328WatHK68Pg3 EefarGZMFKZKyi63e6I6nbRON0yhhhqRYeX6w66xf4+BIubjaFkSQ8XBkO9jw8R5pY8v +V7bwQtGQpZUrHKWAVLqHrzpVk+8Rfi+4DpuHNk7nX33fkmUGlEX4ETLxYY0CwyarCir y9PZAu64HuC07gsdrLzOOOBY0FSVsFPsAI2BVq4ekmbLBhswyxtC6+7UCojR4ZIMpUre WL9NnhoIUZzDuyQRc1RjRWSoP0gD2Y6fpRN1dyoOo8mAP92MSAs1EYrtCSEdbIHilW5m Ceiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696677533; x=1697282333; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HE82fKsRqNui1lL85Tut5y5rEeddBFtWKXtw14M0LWA=; b=EAQiI4e8a2mQwQ1tQQbndqs+ddxcbhy6+dLlnDxIH4jM/JcvAUECfegI39fTpR/Zf9 fP5TZYkdeOSChy5ds1BvXvQmyF0gDCDAsU0gisA4VLMalkT9a/GGxDbs7pWDThbDU23l oiSL1g76gx4we+we0ocLLA4v816Yp2S5IVZkMVtwBe9hCXlce3HMd+nRP/UhYFSv0JoK g8K1T3iTlBuci5qHRMzOKhN/0RPNlI53DothpW05Hjfzd6YMj5yuW8w0mRFx/9DgxWnh M81++w+hW4J2nxt4RqDeKKvYdItcdLWQAjpBrBiAg6mBVJJiekaQKHTZkKUbzhNChRAa XKqw== X-Gm-Message-State: AOJu0YxK9arLiqwT1UfdryTTJUHOs8twvLCfRkZTdKwqUt8hYRR7CXhm EVoTp7hPYuofiqKBjUc+bUo= X-Google-Smtp-Source: AGHT+IF/MN6p5Opci4Ix4doEbmfG6Gf1CP50e465bea85TgVLq4jQ9zDWVMxt+DF5zAfnMiIVlQfUA== X-Received: by 2002:a05:6512:208d:b0:500:bfcb:1bf9 with SMTP id t13-20020a056512208d00b00500bfcb1bf9mr8604112lfr.67.1696677533258; Sat, 07 Oct 2023 04:18:53 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id u7-20020a056512040700b00501ce0cacb6sm659151lfk.188.2023.10.07.04.18.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 Oct 2023 04:18:52 -0700 (PDT) From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Message-Id: Content-Type: multipart/mixed; boundary="Apple-Mail=_ED491BBF-718E-4A02-B67B-DDFC0C122014" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors Date: Sat, 7 Oct 2023 13:18:51 +0200 In-Reply-To: To: Stefan Monnier References: <909EF5E1-6F30-4A35-84E8-2EF4333115FD@gmail.com> <4996E536-72CE-4E6A-9C75-CF7307A82469@gmail.com> <5CB2325C-0A1E-4AC6-B61E-DFA46F3CFC80@gmail.com> <6F3E07C8-3E9E-481C-B89C-7045D1028A2A@gmail.com> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60830 Cc: 60830@debbugs.gnu.org, =?utf-8?Q?Rudolf_Adamkovi=C4=8D?= , Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Apple-Mail=_ED491BBF-718E-4A02-B67B-DDFC0C122014 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii 6 okt. 2023 kl. 18.49 skrev Stefan Monnier : > How 'bout we only activate a handful of rules, and then use a "low > priority background" search for matches to the non-active rules and = when > we find such a match we bring it to the users' attention that maybe = they > should enable that extra rule? "It looks like you are compiling a Pascal program using a Sun compiler = from 1989. Would you like me to parse the error messages for you?" Even if we were to pull off the 'low priority background' part, it seems = difficult to balance such a mechanism so that it's never annoying yet = relevant when it needs to be. In any case we would benefit from a better way to select rules. One = problem is that packages (and users) go wild modifying both CERA and = CERAA. Here is a patch that I'm not satisfied with but tries to make = CERA easier to customise interactively. Its main limitation is assuming that explicit rule specs precede symbols = that refer to CERAA, which makes some kind of sense (new rules are added = for a reason so they should take priority) but may not correspond to = reality. Not sure what to do about that, but at least it's a start. --Apple-Mail=_ED491BBF-718E-4A02-B67B-DDFC0C122014 Content-Disposition: attachment; filename=cera-type.diff Content-Type: application/octet-stream; x-unix-mode=0644; name="cera-type.diff" Content-Transfer-Encoding: 7bit diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index 9e441dbfcf7..f683859a179 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -748,11 +748,32 @@ compilation-error-regexp-alist variable, the `compilation-transform-file-match-alist' variable is then consulted. It allows further transformations of the matched file names, and weeding out false positives." - :type '(repeat (choice (symbol :tag "Predefined symbol") - (sexp :tag "Error specification"))) + :type '(list :tag "Rules" + (repeat :inline t + :tag "Custom message rules" + (list :tag "Rule specification" + regexp + (sexp :tag "File") + (sexp :tag "Line") + (sexp :tag "Column") + (sexp :tag "Type") + (sexp :tag "Hyperlink") + (repeat :inline t + :tag "Highlights" + (list :tag "Highlight" + (natnum :tag "Submatch") + (sexp :tag "Face"))))) + (set :inline t + :tag "Predefined rules" + :convert-widget compilation--predef-rules-widgets)) :link `(file-link :tag "example file" ,(expand-file-name "compilation.txt" data-directory))) +(defun compilation--predef-rules-widgets (widget) + (widget-put widget :args (mapcar (lambda (x) (list 'const (car x))) + compilation-error-regexp-alist-alist)) + widget) + (defvar compilation-error-case-fold-search nil "If non-nil, use case-insensitive matching of compilation errors. If nil, matching is case-sensitive. --Apple-Mail=_ED491BBF-718E-4A02-B67B-DDFC0C122014-- From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 07 11:22:56 2023 Received: (at 60830) by debbugs.gnu.org; 7 Oct 2023 15:22:56 +0000 Received: from localhost ([127.0.0.1]:55675 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qp98p-0001Ha-Ke for submit@debbugs.gnu.org; Sat, 07 Oct 2023 11:22:55 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:14967) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qp98n-0001HO-Ew for 60830@debbugs.gnu.org; Sat, 07 Oct 2023 11:22:54 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 72E8680595; Sat, 7 Oct 2023 11:22:28 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1696692143; bh=ozMbkaeZ2wLGE7M3JL6xiwEs2cGzsn/aIZ7+U6yr82M=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=bTas19Zyprksy84L2QUMp7vkmPnn2QzfEy4DVHA6reOZ/QnWd9rf4NGbPhfE4zHAR koEf+OaHYJY+C3TVzgwTtj6oUCYuVj/ICggRNrREiBsSH8pbUr9WqugxEl48cOHvTd Yn8koPXJqOy0oVXMYvk17CaqAJtgvCQs9plKSn6Jsc8heRVmOFEmr/N4xLOeWiZxaE WsGwEcMBl1TYLlv+GPiz8oheNSxwpE69Wk8boSZCevZEnCcgTiqhFlkWdw51F8rH6o DANw9vR9ms8d/okETXcmgR3dS4PExeAGYPUPIs0ufjSb5CqsR8Aj0OmjnuLQ8nZgKt OjnyQHdGOHpIg== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id F3CA580148; Sat, 7 Oct 2023 11:22:22 -0400 (EDT) Received: from pastel (unknown [45.72.225.62]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C288712040B; Sat, 7 Oct 2023 11:22:22 -0400 (EDT) From: Stefan Monnier To: Mattias =?windows-1252?Q?Engdeg=E5rd?= Subject: Re: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors In-Reply-To: ("Mattias =?windows-1252?Q?Engdeg=E5rd=22's?= message of "Sat, 7 Oct 2023 13:18:51 +0200") Message-ID: References: <909EF5E1-6F30-4A35-84E8-2EF4333115FD@gmail.com> <4996E536-72CE-4E6A-9C75-CF7307A82469@gmail.com> <5CB2325C-0A1E-4AC6-B61E-DFA46F3CFC80@gmail.com> <6F3E07C8-3E9E-481C-B89C-7045D1028A2A@gmail.com> Date: Sat, 07 Oct 2023 11:22:22 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.013 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60830 Cc: 60830@debbugs.gnu.org, Rudolf =?utf-8?Q?Adamkovi=C4=8D?= , Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Even if we were to pull off the 'low priority background' part, I'm counting on you for this part. > it seems difficult to balance such a mechanism so that it's never > annoying yet relevant when it needs to be. I suspect the "never annoying" is not too hard to get: those regexps are currently matched so if they were annoying we'd know about it. So just: if there's a match highlight it somehow and put a `help-echo` (and maybe also a `mouse-2` binding) that tells how to activate it. > In any case we would benefit from a better way to select rules. Agreed. > One problem is that packages (and users) go wild modifying both CERA > and CERAA. Here is a patch that I'm not satisfied with but tries to > make CERA easier to customise interactively. Looks OK to me, tho it will complain to the user if they have it set to a shape that doesn't fit your mold :-( > Its main limitation is assuming that explicit rule specs precede symbols > that refer to CERAA, which makes some kind of sense (new rules are added for > a reason so they should take priority) but may not correspond to > reality. Not sure what to do about that, but at least it's a start. I wonder how common it is for people to set it "manually" in their init file. It seems more common to set it in ELisp packages. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 07 17:02:57 2023 Received: (at 60830) by debbugs.gnu.org; 7 Oct 2023 21:02:57 +0000 Received: from localhost ([127.0.0.1]:55989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpERs-0007Fy-Vl for submit@debbugs.gnu.org; Sat, 07 Oct 2023 17:02:57 -0400 Received: from qs51p00im-qukt01072102.me.com ([17.57.155.11]:54953) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpERr-0007Fk-0z for 60830@debbugs.gnu.org; Sat, 07 Oct 2023 17:02:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1696712549; bh=QFVa8eNAnZ2A67bHdtUMK/DUrRQHmiqEPY3EswtNfVY=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=WgOdUcKMtfQ32Fm9jnqWAwB05x+o8MBixl3Ur1M1MFvVD+PYpk2+3OJ7fz64SjfsC PQ5jy1wZ/5NPm+1t5dtpYrQDNyV1nXBheDN3Nz5WFmR7ICmnw6z7Fq9dCMB2ic4bHE 4E6Jhdw7341TT4LgRL2C2teN/98TzlJJOCxPgZJKFQKjkLTX5dkdD1DxUOUMIEyuR8 vEWTqliz4wDKh8fcEOsA4yn/SqfDpCgTLc1nww3bxF4zzCA5bSyJIhcq3ajut/hk19 L/3s7sU8POpdm6XmYGav6coyI9W4TNe4VbIbEcodEUj4cliFxoiP8U7m8gnEpLO1tw JX81tzQIRYqog== Received: from Rudolfs-MacBook-Air.local (qs51p00im-dlb-asmtp-mailmevip.me.com [17.57.155.28]) by qs51p00im-qukt01072102.me.com (Postfix) with ESMTPSA id 86D72340214; Sat, 7 Oct 2023 21:02:28 +0000 (UTC) From: Rudolf =?utf-8?Q?Adamkovi=C4=8D?= To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Subject: Re: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors In-Reply-To: <4996E536-72CE-4E6A-9C75-CF7307A82469@gmail.com> References: <909EF5E1-6F30-4A35-84E8-2EF4333115FD@gmail.com> <4996E536-72CE-4E6A-9C75-CF7307A82469@gmail.com> Date: Sat, 07 Oct 2023 23:02:25 +0200 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Proofpoint-ORIG-GUID: bChcAAy6_AjTY8zKWz_RnKasq6pSCmK6 X-Proofpoint-GUID: bChcAAy6_AjTY8zKWz_RnKasq6pSCmK6 X-Proofpoint-Virus-Version: =?UTF-8?Q?vendor=3Dfsecure_engine=3D1.1.170-22c6f66c430a71ce266a39bfe25bc?= =?UTF-8?Q?2903e8d5c8f:6.0.425,18.0.572,17.0.605.474.0000000_definitions?= =?UTF-8?Q?=3D2022-01-11=5F01:2022-01-11=5F01,2020-02-14=5F11,2020-01-23?= =?UTF-8?Q?=5F02_signatures=3D0?= X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 mlxscore=0 bulkscore=0 clxscore=1015 spamscore=0 suspectscore=0 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2310070193 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60830 Cc: 60830@debbugs.gnu.org, Stefan Kangas , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mattias Engdeg=C3=A5rd writes: > Your rules incorrectly match "[C]" as a file name. This isn't just a > matter of aesthetics; the user must be able to step through matches > without tripping. Good catch! I have two questions: (1) How can I specify "this group cannot be '[C]'" in the regexp? (2) How can I test this scenario in 'compile-tests.el'? > I see no reason for the non-greedy match in the first regexp, do you? I made the relevant groups greedy, but I wonder what difference it makes. Is there a way to test the change in 'compile-tests.el'? > We try to make rules work with Windows file names (or names containing > spaces, which are also somewhat common on Windows) where relevant and > practical. Your patterns don't; can you argue that it's not useful for > Lua or not possible to do so? Good catch! Fixed. > Don't keep capture groups that you don't use. Fixed and TIL about "shy groups". > I'm still erring on having these rules disabled by default because > they seem very close to unrelated compiler output. Would that be a > major inconvenience? I would understand if we did that for some long-dead compilers but not for Lua. I think we need a systematic approach to solve the performance penalty and false positives. Arbitrarily disabling languages that are alive and well, and even supported by Emacs out of the box, such as Lua, is not a good idea, IMHO. >> While on it, I also added support for stack frames with no line >> number, as per Lua source code. > > That doesn't result in anything useful as far as I can tell. We still detect the file path/name, which is useful. That said, Lua stack frames typically include line numbers. > Please include an addition to etc/compilation.txt as well. Fixed. [The current version of the patch is attached below.] Rudy --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Make-the-Compilation-mode-recognize-Lua-errors.patch >From 0d2e317efd7f66d5605cd804648d30f7beef6709 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rudolf=20Adamkovi=C4=8D?= Date: Tue, 3 Oct 2023 09:07:40 +0200 Subject: [PATCH] Make the Compilation mode recognize Lua errors Emacs comes with built-in support for the Lua programming language in the form of the Lua mode and now also the Lua Tree-sitter mode. This patch further improves Lua support in Emacs by making the Compilation mode recognize Lua errors and stack traces. Reported as bug#60830. * etc/compilation.txt (Lua): Add an example of a Lua error message with a stack trace. * lisp/progmodes/compile.el (compilation-error-regexp-alist-alist): Add regexps to aid Lua development, namely the 'lua' regexp that matches Lua errors and the 'lua-stack' regexp that matches Lua stack frames. * test/lisp/progmodes/compile-tests.el (compile-tests--test-regexps-data): (compile-test-error-regexps): Test the new 'lua' and 'lua-stack' regexps added to the 'compilation-error-regexp-alist-alist'. --- etc/NEWS | 5 +++++ etc/compilation.txt | 13 +++++++++++++ lisp/progmodes/compile.el | 7 +++++++ test/lisp/progmodes/compile-tests.el | 19 +++++++++++++++++-- 4 files changed, 42 insertions(+), 2 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index 12c2d52a4ab..cf98e8d6f43 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -307,6 +307,11 @@ This is because it partly acts by modifying other rules which may occasionally be surprising. It can be re-enabled by adding 'omake' to 'compilation-error-regexp-alist'. +*** Lua errors and stack traces are now recognized. +The compilation mode now recognizes Lua language errors and stack +traces. Every Lua error is recognized as a compilation error, and +every Lua stack frame is recognized as a compilation info. + ** VC --- diff --git a/etc/compilation.txt b/etc/compilation.txt index 5f6ecb09cc2..9a5e3e732c8 100644 --- a/etc/compilation.txt +++ b/etc/compilation.txt @@ -344,6 +344,19 @@ In /home/janneke/vc/guile/examples/gud-break.scm: 1033: 0 [stderr "~a:hello world\n" (# # #)] +* Lua + +/usr/bin/lua: database.lua:31: assertion failed! +stack traceback: + [C]: in function 'assert' + database.lua:31: in field 'statement' + database.lua:42: in field 'table' + database.lua:55: in field 'row' + database.lua:63: in field 'value' + database.lua:68: in main chunk + [C]: in ? + + * Lucid Compiler, lcc 3.x symbol: lcc diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index 9e441dbfcf7..a394f953775 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -362,6 +362,13 @@ compilation-error-regexp-alist-alist (ruby-Test::Unit "^ [[ ]?\\([^ (].*\\):\\([1-9][0-9]*\\)\\(\\]\\)?:in " 1 2) + (lua + "^[^:\n\t]?+: \\([^:\n\t]+\\):\\([0-9]+\\): .*?\nstack traceback:\n\t" + 1 2 nil 2 1) + (lua-stack + "^\t\\([^:\n\t]?+\\):\\(?:\\([0-9]+\\):\\)? in " + 1 2 nil 0 1) + (gmake ;; Set GNU make error messages as INFO level. ;; It starts with the name of the make program which is variable, diff --git a/test/lisp/progmodes/compile-tests.el b/test/lisp/progmodes/compile-tests.el index d497644c389..3ed41e8afb1 100644 --- a/test/lisp/progmodes/compile-tests.el +++ b/test/lisp/progmodes/compile-tests.el @@ -206,6 +206,21 @@ compile-tests--test-regexps-data 1 0 31 "/usr/include/c++/3.3/backward/iostream.h") (gcc-include " from test_clt.cc:1:" 1 nil 1 "test_clt.cc") + ;; Lua + (lua "lua: database.lua:10: assertion failed!\nstack traceback:\n\t" + 6 nil 10 "database.lua") + (lua "lua 5.4: database 2.lua:10: assertion failed!\nstack traceback:\n\t" + 10 nil 10 "database 2.lua") + (lua "/usr/local/bin/lua: core/database.lua:20: assertion failed!\nstack traceback:\n\t" + 21 nil 20 "core/database.lua") + (lua-stack " database.lua: in field 'statement'" + 2 nil nil "database.lua" 0) + (lua-stack " database.lua:10: in field 'statement'" + 2 nil 10 "database.lua" 0) + (lua-stack " core/database.lua:20: in field 'statement'" + 2 nil 20 "core/database.lua" 0) + (lua-stack " database 2.lua: in field 'statement'" + 2 nil nil "database 2.lua" 0) ;; gmake (gmake "make: *** [Makefile:20: all] Error 2" 12 nil 20 "Makefile" 0) (gmake "make[4]: *** [sub/make.mk:19: all] Error 127" 15 nil 19 @@ -507,9 +522,9 @@ compile-test-error-regexps 1 15 5 "alpha.c"))) (compile--test-error-line test)) - (should (eq compilation-num-errors-found 100)) + (should (eq compilation-num-errors-found 103)) (should (eq compilation-num-warnings-found 35)) - (should (eq compilation-num-infos-found 28))))) + (should (eq compilation-num-infos-found 32))))) (ert-deftest compile-test-grep-regexps () "Test the `grep-regexp-alist' regexps. -- 2.39.3 (Apple Git-145) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable --=20 "It is no paradox to say that in our most theoretical moods we may be nearest to our most practical applications." -- Alfred North Whitehead, 1861-1947 Rudolf Adamkovi=C4=8D [he/him] Studenohorsk=C3=A1 25 84103 Bratislava Slovakia --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 08 05:59:48 2023 Received: (at 60830) by debbugs.gnu.org; 8 Oct 2023 09:59:49 +0000 Received: from localhost ([127.0.0.1]:56287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpQZg-0007g4-II for submit@debbugs.gnu.org; Sun, 08 Oct 2023 05:59:48 -0400 Received: from mail-lj1-x235.google.com ([2a00:1450:4864:20::235]:58804) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpQZe-0007fh-Lu for 60830@debbugs.gnu.org; Sun, 08 Oct 2023 05:59:47 -0400 Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2c3ca6ff5a7so18962951fa.1 for <60830@debbugs.gnu.org>; Sun, 08 Oct 2023 02:59:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696759161; x=1697363961; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=ZD0pUwH+MqML+nEfpi0y6ZRG4vML4h3bhfI9kQGNGqo=; b=Ck5P8XGQUBBt2m9qUYGdhWFWeIlT7WjniWjJsRL1SJTiEPQPyEPECWDvQ2xkxd987T +EJP9GP6wZka6rCjElfgHMdECgBs3JtMtXkw6NrE2UzK9NPv+xuhZ91Kl3GUMeuf0Ybh wU3CjMLmVANQ7aNREMNeExU8V/dVc17nEz9XWAMrYt3qZWUmuTB+13BhecAo+zzrU1X5 VGOJdzmLVG1U1Bdjphy8U4LHJ9WbjCZ+K5S7OVtFPAvY8LpFWBo5aF+lbSsZb9ClrbZr vSht2UxuR1HwteMyEssCQrVJ2qgGXP9Rp0DJzYr/w3Zn25krfb1MKMgkqVT7aB83rtbX 2ikg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696759161; x=1697363961; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ZD0pUwH+MqML+nEfpi0y6ZRG4vML4h3bhfI9kQGNGqo=; b=E+gxaTSMwPvO7KQ4xkkH63OEL3GGww2/xUxU8zj6sWaeV3vZUTXKP/rB4qcDDwA3aF mYr+5f4ohSzF+2vPK6lIq0AWCcwAsk2/xuzS6u+eCDIoCQYsyOdDOH5L0uxBwfBr8MDj Z3+IxcaEV8mMUqoZutgVevP9upRdcNfFx8XN45PYrKs+e+FBvhZfPExSd0UuBoIdSdnR MVQpJe8sEQMVnXOKCV/2MA7qChktWTwejove9GN5fjTqKMMWUr1rzndln57Ci3cMomDB i/K+Ou2r4OAfxOnk95cZHIGpXyIf3PQspqaIF4U8yXErzju7kU2BcTOE9pwu8AC40IUH JIDA== X-Gm-Message-State: AOJu0Yz6DzZPslWw43KX165MurOjkUlivrvVd2Y1ZlZaksE3LLTv+1UY uxK7dy6GxHtYQSEJeVKIMNE= X-Google-Smtp-Source: AGHT+IHXLuhxhHHK4F2eOMT+qVneuYytpvJ1iUCvbHadqJgzB+QrmX88p7cVpqcWbHkRTOdgPiZpcA== X-Received: by 2002:a2e:8eca:0:b0:2bc:39f5:ecb4 with SMTP id e10-20020a2e8eca000000b002bc39f5ecb4mr10765341ljl.25.1696759160386; Sun, 08 Oct 2023 02:59:20 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id r25-20020a2e9959000000b002bfba0d26bcsm1573361ljj.8.2023.10.08.02.59.18 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 Oct 2023 02:59:19 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: Date: Sun, 8 Oct 2023 11:59:18 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <8170D896-5520-4A5E-83F0-51C99BD54802@gmail.com> References: <909EF5E1-6F30-4A35-84E8-2EF4333115FD@gmail.com> <4996E536-72CE-4E6A-9C75-CF7307A82469@gmail.com> To: =?utf-8?Q?Rudolf_Adamkovi=C4=8D?= X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60830 Cc: 60830@debbugs.gnu.org, Stefan Kangas , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 7 okt. 2023 kl. 23.02 skrev Rudolf Adamkovi=C4=8D : > (1) How can I specify "this group cannot be '[C]'" in the regexp? Disallow files starting with a left square bracket? > (2) How can I test this scenario in 'compile-tests.el'? We can help out. > I made the relevant groups greedy, but I wonder what difference it > makes. Only use non-greedy operators if they make the regexp significantly = easier to express. Greedy should be the default. Non-greedy operators are usually less efficient, and always raise = eyebrows when read: why is this non-greedy? Writing ".*?\n", as you did, makes no sense at all since "." will match = anything except newline, and the result is identical to ".*\n" but less = readable and maybe slower. >> We try to make rules work with Windows file names (or names = containing >> spaces, which are also somewhat common on Windows) where relevant and >> practical. Your patterns don't; can you argue that it's not useful = for >> Lua or not possible to do so? >=20 > Good catch! Fixed. Maybe you should test it just in case. (You don't need a Windows machine = to do that but it adds authenticity). > I would understand if we did that for some long-dead compilers but not > for Lua. Look, it's not a beauty contest. We'll do what we have to. > We still detect the file path/name, which is useful. The point is that it substantially increases the risks of false matches. = Lua needs to be a good neighbour and can't just think of its own needs = over anything else. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 08 06:46:08 2023 Received: (at 60830) by debbugs.gnu.org; 8 Oct 2023 10:46:08 +0000 Received: from localhost ([127.0.0.1]:56364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpRIV-0003XU-Ju for submit@debbugs.gnu.org; Sun, 08 Oct 2023 06:46:07 -0400 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]:62649) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpRIS-0003TD-Pg for 60830@debbugs.gnu.org; Sun, 08 Oct 2023 06:46:05 -0400 Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2c27d653856so56346921fa.0 for <60830@debbugs.gnu.org>; Sun, 08 Oct 2023 03:45:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696761939; x=1697366739; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=koGwrub0+HvrlsAJhkCD9GvDTCWF9Pq8BrlPS6OY64I=; b=DE27cgU6kjb66KsUdJPNQdoPJDSgeCFCem8J97T0DhZJkDc9xtWcc3A1pWLsJhIgCL i4xo1qPo3OSma1qgt/iQB+5zysiJKvqhx1Xgvz+clBeAzjcnAGNIdN6KJDvzQ9BwdTTD RNfphUoSoTR7qwCOKZ01EVQguSCZ+qLafh7xA3E9zqLOePaN9TbV5K/xLyQjekVTmV8m 8fI62uPLbH1/svpPdIwCXAaYijc4+lPa0mmCCQuJtNoUKQn+oQfeQV4o8ntqtBXKZ2Hv zXrjWQ3XFH00Q7joEfPX4NLTeSw9akbe8hh2Md+Jub9ulngnpHG1PTGjh+jUaUge59oq GnHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696761939; x=1697366739; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=koGwrub0+HvrlsAJhkCD9GvDTCWF9Pq8BrlPS6OY64I=; b=Plj4tf5pqJsqlrYlhtJU25Prc1z3txLGWNCL7V6ayhxSCC9da7s0iwgKRBi2fNfKB3 mEAT3I66pp3cTRTPrH7+GUcnyU1Sur01bo/KDwKPIwNYZ9dx3JwjpJCYPU7C0sINPNfJ xpFBC7KsJIYZXNEJdXwOXAOJCwu3PPZTdfxib2AlUT6b6J5TfOo7VePadbvvur9bzot9 kYmx0at9sn+yqUeQKEQiQR74XwcjE3aR+/LVdiMPJxAH8k9buH34NrOYqw5w33nxZmcn QLfGIpTqrlDRBzIYUrJ44c61NHKgnBjqHNEjYDSma/yoviZk8wWJaJv9pJsqu2H5X9j2 36PA== X-Gm-Message-State: AOJu0YxptM4Lg1Ln9GrRvTlRWjyr6/MP+6j8XLzwWbzI5ZX2BKxV1p1b kO6jKE/qYu/lNVoWs8eZwOsky7svQw1NqQ== X-Google-Smtp-Source: AGHT+IF1s0QmbyKMDqBURrDQy+i4IoGdMU4E3lv159e6W2+BFe2sGZKVrlSq1TN9rqeDuW6Bcbg0jA== X-Received: by 2002:a05:6512:10cd:b0:503:4:b271 with SMTP id k13-20020a05651210cd00b005030004b271mr6898617lfg.0.1696761938424; Sun, 08 Oct 2023 03:45:38 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id y20-20020ac24214000000b00500829f7b2bsm1025463lfh.250.2023.10.08.03.45.37 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 Oct 2023 03:45:37 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: Date: Sun, 8 Oct 2023 12:45:36 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <4F844611-9A1E-409C-9E93-31C073E25453@gmail.com> References: <909EF5E1-6F30-4A35-84E8-2EF4333115FD@gmail.com> <4996E536-72CE-4E6A-9C75-CF7307A82469@gmail.com> <5CB2325C-0A1E-4AC6-B61E-DFA46F3CFC80@gmail.com> <6F3E07C8-3E9E-481C-B89C-7045D1028A2A@gmail.com> To: Stefan Monnier X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60830 Cc: 60830@debbugs.gnu.org, =?utf-8?Q?Rudolf_Adamkovi=C4=8D?= , Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 7 okt. 2023 kl. 17.22 skrev Stefan Monnier : > I suspect the "never annoying" is not too hard to get: those regexps = are > currently matched so if they were annoying we'd know about it. Yes, but one of the points of this soft CERA reform is to allow rules in = that may conflict with one another so this balance may not last. > Looks OK to me, tho it will complain to the user if they have it set = to > a shape that doesn't fit your mold :-( Indeed it does and I'm not sure what to do about it -- the widget system = is a bit of a labyrinth to me. Is there a way to somehow preprocess a value before the widget machinery = tries to type-match it? If so, we could run CERA through a centrifuge = that moves all symbols to the end of the list. > I wonder how common it is for people to set it "manually" in their > init file. It seems more common to set it in ELisp packages. Probably, but I have vivid memories of packages in the past that came = with comments telling the user what to add to their ~/.emacs and a = number of those may have survived. Packages also vary in their practices: some add a rule to CERAA an its = symbol to CERA, others just a pattern to CERA. Most push their additions = to the front but some are shy and put theirs at the end. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 08 10:48:15 2023 Received: (at 60830) by debbugs.gnu.org; 8 Oct 2023 14:48:15 +0000 Received: from localhost ([127.0.0.1]:58250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpV4p-0002tW-0E for submit@debbugs.gnu.org; Sun, 08 Oct 2023 10:48:15 -0400 Received: from mail-lj1-x231.google.com ([2a00:1450:4864:20::231]:42466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpV4m-0002sc-JM for 60830@debbugs.gnu.org; Sun, 08 Oct 2023 10:48:13 -0400 Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2c1807f3400so45562141fa.1 for <60830@debbugs.gnu.org>; Sun, 08 Oct 2023 07:47:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696776466; x=1697381266; darn=debbugs.gnu.org; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:sender:from:to:cc:subject:date:message-id:reply-to; bh=UxpwSqGgQqfUftZ8s1PijK3lbGN3T2XSK6NbqvWqwyo=; b=eSvi/+sbAZvgXeYzPYr/iYavURC2M5nCTLx8EpC4nsXsM66+wL71VySjCH8mlgHwOh vngwXgsBiFW1gCT1jXyE3+VaHq93VS9/Plbcgd9ME+tl4JyxvhcVhjeh9BPKGekWuBSs ljD5pfp7isptl03osdolfPMB5pU1UcvFBx/99YLXBZeUEazzzjWPaaaoNRKIQ9kleNVO VyJ7iShkTzZum18lTUxRG0y5agY9JGdRHCBbtooVLgy82UnDdSJuNH/Ve9DqnGteoJzq x1JW+hUtPFY96DFcXH8bMqT8ly4WHxY301qdRSSF1MuVxWeamqmQsKgSLgswfKrNcXdK Srog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696776466; x=1697381266; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UxpwSqGgQqfUftZ8s1PijK3lbGN3T2XSK6NbqvWqwyo=; b=NglOcbUJkqvKgQHek9Et3nx0ki3SyObjNk+UH5Frymz1na0y4EmSi8Ec80fSo/vXH3 IifsS0x5ofGTyIq5EGlBc1hIx/Nn6q6Ki0O+iUg5CJ/7uDCZf8iYSP//e0wbP6yAldyt kjwGfYd/hQC89dY+8ZbR2ojbR2z7FU3VzTAKCmujhxrr+RcnzrrwR8SimOUHQFVHEBSc UnYGIMfoUY+UKOPOBWqHQm3U9DmCFudiFirRVibbPWc1ii/MN1Hcgnt9bv+nF53ihic8 X85iMzvukIVLv9o4PHflGi12cU73Rb3ke2pasqaU5md4Lvy+udboAgBWWyd422dZJrdm +Xhw== X-Gm-Message-State: AOJu0YyTPexSQawUx0cRkb29FMiTi9269fno+3HGZT5KuWradUNk7pj+ btcM5suNOsKw4ze5pVX+3CA= X-Google-Smtp-Source: AGHT+IFOSBSpX8cQdQfbw/PS6piTqvXLwHK6gpAeW+++dyYHLY/BB4unK6YeGpAMVCwnQ5KjO30Lzw== X-Received: by 2002:a2e:a4a3:0:b0:2c0:a0d:1f0a with SMTP id g3-20020a2ea4a3000000b002c00a0d1f0amr7115587ljm.18.1696776465645; Sun, 08 Oct 2023 07:47:45 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id q2-20020a2e9682000000b002b9ef00b10csm1663829lji.2.2023.10.08.07.47.44 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 Oct 2023 07:47:45 -0700 (PDT) From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Message-Id: <2294A949-ACB1-4962-91B1-B798F22C5C1C@gmail.com> Content-Type: multipart/mixed; boundary="Apple-Mail=_59C195E2-5E34-41A7-BA0F-B37E7A82743A" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors Date: Sun, 8 Oct 2023 16:47:43 +0200 In-Reply-To: <4F844611-9A1E-409C-9E93-31C073E25453@gmail.com> To: Stefan Monnier References: <909EF5E1-6F30-4A35-84E8-2EF4333115FD@gmail.com> <4996E536-72CE-4E6A-9C75-CF7307A82469@gmail.com> <5CB2325C-0A1E-4AC6-B61E-DFA46F3CFC80@gmail.com> <6F3E07C8-3E9E-481C-B89C-7045D1028A2A@gmail.com> <4F844611-9A1E-409C-9E93-31C073E25453@gmail.com> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60830 Cc: 60830@debbugs.gnu.org, =?utf-8?Q?Rudolf_Adamkovi=C4=8D?= , Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Apple-Mail=_59C195E2-5E34-41A7-BA0F-B37E7A82743A Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > Is there a way to somehow preprocess a value before the widget = machinery tries to type-match it? If so, we could run CERA through a = centrifuge that moves all symbols to the end of the list. Of course there is, and here is the patch with the centrifuge installed. (It may reorder the list if edited this way but again, this shouldn't be = much of a problem in practice.) --Apple-Mail=_59C195E2-5E34-41A7-BA0F-B37E7A82743A Content-Disposition: attachment; filename=cera-type.diff Content-Type: application/octet-stream; x-unix-mode=0644; name="cera-type.diff" Content-Transfer-Encoding: 7bit diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index 9e441dbfcf7..79bf3f07f60 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -748,11 +748,39 @@ compilation-error-regexp-alist variable, the `compilation-transform-file-match-alist' variable is then consulted. It allows further transformations of the matched file names, and weeding out false positives." - :type '(repeat (choice (symbol :tag "Predefined symbol") - (sexp :tag "Error specification"))) + ;; Segregate explicit rule specs and rule names in the list before we edit, + ;; to allow the names to be edited using a `set' widget. + :get (lambda (_) + (let ((specs nil) (syms nil)) + (dolist (x compilation-error-regexp-alist) + (push x (if (symbolp x) syms specs))) + (append (nreverse specs) (nreverse syms)))) + :type '(list :tag "Rules" + (repeat :tag "Custom message rules" + :inline t + (list :tag "Rule specification" + regexp + (sexp :tag "File") + (sexp :tag "Line") + (sexp :tag "Column") + (sexp :tag "Type") + (sexp :tag "Hyperlink") + (repeat :inline t + :tag "Highlights" + (list :tag "Highlight" + (natnum :tag "Submatch") + (sexp :tag "Face"))))) + (set :tag "Predefined rules" + :inline t + :convert-widget compilation--predef-rules-widgets)) :link `(file-link :tag "example file" ,(expand-file-name "compilation.txt" data-directory))) +(defun compilation--predef-rules-widgets (widget) + (widget-put widget :args (mapcar (lambda (x) (list 'const (car x))) + compilation-error-regexp-alist-alist)) + widget) + (defvar compilation-error-case-fold-search nil "If non-nil, use case-insensitive matching of compilation errors. If nil, matching is case-sensitive. --Apple-Mail=_59C195E2-5E34-41A7-BA0F-B37E7A82743A-- From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 08 11:49:33 2023 Received: (at 60830) by debbugs.gnu.org; 8 Oct 2023 15:49:34 +0000 Received: from localhost ([127.0.0.1]:58270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpW29-00052N-Kn for submit@debbugs.gnu.org; Sun, 08 Oct 2023 11:49:33 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:53184) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpW27-00051w-Tb for 60830@debbugs.gnu.org; Sun, 08 Oct 2023 11:49:32 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D376A1000AD; Sun, 8 Oct 2023 11:49:05 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1696780144; bh=/GxiglKuudbCcMWQFd80RnsVB/+dtrS2p2lGg/T13dI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=KGxLdHn/RjKBPqT6Oj/csFLYeCSE6BqlTMyhXVBqb0aLsSSxNQpqgQTo2I2g+Rqxq n6yjkdGMo9OWYVVWXHFQjYD4Op47Fv8rWVTjIgiYZua5u5ZCrhtl6yctp4RMuTuGUg VZAdS4+eZw1J9vAm5mSMHwR6NAFirywjOFUz3iA4PiVTVZYCShsOy8cBThwC8UFvZo /MgTO1VgvMN2GGezQXUTT4NqQPlKPhK4kpsEIzxXi+/e/dPuJXfSGWr8F2wPttVOTU dZS4DJsvmJRVRrVeA3xRrqd1dfWV26GtvqeZMcUI013BSiVFX4jRmYQSE4/K+fFj/p dCKhBExgq/jXQ== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id C1399100033; Sun, 8 Oct 2023 11:49:04 -0400 (EDT) Received: from alfajor (unknown [129.222.204.65]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5ED1E1204BB; Sun, 8 Oct 2023 11:49:04 -0400 (EDT) From: Stefan Monnier To: Rudolf =?utf-8?Q?Adamkovi=C4=8D?= Subject: Re: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors In-Reply-To: ("Rudolf =?utf-8?Q?Adamkovi=C4=8D=22'?= =?utf-8?Q?s?= message of "Sat, 07 Oct 2023 23:02:25 +0200") Message-ID: References: <909EF5E1-6F30-4A35-84E8-2EF4333115FD@gmail.com> <4996E536-72CE-4E6A-9C75-CF7307A82469@gmail.com> Date: Sun, 08 Oct 2023 11:49:03 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60830 Cc: Mattias =?windows-1252?Q?Engdeg=E5rd?= , 60830@debbugs.gnu.org, Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > (1) How can I specify "this group cannot be '[C]'" in the regexp? For true "regular expressions", you'd use conjunction and negation and Bob's your uncle, but sadly, our regexps don't support conjunction nor negation, so you're stuck doing it by hand, e.g.: "\\|\\[\\|[^[].*\\|\\[C\\|\\[[^C].*\\|\\[C[^]].*\\|\\[C].+" Yes, it's hideous and it suffers from a really bad size-explosion syndrome. I don't even want to think about how to encode "this group can match neither "joe" nor "henry". >> I see no reason for the non-greedy match in the first regexp, do you? > I made the relevant groups greedy, but I wonder what difference it > makes. Is there a way to test the change in 'compile-tests.el'? .*?\n and .*\n are equivalent because . can't match the same char as \n, so there's no choice to be made about how many repetitions of . to use. But the regexp compiler notices this fact (which it can use to avoid using backtracking and thus work noticeably more efficiently) only if you use ".*\n". Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 12 04:12:45 2023 Received: (at 60830) by debbugs.gnu.org; 12 Oct 2023 08:12:45 +0000 Received: from localhost ([127.0.0.1]:40574 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqqoG-0001A6-PR for submit@debbugs.gnu.org; Thu, 12 Oct 2023 04:12:45 -0400 Received: from pv50p00im-ztdg10021101.me.com ([17.58.6.44]:49936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqqoB-00019q-PZ for 60830@debbugs.gnu.org; Thu, 12 Oct 2023 04:12:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1697098331; bh=JHO9zG/ryzQ0DaHD8OJvELYNO8Xopu2JCFFQ9KLn8Io=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=kFkciv8OlC4ac6qZQDmFNlPUWVu4s0mOtOHwS5oNLFtRiC5UWjgbr5Klza99H6GvM pSXye07M2Xvi6Q8UQtVqjv+Yyxot3nw+DWVSb7nd+pkB70pBXWuq08q7JjUIGwzp77 WYe2fr0I1Xpje0a68Zlx7C1ii0FHYHxeZLoyODvLQsHyxM9hAyeUZ6+rPVeOpVQGx2 35qsPkCiHyTl31gwDB3d/5Sy4zdVxjkLlKTwNTeNwRI2Aj3K6rRYS0SGW1IUy9fBOA 5gCapwXHQ6EHNLTZcDDC7zQ3uzZ6+NHvLG3ajCRgiOPfcZOWrajukVbRAzHwZyOfJh EURHIUAdemjSQ== Received: from Rudolfs-MacBook-Air.local (pv50p00im-dlb-asmtp-mailmevip.me.com [17.56.9.10]) by pv50p00im-ztdg10021101.me.com (Postfix) with ESMTPSA id 9139AD001C6; Thu, 12 Oct 2023 08:12:09 +0000 (UTC) From: Rudolf =?utf-8?Q?Adamkovi=C4=8D?= To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Subject: Re: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors In-Reply-To: <8170D896-5520-4A5E-83F0-51C99BD54802@gmail.com> References: <909EF5E1-6F30-4A35-84E8-2EF4333115FD@gmail.com> <4996E536-72CE-4E6A-9C75-CF7307A82469@gmail.com> <8170D896-5520-4A5E-83F0-51C99BD54802@gmail.com> Date: Thu, 12 Oct 2023 10:12:05 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: TtJW0ch_I_YMS1xBPZgBz8ii3UM9-VYv X-Proofpoint-ORIG-GUID: TtJW0ch_I_YMS1xBPZgBz8ii3UM9-VYv X-Proofpoint-Virus-Version: =?UTF-8?Q?vendor=3Dfsecure_engine=3D1.1.170-22c6f66c430a71ce266a39bfe25bc?= =?UTF-8?Q?2903e8d5c8f:6.0.138,18.0.572,17.0.605.474.0000000_definitions?= =?UTF-8?Q?=3D2020-02-14=5F11:2020-02-14=5F02,2020-02-14=5F11,2020-01-23?= =?UTF-8?Q?=5F02_signatures=3D0?= X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 suspectscore=0 spamscore=0 malwarescore=0 bulkscore=0 phishscore=0 mlxlogscore=999 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2310120069 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60830 Cc: 60830@debbugs.gnu.org, Stefan Kangas , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Mattias Engdeg=C3=A5rd writes: > We can help out. To quote you, "That's the spirit!" :) Please see the to-do comment I left in the 'compile-tests.el'. I think we want 'compile--test-error-line' to support both positive and negative test cases. > Only use non-greedy operators [...] I updated everything to my best knowledge. If the regexps are still not good enough, please quote the problematic fragments, so that I know exactly where the problem is. > Maybe you should test it just in case. (You don't need a Windows > machine to do that but it adds authenticity). I do not understand. Are you saying that the tests I wrote are insufficient? If so, could you please elaborate? > Look, it's not a beauty contest. We'll do what we have to. How do false positives and performance tie to "beauty"? I must have miscommunicated badly. What I wanted to say is that I imagine Lua working out of the box, hence my hunch for the most precise regexps. >> We still detect the file path/name, which is useful. > > The point is that it substantially increases the risks of false > matches. Lua needs to be a good neighbour and can't just think of its > own needs over anything else. The sequence of characters is fairly unique, given each stack frame must start with a tab and then contain ": in " after the file name. Rudy --=20 "Programming reliably -- must be an activity of an undeniably mathematical nature [=E2=80=A6] You see, mathematics is about thinking, and doing mathematics is always trying to think as well as possible." -- Edsger W. Dijkstra, 1981 Rudolf Adamkovi=C4=8D [he/him] Studenohorsk=C3=A1 25 84103 Bratislava Slovakia From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 12 04:15:27 2023 Received: (at 60830) by debbugs.gnu.org; 12 Oct 2023 08:15:27 +0000 Received: from localhost ([127.0.0.1]:40584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqqqt-0002Z7-DM for submit@debbugs.gnu.org; Thu, 12 Oct 2023 04:15:27 -0400 Received: from pv50p00im-hyfv10021501.me.com ([17.58.6.48]:38886) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqqqk-0001tB-TS for 60830@debbugs.gnu.org; Thu, 12 Oct 2023 04:15:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1697098490; bh=2dQ1vme1qxRP9mc2RcD1wsz0EddWDkBMMsE3UyVBdS8=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=fxHtueKelmR0Q6IM+9cfgvwM4b7WxgWuumAtBSksnGkfecUUHqbgWiERwEzI0spAs 62b+fhPOhnaMoMA6BOYRc5ExOsxqdUL26NkIsDlqh/x3dMxO9tCNchqrSENgRS/6AS Opw7rpLNvl90XnMWXIEqo8FvS7e0U59TEQz3FZ6Ytb9yMkSogZkl4gV85LjAB89z3R qCNhVS1V4CcBNnSl2E+M4gjkPNEMK5QgR75DpilNaQAK2ZYU5RQYiH/ilDF/7MNZUs XkqP9o7Y2JicZIzcQJ9A3QoB2EbuwEyXeVVF6q3wnNbPYt+F4/0Em7GnIEGXm7HzjW XzCozonthTqEQ== Received: from Rudolfs-MacBook-Air.local (pv50p00im-dlb-asmtp-mailmevip.me.com [17.56.9.10]) by pv50p00im-hyfv10021501.me.com (Postfix) with ESMTPSA id E13582C01DB; Thu, 12 Oct 2023 08:14:48 +0000 (UTC) From: Rudolf =?utf-8?Q?Adamkovi=C4=8D?= To: Stefan Monnier Subject: Re: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors In-Reply-To: References: <909EF5E1-6F30-4A35-84E8-2EF4333115FD@gmail.com> <4996E536-72CE-4E6A-9C75-CF7307A82469@gmail.com> Date: Thu, 12 Oct 2023 10:14:46 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: eL2TaGdHOLk7lOo093vMEQ6ro4KDu4tT X-Proofpoint-ORIG-GUID: eL2TaGdHOLk7lOo093vMEQ6ro4KDu4tT X-Proofpoint-Virus-Version: =?UTF-8?Q?vendor=3Dfsecure_engine=3D1.1.170-22c6f66c430a71ce266a39bfe25bc?= =?UTF-8?Q?2903e8d5c8f:6.0.517,18.0.572,17.11.64.514.0000000_definitions?= =?UTF-8?Q?=3D2022-06-21=5F01:2022-06-21=5F01,2020-02-14=5F11,2022-02-23?= =?UTF-8?Q?=5F01_signatures=3D0?= X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0 mlxlogscore=701 adultscore=0 bulkscore=0 mlxscore=0 clxscore=1015 suspectscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2310120069 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60830 Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= , 60830@debbugs.gnu.org, Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Stefan Monnier writes: > For true "regular expressions", you'd use conjunction and negation and > Bob's your uncle, but sadly, our regexps don't support conjunction nor > negation, so you're stuck doing it by hand, e.g.: > > "\\|\\[\\|[^[].*\\|\\[C\\|\\[[^C].*\\|\\[C[^]].*\\|\\[C].+" > > Yes, it's hideous and it suffers from a really bad size-explosion > syndrome. I don't even want to think about how to encode "this group > can match neither "joe" nor "henry". After a bit of thinking, I used a shy group \\(?:\\[C\\]\\|.......\\) ^^^^^^^ ^^^^^^^=20=20 NEGATIVE POSITIVE This either matches nothing or the groups in the POSITIVE alternative. Rudy --=20 "I love deadlines. I love the whooshing noise they make as they go by." -- Douglas Adams, The Salmon of Doubt, 2002 Rudolf Adamkovi=C4=8D [he/him] Studenohorsk=C3=A1 25 84103 Bratislava Slovakia From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 12 04:17:46 2023 Received: (at 60830) by debbugs.gnu.org; 12 Oct 2023 08:17:46 +0000 Received: from localhost ([127.0.0.1]:40589 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqqt8-0003tG-0i for submit@debbugs.gnu.org; Thu, 12 Oct 2023 04:17:46 -0400 Received: from pv50p00im-ztdg10011201.me.com ([17.58.6.39]:35218) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqqt6-0003t4-CA for 60830@debbugs.gnu.org; Thu, 12 Oct 2023 04:17:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1697098635; bh=+D5qS9+pqSZImcIQgiERHhcLtgOoGwjlaMuRtJttvl0=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=RKNSWBFRMBAK4f1XyGmvQTjWLCb6o95wkoH4wffUJiYCFh8iFFMRNZ5BXNsnG6ROb pqKdLnG7u8aNBVCDE81OKX3p2m4FJcIIHOURhQ/9n0ji9pZZR8UolLMnALltak6V9t GR6CAlJOKyJ57QiNJWDo+aBFGILUCHwuTH3ENl4kpfi4MnstdLKeDhiaRP7JwABrtr RRZhEfN4h+n3IbDwRlHfaYlOdBgPluhVyBQrrYgDyhzSTWrzgtoTNqVg6GtCEo0Jcz xPCjFc7J9Kw3AXyLkbitHuMSPZCx4dCudSlaXp2YZwVDnGdpAQ2cLs8pqHp5A0A/sz F95ueI6lzoZWw== Received: from Rudolfs-MacBook-Air.local (pv50p00im-dlb-asmtp-mailmevip.me.com [17.56.9.10]) by pv50p00im-ztdg10011201.me.com (Postfix) with ESMTPSA id 333C668017B; Thu, 12 Oct 2023 08:17:12 +0000 (UTC) From: Rudolf =?utf-8?Q?Adamkovi=C4=8D?= To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Subject: Re: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors In-Reply-To: References: <909EF5E1-6F30-4A35-84E8-2EF4333115FD@gmail.com> <4996E536-72CE-4E6A-9C75-CF7307A82469@gmail.com> <8170D896-5520-4A5E-83F0-51C99BD54802@gmail.com> Date: Thu, 12 Oct 2023 10:17:10 +0200 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Proofpoint-ORIG-GUID: bBjT8qfwqwGqBdSruGxYRMxjOGPgcWXZ X-Proofpoint-GUID: bBjT8qfwqwGqBdSruGxYRMxjOGPgcWXZ X-Proofpoint-Virus-Version: =?UTF-8?Q?vendor=3Dfsecure_engine=3D1.1.170-22c6f66c430a71ce266a39bfe25bc?= =?UTF-8?Q?2903e8d5c8f:6.0.517,18.0.572,17.0.605.474.0000000_definitions?= =?UTF-8?Q?=3D2022-06-21=5F01:2022-06-21=5F01,2020-02-14=5F11,2020-01-23?= =?UTF-8?Q?=5F02_signatures=3D0?= X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 bulkscore=0 mlxlogscore=447 adultscore=0 clxscore=1015 spamscore=0 malwarescore=0 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2310120070 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60830 Cc: 60830@debbugs.gnu.org, Stefan Kangas , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Rudolf Adamkovi=C4=8D writes: > ... And I forgot to attach the latest version of the patch. :) Rudy --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Make-the-Compilation-mode-recognize-Lua-errors.patch >From 715e9c353de17f9462842943e6000678ca8fab3a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rudolf=20Adamkovi=C4=8D?= Date: Tue, 3 Oct 2023 09:07:40 +0200 Subject: [PATCH] Make the Compilation mode recognize Lua errors Emacs comes with built-in support for the Lua programming language in the form of the Lua mode and now also the Lua Tree-sitter mode. This patch further improves Lua support in Emacs by making the Compilation mode recognize Lua errors and stack traces. Reported as bug#60830. * etc/compilation.txt (Lua): Add an example of a Lua error message with a stack trace. * lisp/progmodes/compile.el (compilation-error-regexp-alist-alist): Add regexps to aid Lua development, namely the 'lua' regexp that matches Lua errors and the 'lua-stack' regexp that matches Lua stack frames. * test/lisp/progmodes/compile-tests.el (compile-tests--test-regexps-data): (compile-test-error-regexps): Test the new 'lua' and 'lua-stack' regexps added to the 'compilation-error-regexp-alist-alist'. --- etc/NEWS | 5 +++++ etc/compilation.txt | 13 +++++++++++++ lisp/progmodes/compile.el | 7 +++++++ test/lisp/progmodes/compile-tests.el | 22 ++++++++++++++++++++-- 4 files changed, 45 insertions(+), 2 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index 8b2bcaaf01d..d0df4df2b2e 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -319,6 +319,11 @@ This is because it partly acts by modifying other rules which may occasionally be surprising. It can be re-enabled by adding 'omake' to 'compilation-error-regexp-alist'. +*** Lua errors and stack traces are now recognized. +The compilation mode now recognizes Lua language errors and stack +traces. Every Lua error is recognized as a compilation error, and +every Lua stack frame is recognized as a compilation info. + ** VC --- diff --git a/etc/compilation.txt b/etc/compilation.txt index 5f6ecb09cc2..fa43c89879a 100644 --- a/etc/compilation.txt +++ b/etc/compilation.txt @@ -344,6 +344,19 @@ In /home/janneke/vc/guile/examples/gud-break.scm: 1033: 0 [stderr "~a:hello world\n" (# # #)] +* Lua + +/usr/bin/lua: database.lua:31: assertion failed! +stack traceback: + [C]: in function 'assert' + database.lua:31: in field 'statement' + database.lua:42: in field 'table' + database.lua:55: in field 'row' + database.lua:63: in field 'value' + io.lua: in main chunk + [C]: in ? + + * Lucid Compiler, lcc 3.x symbol: lcc diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index 9e441dbfcf7..9a2f633e3ec 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -362,6 +362,13 @@ compilation-error-regexp-alist-alist (ruby-Test::Unit "^ [[ ]?\\([^ (].*\\):\\([1-9][0-9]*\\)\\(\\]\\)?:in " 1 2) + (lua + "^[^:\n\t]+: \\([^:\n\t]+\\):\\([0-9]+\\): .+\nstack traceback:\n\t" + 1 2 nil 2 1) + (lua-stack + "^\t\\(?:\\[C\\]:\\|\\([^:\n\t]+\\):\\(?:\\([0-9]+\\):\\)?\\) in " + 1 2 nil 0 1) + (gmake ;; Set GNU make error messages as INFO level. ;; It starts with the name of the make program which is variable, diff --git a/test/lisp/progmodes/compile-tests.el b/test/lisp/progmodes/compile-tests.el index d497644c389..2e917d3b614 100644 --- a/test/lisp/progmodes/compile-tests.el +++ b/test/lisp/progmodes/compile-tests.el @@ -206,6 +206,24 @@ compile-tests--test-regexps-data 1 0 31 "/usr/include/c++/3.3/backward/iostream.h") (gcc-include " from test_clt.cc:1:" 1 nil 1 "test_clt.cc") + ;; Lua + (lua "lua: database.lua:10: assertion failed!\nstack traceback:\n\t" + 6 nil 10 "database.lua") + (lua "lua 5.4: database 2.lua:10: assertion failed!\nstack traceback:\n\t" + 10 nil 10 "database 2.lua") + (lua "/usr/local/bin/lua: core/database.lua:20: assertion failed!\nstack traceback:\n\t" + 21 nil 20 "core/database.lua") + (lua-stack " database.lua: in field 'statement'" + 2 nil nil "database.lua" 0) + (lua-stack " database.lua:10: in field 'statement'" + 2 nil 10 "database.lua" 0) + (lua-stack " core/database.lua:20: in field 'statement'" + 2 nil 20 "core/database.lua" 0) + (lua-stack " database 2.lua: in field 'statement'" + 2 nil nil "database 2.lua" 0) + ;; TODO Test the negative case: + ;; (lua-stack " [C]: in field 'statement'" + ;; nil nil nil nil nil) ;; gmake (gmake "make: *** [Makefile:20: all] Error 2" 12 nil 20 "Makefile" 0) (gmake "make[4]: *** [sub/make.mk:19: all] Error 127" 15 nil 19 @@ -507,9 +525,9 @@ compile-test-error-regexps 1 15 5 "alpha.c"))) (compile--test-error-line test)) - (should (eq compilation-num-errors-found 100)) + (should (eq compilation-num-errors-found 103)) (should (eq compilation-num-warnings-found 35)) - (should (eq compilation-num-infos-found 28))))) + (should (eq compilation-num-infos-found 32))))) (ert-deftest compile-test-grep-regexps () "Test the `grep-regexp-alist' regexps. -- 2.39.3 (Apple Git-145) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable --=20 "Great minds discuss ideas; average minds discuss events; small minds discu= ss people." --- Anna Eleanor Roosevelt (1884-1962) Rudolf Adamkovi=C4=8D [he/him] Studenohorsk=C3=A1 25 84103 Bratislava Slovakia --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 12 10:33:25 2023 Received: (at 60830) by debbugs.gnu.org; 12 Oct 2023 14:33:25 +0000 Received: from localhost ([127.0.0.1]:44015 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqwke-0004iD-QN for submit@debbugs.gnu.org; Thu, 12 Oct 2023 10:33:25 -0400 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]:50217) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqwkc-0004hm-KR for 60830@debbugs.gnu.org; Thu, 12 Oct 2023 10:33:23 -0400 Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2c16bc71e4cso12620881fa.0 for <60830@debbugs.gnu.org>; Thu, 12 Oct 2023 07:33:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697121174; x=1697725974; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=oWtwJONI6FUhZouDVFdsNGu6UgVRKndUvXkUM3iYEUw=; b=aAV8YovIAKWzu40n2C2t2hL3Q4Qw+q3RQeQniYj8e8WHChJ7UrHjQQQQ1iQaw9BbzX i41WnHoslxzfw+YpteUvteQnk+zkMQ1M+rB5gD6rPqQ7nFGrCW7WqHmtisjlJ43dpYpO 8GXCOi3Y7mSRAgCEuL40kocYQ76NLjcEO/B10Hd+OzweU4KCiptboYApiwkzQNwAXkxw cZ+vg5lweoLnHH1u44hCYMKkuB3lie6o67IJzuo5WYP2qKYq3/knaCf3b5ZvV16iTmbu wkvizkW699H0ex0JaXJnNQUWZEr0YVtoc64V+tnl4zQMP6ZfiuHX05fCkbFFP1UH6yot 6d0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697121174; x=1697725974; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=oWtwJONI6FUhZouDVFdsNGu6UgVRKndUvXkUM3iYEUw=; b=TUHmetg5FE+fxBzLNgIP03XQa658AouyfLs2YJ+HH5pAwuyzRiZdd8knqhM+iBWQdY Z0rN3TVsOmC2CDwdOb+UB2AP2XIWPqn9ONIEzVyU3+p3P2IQqEFw6y9XWlRsMXK8Uzq4 y8EERsYBREf7X5ycuv6OiNUH2IJclWXBNV9kVdjLHoV1Ba2vIPf9/F+iWzP8AJiaybkV JG3IDQEHc9bgCMk7GwjZ4aCpLMKFDC8K/ji6llGO6fiR2SJoSrj33R8hyDazbkRdVH35 XTcOlaoVYBI9JrXj3jiDPsUI0R0CKjckX4XLNAv4jHboJ66z5Pv7EJ118ZhBdv2UqA05 07tg== X-Gm-Message-State: AOJu0Ywx668juYB9GxIlIVb9Qe98fmoFprOJiW0QBRpTj3G9vu0MMNhQ vgfm1sAj7y1+ZPx/J82OCp8= X-Google-Smtp-Source: AGHT+IEb+S5ax5OxS/BYnGKH3pl+qzQNaiLJOhXcc5Z8ubp7YIYJEu8xLFElwqeib5Cr8bYLjeMEsg== X-Received: by 2002:a05:6512:31c3:b0:500:9bbf:da17 with SMTP id j3-20020a05651231c300b005009bbfda17mr24810195lfe.51.1697121173928; Thu, 12 Oct 2023 07:32:53 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id o9-20020a05651238a900b00505666d024csm2846320lft.102.2023.10.12.07.32.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Oct 2023 07:32:53 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: Date: Thu, 12 Oct 2023 16:32:51 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <57BD4380-6307-469B-9DE7-FF1BCD44B679@gmail.com> References: <909EF5E1-6F30-4A35-84E8-2EF4333115FD@gmail.com> <4996E536-72CE-4E6A-9C75-CF7307A82469@gmail.com> <8170D896-5520-4A5E-83F0-51C99BD54802@gmail.com> To: =?utf-8?Q?Rudolf_Adamkovi=C4=8D?= X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60830 Cc: 60830@debbugs.gnu.org, Stefan Kangas , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 12 okt. 2023 kl. 10.12 skrev Rudolf Adamkovi=C4=8D : >> Maybe you should test it just in case. (You don't need a Windows >> machine to do that but it adds authenticity). >=20 > I do not understand. Perhaps you could tell us exactly what you have tested that makes you = confident in saying that Windows file names have been 'fixed'. Otherwise = there is no way for us to know, because the tests in your patch give us = no indication. > How do false positives and performance tie to "beauty"? It's a figure of speech. By the way, precisely what versions of Lua use the message format you = described? This information should go into the entry of compilation.txt = (and the comments describing the new entries in = compilation-error-regexp-alist-alist). As you say, Lua versions tend to introduce incompatible changes because = of how the language is used, and this could very well include the = formatting of diagnostics. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 10 17:53:59 2023 Received: (at 60830) by debbugs.gnu.org; 10 Dec 2023 22:53:59 +0000 Received: from localhost ([127.0.0.1]:51931 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCSgQ-0008Bt-Q9 for submit@debbugs.gnu.org; Sun, 10 Dec 2023 17:53:59 -0500 Received: from pv50p00im-zteg10011401.me.com ([17.58.6.41]:43834) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCSgM-0008BQ-AB for 60830@debbugs.gnu.org; Sun, 10 Dec 2023 17:53:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1702248814; bh=064pvrDsPyWMzJg+7vEZMHJmmFcjchT4U2qNrXOcjGc=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=Cu/aRmznjKHbOMY53eBcIdf7kBhS6rpUkDc/fvpsWkOzNnYmI00yUeFJ79ATW+ld8 n0XLb79/OsiyvmJLVU+otvSLOxUSmGTEUARlIsaU+wo4Au2UQ8vPKZXqcIOPZXegVL 2IR2sqUKcgK3pqxFk8G/6O/2v84iq9rdBEn+ffkNqjVwdzFylFMdjgBCKpvQz/hbbL CdGMFGfoC72lKdZ5hofOgVI988/CEDWOCSPLm8ySBzvkaGDx1qCnkMcflhIVP27jUW lI2OkMnFIyhXthwUkpvikwv9FjxLqEu0P/wPaPGzgjVQBB5flhR5A4f6BIQiu8Lp+4 5Ivdsyrwl+OXg== Received: from Rudolfs-MacBook-Air.local (pv50p00im-dlb-asmtp-mailmevip.me.com [17.56.9.10]) by pv50p00im-zteg10011401.me.com (Postfix) with ESMTPSA id E642EDC0181; Sun, 10 Dec 2023 22:53:31 +0000 (UTC) From: Rudolf =?utf-8?Q?Adamkovi=C4=8D?= To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Subject: Re: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors In-Reply-To: <57BD4380-6307-469B-9DE7-FF1BCD44B679@gmail.com> References: <909EF5E1-6F30-4A35-84E8-2EF4333115FD@gmail.com> <4996E536-72CE-4E6A-9C75-CF7307A82469@gmail.com> <8170D896-5520-4A5E-83F0-51C99BD54802@gmail.com> <57BD4380-6307-469B-9DE7-FF1BCD44B679@gmail.com> Date: Sun, 10 Dec 2023 23:53:28 +0100 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Proofpoint-GUID: OjAIR_A0pPRVdFL0aDVZoWCwHlVmShJl X-Proofpoint-ORIG-GUID: OjAIR_A0pPRVdFL0aDVZoWCwHlVmShJl X-Proofpoint-Virus-Version: =?UTF-8?Q?vendor=3Dfsecure_engine=3D1.1.170-22c6f66c430a71ce266a39bfe25bc?= =?UTF-8?Q?2903e8d5c8f:6.0.517,18.0.572,17.0.605.474.0000000_definitions?= =?UTF-8?Q?=3D2022-06-21=5F01:2022-06-21=5F01,2020-02-14=5F11,2020-01-23?= =?UTF-8?Q?=5F02_signatures=3D0?= X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 clxscore=1015 spamscore=0 bulkscore=0 mlxscore=0 malwarescore=0 phishscore=0 suspectscore=0 mlxlogscore=826 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2312100201 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60830 Cc: 60830@debbugs.gnu.org, Stefan Kangas , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mattias Engdeg=C3=A5rd writes: > [...] Windows file names [...] tests [...] give us no indication. Good catch! I added more tests and updated the code to handle DOS/Windows paths. >> How do false positives and performance tie to "beauty"? > > It's a figure of speech. I see. > [...] precisely what versions of Lua [...] information should go into > the entry of compilation.txt (and the comments describing the new > entries in compilation-error-regexp-alist-alist). So that we can be 100% sure, today I compiled and tested the patch against the last four versions of Lua, as well as, the famously speedy fork LuaJIT. It works correctly in all cases. I added the version information to the appropriate places. I am attaching a new version of the patch. Thank you! Rudy --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Make-the-Compilation-mode-recognize-Lua-errors.patch >From 880989d695929f2488418d69f56f465537c48110 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rudolf=20Adamkovi=C4=8D?= Date: Tue, 3 Oct 2023 09:07:40 +0200 Subject: [PATCH] Make the Compilation mode recognize Lua errors Emacs comes with built-in support for the Lua programming language in the form of the Lua mode and now also the Lua Tree-sitter mode. This patch further improves Lua support in Emacs by making the Compilation mode recognize Lua errors and stack traces. Reported as bug#60830. * etc/compilation.txt (Lua): Add an example of a Lua error message with a stack trace. * lisp/progmodes/compile.el (compilation-error-regexp-alist-alist): Add regexps to aid Lua development, namely the 'lua' regexp that matches Lua errors and the 'lua-stack' regexp that matches Lua stack frames. * test/lisp/progmodes/compile-tests.el (compile-tests--test-regexps-data): (compile-test-error-regexps): Test the new 'lua' and 'lua-stack' regexps added to the 'compilation-error-regexp-alist-alist'. --- etc/NEWS | 5 +++++ etc/compilation.txt | 13 ++++++++++++ lisp/progmodes/compile.el | 8 +++++++ test/lisp/progmodes/compile-tests.el | 31 ++++++++++++++++++++++++++-- 4 files changed, 55 insertions(+), 2 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index 33afb34b029..079afe01d7d 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -407,6 +407,11 @@ This is because it partly acts by modifying other rules which may occasionally be surprising. It can be re-enabled by adding 'omake' to 'compilation-error-regexp-alist'. +*** Lua errors and stack traces are now recognized. +The compilation mode now recognizes Lua language errors and stack +traces. Every Lua error is recognized as a compilation error, and +every Lua stack frame is recognized as a compilation info. + ** Project +++ diff --git a/etc/compilation.txt b/etc/compilation.txt index 5f6ecb09cc2..aaab9cd3bbe 100644 --- a/etc/compilation.txt +++ b/etc/compilation.txt @@ -344,6 +344,19 @@ In /home/janneke/vc/guile/examples/gud-break.scm: 1033: 0 [stderr "~a:hello world\n" (# # #)] +* Lua 5.1, 5.2, 5.3, 5.4, and LuaJIT 2.1 + +/usr/bin/lua: database.lua:31: assertion failed! +stack traceback: + [C]: in function 'assert' + database.lua:31: in field 'statement' + database.lua:42: in field 'table' + database.lua:55: in field 'row' + database.lua:63: in field 'value' + io.lua: in main chunk + [C]: in ? + + * Lucid Compiler, lcc 3.x symbol: lcc diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index 5522c1afc55..c97874e590e 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -362,6 +362,14 @@ compilation-error-regexp-alist-alist (ruby-Test::Unit "^ [[ ]?\\([^ (].*\\):\\([1-9][0-9]*\\)\\(\\]\\)?:in " 1 2) + ;; Tested with Lua 5.1, 5.2, 5.3, 5.4, and LuaJIT 2.1. + (lua + "^[^\n\t]+?: \\([^\n\t]+?\\):\\([0-9]+?\\): .+\nstack traceback:\n\t" + 1 2 nil 2 1) + (lua-stack + "^\t\\(?:\\[C\\]:\\|\\([^\n\t]+?\\):\\(?:\\([0-9]+?\\):\\)?\\) in " + 1 2 nil 0 1) + (gmake ;; Set GNU make error messages as INFO level. ;; It starts with the name of the make program which is variable, diff --git a/test/lisp/progmodes/compile-tests.el b/test/lisp/progmodes/compile-tests.el index d497644c389..be3b5723d24 100644 --- a/test/lisp/progmodes/compile-tests.el +++ b/test/lisp/progmodes/compile-tests.el @@ -206,6 +206,33 @@ compile-tests--test-regexps-data 1 0 31 "/usr/include/c++/3.3/backward/iostream.h") (gcc-include " from test_clt.cc:1:" 1 nil 1 "test_clt.cc") + ;; Lua + (lua "lua: database.lua:10: assertion failed!\nstack traceback:\n\t" + 6 nil 10 "database.lua") + (lua "lua 5.4: database 2.lua:10: assertion failed!\nstack traceback:\n\t" + 10 nil 10 "database 2.lua") + (lua "/usr/local/bin/lua: core/database.lua:20: assertion failed!\nstack traceback:\n\t" + 21 nil 20 "core/database.lua") + (lua "C:\\Lua\\Lua.exe: Core\\Database.lua:20: assertion failed!\nstack traceback:\n\t" + 17 nil 20 "Core\\Database.lua") + (lua "lua: /tmp/database.lua:20: assertion failed!\nstack traceback:\n\t" + 6 nil 20 "/tmp/database.lua") + (lua "Lua.exe: C:\\Temp\\Database.lua:20: assertion failed!\nstack traceback:\n\t" + 10 nil 20 "C:\\Temp\\Database.lua") + (lua-stack " database.lua: in field 'statement'" + 2 nil nil "database.lua" 0) + (lua-stack " database.lua:10: in field 'statement'" + 2 nil 10 "database.lua" 0) + (lua-stack " core/database.lua:20: in field 'statement'" + 2 nil 20 "core/database.lua" 0) + (lua-stack " database 2.lua: in field 'statement'" + 2 nil nil "database 2.lua" 0) + (lua-stack " Core\\Database.lua:20: in field 'statement'" + 2 nil 20 "Core\\Database.lua" 0) + (lua-stack " /tmp/database.lua: in field 'statement'" + 2 nil nil "/tmp/database.lua" 0) + (lua-stack " C:\\Core\\Database.lua: in field 'statement'" + 2 nil nil "C:\\Core\\Database.lua" 0) ;; gmake (gmake "make: *** [Makefile:20: all] Error 2" 12 nil 20 "Makefile" 0) (gmake "make[4]: *** [sub/make.mk:19: all] Error 127" 15 nil 19 @@ -507,9 +534,9 @@ compile-test-error-regexps 1 15 5 "alpha.c"))) (compile--test-error-line test)) - (should (eq compilation-num-errors-found 100)) + (should (eq compilation-num-errors-found 106)) (should (eq compilation-num-warnings-found 35)) - (should (eq compilation-num-infos-found 28))))) + (should (eq compilation-num-infos-found 35))))) (ert-deftest compile-test-grep-regexps () "Test the `grep-regexp-alist' regexps. -- 2.39.3 (Apple Git-145) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable --=20 "Be especially critical of any statement following the word 'obviously.'" -- Anna Pell Wheeler, 1883-1966 Rudolf Adamkovi=C4=8D [he/him] Studenohorsk=C3=A1 25 84103 Bratislava Slovakia --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 10 08:49:00 2024 Received: (at 60830-done) by debbugs.gnu.org; 10 Jan 2024 13:49:00 +0000 Received: from localhost ([127.0.0.1]:39264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNYx2-00038L-1V for submit@debbugs.gnu.org; Wed, 10 Jan 2024 08:49:00 -0500 Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234]:48389) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNYx0-00037Z-8h for 60830-done@debbugs.gnu.org; Wed, 10 Jan 2024 08:48:59 -0500 Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2cd65f803b7so22239821fa.1 for <60830-done@debbugs.gnu.org>; Wed, 10 Jan 2024 05:48:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704894533; x=1705499333; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=eeGHZugG1ReJS8/OXCToBgTk2CPQ9lR3bnDSLpu6t1M=; b=cmcHQY2sjbe8JTZwg6SMQ/+ogeh3eHEVGUkffEEuoI0mCzDrfAIh8Ksx3kezGyRocI ZK4GAmh/RDKJAxbeIXfiWSNRnxzd1DQdS9mPnPxgZXbDlqvAiII55zlWjrQMp+JDKtgG TzmPHOpdPiGuJYwNqn5O0ggYdVrwn51BL0ljm3G347TOtebscBrw64htknMl9SolZHfn Q+vaGTd0MjaJV2YXex72jL9R/hHEKx+IOVflWrWrsjRsZHycG6XFgJ5gIS8IJPTzOd2D rdXPM8OiiiISpg3qIjMBK8JwKLrZQxQnDb/1/o2WQCot/6K2edpL/fKneCZ9QtErXN6v dp0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704894533; x=1705499333; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=eeGHZugG1ReJS8/OXCToBgTk2CPQ9lR3bnDSLpu6t1M=; b=rdWyaN8ilkNPSrGh3AT5KceLJO7eHsUVXJ9HqeGLnrlsxfZ//w0JQqejxE6YV2z4x4 /6lAIuDJF9YbW2/bCZk26HjjH69HLoq48v0Q13qAJk9Apwbx66IbWBYp5xhHigIAn/de H64zAIDxLkk3mzAIyQwNaKFgBUA8TwD4KMqF8wRCZCqaRSw6p+j3ZVXztg8GBydYSMpL Tiv9zFkUpr6IZ4G+O8YO+aj5NZOQv8l2V7XyubSPzL6FH+gkz38GJgJ/XvkzVKAbZYj4 PKPRrX1kW48x8CrAGcY1N61cxqhecje7tnvqCEUESseXr+LKyxNJxoxSnb5G4MzyJ4is 2KWQ== X-Gm-Message-State: AOJu0YxU0A/HPWvh2EPnWCCcGu77Wv14ui66QuNvQwhVA/lMZotIrR8Z 3WY06KZMjG7lk6HzMOp67icr4nWRQamtXVyRvu8= X-Google-Smtp-Source: AGHT+IHG433pUVdgjyMU0VnbP91gunM65vmIG9LLqsf5enH3Hy3POJvqoK5nvGJHNHityymUogM/ges36rYTZ98BSHU= X-Received: by 2002:a2e:9e48:0:b0:2cc:f698:b0b3 with SMTP id g8-20020a2e9e48000000b002ccf698b0b3mr495689ljk.35.1704894532674; Wed, 10 Jan 2024 05:48:52 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 10 Jan 2024 05:48:51 -0800 From: Stefan Kangas In-Reply-To: References: <909EF5E1-6F30-4A35-84E8-2EF4333115FD@gmail.com> <4996E536-72CE-4E6A-9C75-CF7307A82469@gmail.com> <8170D896-5520-4A5E-83F0-51C99BD54802@gmail.com> <57BD4380-6307-469B-9DE7-FF1BCD44B679@gmail.com> MIME-Version: 1.0 Date: Wed, 10 Jan 2024 05:48:51 -0800 Message-ID: Subject: Re: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors To: =?UTF-8?Q?Rudolf_Adamkovi=C4=8D?= , =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60830-done Cc: 60830-done@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Rudolf Adamkovi=C4=8D writes: > I am attaching a new version of the patch. Thank you, installed on master (cd0eb055fd4) and closing the bug. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 10 11:37:43 2024 Received: (at 60830) by debbugs.gnu.org; 10 Jan 2024 16:37:43 +0000 Received: from localhost ([127.0.0.1]:42629 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNbaI-0004B3-Rj for submit@debbugs.gnu.org; Wed, 10 Jan 2024 11:37:43 -0500 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]:59573) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNbaH-0004Aq-9P for 60830@debbugs.gnu.org; Wed, 10 Jan 2024 11:37:41 -0500 Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-50eabbc3dccso4683619e87.2 for <60830@debbugs.gnu.org>; Wed, 10 Jan 2024 08:37:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704904656; x=1705509456; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=CXLADow3X3CT2UNdk1PrSJ+OK6Bokmkd54AP4hZP8Ks=; b=Rp6DGRvkvMCZOacW8tBvncZ2a1IzkdHzc4ltLMBnByJHA7ov+RzNrhTQVpJloNpPFP yxHWIgPX7rXfcbDQ1Fv/GwazXcZMyQ5pHS4xTYdeOtJNk5QVTyjOYfaNnmFP+192zvB+ bLRbVU5tgj3cJMmqVAASDMFAnFiXb+TDWbmymYE56NM58ze37FEvI7oJlTIZ0RRmFZOW tft66s1KckOPBrd5uPAdYqXcsQGWtoYU+18ScITAA4/ofVc2YpcFmcAd+LXA7H7g+Drg 7SzrVfHMn4wMxjvaOdN18UJswvUWTtkBHNZBUJ71m94Q9KBACDoBLXouJoh01hh8y/P2 srSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704904656; x=1705509456; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=CXLADow3X3CT2UNdk1PrSJ+OK6Bokmkd54AP4hZP8Ks=; b=E6y79i2yX4mbEJKpqUKgYku4492REE1OgKKOhNHkKjChKJ4QrtQNBrw/cCk3O5Bigi bgyGkTTLbV8SLhAR5tz/hILtNm1OccuuoSFLZxt0c1rYSeIw/L0o0g/VK7HQKxAPeA3E lf8pLbyAmEFQtUTNGh8Olu0CRJp1QOmX/YGPeeK4xa+1V+CLcmNpOwe2SLMRQXzJr/Fo pISAojQkZfSvGiVFtrFEmuvhpewtphUpDCYj56DxgijPk4+ELbsv6Jb1zL1fXIZ/K8Lt BFU54zbraeEcfEJiC+WJdd9MDBv163hKi8pUgjFO5T6j8z3Kd+tMvnMOW8N4uDxYfRCr 10ug== X-Gm-Message-State: AOJu0Yyv1E2pQtKzhTItJ5ZgPX3hAn6AHHC+vKJXHuXgPG1cHCJZteXt th9OuHVd5L72wCyzGMhIM5M= X-Google-Smtp-Source: AGHT+IHCeQPwZxlM15Lcuy96y1c4HLbEVdPiIbhv83GGBG4vLwS/oyd6Z3yMG+LTnOWQrPhjGzASDQ== X-Received: by 2002:a19:750a:0:b0:50e:3129:bbee with SMTP id y10-20020a19750a000000b0050e3129bbeemr317896lfe.5.1704904656157; Wed, 10 Jan 2024 08:37:36 -0800 (PST) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id m18-20020a056512115200b0050ec7956b1fsm705420lfg.29.2024.01.10.08.37.35 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Jan 2024 08:37:35 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: Date: Wed, 10 Jan 2024 17:37:34 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <4B80400D-9223-47F3-8F59-BC95C79A6DBE@gmail.com> References: <909EF5E1-6F30-4A35-84E8-2EF4333115FD@gmail.com> <4996E536-72CE-4E6A-9C75-CF7307A82469@gmail.com> <8170D896-5520-4A5E-83F0-51C99BD54802@gmail.com> <57BD4380-6307-469B-9DE7-FF1BCD44B679@gmail.com> To: Stefan Kangas X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60830 Cc: 60830@debbugs.gnu.org, =?utf-8?Q?Rudolf_Adamkovi=C4=8D?= , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 10 jan. 2024 kl. 14.48 skrev Stefan Kangas : > Thank you, installed on master (cd0eb055fd4) and closing the bug. Sorry for falling behind on this bug, and thank you for helping me catch = up. However I wasn't actually finished here: the new regexps are still = annoyingly close to other patterns that mismatches and/or bad = performance cannot be ruled out, and it would be good to have a way to = deal with it. I'm tempted go about disabling large swaths of rules since for every = useful contemporary rule like Gnu, Typescript and yes, Lua, there seem = to be a half-dozen ones for niche and/or outright antiquated tools. Anyway, I performed some minimum maintenance on the new Lua patterns but = can't promise that they be enabled by default in the end -- it's not = that they aren't useful but risk of interference. (And it's probably high time I made a batch conversion of the remaining = patterns to rx.) From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 10 12:09:19 2024 Received: (at 60830) by debbugs.gnu.org; 10 Jan 2024 17:09:19 +0000 Received: from localhost ([127.0.0.1]:42690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNc4t-0001vJ-1T for submit@debbugs.gnu.org; Wed, 10 Jan 2024 12:09:19 -0500 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]:48583) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNc4r-0001v6-4O for 60830@debbugs.gnu.org; Wed, 10 Jan 2024 12:09:17 -0500 Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-55719cdc0e1so4974277a12.1 for <60830@debbugs.gnu.org>; Wed, 10 Jan 2024 09:09:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704906552; x=1705511352; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=Tqcw4TQeqY/4+xXGK9NYkFlwyvgkp47vJuIX/waJIYs=; b=Kyu3wiPxL/4HcW5MLMVFL1kE5/L88D1NEAwPOypXooPfUcvM1DNIFg9Nku9sArHNtj mVNiiWhW9r1MYqUpj8V3NMw4tPwBiFQR8r7m+cuCTovYXxnVUy6wJexquUZAB4+YzEoY BPGI/5yLLNnz0bpJBbyzYFIZH3cQ9UyN8+XxaIVZTZUtSc75YzdT5upGOGRq76YjTZ01 JAckmk/72OzNpWDxPXw8rYXPKlHuPVu6R/no0OEQbLdW2DLW8kawNPIh9wGt5wgdJV87 lY7lygYbiRQvSaMGsp271NI9Ins/OGhfd1bjE0l/xR+b64AIjGCPDjmTzjyJ5rbO8Hdf DuYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704906552; x=1705511352; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Tqcw4TQeqY/4+xXGK9NYkFlwyvgkp47vJuIX/waJIYs=; b=MymqUMHfPR7DVULtJ1Kl2oJZ83fIG2pDp09gszguQuwudIWokXoxOmzqTbUjIqB8sf PvsHpSqwbpC7Kh7iajdNa2v3ZTbANPz38fJCt8ZeypVFjDrx/nO08JdktVZzrN1neklf 3fhZvX9N8pR7tkAES8XgxN2xPncefTfQhorKMtAZ3t3prM3OwMEGK8JhBGouoqW4DK9c 0v0Zgrcy3ZDAgky0DNSlUOlXuZK8RFs1PB+7+uyUymqm/8oj5GTVANsw2b5Wosk0bdrQ 1TKajBL7xCSJWy9uCfoBq/zk9oDs7jik/ZnYYRtZ5LdipBIbTzO0rYAfOFDEC7PjOEVX 5hbQ== X-Gm-Message-State: AOJu0YzbzsDv5rBXSdwunEcX41hLZziiwPcuDB9oQLDQSV/rtYB7eFXm zSveBEFkGrtaf534JdIbWh+UosqgsZeRZwEFg48= X-Google-Smtp-Source: AGHT+IEqEApUuGPeWZxJ1jUIBCrEmqkIn1sWxUR73Smma8HkBR4FpNhBYTW6+ZMSc2RWLUc6qasqhO97omPAAiUS8zE= X-Received: by 2002:a50:c349:0:b0:557:1e56:c2cb with SMTP id q9-20020a50c349000000b005571e56c2cbmr753522edb.69.1704906551805; Wed, 10 Jan 2024 09:09:11 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 10 Jan 2024 09:09:11 -0800 From: Stefan Kangas In-Reply-To: <4B80400D-9223-47F3-8F59-BC95C79A6DBE@gmail.com> References: <909EF5E1-6F30-4A35-84E8-2EF4333115FD@gmail.com> <4996E536-72CE-4E6A-9C75-CF7307A82469@gmail.com> <8170D896-5520-4A5E-83F0-51C99BD54802@gmail.com> <57BD4380-6307-469B-9DE7-FF1BCD44B679@gmail.com> <4B80400D-9223-47F3-8F59-BC95C79A6DBE@gmail.com> MIME-Version: 1.0 Date: Wed, 10 Jan 2024 09:09:11 -0800 Message-ID: Subject: Re: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors To: =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60830 Cc: 60830@debbugs.gnu.org, =?UTF-8?Q?Rudolf_Adamkovi=C4=8D?= , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mattias Engdeg=C3=A5rd writes: > 10 jan. 2024 kl. 14.48 skrev Stefan Kangas : > >> Thank you, installed on master (cd0eb055fd4) and closing the bug. > > Sorry for falling behind on this bug, and thank you for helping me > catch up. > > However I wasn't actually finished here: the new regexps are still > annoyingly close to other patterns that mismatches and/or bad > performance cannot be ruled out, and it would be good to have a way to > deal with it. Sorry, that was a misunderstanding on my part. I thought we were done discussing it. Feel free to revert the change and reopen the bug, or whatever else you think makes sense here. > I'm tempted go about disabling large swaths of rules since for every > useful contemporary rule like Gnu, Typescript and yes, Lua, there seem > to be a half-dozen ones for niche and/or outright antiquated tools. > > Anyway, I performed some minimum maintenance on the new Lua patterns > but can't promise that they be enabled by default in the end -- it's > not that they aren't useful but risk of interference. If we can't even enable new patterns due to risk of interference, then it's clear that we've dug ourselves into a hole. How about adding a new user option `compilation-enabled-errors' where you could disable (or enable) the ones you are interested in, and then generate `compilation-error-regexp-alist-alist' based on that? That would provide a convenient way for users to get back the support for their trusty Jikes compiler or whatever. We should probably also support using it as a directory local variable somehow, so that projects could set this only once. > (And it's probably high time I made a batch conversion of the > remaining patterns to rx.) That would help maintenance, so I'm all for it. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 10 12:45:34 2024 Received: (at 60830) by debbugs.gnu.org; 10 Jan 2024 17:45:34 +0000 Received: from localhost ([127.0.0.1]:42860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNcdx-0001Ah-Ol for submit@debbugs.gnu.org; Wed, 10 Jan 2024 12:45:34 -0500 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]:59668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNcdv-0000xl-KT for 60830@debbugs.gnu.org; Wed, 10 Jan 2024 12:45:32 -0500 Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-50e7c6e3c63so4602230e87.3 for <60830@debbugs.gnu.org>; Wed, 10 Jan 2024 09:45:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704908727; x=1705513527; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=7OeBBuzvmqo9GlatGBYHwY0kD8JBZIN+ePywYHJexQs=; b=OhLPgLxLLLAe5ekMrfAozOMCFx/3ZtSGEGiLBy8bCG0Q2KEaXGeIGBXAjxJzQ4KGze z9aDuC4Oawse0Lk9z1O2XRSTxHkbLGlU6Mzh0L25bCgWpyuo/wb9hUP8pcSx+XSGnT1l 8G/E+VTbkJB0YQsBi3fjfNtgVvW1v8sM8YW0TcTOUAghHRpuDHcQNiE7vPXLj6aJr5b1 iXeq9z85tXPCtGBbDMURlI/paq9mc58yWQ8UBC6OTkeNRRPWXicp4sbprWNAvuCj+GFc fjjsJHEFvuJRuhhJc6mG3AltNqTwuYiz4G3S+dUY1gy1tKV4JEre7vIEKt2Vfo0q/Asx rF6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704908727; x=1705513527; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=7OeBBuzvmqo9GlatGBYHwY0kD8JBZIN+ePywYHJexQs=; b=ctbzn/x6B5ewK7t1cCuesUnCBEKR0bfOjSw/KyW7BipfgX+G+2A4gco40CUDPklWu9 Ji4kMib2QQdobJtwOH8/LH1eyaD4vHdu7AYAuYJo7hUO3QrLTt0a0P1JbGNjXTciYCm9 ihaIJ2QromVp8mdVpdFCYI1Nq52esJBlJrT3V3T/xTld6ZvnJOlE5LtarsHlB7HPRTe1 LC7FvFQsCgakQwRvYfFRS5dhz9Xzfz7PUcTwDJPuDIuTdwWs+IXW4aH7vM2r9lUJ1tMu UuagHO3sVo7rVlGf8is+agTpXbe593l/nXnE/UsMakHAhx2HjU8FqTE/qVRkymdZ9Ofi NsJw== X-Gm-Message-State: AOJu0Yyv1mMIcN0nDgPDWUQzl2HvsPprICFvexD3oLNe0UXlQ8HsqF2B r0eOUp8XPKCL+Cjn0sC+pVCJ72LgvvE= X-Google-Smtp-Source: AGHT+IGx9d+Bc27rvosZ7oNp6AkOpZEIaWi8yZu69MbM5QMJJDA5zj0qB6FTGYp+iAw2wYOeIAGSpQ== X-Received: by 2002:ac2:4e4f:0:b0:50e:3d60:7784 with SMTP id f15-20020ac24e4f000000b0050e3d607784mr266153lfr.235.1704908726710; Wed, 10 Jan 2024 09:45:26 -0800 (PST) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id a29-20020a056512021d00b0050e7c6dfff8sm710639lfo.110.2024.01.10.09.45.26 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Jan 2024 09:45:26 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: Date: Wed, 10 Jan 2024 18:45:24 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <366768EE-1232-466C-9456-9196F90D1E78@gmail.com> References: <909EF5E1-6F30-4A35-84E8-2EF4333115FD@gmail.com> <4996E536-72CE-4E6A-9C75-CF7307A82469@gmail.com> <8170D896-5520-4A5E-83F0-51C99BD54802@gmail.com> <57BD4380-6307-469B-9DE7-FF1BCD44B679@gmail.com> <4B80400D-9223-47F3-8F59-BC95C79A6DBE@gmail.com> To: Stefan Kangas X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60830 Cc: 60830@debbugs.gnu.org, =?utf-8?Q?Rudolf_Adamkovi=C4=8D?= , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 10 jan. 2024 kl. 18.09 skrev Stefan Kangas : > Sorry, that was a misunderstanding on my part. I thought we were done > discussing it. Feel free to revert the change and reopen the bug, or > whatever else you think makes sense here. No, I think we're done with the bug at hand (Lua messages) for now, even = if it means that we may revisit the choices made later on. > How about adding a new user option `compilation-enabled-errors' where > you could disable (or enable) the ones you are interested in, and then > generate `compilation-error-regexp-alist-alist' based on that? See the (somewhat lengthy) history of this bug for some discussion about = that. In short, we already have `compilation-error-regexp-alist` which = basically serves that purpose, but is complicated by the fact that both = users and packages edit it and `compilation-error-regexp-alist-alist`, = often at the same time. The question is how we can reinterpret CERA and CERAA in a compatible = way that allows for easy user customisation but also for them to be = extended in a modular way. >> (And it's probably high time I made a batch conversion of the >> remaining patterns to rx.) >=20 > That would help maintenance, so I'm all for it. I'll do that a little later then. From unknown Sat Sep 06 02:32:44 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 08 Feb 2024 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator