GNU bug report logs - #60829
[PATCH] m4: use AS_IF to avoid ! portability issues

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mike Frysinger <vapier <at> gentoo.org>
Subject: bug#60829: closed (Re: [bug#60829] [PATCH] m4: use AS_IF to avoid
 ! portability issues)
Date: Wed, 15 Nov 2023 21:27:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#60829: [PATCH] m4: use AS_IF to avoid ! portability issues

which was filed against the automake-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 60829 <at> debbugs.gnu.org.

-- 
60829: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60829
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Karl Berry <karl <at> freefriends.org>
To: vapier <at> gentoo.org
Cc: 60829 <at> debbugs.gnu.org
Subject: Re: [bug#60829] [PATCH] m4: use AS_IF to avoid ! portability issues
Date: Wed, 15 Nov 2023 14:26:43 -0700

    diff --git a/m4/sanity.m4 b/m4/sanity.m4
    ...
    -if ! test -e conftest.file || grep 'slept: no' conftest.file >/dev/null 2>&1; then
    +AS_IF([test -e conftest.file || grep 'slept: no' conftest.file >/dev/null 2>&1],, [dnl

Finally installed this change. (And closing.) Thanks Mike. -k

[Message part 3 (message/rfc822, inline)]

From: Mike Frysinger <vapier <at> gentoo.org>
To: automake-patches <at> gnu.org
Subject: [PATCH] m4: use AS_IF to avoid ! portability issues
Date: Sun, 15 Jan 2023 03:38:25 -0500

Since the ! builtin has portability issues (as documented in the Autoconf
manual), switch to AS_IF which takes care of these issues for us.

* m4/sanity.m4: Switch `if` to AS_IF.
---
 m4/sanity.m4 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/m4/sanity.m4 b/m4/sanity.m4
index db9a1f5639f1..c24648045e2f 100644
--- a/m4/sanity.m4
+++ b/m4/sanity.m4
@@ -110,10 +110,10 @@ fi
 # If we didn't sleep, we still need to ensure time stamps of config.status and
 # generated files are strictly newer.
 am_sleep_pid=
-if ! test -e conftest.file || grep 'slept: no' conftest.file >/dev/null 2>&1; then
+AS_IF([test -e conftest.file || grep 'slept: no' conftest.file >/dev/null 2>&1],, [dnl
   ( sleep $am_cv_filesystem_timestamp_resolution ) &
   am_sleep_pid=$!
-fi
+])
 AC_CONFIG_COMMANDS_PRE(
   [AC_MSG_CHECKING([that generated files are newer than configure])
    if test -n "$am_sleep_pid"; then
-- 
2.39.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.