From unknown Sat Sep 06 13:37:58 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#60829] [PATCH] m4: use AS_IF to avoid ! portability issues Resent-From: Mike Frysinger Original-Sender: "Debbugs-submit" Resent-CC: automake-patches@gnu.org Resent-Date: Sun, 15 Jan 2023 08:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 60829 X-GNU-PR-Package: automake-patches X-GNU-PR-Keywords: patch To: 60829@debbugs.gnu.org X-Debbugs-Original-To: automake-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16737719369191 (code B ref -1); Sun, 15 Jan 2023 08:39:01 +0000 Received: (at submit) by debbugs.gnu.org; 15 Jan 2023 08:38:56 +0000 Received: from localhost ([127.0.0.1]:56086 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGyXU-0002O5-Au for submit@debbugs.gnu.org; Sun, 15 Jan 2023 03:38:56 -0500 Received: from lists.gnu.org ([209.51.188.17]:37070) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGyXR-0002Nu-5t for submit@debbugs.gnu.org; Sun, 15 Jan 2023 03:38:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGyXJ-0005W8-BU for automake-patches@gnu.org; Sun, 15 Jan 2023 03:38:43 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183] helo=smtp.gentoo.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1pGyXG-0006Kk-Ju for automake-patches@gnu.org; Sun, 15 Jan 2023 03:38:40 -0500 Received: by smtp.gentoo.org (Postfix, from userid 559) id 95CB6340EE9; Sun, 15 Jan 2023 08:38:28 +0000 (UTC) From: Mike Frysinger Date: Sun, 15 Jan 2023 03:38:25 -0500 Message-Id: <20230115083825.12606-1-vapier@gentoo.org> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=140.211.166.183; envelope-from=vapier@gentoo.org; helo=smtp.gentoo.org X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Since the ! builtin has portability issues (as documented in the Autoconf manual), switch to AS_IF which takes care of these issues for us. * m4/sanity.m4: Switch `if` to AS_IF. --- m4/sanity.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/m4/sanity.m4 b/m4/sanity.m4 index db9a1f5639f1..c24648045e2f 100644 --- a/m4/sanity.m4 +++ b/m4/sanity.m4 @@ -110,10 +110,10 @@ fi # If we didn't sleep, we still need to ensure time stamps of config.status and # generated files are strictly newer. am_sleep_pid= -if ! test -e conftest.file || grep 'slept: no' conftest.file >/dev/null 2>&1; then +AS_IF([test -e conftest.file || grep 'slept: no' conftest.file >/dev/null 2>&1],, [dnl ( sleep $am_cv_filesystem_timestamp_resolution ) & am_sleep_pid=$! -fi +]) AC_CONFIG_COMMANDS_PRE( [AC_MSG_CHECKING([that generated files are newer than configure]) if test -n "$am_sleep_pid"; then -- 2.39.0 From unknown Sat Sep 06 13:37:58 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#60829] [PATCH] m4: use AS_IF to avoid ! portability issues References: <20230115083825.12606-1-vapier@gentoo.org> Resent-From: Karl Berry Original-Sender: "Debbugs-submit" Resent-CC: automake-patches@gnu.org Resent-Date: Wed, 15 Nov 2023 21:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60829 X-GNU-PR-Package: automake-patches X-GNU-PR-Keywords: patch To: vapier@gentoo.org Cc: 60829@debbugs.gnu.org Received: via spool by 60829-submit@debbugs.gnu.org id=B60829.170008360818684 (code B ref 60829); Wed, 15 Nov 2023 21:27:02 +0000 Received: (at 60829) by debbugs.gnu.org; 15 Nov 2023 21:26:48 +0000 Received: from localhost ([127.0.0.1]:53983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3NPL-0004rD-MR for submit@debbugs.gnu.org; Wed, 15 Nov 2023 16:26:47 -0500 Received: from frenzy.freefriends.org ([198.99.81.75]:47254 helo=freefriends.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3NPH-0004qp-GF; Wed, 15 Nov 2023 16:26:45 -0500 X-Envelope-From: karl@freefriends.org Received: from freefriends.org (localhost [127.0.0.1]) by freefriends.org (8.14.7/8.14.7) with ESMTP id 3AFLQhfU009699 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 15 Nov 2023 14:26:43 -0700 Received: (from apache@localhost) by freefriends.org (8.14.7/8.14.7/Submit) id 3AFLQhcS009698; Wed, 15 Nov 2023 14:26:43 -0700 Date: Wed, 15 Nov 2023 14:26:43 -0700 Message-Id: <202311152126.3AFLQhcS009698@freefriends.org> From: Karl Berry In-Reply-To: <20230115083825.12606-1-vapier@gentoo.org> X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) diff --git a/m4/sanity.m4 b/m4/sanity.m4 ... -if ! test -e conftest.file || grep 'slept: no' conftest.file >/dev/null 2>&1; then +AS_IF([test -e conftest.file || grep 'slept: no' conftest.file >/dev/null 2>&1],, [dnl Finally installed this change. (And closing.) Thanks Mike. -k From unknown Sat Sep 06 13:37:58 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Mike Frysinger Subject: bug#60829: closed (Re: [bug#60829] [PATCH] m4: use AS_IF to avoid ! portability issues) Message-ID: References: <202311152126.3AFLQhcS009698@freefriends.org> <20230115083825.12606-1-vapier@gentoo.org> X-Gnu-PR-Message: they-closed 60829 X-Gnu-PR-Package: automake-patches X-Gnu-PR-Keywords: patch Reply-To: 60829@debbugs.gnu.org Date: Wed, 15 Nov 2023 21:27:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1700083623-18754-1" This is a multi-part message in MIME format... ------------=_1700083623-18754-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #60829: [PATCH] m4: use AS_IF to avoid ! portability issues which was filed against the automake-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 60829@debbugs.gnu.org. --=20 60829: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D60829 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1700083623-18754-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 60829-done) by debbugs.gnu.org; 15 Nov 2023 21:26:47 +0000 Received: from localhost ([127.0.0.1]:53981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3NPL-0004rB-Ec for submit@debbugs.gnu.org; Wed, 15 Nov 2023 16:26:47 -0500 Received: from frenzy.freefriends.org ([198.99.81.75]:47254 helo=freefriends.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3NPH-0004qp-GF; Wed, 15 Nov 2023 16:26:45 -0500 X-Envelope-From: karl@freefriends.org Received: from freefriends.org (localhost [127.0.0.1]) by freefriends.org (8.14.7/8.14.7) with ESMTP id 3AFLQhfU009699 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 15 Nov 2023 14:26:43 -0700 Received: (from apache@localhost) by freefriends.org (8.14.7/8.14.7/Submit) id 3AFLQhcS009698; Wed, 15 Nov 2023 14:26:43 -0700 Date: Wed, 15 Nov 2023 14:26:43 -0700 Message-Id: <202311152126.3AFLQhcS009698@freefriends.org> From: Karl Berry To: vapier@gentoo.org Subject: Re: [bug#60829] [PATCH] m4: use AS_IF to avoid ! portability issues In-Reply-To: <20230115083825.12606-1-vapier@gentoo.org> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60829-done Cc: 60829@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) diff --git a/m4/sanity.m4 b/m4/sanity.m4 ... -if ! test -e conftest.file || grep 'slept: no' conftest.file >/dev/null 2>&1; then +AS_IF([test -e conftest.file || grep 'slept: no' conftest.file >/dev/null 2>&1],, [dnl Finally installed this change. (And closing.) Thanks Mike. -k ------------=_1700083623-18754-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 15 Jan 2023 08:38:56 +0000 Received: from localhost ([127.0.0.1]:56086 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGyXU-0002O5-Au for submit@debbugs.gnu.org; Sun, 15 Jan 2023 03:38:56 -0500 Received: from lists.gnu.org ([209.51.188.17]:37070) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGyXR-0002Nu-5t for submit@debbugs.gnu.org; Sun, 15 Jan 2023 03:38:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGyXJ-0005W8-BU for automake-patches@gnu.org; Sun, 15 Jan 2023 03:38:43 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183] helo=smtp.gentoo.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1pGyXG-0006Kk-Ju for automake-patches@gnu.org; Sun, 15 Jan 2023 03:38:40 -0500 Received: by smtp.gentoo.org (Postfix, from userid 559) id 95CB6340EE9; Sun, 15 Jan 2023 08:38:28 +0000 (UTC) From: Mike Frysinger To: automake-patches@gnu.org Subject: [PATCH] m4: use AS_IF to avoid ! portability issues Date: Sun, 15 Jan 2023 03:38:25 -0500 Message-Id: <20230115083825.12606-1-vapier@gentoo.org> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=140.211.166.183; envelope-from=vapier@gentoo.org; helo=smtp.gentoo.org X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Since the ! builtin has portability issues (as documented in the Autoconf manual), switch to AS_IF which takes care of these issues for us. * m4/sanity.m4: Switch `if` to AS_IF. --- m4/sanity.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/m4/sanity.m4 b/m4/sanity.m4 index db9a1f5639f1..c24648045e2f 100644 --- a/m4/sanity.m4 +++ b/m4/sanity.m4 @@ -110,10 +110,10 @@ fi # If we didn't sleep, we still need to ensure time stamps of config.status and # generated files are strictly newer. am_sleep_pid= -if ! test -e conftest.file || grep 'slept: no' conftest.file >/dev/null 2>&1; then +AS_IF([test -e conftest.file || grep 'slept: no' conftest.file >/dev/null 2>&1],, [dnl ( sleep $am_cv_filesystem_timestamp_resolution ) & am_sleep_pid=$! -fi +]) AC_CONFIG_COMMANDS_PRE( [AC_MSG_CHECKING([that generated files are newer than configure]) if test -n "$am_sleep_pid"; then -- 2.39.0 ------------=_1700083623-18754-1--