From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 13 20:47:37 2023 Received: (at submit) by debbugs.gnu.org; 14 Jan 2023 01:47:37 +0000 Received: from localhost ([127.0.0.1]:52852 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGVdw-000099-Nw for submit@debbugs.gnu.org; Fri, 13 Jan 2023 20:47:37 -0500 Received: from lists.gnu.org ([209.51.188.17]:40316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGVdt-00008v-QY for submit@debbugs.gnu.org; Fri, 13 Jan 2023 20:47:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGVdt-0001QJ-LB for guix-patches@gnu.org; Fri, 13 Jan 2023 20:47:33 -0500 Received: from mx0.riseup.net ([198.252.153.6]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGVdr-00017h-Pf for guix-patches@gnu.org; Fri, 13 Jan 2023 20:47:33 -0500 Received: from fews1.riseup.net (fews1-pn.riseup.net [10.0.1.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.riseup.net", Issuer "R3" (not verified)) by mx0.riseup.net (Postfix) with ESMTPS id 4Nv1PZ0vxWz9slr; Sat, 14 Jan 2023 01:47:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1673660850; bh=wP5W3WFHYYg/07SRU5lf/NJ5rgdZpUe5u1wd6NhdAc4=; h=From:To:Cc:Subject:Date:From; b=G+wGMvfsCyng/ik6NfzbNGkqUM/2EEuUd7RcKpY3KVLBzOLqcvoEkkEuqNeoQ66vd g0bh3C4OkrTVEAY7EKLqEySuK+Q5Ptkx0iuQWXr3yRpWmRqr2zP+RQ6FQaGmkecgI1 h8VBkUFNP7hkrQ3o67tGtubDYVLmojt2BOtT37a4= X-Riseup-User-ID: 54C687042E1A2F807EC19783FD5474CF8711D1A3BDAE63DA7950DFDC662BBA83 Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews1.riseup.net (Postfix) with ESMTPSA id 4Nv1PY27jlz5vSS; Sat, 14 Jan 2023 01:47:29 +0000 (UTC) From: Declan Tsien To: guix-patches@gnu.org Subject: [PATCH] services: connman: Add option to disable wpa-supplicant. Date: Sat, 14 Jan 2023 09:47:22 +0800 Message-ID: <87sfgdanv9.fsf@riseup.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Received-SPF: pass client-ip=198.252.153.6; envelope-from=declantsien@riseup.net; helo=mx0.riseup.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Bruno Victal X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain I am starting a new thread and will close the old one, since the subject changed. Not sure this is the right way. This is a follow-up of https://issues.guix.gnu.org/60752 As Bruno Victal writes: > Hi, > > Does connman absolutely require a wireless adapter backend? > IMO if that's not the case, neither iwd nor wpa-supplicant backends should be pulled by connman. (or at least they should be required only if they are present among the services field) > This is because not every machine comes or wants to use a wireless adapter. > > > Cheers, > Bruno This patch allows users to disable wireless adapters or hook in a another implementation like iwd, without breaking existing installations. --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-services-connman-Add-option-to-disable-wpa-supplican.patch Content-Transfer-Encoding: quoted-printable Content-Description: services: connman: Add option to disable wpa-supplicant. From=20379d4afac343101a2351bab4f314496395828d8d Mon Sep 17 00:00:00 2001 From: Declan Tsien Date: Sat, 14 Jan 2023 08:57:02 +0800 Subject: [PATCH] services: connman: Add option to disable wpa-supplicant. * gnu/services/networking.scm (connman-configuration)[disable-wpa-supplicant?]: New field. (connman-shepherd-service): Applied disable-wpa-supplicant? logic. * doc/guix.texi: Add information about connman-configuration disable-wpa-supplicant? option. =2D-- doc/guix.texi | 4 ++++ gnu/services/networking.scm | 20 ++++++++++++-------- 2 files changed, 16 insertions(+), 8 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 751d0957d8..29be830bd4 100644 =2D-- a/doc/guix.texi +++ b/doc/guix.texi @@ -19726,6 +19726,10 @@ The connman package to use. =20 @item @code{disable-vpn?} (default: @code{#f}) When true, disable connman's vpn plugin. + +@item @code{disable-wpa-supplicant?} (default: @code{#f}) +When true, remove @code{wpa-supplicant} requirement. Let users disable +wireless adapters or hook in a another implementation like @code{iwd}. @end table @end deftp =20 diff --git a/gnu/services/networking.scm b/gnu/services/networking.scm index 702404bc6c..39162fe822 100644 =2D-- a/gnu/services/networking.scm +++ b/gnu/services/networking.scm @@ -19,6 +19,7 @@ ;;; Copyright =C2=A9 2021 Maxime Devos ;;; Copyright =C2=A9 2021 Guillaume Le Vaillant ;;; Copyright =C2=A9 2022 Andrew Tropin +;;; Copyright =C2=A9 2023 Declan Tsien ;;; ;;; This file is part of GNU Guix. ;;; @@ -1262,10 +1263,12 @@ (define network-manager-service-type (define-record-type* connman-configuration make-connman-configuration connman-configuration? =2D (connman connman-configuration-connman =2D (default connman)) =2D (disable-vpn? connman-configuration-disable-vpn? =2D (default #f))) + (connman connman-configuration-connman + (default connman)) + (disable-vpn? connman-configuration-disable-vpn? + (default #f)) + (disable-wpa-supplicant? connman-configuration-disable-wpa-supplicant? + (default #f))) =20 (define (connman-activation config) (let ((disable-vpn? (connman-configuration-disable-vpn? config))) @@ -1280,13 +1283,14 @@ (define (connman-shepherd-service config) "Return a shepherd service for Connman" (and (connman-configuration? config) =2D (let ((connman (connman-configuration-connman config)) =2D (disable-vpn? (connman-configuration-disable-vpn? config))) + (let ((connman (connman-configuration-connman config)) + (disable-vpn? (connman-configuration-disable-vpn? conf= ig)) + (disable-wpa-supplicant? (connman-configuration-disable-wpa-suppl= icant? config))) (list (shepherd-service (documentation "Run Connman") (provision '(networking)) =2D (requirement =2D '(user-processes dbus-system loopback wpa-supplicant)) + (requirement (append '(user-processes dbus-system loopback) + (if disable-wpa-supplicant? '() '(wpa-sup= plicant)))) (start #~(make-forkexec-constructor (list (string-append #$connman "/sbin/connmand") =2D-=20 2.38.1 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHLBAEBCAA1FiEE9pXznsYl4IEztXWfD8aHA3Xv4vUFAmPCCaoXHGRlY2xhbnRz aWVuQHJpc2V1cC5uZXQACgkQD8aHA3Xv4vWhGAv/aOc7eFPX2VdNgq4+KycnaunF Vbn/Fk5Ms99ya4s4UDSOk7eBF1rc0ooIfXZI4MplLit4KIJYy+Voe1a41m7U5PZx Slsdhr19OSSkqLGaqsaubeUQJT+JgXT/WWvA7c7bU1xjJxdOrxaugY5l72GxY1Jo f3NL9DxJaEL5AGypB+F2IX5e1bt6PD+z8EhFNaCYi+gVtnf0yvMPZ9t7wbqwKkiS PcwB6/jPa2KREuaECw7WuoSOvqqzoU/+6TM8g6OAD3W4Kc8xQCdWgICE4G9gzhXV LpjrK9Pox9ZJ7SBEJXIPWR3KXQHeTEN5I1Oc25u9BY6PVJjpPLfMjQ0uw7SME5It DSvclituhOgv7TEyq5TiZtPbZIkyaSgkxaPBuk6jfw1zmnDgZ0B3PyTAllB5NWln IpOvYXL/jN2+ao31L6qcpMPth1YkzAVU3rSBZPKoPbU/G/Mj0P1dDte/D4Cgl8vJ bep9nb6lCE44Avy8nwL7nKFoT4S2c7ax6oESbM/C =9frX -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 16 11:34:42 2023 Received: (at control) by debbugs.gnu.org; 16 Jan 2023 16:34:42 +0000 Received: from localhost ([127.0.0.1]:34496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHSRW-000474-CZ for submit@debbugs.gnu.org; Mon, 16 Jan 2023 11:34:42 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:55113) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHSRT-00046l-AA for control@debbugs.gnu.org; Mon, 16 Jan 2023 11:34:40 -0500 Received: (Authenticated sender: andrew@trop.in) by mail.gandi.net (Postfix) with ESMTPSA id C029E6000F for ; Mon, 16 Jan 2023 16:34:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop.in; s=gm1; t=1673886873; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=C0SX2RXR1lHyZsTDEoBzut2TezVplLAfGGM3QdiexnE=; b=glARCapJHxW3KgXGJEA/ldf3f+6e8clXDaFErRPds1omQdjCvGcn7ZftFVTFt0guVT46s4 8CG/5laPJ0aPu4WvIYVJPu9PbD3mtowxY0lw8UkdXfq4X3aPyGRB14gyBC/LGU9lTm5hsq ZvbCK7eFvFFcs9JqONeRKvpsGTyLvoXQc9VKDWucutDGheHcRkL74UOXYjd/ayXTYBY2+C o4pzCCQkw6HyXd1MNwW69451FWSnB4uQe6Y9Dp5ZY/cAnuDk7cw3m/iJkJBMsio+y6cTJA w75Du4FgHovbM3/83uY70qVF+OTPssO+Asc42q3UhZ2wUzgTTMFtQhmnKPv4FQ== From: Andrew Tropin To: control@debbugs.gnu.org Subject: Date: Mon, 16 Jan 2023 20:34:28 +0400 Message-ID: <87o7qyl9pn.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: reopen 60752 merge 60752 60800 Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [217.70.183.195 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [217.70.183.195 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 2.0 BLANK_SUBJECT Subject is present but empty X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) --=-=-= Content-Type: text/plain reopen 60752 merge 60752 60800 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmPFfJQACgkQIgjSCVjB 3rDTEw//cy608zyzDz75vj3usKHX50Uofy1CX8h5vGtI3mcdWMb1fvqQS9IHweP1 MJbzulh7XVXQxMaP6g8EFQLFj5gpoB5vCvniyiMXbATwqWi6Edu8zN/ZunXqsnWe HEQbyKru+iZjyxpAHntYIzI0SaXJHJwoRWSlYV4XIfad9ldUllj9Qtkv2Y57FFtb ZxQfr9wHvoVgTDIeKOgmDz7qtY6oDQWqM0MAJkfeZEQEcWriU/bcpLt8+DG4GH3j cvYEHHVMsTQ79oCyLoh16ZIHpSW6UjwxT2sN9jHLUtOq5x/g+rIj5xLsRNXH6un2 8I0QZWHSWkQydux8jNZnyNRh8BFaUHbzsfPJxc0TsMhz6Yj89MbWZaMms/LJi9TR DIpcgcpHv6pnfxmGlMtk+JNTbI7k2ToyoVTb47DA9Vlp5YWsuqoNCk6UVNzzv3P5 2cJtahs0/ajc8tustVJ/EyQoJ/BoqZl6lHUB+sAT+CuU9srjAEw6waC/2PbX/ev1 OVHN9VKJOWNIdSDlshcxJnPC9g8hsJBel13wiqn3eY2aNK7S52/WpiAl2wdsc5+R QeHbUcSEm8VxdIU/m92w+RtWddeGzFG3uzU/q9aI6SjZDUYPyv8zH+qiKSm3aGnp lowcxvBcenoLr154KrDaSCFa4vLfKbnER4lz7oAdcmXw4SAi6v0= =agd2 -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Aug 16 21:22:05 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 14 Feb 2023 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator