From unknown Fri Aug 15 15:38:25 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#60791 <60791@debbugs.gnu.org> To: bug#60791 <60791@debbugs.gnu.org> Subject: Status: [PATCH] gnu: services: Add joycond-service. Reply-To: bug#60791 <60791@debbugs.gnu.org> Date: Fri, 15 Aug 2025 22:38:25 +0000 retitle 60791 [PATCH] gnu: services: Add joycond-service. reassign 60791 guix-patches submitter 60791 "Thompson, David" severity 60791 normal tag 60791 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 13 17:12:44 2023 Received: (at submit) by debbugs.gnu.org; 13 Jan 2023 22:12:44 +0000 Received: from localhost ([127.0.0.1]:52626 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGSI0-0006OH-1W for submit@debbugs.gnu.org; Fri, 13 Jan 2023 17:12:44 -0500 Received: from lists.gnu.org ([209.51.188.17]:52424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGSHx-0006O8-9o for submit@debbugs.gnu.org; Fri, 13 Jan 2023 17:12:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGSHw-0003H5-RT for guix-patches@gnu.org; Fri, 13 Jan 2023 17:12:41 -0500 Received: from mail-qv1-xf34.google.com ([2607:f8b0:4864:20::f34]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pGSHu-0004zw-U2 for guix-patches@gnu.org; Fri, 13 Jan 2023 17:12:40 -0500 Received: by mail-qv1-xf34.google.com with SMTP id g10so10186111qvo.6 for ; Fri, 13 Jan 2023 14:12:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=worcester-edu.20210112.gappssmtp.com; s=20210112; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=YKgaNeapawVdPEqEWs0aPvZ/vCNHQ5YH6PpF/VlgDkc=; b=CNm+CuGcqTMYDb6RVjlgfqtHHNvt+SZ/mlckw77QWJTTFgYxCxZNO/ECeLx2HGDEH+ tWEELYBKR1YlYTqmA4wgARo6UYi1QcCqklkG8rIYst+QQQQ9S0zHsG1Z2NDp2NmCo6im VbyDIsazh2Bryp8E8wU7A4+MhjDP0aeVuUiZaMFad1TIiSjYuctf1mqyJkeQfnjh4Ba5 irgA6Ox07lD+976GOC1dHasmIyIBZBpV7Ef8wzOkNRIkMMafiV3n8dYvW3kH43VRwV6P 4dNDt857Xdmw2yHL+nvf0t+ZXFpUnJlb0q0i8KwvqnFgyOGqufouow+paDvUhLzL9l0z u2Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=YKgaNeapawVdPEqEWs0aPvZ/vCNHQ5YH6PpF/VlgDkc=; b=jBGn5eeUy6lrExkgjXgH2mzEHTv69JdArGmXThbTqUTLRng3DPUychLhD6IKJrOM1W Ga0ReInnQflXXgW/YRYOZrFXEYdeBOGIVM/lEXqAhHLyBoYTRDhrTO42rgAiRPxrNYSm Y7Kk9JaKwpAv974wDIGP0Zw5bqOJqwlgPsA1y41I+RuIm428mvLagJ4WEz1hqXOG1JIy RayEH3o0NHzaIyiypUlM+XxClAXdGCHF3qJglRqTos3K9sQArdnDLMnxcRPB32nVbLlZ /y/1vg4oXKpqAYyicyD5vTvlDWpJ06H2Rqz/vtaXFui1fN7Fqfts/KrMQbrEznlq/g9W LDTQ== X-Gm-Message-State: AFqh2kpRVI3PUpAQFulWbYIqlVxYAPhL8aJjD3pX65phayHNTIV4EMWg RxT2pg3Ci6QHy/ZPfUW/e+AsUXNIYUQ771/k+nciJ1qXYqOoqg== X-Google-Smtp-Source: AMrXdXsKt/7sNqfXw7x3BMEOa3fjIaBRuY4Yxfn/KOyE+ULCtr3jBgmnAThjnCh0P6br4VCfe3PineELDohP+12ChF0= X-Received: by 2002:a05:6214:4287:b0:4cc:b954:de7b with SMTP id og7-20020a056214428700b004ccb954de7bmr4961352qvb.26.1673647957059; Fri, 13 Jan 2023 14:12:37 -0800 (PST) MIME-Version: 1.0 From: "Thompson, David" Date: Fri, 13 Jan 2023 17:12:26 -0500 Message-ID: Subject: [PATCH] gnu: services: Add joycond-service. To: guix-patches@gnu.org Content-Type: multipart/mixed; boundary="000000000000f6129905f22c87db" Received-SPF: pass client-ip=2607:f8b0:4864:20::f34; envelope-from=dthompson2@worcester.edu; helo=mail-qv1-xf34.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --000000000000f6129905f22c87db Content-Type: text/plain; charset="UTF-8" Hello Guix, Joycond is a handy daemon for pairing bluetooth controllers made by Nintendo. Someone already did the hard work of packaging it, so I added this simple service to make it easy to use as a system service. WDYT? - Dave --000000000000f6129905f22c87db Content-Type: text/x-patch; charset="US-ASCII"; name="0001-gnu-services-Add-joycond-service.patch" Content-Disposition: attachment; filename="0001-gnu-services-Add-joycond-service.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lcv2p72p0 RnJvbSAyNDdjZTljZDMwMmQzZmYxOTZlYWU2NjJkMjdmNWEzN2FjNmNlMzc2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBUaG9tcHNvbiA8ZHRob21wc29uMkB3b3JjZXN0ZXIu ZWR1PgpEYXRlOiBGcmksIDEzIEphbiAyMDIzIDE3OjA0OjIxIC0wNTAwClN1YmplY3Q6IFtQQVRD SF0gZ251OiBzZXJ2aWNlczogQWRkIGpveWNvbmQtc2VydmljZS4KCiogZ251L3NlcnZpY2VzL2dh bWVzLnNjbSAoPGpveWNvbmQtY29uZmlndXJhdGlvbj4pOiBOZXcgcmVjb3JkIHR5cGUuCihqb3lj b25kLWNvbmZpZ3VyYXRpb24sIGpveWNvbmQtY29uZmlndXJhdGlvbj8sIGpveWNvbmQtY29uZmln dXJhdGlvbi1qb3ljb25kLApqb3ljb25kLXNoZXBoZXJkLXNlcnZpY2UpOiBOZXcgcHJvY2VkdXJl cy4KKGpveWNvbmQtc2VydmljZS10eXBlKTogTmV3IHZhcmlhYmxlLgoqIGRvYy9ndWl4LnRleGkg KEdhbWUgU2VydmljZXMpOiBEb2N1bWVudCBpdC4KLS0tCiBkb2MvZ3VpeC50ZXhpICAgICAgICAg IHwgMTkgKysrKysrKysrKysrKysrKysrKwogZ251L3NlcnZpY2VzL2dhbWVzLnNjbSB8IDM3ICsr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0KIDIgZmlsZXMgY2hhbmdlZCwgNTUg aW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2RvYy9ndWl4LnRleGkg Yi9kb2MvZ3VpeC50ZXhpCmluZGV4IDc1MWQwOTU3ZDguLjRhZWM1ODk1ZDIgMTAwNjQ0Ci0tLSBh L2RvYy9ndWl4LnRleGkKKysrIGIvZG9jL2d1aXgudGV4aQpAQCAtMzYyNzcsNiArMzYyNzcsMjUg QEAgbGlrZSB0byBzZXJ2ZS4KIEBub2RlIEdhbWUgU2VydmljZXMKIEBzdWJzZWN0aW9uIEdhbWUg U2VydmljZXMKIAorQHN1YnN1YmhlYWRpbmcgSm95Y29uZCBzZXJ2aWNlCitAY2luZGV4IGpveWNv bmQKK1RoZSBqb3ljb25kIHNlcnZpY2UgYWxsb3dzIHRoZSBwYWlyaW5nIG9mIE5pbnRlbmRvIGpv eWNvbiBnYW1lCitjb250cm9sbGVycyBvdmVyIEJsdWV0b290aC4gKEBweHJlZntEZXNrdG9wIFNl cnZpY2VzfSBmb3Igc2V0dGluZyB1cAorQmx1ZXRvb3RoLikKKworQGRlZnRwIHtEYXRhIFR5cGV9 IGpveWNvbmQtY29uZmlndXJhdGlvbgorRGF0YSB0eXBlIHJlcHJlc2VudGluZyB0aGUgY29uZmln dXJhdGlvbiBvZiBAY29tbWFuZHtqb3ljb25kfS4KKworQHRhYmxlIEBhc2lzCitAaXRlbSBAY29k ZXtqb3ljb25kfSAoZGVmYXVsdDogQGNvZGV7am95Y29uZH0pCitUaGUgam95Y29uZCBwYWNrYWdl IHRvIHVzZS4KK0BlbmQgdGFibGUKK0BlbmQgZGVmdHAKKworQGRlZnZhciB7U2NoZW1lIFZhcmlh YmxlfSBqb3ljb25kLXNlcnZpY2UtdHlwZQorU2VydmljZSB0eXBlIGZvciB0aGUgam95Y29uZCBz ZXJ2aWNlLgorQGVuZCBkZWZ2YXIKKwogQHN1YnN1YmhlYWRpbmcgVGhlIEJhdHRsZSBmb3IgV2Vz bm90aCBTZXJ2aWNlCiBAY2luZGV4IHdlc25vdGhkCiBAdXJlZntodHRwczovL3dlc25vdGgub3Jn LCBUaGUgQmF0dGxlIGZvciBXZXNub3RofSBpcyBhIGZhbnRhc3ksIHR1cm4KZGlmZiAtLWdpdCBh L2dudS9zZXJ2aWNlcy9nYW1lcy5zY20gYi9nbnUvc2VydmljZXMvZ2FtZXMuc2NtCmluZGV4IDZj MmFmNDRiNDkuLmFkY2NkZGZiOTkgMTAwNjQ0Ci0tLSBhL2dudS9zZXJ2aWNlcy9nYW1lcy5zY20K KysrIGIvZ251L3NlcnZpY2VzL2dhbWVzLnNjbQpAQCAtMzAsMTAgKzMwLDQ1IEBAIChkZWZpbmUt bW9kdWxlIChnbnUgc2VydmljZXMgZ2FtZXMpCiAgICM6dXNlLW1vZHVsZSAoZ3VpeCBtb2R1bGVz KQogICAjOnVzZS1tb2R1bGUgKGd1aXggcmVjb3JkcykKICAgIzp1c2UtbW9kdWxlIChpY2UtOSBt YXRjaCkKLSAgIzpleHBvcnQgKHdlc25vdGhkLWNvbmZpZ3VyYXRpb24KKyAgIzpleHBvcnQgKGpv eWNvbmQtY29uZmlndXJhdGlvbgorICAgICAgICAgICAgam95Y29uZC1jb25maWd1cmF0aW9uPwor ICAgICAgICAgICAgam95Y29uZC1jb25maWd1cmF0aW9uLWpveWNvbmQKKyAgICAgICAgICAgIGpv eWNvbmQtc2VydmljZS10eXBlCisKKyAgICAgICAgICAgIHdlc25vdGhkLWNvbmZpZ3VyYXRpb24K ICAgICAgICAgICAgIHdlc25vdGhkLWNvbmZpZ3VyYXRpb24/CiAgICAgICAgICAgICB3ZXNub3Ro ZC1zZXJ2aWNlLXR5cGUpKQogCis7OzsKKzs7OyBKb3ljb25kCis7OzsKKworKGRlZmluZS1yZWNv cmQtdHlwZSogPGpveWNvbmQtY29uZmlndXJhdGlvbj4KKyAgam95Y29uZC1jb25maWd1cmF0aW9u IG1ha2Utam95Y29uZC1jb25maWd1cmF0aW9uCisgIGpveWNvbmQtY29uZmlndXJhdGlvbj8KKyAg KGpveWNvbmQgam95Y29uZC1jb25maWd1cmF0aW9uLWpveWNvbmQgKGRlZmF1bHQgam95Y29uZCkp KQorCisoZGVmaW5lIChqb3ljb25kLXNoZXBoZXJkLXNlcnZpY2UgY29uZmlnKQorICAobGV0ICgo am95Y29uZCAoam95Y29uZC1jb25maWd1cmF0aW9uLWpveWNvbmQgY29uZmlnKSkpCisgICAgKGxp c3QgKHNoZXBoZXJkLXNlcnZpY2UKKyAgICAgICAgICAgKGRvY3VtZW50YXRpb24gIlJ1biBqb3lj b25kLiIpCisgICAgICAgICAgIChwcm92aXNpb24gJyhqb3ljb25kKSkKKyAgICAgICAgICAgKHJl cXVpcmVtZW50ICcoYmx1ZXRvb3RoKSkKKyAgICAgICAgICAgKHN0YXJ0ICN+KG1ha2UtZm9ya2V4 ZWMtY29uc3RydWN0b3IKKyAgICAgICAgICAgICAgICAgICAgIChsaXN0ICMkKGZpbGUtYXBwZW5k IGpveWNvbmQgIi9iaW4vam95Y29uZCIpKSkpCisgICAgICAgICAgIChzdG9wICN+KG1ha2Uta2ls bC1kZXN0cnVjdG9yKSkpKSkpCisKKyhkZWZpbmUgam95Y29uZC1zZXJ2aWNlLXR5cGUKKyAgKHNl cnZpY2UtdHlwZQorICAgKG5hbWUgJ2pveWNvbmQpCisgICAoZGVzY3JpcHRpb24KKyAgICAiUnVu IEBjb21tYW5ke2pveWNvbmR9IGZvciBwYWlyaW5nIE5pbnRlbmRvIGpveWNvbnMgdmlhIEJsdWV0 b290aC4iKQorICAgKGV4dGVuc2lvbnMKKyAgICAobGlzdCAoc2VydmljZS1leHRlbnNpb24gc2hl cGhlcmQtcm9vdC1zZXJ2aWNlLXR5cGUKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgam95 Y29uZC1zaGVwaGVyZC1zZXJ2aWNlKSkpCisgICAoZGVmYXVsdC12YWx1ZSAoam95Y29uZC1jb25m aWd1cmF0aW9uKSkpKQorCisMCiA7OzsKIDs7OyBUaGUgQmF0dGxlIGZvciBXZXNub3RoIHNlcnZl cgogOzs7Ci0tIAoyLjM4LjEKCg== --000000000000f6129905f22c87db-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 13 17:46:27 2023 Received: (at 60791) by debbugs.gnu.org; 13 Jan 2023 22:46:27 +0000 Received: from localhost ([127.0.0.1]:52665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGSod-0007Fj-7s for submit@debbugs.gnu.org; Fri, 13 Jan 2023 17:46:27 -0500 Received: from smtpmciv5.myservices.hosting ([185.26.107.241]:41722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGSoa-0007FV-Un for 60791@debbugs.gnu.org; Fri, 13 Jan 2023 17:46:25 -0500 Received: from mail1.netim.hosting (unknown [185.26.106.172]) by smtpmciv5.myservices.hosting (Postfix) with ESMTP id BA6C120991; Fri, 13 Jan 2023 23:46:21 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id 7896080096; Fri, 13 Jan 2023 23:46:21 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-1.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id BCFjwBGgFS0x; Fri, 13 Jan 2023 23:46:21 +0100 (CET) Received: from [192.168.1.239] (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id EB91F80093; Fri, 13 Jan 2023 23:46:20 +0100 (CET) Message-ID: <5eaac013-2a20-c322-24a9-ab389ec974c5@makinata.eu> Date: Fri, 13 Jan 2023 22:46:19 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 To: 60791@debbugs.gnu.org Subject: [PATCH] gnu: services: Add joycond-service. Content-Language: en-US From: Bruno Victal Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60791 Cc: dthompson2@worcester.edu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, --8<---------------cut here---------------start------------->8--- +@defvar {Scheme Variable} joycond-service-type +Service type for the joycond service. +@end defvar --8<---------------cut here---------------end--------------->8--- Should be `@defvar joycond-service-type'. --8<---------------cut here---------------start------------->8--- +(define-record-type* + joycond-configuration make-joycond-configuration + joycond-configuration? + (joycond joycond-configuration-joycond (default joycond))) --8<---------------cut here---------------end--------------->8--- This could be replaced with define-configuration/no-serialization since the only field here is a package / file-like object. (see [1], [2] for examples) I'd prefer the field be called 'package' here. --8<---------------cut here---------------start------------->8--- +(define (joycond-shepherd-service config) + (let ((joycond (joycond-configuration-joycond config))) + (list (shepherd-service + (documentation "Run joycond.") + (provision '(joycond)) + (requirement '(bluetooth)) + (start #~(make-forkexec-constructor + (list #$(file-append joycond "/bin/joycond")))) + (stop #~(make-kill-destructor)))))) --8<---------------cut here---------------end--------------->8--- You might prefer match-record here but this is okay as well. [1]: https://issues.guix.gnu.org/60788 [2]: ddclient-configuration in gnu/services/dns.scm Cheers, Bruno From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 13 18:50:49 2023 Received: (at 60791) by debbugs.gnu.org; 13 Jan 2023 23:50:49 +0000 Received: from localhost ([127.0.0.1]:52746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGTou-0000W5-Op for submit@debbugs.gnu.org; Fri, 13 Jan 2023 18:50:49 -0500 Received: from mail-qk1-f180.google.com ([209.85.222.180]:41641) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGTos-0000Vk-4R for 60791@debbugs.gnu.org; Fri, 13 Jan 2023 18:50:46 -0500 Received: by mail-qk1-f180.google.com with SMTP id h8so11617917qkk.8 for <60791@debbugs.gnu.org>; Fri, 13 Jan 2023 15:50:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=worcester-edu.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=6quylZXyD80zfkRpdEfxUSw3iSQH/9Cw8cm0lsiVM6w=; b=Xuhzrd0dRd2MSu2zvcC72x5XsqHMRg0IVIH7fTOkmA0W2SaNDLna/oKuI+/q0G5IBQ KIGxQKueECkXZ1fC0bIab7/rQJqy9bFJBCid3qwRjb9s/jTq4TIl32O0wUMwwvG7Xk+Z bCrAEvRhcmDSzQMmR7UzC1fpXjRnm4SHxE3maDDjr1BvTNzVQWcx8cAQfBI587Ni8/V4 rBYQMdKRtwufcCMkfinWpUHKRQ924AAEQUlERMFgpu00F3i3xpQf3xlICmUY01Lmkswr //YR+jb857R+2B3Gs/50jnRhqbLuytUl+7LPFwY2ZfelpIBS3t7SsyG5cIqxyDtmZ+GX GfaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6quylZXyD80zfkRpdEfxUSw3iSQH/9Cw8cm0lsiVM6w=; b=J/wlIg/rkHrArxfLWM8uYvYbjCHM4+8elJgQEAL3uteausQ9Iiz6ifpFVph5wDSdoW q1ZLRs/jMkOl6mNKsBTCWUeoZuOuBqgNOvOkQ8Bxgm6sI3JLElLs8JXSlDw2HOFHDGyV JG1WbfMLi6wmnvchTAl3o/O1sZ3B5CFrzGkP+aCebcVYWVJdshE51SO9FGt/P4b7130l Y9VF9GXMo99NXpD2KfCrStR+zNy9J9OvADDhX7nFmLHjO7yIkvEfWPq5JKzy96Ctivhm QevnqgWTD6E38m9V4fc/Wfy9SzSXgPq7KeoFYpbnpo2QB111pbmKs8NGqnqF4DY2bVW1 rw+A== X-Gm-Message-State: AFqh2kpvsWBtIit0/Xh8k27ZEQJlTkxByTgLSsbuhXC3KLzDU7i56ssj VhxttWN1jx5w/FgKkohNDS9US2W8sm8AzRVOJBdF0A== X-Google-Smtp-Source: AMrXdXtOtXTa0cLUi57+UwWyT44LBCL/fr8OwmKvzDpa/ECtK1yhBZ+iGmyGjQEFQlimQbRzDp1QhNwbhm6yPfNWKSY= X-Received: by 2002:a05:620a:21c2:b0:6fe:d745:5ee8 with SMTP id h2-20020a05620a21c200b006fed7455ee8mr5509480qka.387.1673653840410; Fri, 13 Jan 2023 15:50:40 -0800 (PST) MIME-Version: 1.0 References: <5eaac013-2a20-c322-24a9-ab389ec974c5@makinata.eu> In-Reply-To: <5eaac013-2a20-c322-24a9-ab389ec974c5@makinata.eu> From: "Thompson, David" Date: Fri, 13 Jan 2023 18:50:28 -0500 Message-ID: Subject: Re: [PATCH] gnu: services: Add joycond-service. To: mirai@makinata.eu Content-Type: multipart/mixed; boundary="000000000000a31e7c05f22de62b" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60791 Cc: 60791@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000a31e7c05f22de62b Content-Type: text/plain; charset="UTF-8" Hi Bruno, Thanks for the review! On Fri, Jan 13, 2023 at 5:46 PM Bruno Victal wrote: > > Hi, > > --8<---------------cut here---------------start------------->8--- > +@defvar {Scheme Variable} joycond-service-type > +Service type for the joycond service. > +@end defvar > --8<---------------cut here---------------end--------------->8--- > > Should be `@defvar joycond-service-type'. Oh, okay. Guess I missed that change in convention. There's lots of '@defvar {Scheme Variable}' in the manual. > --8<---------------cut here---------------start------------->8--- > +(define-record-type* > + joycond-configuration make-joycond-configuration > + joycond-configuration? > + (joycond joycond-configuration-joycond (default joycond))) > --8<---------------cut here---------------end--------------->8--- > > This could be replaced with define-configuration/no-serialization since > the only field here is a package / file-like object. (see [1], [2] for examples) > I'd prefer the field be called 'package' here. Ahhhh unhygienic macros! Not a fan but I see that this macro is the preferred thing these days so okay, changed! I also prefer the field to be called 'package' so I've changed it! When I looked around at some other services they used the package name as the field name so I followed their lead. > --8<---------------cut here---------------start------------->8--- > +(define (joycond-shepherd-service config) > + (let ((joycond (joycond-configuration-joycond config))) > + (list (shepherd-service > + (documentation "Run joycond.") > + (provision '(joycond)) > + (requirement '(bluetooth)) > + (start #~(make-forkexec-constructor > + (list #$(file-append joycond "/bin/joycond")))) > + (stop #~(make-kill-destructor)))))) > --8<---------------cut here---------------end--------------->8--- > > You might prefer match-record here but this is okay as well. If I was destructuring many record fields I'd use it. Updated patch attached. Thanks! - Dave --000000000000a31e7c05f22de62b Content-Type: application/x-patch; name="0001-gnu-services-Add-joycond-service.patch" Content-Disposition: attachment; filename="0001-gnu-services-Add-joycond-service.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lcv66odt0 RnJvbSBlOTg3YjU1YmQyYWFmZWQ1MjM3OWEwZDE3ZTMzZGU4OGI1MWY0YWQzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBUaG9tcHNvbiA8ZHRob21wc29uMkB3b3JjZXN0ZXIu ZWR1PgpEYXRlOiBGcmksIDEzIEphbiAyMDIzIDE3OjA0OjIxIC0wNTAwClN1YmplY3Q6IFtQQVRD SF0gZ251OiBzZXJ2aWNlczogQWRkIGpveWNvbmQtc2VydmljZS4KCiogZ251L3NlcnZpY2VzL2dh bWVzLnNjbSAoPGpveWNvbmQtY29uZmlndXJhdGlvbj4pOiBOZXcgcmVjb3JkIHR5cGUuCihqb3lj b25kLWNvbmZpZ3VyYXRpb24sIGpveWNvbmQtY29uZmlndXJhdGlvbj8sIGpveWNvbmQtY29uZmln dXJhdGlvbi1qb3ljb25kLApqb3ljb25kLXNoZXBoZXJkLXNlcnZpY2UpOiBOZXcgcHJvY2VkdXJl cy4KKGpveWNvbmQtc2VydmljZS10eXBlKTogTmV3IHZhcmlhYmxlLgoqIGRvYy9ndWl4LnRleGkg KEdhbWUgU2VydmljZXMpOiBEb2N1bWVudCBpdC4KLS0tCiBkb2MvZ3VpeC50ZXhpICAgICAgICAg IHwgMTkgKysrKysrKysrKysrKysrKysrKwogZ251L3NlcnZpY2VzL2dhbWVzLnNjbSB8IDM3ICsr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0KIDIgZmlsZXMgY2hhbmdlZCwgNTUg aW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2RvYy9ndWl4LnRleGkg Yi9kb2MvZ3VpeC50ZXhpCmluZGV4IDc1MWQwOTU3ZDguLmZmZTg3ZjJlNzUgMTAwNjQ0Ci0tLSBh L2RvYy9ndWl4LnRleGkKKysrIGIvZG9jL2d1aXgudGV4aQpAQCAtMzYyNzcsNiArMzYyNzcsMjUg QEAgbGlrZSB0byBzZXJ2ZS4KIEBub2RlIEdhbWUgU2VydmljZXMKIEBzdWJzZWN0aW9uIEdhbWUg U2VydmljZXMKIAorQHN1YnN1YmhlYWRpbmcgSm95Y29uZCBzZXJ2aWNlCitAY2luZGV4IGpveWNv bmQKK1RoZSBqb3ljb25kIHNlcnZpY2UgYWxsb3dzIHRoZSBwYWlyaW5nIG9mIE5pbnRlbmRvIGpv eWNvbiBnYW1lCitjb250cm9sbGVycyBvdmVyIEJsdWV0b290aC4gKEBweHJlZntEZXNrdG9wIFNl cnZpY2VzfSBmb3Igc2V0dGluZyB1cAorQmx1ZXRvb3RoLikKKworQGRlZnRwIHtEYXRhIFR5cGV9 IGpveWNvbmQtY29uZmlndXJhdGlvbgorRGF0YSB0eXBlIHJlcHJlc2VudGluZyB0aGUgY29uZmln dXJhdGlvbiBvZiBAY29tbWFuZHtqb3ljb25kfS4KKworQHRhYmxlIEBhc2lzCitAaXRlbSBAY29k ZXtqb3ljb25kfSAoZGVmYXVsdDogQGNvZGV7am95Y29uZH0pCitUaGUgam95Y29uZCBwYWNrYWdl IHRvIHVzZS4KK0BlbmQgdGFibGUKK0BlbmQgZGVmdHAKKworQGRlZnZhciBqb3ljb25kLXNlcnZp Y2UtdHlwZQorU2VydmljZSB0eXBlIGZvciB0aGUgam95Y29uZCBzZXJ2aWNlLgorQGVuZCBkZWZ2 YXIKKwogQHN1YnN1YmhlYWRpbmcgVGhlIEJhdHRsZSBmb3IgV2Vzbm90aCBTZXJ2aWNlCiBAY2lu ZGV4IHdlc25vdGhkCiBAdXJlZntodHRwczovL3dlc25vdGgub3JnLCBUaGUgQmF0dGxlIGZvciBX ZXNub3RofSBpcyBhIGZhbnRhc3ksIHR1cm4KZGlmZiAtLWdpdCBhL2dudS9zZXJ2aWNlcy9nYW1l cy5zY20gYi9nbnUvc2VydmljZXMvZ2FtZXMuc2NtCmluZGV4IDZjMmFmNDRiNDkuLmU5MjViMjFj YjQgMTAwNjQ0Ci0tLSBhL2dudS9zZXJ2aWNlcy9nYW1lcy5zY20KKysrIGIvZ251L3NlcnZpY2Vz L2dhbWVzLnNjbQpAQCAtMTksNiArMTksNyBAQAogCiAoZGVmaW5lLW1vZHVsZSAoZ251IHNlcnZp Y2VzIGdhbWVzKQogICAjOnVzZS1tb2R1bGUgKGdudSBzZXJ2aWNlcykKKyAgIzp1c2UtbW9kdWxl IChnbnUgc2VydmljZXMgY29uZmlndXJhdGlvbikKICAgIzp1c2UtbW9kdWxlIChnbnUgc2Vydmlj ZXMgc2hlcGhlcmQpCiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIGFkbWluKQogICAjOnVz ZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBnYW1lcykKQEAgLTI4LDEyICsyOSw0NiBAQCAoZGVmaW5l LW1vZHVsZSAoZ251IHNlcnZpY2VzIGdhbWVzKQogICAjOmF1dG9sb2FkICAgKGd1aXggbGVhc3Qt YXV0aG9yaXR5KSAobGVhc3QtYXV0aG9yaXR5LXdyYXBwZXIpCiAgICM6dXNlLW1vZHVsZSAoZ3Vp eCBnZXhwKQogICAjOnVzZS1tb2R1bGUgKGd1aXggbW9kdWxlcykKKyAgIzp1c2UtbW9kdWxlIChn dWl4IHBhY2thZ2VzKQogICAjOnVzZS1tb2R1bGUgKGd1aXggcmVjb3JkcykKICAgIzp1c2UtbW9k dWxlIChpY2UtOSBtYXRjaCkKLSAgIzpleHBvcnQgKHdlc25vdGhkLWNvbmZpZ3VyYXRpb24KKyAg IzpleHBvcnQgKGpveWNvbmQtY29uZmlndXJhdGlvbgorICAgICAgICAgICAgam95Y29uZC1jb25m aWd1cmF0aW9uPworICAgICAgICAgICAgam95Y29uZC1jb25maWd1cmF0aW9uLWpveWNvbmQKKyAg ICAgICAgICAgIGpveWNvbmQtc2VydmljZS10eXBlCisKKyAgICAgICAgICAgIHdlc25vdGhkLWNv bmZpZ3VyYXRpb24KICAgICAgICAgICAgIHdlc25vdGhkLWNvbmZpZ3VyYXRpb24/CiAgICAgICAg ICAgICB3ZXNub3RoZC1zZXJ2aWNlLXR5cGUpKQogCis7OzsKKzs7OyBKb3ljb25kCis7OzsKKwor KGRlZmluZS1jb25maWd1cmF0aW9uL25vLXNlcmlhbGl6YXRpb24gam95Y29uZC1jb25maWd1cmF0 aW9uCisgIChwYWNrYWdlIChwYWNrYWdlIGpveWNvbmQpICJUaGUgam95Y29uZCBwYWNrYWdlIHRv IHVzZSIpKQorCisoZGVmaW5lIChqb3ljb25kLXNoZXBoZXJkLXNlcnZpY2UgY29uZmlnKQorICAo bGV0ICgoam95Y29uZCAoam95Y29uZC1jb25maWd1cmF0aW9uLXBhY2thZ2UgY29uZmlnKSkpCisg ICAgKGxpc3QgKHNoZXBoZXJkLXNlcnZpY2UKKyAgICAgICAgICAgKGRvY3VtZW50YXRpb24gIlJ1 biBqb3ljb25kLiIpCisgICAgICAgICAgIChwcm92aXNpb24gJyhqb3ljb25kKSkKKyAgICAgICAg ICAgKHJlcXVpcmVtZW50ICcoYmx1ZXRvb3RoKSkKKyAgICAgICAgICAgKHN0YXJ0ICN+KG1ha2Ut Zm9ya2V4ZWMtY29uc3RydWN0b3IKKyAgICAgICAgICAgICAgICAgICAgIChsaXN0ICMkKGZpbGUt YXBwZW5kIGpveWNvbmQgIi9iaW4vam95Y29uZCIpKSkpCisgICAgICAgICAgIChzdG9wICN+KG1h a2Uta2lsbC1kZXN0cnVjdG9yKSkpKSkpCisKKyhkZWZpbmUgam95Y29uZC1zZXJ2aWNlLXR5cGUK KyAgKHNlcnZpY2UtdHlwZQorICAgKG5hbWUgJ2pveWNvbmQpCisgICAoZGVzY3JpcHRpb24KKyAg ICAiUnVuIEBjb21tYW5ke2pveWNvbmR9IGZvciBwYWlyaW5nIE5pbnRlbmRvIGpveWNvbnMgdmlh IEJsdWV0b290aC4iKQorICAgKGV4dGVuc2lvbnMKKyAgICAobGlzdCAoc2VydmljZS1leHRlbnNp b24gc2hlcGhlcmQtcm9vdC1zZXJ2aWNlLXR5cGUKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgam95Y29uZC1zaGVwaGVyZC1zZXJ2aWNlKSkpCisgICAoZGVmYXVsdC12YWx1ZSAoam95Y29u ZC1jb25maWd1cmF0aW9uKSkpKQorCisMCiA7OzsKIDs7OyBUaGUgQmF0dGxlIGZvciBXZXNub3Ro IHNlcnZlcgogOzs7Ci0tIAoyLjM4LjEKCg== --000000000000a31e7c05f22de62b-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 13 23:47:28 2023 Received: (at 60791) by debbugs.gnu.org; 14 Jan 2023 04:47:29 +0000 Received: from localhost ([127.0.0.1]:52985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGYS0-000191-Oo for submit@debbugs.gnu.org; Fri, 13 Jan 2023 23:47:28 -0500 Received: from smtpm3.myservices.hosting ([185.26.105.234]:40666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGYRz-00018t-BV for 60791@debbugs.gnu.org; Fri, 13 Jan 2023 23:47:27 -0500 Received: from mail1.netim.hosting (unknown [185.26.106.172]) by smtpm3.myservices.hosting (Postfix) with ESMTP id 4F24F20334; Sat, 14 Jan 2023 05:47:22 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id DF10080096; Sat, 14 Jan 2023 05:47:22 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-1.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 3D-ULotxUdLb; Sat, 14 Jan 2023 05:47:22 +0100 (CET) Received: from [192.168.1.239] (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id 850B280093; Sat, 14 Jan 2023 05:47:22 +0100 (CET) Message-ID: Date: Sat, 14 Jan 2023 04:47:13 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] gnu: services: Add joycond-service. Content-Language: en-US To: "Thompson, David" References: <5eaac013-2a20-c322-24a9-ab389ec974c5@makinata.eu> From: Bruno Victal In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: 60791 Cc: 60791@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --8<---------------cut here---------------start------------->8--- joycond-configuration-joycond --8<---------------cut here---------------end--------------->8--- Doesn't need to be exported, commit message could be amended as well. --8<---------------cut here---------------start------------->8--- +@table @asis +@item @code{joycond} (default: @code{joycond}) +The joycond package to use. +@end table +@end deftp --8<---------------cut here---------------end--------------->8--- @code should be updated to the new `package' field name. Overall LTGM. Cheers, Bruno From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 14 08:00:35 2023 Received: (at 60791-done) by debbugs.gnu.org; 14 Jan 2023 13:00:35 +0000 Received: from localhost ([127.0.0.1]:53615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGg9D-00059S-H3 for submit@debbugs.gnu.org; Sat, 14 Jan 2023 08:00:35 -0500 Received: from mail-qk1-f173.google.com ([209.85.222.173]:40693) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGg9A-00059E-FG for 60791-done@debbugs.gnu.org; Sat, 14 Jan 2023 08:00:33 -0500 Received: by mail-qk1-f173.google.com with SMTP id k2so12109963qkk.7 for <60791-done@debbugs.gnu.org>; Sat, 14 Jan 2023 05:00:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=worcester-edu.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=N/WoTP0zQLq3RwTVlcpiQvScWm+A5gQ1VUDozyCWG+g=; b=uXNX94ZDD4LYRsZ2jBnng3nyPdkRbjqkFDFXVCvigCF0CeCeIobX48MwZkqmY4gCFM jQm+hrWXLydMkqKuBVL+73Q2jGzR24IMb/8O6T9GYlQlbMvKT3Y6fI+xRHyxQENFT6h2 LtuR2/tPafd52XciCKfqR7/zo2oCHTiuc0qRWWh8lZJo8+pEd+Am8bcp11dNZ5zyZ/pn mDw1ffvjX4PZibQOMJi9zKxF/WXsRZaxZmx5cL75H0yztoWvOutW5jd+3ErWqCclcDz8 1W7pCcfSmJS21e1lOTBn4tLnaS/6uBuHSH3KXrJEVE3WXybpx6WVTfe1mRfkjScq15mv +NrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=N/WoTP0zQLq3RwTVlcpiQvScWm+A5gQ1VUDozyCWG+g=; b=f397nTcE1d/McBlCP15zVYjsH9yk3TPF7AhW1eJFljeunpixCNC13O8Col2qdR/rvr 3OYXCve2DcJEcqWPDpei02OuB+Ion8QmX3FJBEBOtUTFTlmqTSxh6wWp/tryLAcLE5+6 JGHPiE41zEAQxBmPxl9g/gdI9s1HZsSiMIejmAatdjxm45jZ8bMtOccx6if/OTp4qnih QFgfSTfo9ivkcO77Ba64Cyi6Rio00yEIcgdnZNChcbH2EnxqhT6g4YICqXsPBgBuvpFP qdpKZyMMhauH//n18WVg001dzk24Zm2asmPRFQjEGYnl111MB5qiG+Y37HiOIkUsQwCt qx/g== X-Gm-Message-State: AFqh2kr3apaOUhANukECfCkKZpyvgFS41YkANLry1waypIVItUIdYJRm aYJruM7qDq4MLJa79ZUyBom4XhVxox2RYxfe9LVknw== X-Google-Smtp-Source: AMrXdXthJNjuAZ7VhamfDpyokVvRiuKrdikNAGVoSFGh9CQWf/KCIMt6T2QK2ZqOffo6JR0nkO6oYIvLKW502e4Z3FA= X-Received: by 2002:a05:620a:21c2:b0:6fe:d745:5ee8 with SMTP id h2-20020a05620a21c200b006fed7455ee8mr5600886qka.387.1673701226855; Sat, 14 Jan 2023 05:00:26 -0800 (PST) MIME-Version: 1.0 References: <5eaac013-2a20-c322-24a9-ab389ec974c5@makinata.eu> In-Reply-To: From: "Thompson, David" Date: Sat, 14 Jan 2023 08:00:15 -0500 Message-ID: Subject: Re: [PATCH] gnu: services: Add joycond-service. To: Bruno Victal Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60791-done Cc: 60791-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, Jan 13, 2023 at 11:47 PM Bruno Victal wrote: > > --8<---------------cut here---------------start------------->8--- > joycond-configuration-joycond > --8<---------------cut here---------------end--------------->8--- > > Doesn't need to be exported, commit message could be amended as well. > > > --8<---------------cut here---------------start------------->8--- > +@table @asis > +@item @code{joycond} (default: @code{joycond}) > +The joycond package to use. > +@end table > +@end deftp > --8<---------------cut here---------------end--------------->8--- > > @code should be updated to the new `package' field name. > > > Overall LTGM. Thanks for catching my silly late-evening fixup oversights. Fixed all of that and pushed! - Dave From unknown Fri Aug 15 15:38:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 12 Feb 2023 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator