GNU bug report logs - #60788
[PATCH] services: Add vnstat-service-type.

Previous Next

Package: guix-patches;

Reported by: Bruno Victal <mirai <at> makinata.eu>

Date: Fri, 13 Jan 2023 20:09:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

Message #44 received at 60788 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Bruno Victal <mirai <at> makinata.eu>
Cc: 60788 <at> debbugs.gnu.org
Subject: Re: [PATCH v5] services: Add vnstat-service-type.
Date: Fri, 10 Feb 2023 09:07:40 -0500

Hi!

Bruno Victal <mirai <at> makinata.eu> writes:

[...]

> +            vnstat-configuration
> +            vnstat-configuration?
> +            vnstat-service-type
> +            vnstat-configuration-package
> +            vnstat-configuration-database-dir
> +            vnstat-configuration-5-minute-hours
> +            vnstat-configuration-64bit-interface-counters
> +            vnstat-configuration-always-add-new-interfaces?
> +            vnstat-configuration-bandwidth-detection?
> +            vnstat-configuration-bandwidth-detection-interval
> +            vnstat-configuration-boot-variation
> +            vnstat-configuration-check-disk-space?
> +            vnstat-configuration-create-dirs?
> +            vnstat-configuration-daemon-group
> +            vnstat-configuration-daemon-user
> +            vnstat-configuration-daily-days
> +            vnstat-configuration-database-synchronous
> +            vnstat-configuration-database-write-ahead-logging?
> +            vnstat-configuration-hourly-days
> +            vnstat-configuration-log-file
> +            vnstat-configuration-max-bandwidth
> +            vnstat-configuration-max-BW

^ Looks like you forgot to adjust to use the now all lowercase symbol
here.

> +            vnstat-configuration-monthly-months
> +            vnstat-configuration-month-rotate
> +            vnstat-configuration-month-rotate-affects-years?
> +            vnstat-configuration-offline-save-interval
> +            vnstat-configuration-pid-file
> +            vnstat-configuration-poll-interval
> +            vnstat-configuration-rescan-database-on-save?
> +            vnstat-configuration-save-interval
> +            vnstat-configuration-save-on-status-change?
> +            vnstat-configuration-time-sync-wait
> +            vnstat-configuration-top-day-entries
> +            vnstat-configuration-trafficless-entries?
> +            vnstat-configuration-update-file-owner?
> +            vnstat-configuration-update-interval
> +            vnstat-configuration-use-logging
> +            vnstat-configuration-use-UTC?

Ditto.

The rest LGTM.

-- 
Thanks,
Maxim
This bug report was last modified 2 years and 72 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.