GNU bug report logs - #60788
[PATCH] services: Add vnstat-service-type.

Previous Next

Package: guix-patches;

Reported by: Bruno Victal <mirai <at> makinata.eu>

Date: Fri, 13 Jan 2023 20:09:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Bruno Victal <mirai <at> makinata.eu>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 60788 <at> debbugs.gnu.org
Subject: [bug#60788] [PATCH] services: Add vnstat-service-type.
Date: Thu, 9 Feb 2023 04:19:40 +0000

Hi Maxim,

On 2023-02-09 03:34, Maxim Cournoyer wrote:
> Two remaining comments from me:
> 
> 1. I'd normalize all the configuration field names to lowercase, so
> max-BW and use-UTC? would become max-bw and use-utc?, for example.

No, this is intentional so that uglify+case-conversion yields correct configuration directives.

> 2. I'd add a simple example vnstat usage example to the manual.

The service is "ready to be used" with the default values, so I didn't think
it'd add much value adding an example here. Do you think we should add one?


Cheers,
Bruno
This bug report was last modified 2 years and 72 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.