From unknown Fri Jun 20 07:14:44 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#60769 <60769@debbugs.gnu.org> To: bug#60769 <60769@debbugs.gnu.org> Subject: Status: CC Mode 5.35.2 (C/*l); More incorrect type recognition Reply-To: bug#60769 <60769@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:14:44 +0000 retitle 60769 CC Mode 5.35.2 (C/*l); More incorrect type recognition reassign 60769 cc-mode submitter 60769 Po Lu severity 60769 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 12 22:02:07 2023 Received: (at submit) by debbugs.gnu.org; 13 Jan 2023 03:02:07 +0000 Received: from localhost ([127.0.0.1]:49036 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGAKU-0008O8-NA for submit@debbugs.gnu.org; Thu, 12 Jan 2023 22:02:07 -0500 Received: from lists.gnu.org ([209.51.188.17]:36676) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGAKT-0008O0-2S for submit@debbugs.gnu.org; Thu, 12 Jan 2023 22:02:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGAKS-0000he-MS for bug-gnu-emacs@gnu.org; Thu, 12 Jan 2023 22:02:04 -0500 Received: from sonic303-20.consmr.mail.ne1.yahoo.com ([66.163.188.146]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pGAKQ-0005vR-Gj for bug-gnu-emacs@gnu.org; Thu, 12 Jan 2023 22:02:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673578916; bh=rQ41nPgw3l8jjaN6Oa3Zl//nN+TF2kibqbuDs26rFoY=; h=From:To:Subject:Date:References:From:Subject:Reply-To; b=Edmoezi7lpySGRwrhoI+REVrrZ6Q+lrDXshTSS6tzjKSGA0dMHJDyNftIyvgZ5mLMAfbIbqzWZhf6OhiDin4f6mqzvG1KRckOYuIEjK18fKNPlSM9rNrCX8GrUJClSDyIMldJbXsDCRvsYeePneXzcrcwubF0JXvetNcDGI2lXE7ezWbdMcUyT14pl4yycSVvhtDtr92/feKzaGdG5JG4hHcuV/zPYfPVmdfRIO77dnYYmT+2yWOI/2eeUgOMAS8yA0HJdDYhMKQY5bH5rTwOO88ByMJON6TYcidBuldNPpdf5JFQiy7NfLC1S6c0eOtMyl680uCs7hzbvw2gW+sNA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673578916; bh=CLrTvHoK5kpxSmYj+S8PZ+oxXWcNoxR5Q/NT1bZFwYw=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=YwdXE0y+B4hBBBm0LC4S/0dAw6HVcnPjhjaY9tUeQmcRVW48edsKTeJZplhCMFAVYZagqF0E1OMXk6PRkcPv80OfStA6HfjZppbiX5bcI7NQiwIKsUesie8yRLK+n95z874PG1NUEAgEq0GR/RM+TZOeU3hTtOsZOWTAOu9tETTS1pEXX/tBBUcOazr3aeVLi6LiJnHucXnYrwI6nskBSxXYu+cRRkxiU6X1woBtFdwpHSYMVZNlCJJgWguSp+u8WY7aId7/KeGAjOVStSQaKTezWvOhe7qqn7yQJlKh631CqPWVAsoCfInqkSSD0WL685NrXhbqQk/NTNEhXRQQHw== X-YMail-OSG: qkyLdvkVM1nBHf6.qJbgTgk22tXIcV3VX7FpT6Xp8EnROrvfdDt2KeG3WJzUzHa c6zX2uTWFRfX0F6uIJanqwJRvB5IyRbz8_phRjHBcE.3b7k1AeKH1lTpbE1OO68T_unmSPiVToI4 lc0ji8yO1zC2ZfBXpK0SJrZbp765j1ALa_gbtzfMvX9IIZn_6cyn6bp85plF2PYnavIZm08p2Z13 wCFKzwHSUhpEc5.WMeHXmPmYg8NDu1hBgoNu7pFUUtNNwGsYb49DWfsMGG1jGpwNTPA_hfaIrVml P8p5r0gP6Ay6gFv67z7uBZAFXAFVD81wlbJKePuzoLNdRGXwpmds0tVwxOElAQ8e4F8KewWDMd.L PznclFDOoXnUqlJsQ8fB0eHjC8bLUWWsIQL2Ppbq.gFToDvNjbnngBkwvtKsJH7SmAlPbkWrPebO 8XX0Piab6IXhd5b74oBBVZXH1WVWSMhzN5yuTfskeFMXiYt5yLBUBiLOiWCig5fezvCKJnUnjf8M JxHSnF0.uMv7NTzgKgut42b2jp9Qn.ja0ZqU7ryWsQ85HEbayoSMlzqYijxhy9rLxIbKp2M7QFic AlPZv91DJc6i3fAaxP.8APa1xfus.audrN3yxtuDsUzK2zXJTPa9MaWJnxdelSM_o857wRbOrEgZ Hc0WEiWQxJoUD_C7VH8OoY7f2Vjx3BIeR95owEol.Lx388KQEJ2bF5V7ZWjJVYHk3DT9QEZ0mVGf XCLtaTd82MvzLURoHhBYuAd5bg3B7CuYOGSNdTHRSGTB.RZZYtYZq4M1HI6Rg0PXyEYRnYCYQ.m6 2YUJP2EXNPJa0e72jDsnv61m6PiYfQuJLBh1YTokeYwBETHyhg.3pf1UyiOfw6RYB9BAjrzFqd5z YjF51ACpHW193p0aZdqbHcYnMHHUnZGC_7bmt6vx9URE9NngXblCqon4Bwhxqij_zUDp5VMnf5QV fxnRXi98P45OH4WNpKF9AnUD7nJRICyXIoZ8nkNOIdsezbCZv7bM6NztWFe2km1HyODS59v19l2u 8KgCqvs3P06rKmSXouW3BHgsfm.i8JixktjZ7EXUjn8A4fqK2nWhxYL1kfGLkSb7D9Ei7l6.Fq9j QRIPyd_1KXbRlYp3VDfNQvp6uKIgfYE9nGfI5B40ZVS6Al1dTKi2JjggTKEvNP3Z9Qp5vyBzTiri oXlvySl2XhlgTo84ieKKGGkE18astdYMrZkOJkaFhtLhas0tTQQ_aY5i4W3JBG7wlaJQSBTWp3.D L.9iNJ2CpEwhfwi1FG4eGfzBj7U8BYvypoqk8zqhAfwx2f_NvLVRvxfdeuUB9tm1SPhQFxbCO3Pe U6DTYvbOR19IyzTcCOTFSKHKeyK2FoSOIWtiHBGJAHThBdC9SPOcnDrWBXz_k.5zXbKdIwVJzEyH OiszpFWtlpH9n4vxgwn0ikOO9ixc6rZAw._iyRxGP5R3QdA36lO2cumLx52SFfUunpkhztWHW_rt YXQB2.yud3zFLXfFjB4Kc8jLQV5A5U_d6x2iNPINJdEtxfcP9yUnpoS2_XGGf_ZnmAoESRxJ7ioA pBcE6RN7RFGvhvm999Mdfp3L_A.BGSPXCcJtuO49vbfxHdgrayJ3CK39bY74_VMJ0Kv7ns98vwvF qoERFdBuAGs1CJ.BW6R.0MOEZSSXk_sNNMfpXIpOjXyx1m71Git1zMzrE9aMXjCrSjXODlIgKkv8 CbWifYoInuhFqZzzRX12h1heGVCs5CndOR2WOQfy5OsPBayNsO2p.Who1YGE9qPtj4bPr.DF5Ald HWkSHB.A.Hw3tqn9gh97JXpLyzF0hlW1DLmKpw2nwXBwaButKASulkCMfScYvNGBW62EyWdX2_ko 33YhzvB3aSbx.dGzo5RFxm4LohrGN0Q_WebQ05ek41i74HYHWqPVWUyPy.ZDJjljUzsLrqhf_PRj tz_8sLXdRPPBMUFik1Al5FLTpm1P3DFbXQlNNur1t_TOaRlvytMJZol1255tGnXQs7ZslTLEersj TyQSIF9B2ciBkiYqNON5qqs430ChAK8MUfEHC7ab0sYrhKKTlgIcOo2bX0xepBaL_uevyZNxKgES mr.RUqB_Prqlj5iQiVfZE7S3qSdCkheIhbgh4HZHQIStdaqElAXy4cfStpy.HO9PZY3SvHvYgS0b D1efrwnWN5s5Q1.9gWZm8qFxEd0.c2VfTb12ahWEhNN7c65p8xa7xVedv2XQ5YVJemERyExtYP28 SvXQhkx8_rok6ejq_x2gQv8won2T5hYAE3IiVQE37VaPaloRayTnFXA-- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic303.consmr.mail.ne1.yahoo.com with HTTP; Fri, 13 Jan 2023 03:01:56 +0000 Received: by hermes--production-sg3-5ff5bbd69d-dbccs (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 741cc79c1d943d2836802a49ef228f07; Fri, 13 Jan 2023 03:01:52 +0000 (UTC) From: Po Lu To: bug-gnu-emacs@gnu.org Subject: CC Mode 5.35.2 (C/*l); More incorrect type recognition X-Debbugs-Package: cc-mode Date: Fri, 13 Jan 2023 11:01:44 +0800 Message-ID: <87pmbjcf3b.fsf@yahoo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable References: <87pmbjcf3b.fsf.ref@yahoo.com> X-Mailer: WebService/1.1.21062 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 5903 Received-SPF: pass client-ip=66.163.188.146; envelope-from=luangruo@yahoo.com; helo=sonic303-20.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.6 (-) Package: cc-mode Here is another example of incorrect type recognition in C Mode as a result of a typo: static Lisp_Object frame_geometry (Lisp_Object frame, Lisp_Object attribute) { struct frame *f =3D decode_live_frame (frame); /** XWindowAttributes atts; **/ Window rootw; unsigned int ign, native_width, native_height, x_border_width =3D 0; int x_native =3D 0, y_native =3D 0, xptr =3D 0, yptr =3D 0; int left_off =3D 0, right_off =3D 0, top_off =3D 0, bottom_off =3D 0; int outer_left, outer_top, outer_right, outer_bottom; int native_left, native_top, native_right, native_bottom; int inner_left, inner_top, inner_right, inner_bottom; int internal_border_width; bool menu_bar_external =3D false, tool_bar_external =3D false; int menu_bar_height =3D 0, menu_bar_width =3D 0; int tab_bar_height =3D 0, tab_bar_width =3D 0; int tool_bar_height =3D 0, tool_bar_width =3D 0; if (FRAME_INITIAL_P (f) || !FRAME_ANDROID_P (f) || !FRAME_ANDROID_WINDOW (f)) return Qnil; block_input (); android_get_geometry (FRAME_ANDROID_WINDOW (f), &rootw, &x_native, &y_native, &native_width, &native_height, &x_border_width, &ign); unblock_input (); } Place point after "android_get_geometry (", and accidentally type: d (this was meant to be C-M-d.) Now, FRAME_ANDROID_WINDOW and android_get_geometry are stuck in c-found-types. Thanks. Emacs : GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu) of 2023-01-13 Package: CC Mode 5.35.2 (C/*l) Buffer Style: gnu c-emacs-features: (pps-extended-state col-0-paren posix-char-classes gen-st= ring-delim gen-comment-delim syntax-properties category-properties 1-bit) current state: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D (setq c-basic-offset 2 c-comment-only-line-offset '(0 . 0) c-indent-comment-alist '((anchored-comment column . 0) (end-block space . = 1) (cpp-end-block space . 2)) c-indent-comments-syntactically-p nil c-block-comment-prefix "" c-comment-prefix-regexp '((pike-mode . "//+!?\\|\\**") (awk-mode . "#+") (other . "//+\\|\\**")) c-doc-comment-style '((java-mode . javadoc) (pike-mode . autodoc) (c-mode . gtkdoc) (c++-mode . gtkdoc)) c-cleanup-list '(scope-operator) c-hanging-braces-alist '((substatement-open before after) (arglist-cont-nonempty)) c-hanging-colons-alist nil c-hanging-semi&comma-criteria '(c-semi&comma-inside-parenlist) c-backslash-column 48 c-backslash-max-column 72 c-special-indent-hook '(t c-gnu-impose-minimum) c-label-minimum-indentation 1 c-offsets-alist '((inexpr-class . +) (inexpr-statement . +) (lambda-intro-cont . +) (inlambda . 0) (template-args-cont c-lineup-template-args +) (incomposition . +) (inmodule . +) (innamespace . +) (inextern-lang . +) (composition-close . 0) (module-close . 0) (namespace-close . 0) (extern-lang-close . 0) (composition-open . 0) (module-open . 0) (namespace-open . 0) (extern-lang-open . 0) (objc-method-call-cont c-lineup-ObjC-method-call-colons c-lineup-ObjC-method-call + ) (objc-method-args-cont . c-lineup-ObjC-method-args) (objc-method-intro . [0]) (friend . 0) (cpp-define-intro c-lineup-cpp-define +) (cpp-macro-cont . +) (cpp-macro . [0]) (inclass . +) (stream-op . c-lineup-streamop) (arglist-cont-nonempty c-lineup-gcc-asm-reg c-lineup-arglist ) (arglist-cont c-lineup-gcc-asm-reg 0) (comment-intro c-lineup-knr-region-comment c-lineup-comment ) (catch-clause . 0) (else-clause . 0) (do-while-closure . 0) (access-label . -) (case-label . 0) (substatement . +) (statement-case-intro . +) (statement . 0) (brace-entry-open . 0) (brace-list-entry . 0) (brace-list-close . 0) (block-close . 0) (block-open . 0) (inher-cont . c-lineup-multi-inher) (inher-intro . +) (member-init-cont . c-lineup-multi-inher) (member-init-intro . +) (annotation-var-cont . +) (annotation-top-cont . 0) (topmost-intro . 0) (knr-argdecl . 0) (func-decl-cont . +) (inline-close . 0) (class-close . 0) (class-open . 0) (defun-block-intro . +) (defun-close . 0) (defun-open . 0) (c . c-lineup-C-comments) (string . c-lineup-dont-change) (topmost-intro-cont first c-lineup-topmost-intro-cont c-lineup-gnu-DEFUN-intro-cont ) (brace-list-intro first c-lineup-2nd-brace-entry-in-arglist c-lineup-class-decl-init-+ + ) (brace-list-open . +) (inline-open . 0) (arglist-close . c-lineup-arglist) (arglist-intro . c-lineup-arglist-intro-after-paren) (statement-cont . +) (statement-case-open . +) (label . 0) (substatement-label . 0) (substatement-open . +) (knr-argdecl-intro . 5) (statement-block-intro . +) ) c-buffer-is-cc-mode 'c-mode c-tab-always-indent t c-syntactic-indentation t c-syntactic-indentation-in-macros t c-ignore-auto-fill '(string cpp code) c-auto-align-backslashes t c-backspace-function 'backward-delete-char-untabify c-delete-function 'delete-char c-electric-pound-behavior nil c-default-style '((java-mode . "java") (awk-mode . "awk") (other . "gnu")) c-enable-xemacs-performance-kludge-p nil c-old-style-variable-behavior nil defun-prompt-regexp nil tab-width 8 comment-column 32 parse-sexp-ignore-comments t parse-sexp-lookup-properties t auto-fill-function nil comment-multi-line t comment-start-skip "\\(?://+\\|/\\*+\\)\\s *" fill-prefix nil fill-column 70 paragraph-start "[ ]*\\(//+\\|\\**\\)[ ]*$\\|^\f" adaptive-fill-mode t adaptive-fill-regexp "[ ]*\\(//+\\|\\**\\)[ ]*\\([ ]*\\([-=E2=80=93!|#%= ;>*=C2=B7=E2=80=A2=E2=80=A3=E2=81=83=E2=97=A6]+[ ]*\\)*\\)" ) From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 16 13:08:03 2023 Received: (at 60769) by debbugs.gnu.org; 16 Jan 2023 18:08:03 +0000 Received: from localhost ([127.0.0.1]:34706 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHTtr-0000Uj-8D for submit@debbugs.gnu.org; Mon, 16 Jan 2023 13:08:03 -0500 Received: from mx3.muc.de ([193.149.48.5]:28887) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHTtn-0000UB-59 for 60769@debbugs.gnu.org; Mon, 16 Jan 2023 13:08:02 -0500 Received: (qmail 76805 invoked by uid 3782); 16 Jan 2023 19:07:52 +0100 Received: from acm.muc.de (p4fe15dda.dip0.t-ipconnect.de [79.225.93.218]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Mon, 16 Jan 2023 19:07:51 +0100 Received: (qmail 16982 invoked by uid 1000); 16 Jan 2023 18:07:51 -0000 Date: Mon, 16 Jan 2023 18:07:51 +0000 To: Po Lu Subject: Re: bug#60769: CC Mode 5.35.2 (C/*l); More incorrect type recognition Message-ID: References: <87pmbjcf3b.fsf.ref@yahoo.com> <87pmbjcf3b.fsf@yahoo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87pmbjcf3b.fsf@yahoo.com> X-Submission-Agent: TMDA/1.3.x (Ph3nix) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60769 Cc: 60769@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Po. On Fri, Jan 13, 2023 at 11:01:44 +0800, Po Lu via CC-Mode-help wrote: > Package: cc-mode > Here is another example of incorrect type recognition in C Mode as a > result of a typo: > static Lisp_Object > frame_geometry (Lisp_Object frame, Lisp_Object attribute) > { > struct frame *f = decode_live_frame (frame); > /** XWindowAttributes atts; **/ > Window rootw; > unsigned int ign, native_width, native_height, x_border_width = 0; > int x_native = 0, y_native = 0, xptr = 0, yptr = 0; > int left_off = 0, right_off = 0, top_off = 0, bottom_off = 0; > int outer_left, outer_top, outer_right, outer_bottom; > int native_left, native_top, native_right, native_bottom; > int inner_left, inner_top, inner_right, inner_bottom; > int internal_border_width; > bool menu_bar_external = false, tool_bar_external = false; > int menu_bar_height = 0, menu_bar_width = 0; > int tab_bar_height = 0, tab_bar_width = 0; > int tool_bar_height = 0, tool_bar_width = 0; > if (FRAME_INITIAL_P (f) || !FRAME_ANDROID_P (f) > || !FRAME_ANDROID_WINDOW (f)) > return Qnil; > block_input (); > android_get_geometry (FRAME_ANDROID_WINDOW (f), > &rootw, &x_native, &y_native, > &native_width, &native_height, &x_border_width, > &ign); > unblock_input (); > } > Place point after "android_get_geometry (", and accidentally type: > d > (this was meant to be C-M-d.) > Now, FRAME_ANDROID_WINDOW and android_get_geometry are stuck in > c-found-types. I'm afraid I can't reproduce this on either master or emacs-29. Am I correct in assuming that you mean insert the one single character "d" after the "(" in that line? Even when I additionally insert a space, M-: (c-list-found-types) just lists "Window", which seems correct. > Thanks. > Emacs : GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu) > of 2023-01-13 > Package: CC Mode 5.35.2 (C/*l) > Buffer Style: gnu > c-emacs-features: (pps-extended-state col-0-paren posix-char-classes gen-string-delim gen-comment-delim syntax-properties category-properties 1-bit) -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 17 00:17:04 2023 Received: (at 60769) by debbugs.gnu.org; 17 Jan 2023 05:17:04 +0000 Received: from localhost ([127.0.0.1]:35439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHeLE-0008HJ-JJ for submit@debbugs.gnu.org; Tue, 17 Jan 2023 00:17:04 -0500 Received: from sonic301-30.consmr.mail.ne1.yahoo.com ([66.163.184.199]:37633) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHeL9-0008H0-CA for 60769@debbugs.gnu.org; Tue, 17 Jan 2023 00:16:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673932608; bh=WpHN1OodrhV/cLa6polnW1GZe5e2gw5JxYRkbviueXo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=lN/hnfVPTf1TCx/iaUL+BVax5ngioJ9ZI91yvhVSsX6qc+rfEqHTbnWXgDoz0h86liD6c7zKQHbUBUI7I1QQaoNFVXULJAhcNnG7NNjCpN270ZYNW1tiwxzwADKQl3dn6pTdMEJeM0+YnuPFMbd4cNOPUnv3oyxi9OjhT1G9r9voxg1O7vuYBNl40SttOE++RlejWxDUv6xfv9uB6FiTsBVGjEVWaiifEjjffAP8tvThhXx31kwWvgN+0STS+a2cpDqPqvrWLYJb6ZQx0PzzIaRwlRA8EuEjanPI8Zh7PihfiBbJJoqjyPZ0vT2i7REiYKNMtUkKtvLGDfRR1fBCsg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673932608; bh=6AVXV8c0fNDkD/mfbRL4CQ+getCiwdtLeyNPFkF/aWh=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=nxGri9uxEKB8Kz722tgC84w677Njc3SmSF+YaQYGatmCjJI0jg76YBCOvxxm+4K1hVgWxbhu3c87rnYusPxZSaMkAlcpIAj584CON1fMh/XOCG+IZCrfIIwn5MylCoW2IrJIEiSsrtw9SgSnkEmVnCkvEUViTQMAAY2VMsws4ee9J3lF2hYsVQFH0Nns7U2qwd69q5Eq4xAId/NkGsP/nQEXgcdUuF5DFT8fqp9W0qMByXSs7wbKBliB5o2s2/49V0Sn/70ZCIBNZppUxDkuU7by89wawoUszHjGYIVS7yNz9JOtE+shttfUfpuWwAkjW2sNT/x3XiErxxT890X1Tg== X-YMail-OSG: UXLCYvcVM1muxBKLca.F8.tBLl1fhit.rx_kCnKXtsylay5QbOLCPOXIBErK0ho wt9VDAPZB2GquzJOZZq8PhphXH2yifYJAAL5gHVsDJ4YKD8Go2OqqT0m5XaYTPz4ViWxkEzxOrRP 7ySm6syWDHJI5bUnUQ40HdHsEdagnJ5pRNo54qJdH6cszY5m_5M62_rXym4CUBLidXOwDfJFqzOZ 5gzhFnURyr8YGws6KNCOey2pY_ZkpUU0nXf7kJ7FPZfiyNoOPOtmJ0GTvFbGMZD64X4CZw1dB5KC myoTclvtO_gEZwLI_oMcAQp0ai4tVpU6KSd3IJvI0mql37HfqEzzqb4UuqpHAJPXCLoSPYPoQszb .QoYO4.nzxvO7T.5ecWOSzg6zsigrCuQ2N3xiYDpmGFvzgLoLYuXB6IzS9SV3wbavkrDyaB7PGNc IfKOdY9ZWrXc_dFCz1mLW72ZoBSLGazHMUrtWrdQS7qg7Kzt9aCXziked_KuzEaHt52jdYUBqhMg ABPywOy3B2kv01QmeA.2GCksNm_e0QjH1hTgTzVXt2OofO68WMh2YX4HmP0HEQtxir2jBscFsqUB Yy0QdOdVuaDbZo65pzgJ.NMSYDDbvKHfUszZc5Mh9VWvMcpo0ZJbYLbLxHrrEcXUHAI8yPXb8XLW BZo5LCngGCvdmBzGq9p4zqfqTGlno517uhgs06vg.Bx1WnW_ELYyqF49I28VddbphRs25yo.Pa1o KqQCO4wkmS.f342qOAEgOV8NSkPxnmn8QvUCI8_OeeNHz.7pZWGmr.HzMYs.V57c0gcygemkf2Ia F5JT6z_DCcMuiDbozCbVbi57nR4sdzOAoKD4T1zEdoJuYRigLoxQ8cZgRlCwz8L5H17Ap5JxU2xS jPHAPqrO4rNSmCCfebCvROC72rTwTWoUXMs0q5TGdZY_WGzekjxJmq1eDwJYpGcwL0eJ7awzMd8W LHxe6ZQswBeXpp12YZrVzM_YyNPkpTbylfaW6xAwz7ohiivNsd13ngkOpV4wSUZom9zQud_1Iw50 4v.oVEix4CNT7LDdjFe9uEZQVFiy_En1N8ZKj0gDABh5Jew1mMFNmQcZrRUK38QomYmQWDm6ePdY 2dD99mZ8cwc11mgnrlr5bpp92IxgwjxtKpCgcmt190Br8vYwMoNTI1WrCTtWGBXGd.8ZY0XqNQ4S g2x4t.mor46c3u9qHkJHmL6xyxjhslud1F48w1hhZnvNt82DntuFi0BBIDEfi8AOVfGWFNm43lpv l.hhYFKyLMmLLs1nDpxNBTU8izRqg5ozTZV0PzhRxlx3IJME0uoDUQ5PHaj1JpHfzyL1vtJrRQzD .bdZ6V7dksa_7GiE5zcc1POMBc3ClsGMrCDFncyWUQ0sJEF_brcjOi1XAzJLU9a0Kbe395okzBGJ prLPmZUGh5VyzZIRfYFBUsHTivzxT0dPnQfNVVPbaVsIXaFzWWPuZk7Ri4kSNN1X_IRXXlVgLGCS jChUicVt7VXbn9_1quzEQJptY.ET6dxl7ftdSWO61pD05ngEawjOS10Dq5.CQxzhWrcyw2kVBLJD eS9PvaP33DfxskLJ024V1rsF14JgPoz125V6yjHrVcyGzwywTjhX0DfvkvJfqyIzBuq3ajjOGhTP BV8ElY6Mt6MCIQt0TLgPd19Xgr4PR6uPmx2oo0AuDWpNLCgdn7dJDVQWQAqJZEYttvKo4bKyLIDv wqwY__9p7f6NGfpdl8qLcYC3mFUKXRYdce3kTQjIaXe8bLU1iMLw1AjNKhZV95cMufGf6dXcVf0S C7pxzVtRN2zfM5a8x2QsKJDLt.aUCVJ.DTRS_30VuE1Sj0I0uQym2vn.QaroYMhFDzPUiszpv9Sr h3Xo_sccgTw8_DU9VcWpJFXtlfecJklv42vsrCLQ1IvwEh.q567OcnIJWWvkEoJO7saHgDZzGcYA XCgxY5EdVyC0lkH1QvYEblBOyG3p1BO0OVZoswVRCaNv_hL_BWOAsVjuFaKgXkQUTTyAK9qPCZzR xK.nZzrSe69iRCTvViAa1NT7IcpUmjiSY8_1_FUj9ecLZGmG8PVJOgxkjfKBdNDaTSB7zaSykmMk bs5LTvYhSwMJIaz0y_oO_FFD9.HYMnOFNl3u0jN7ytWbM7Sq7EZlRLdvO60L3ryibHZm5zeFxj9H ZEuSEzRqbrm808WozkfJkiXolK5YqWZAeAWYANG_WRqOwJJWNfMfaP9v5CNfMRn_uao2X5Qt4LeP aZS_Io.wfTFic.n7wjTJxMCWSBEJRr6mU4O4AKiQFxQmGSyj7RdpviFPodlNF0d43bmE- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.ne1.yahoo.com with HTTP; Tue, 17 Jan 2023 05:16:48 +0000 Received: by hermes--production-sg3-5ff5bbd69d-8jmj2 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID faea5289f87fbffa211007f133232965; Tue, 17 Jan 2023 05:16:43 +0000 (UTC) From: Po Lu To: Alan Mackenzie Subject: Re: bug#60769: CC Mode 5.35.2 (C/*l); More incorrect type recognition In-Reply-To: (Alan Mackenzie's message of "Mon, 16 Jan 2023 18:07:51 +0000") References: <87pmbjcf3b.fsf.ref@yahoo.com> <87pmbjcf3b.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Tue, 17 Jan 2023 13:16:22 +0800 Message-ID: <87tu0p91w9.fsf@yahoo.com> MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.21062 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 1971 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60769 Cc: 60769@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alan Mackenzie writes: > Hello, Po. > > On Fri, Jan 13, 2023 at 11:01:44 +0800, Po Lu via CC-Mode-help wrote: >> Package: cc-mode > >> Here is another example of incorrect type recognition in C Mode as a >> result of a typo: > >> static Lisp_Object >> frame_geometry (Lisp_Object frame, Lisp_Object attribute) >> { >> struct frame *f = decode_live_frame (frame); >> /** XWindowAttributes atts; **/ >> Window rootw; >> unsigned int ign, native_width, native_height, x_border_width = 0; >> int x_native = 0, y_native = 0, xptr = 0, yptr = 0; >> int left_off = 0, right_off = 0, top_off = 0, bottom_off = 0; >> int outer_left, outer_top, outer_right, outer_bottom; >> int native_left, native_top, native_right, native_bottom; >> int inner_left, inner_top, inner_right, inner_bottom; >> int internal_border_width; >> bool menu_bar_external = false, tool_bar_external = false; >> int menu_bar_height = 0, menu_bar_width = 0; >> int tab_bar_height = 0, tab_bar_width = 0; >> int tool_bar_height = 0, tool_bar_width = 0; > >> if (FRAME_INITIAL_P (f) || !FRAME_ANDROID_P (f) >> || !FRAME_ANDROID_WINDOW (f)) >> return Qnil; > >> block_input (); >> android_get_geometry (FRAME_ANDROID_WINDOW (f), >> &rootw, &x_native, &y_native, >> &native_width, &native_height, &x_border_width, >> &ign); >> unblock_input (); >> } > >> Place point after "android_get_geometry (", and accidentally type: > >> d > >> (this was meant to be C-M-d.) > >> Now, FRAME_ANDROID_WINDOW and android_get_geometry are stuck in >> c-found-types. > > I'm afraid I can't reproduce this on either master or emacs-29. Am I > correct in assuming that you mean insert the one single character "d" > after the "(" in that line? Even when I additionally insert a space, > M-: (c-list-found-types) just lists "Window", which seems correct. Sorry for the confusion, Alan. I meant to insert the character "d" immediately before "(". Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 18 10:24:24 2023 Received: (at 60769) by debbugs.gnu.org; 18 Jan 2023 15:24:24 +0000 Received: from localhost ([127.0.0.1]:41576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIAIa-0008Sw-8m for submit@debbugs.gnu.org; Wed, 18 Jan 2023 10:24:24 -0500 Received: from mx3.muc.de ([193.149.48.5]:52505) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIAIY-0008Sh-8g for 60769@debbugs.gnu.org; Wed, 18 Jan 2023 10:24:23 -0500 Received: (qmail 60442 invoked by uid 3782); 18 Jan 2023 16:24:15 +0100 Received: from acm.muc.de (p4fe15d46.dip0.t-ipconnect.de [79.225.93.70]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 18 Jan 2023 16:24:15 +0100 Received: (qmail 4512 invoked by uid 1000); 18 Jan 2023 15:24:15 -0000 Date: Wed, 18 Jan 2023 15:24:15 +0000 To: Po Lu Subject: Re: bug#60769: CC Mode 5.35.2 (C/*l); More incorrect type recognition Message-ID: References: <87pmbjcf3b.fsf.ref@yahoo.com> <87pmbjcf3b.fsf@yahoo.com> <87tu0p91w9.fsf@yahoo.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="tLtHHgs3YHJvFBmM" Content-Disposition: inline In-Reply-To: <87tu0p91w9.fsf@yahoo.com> X-Submission-Agent: TMDA/1.3.x (Ph3nix) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60769 Cc: 60769@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --tLtHHgs3YHJvFBmM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hello, Po. On Tue, Jan 17, 2023 at 13:16:22 +0800, Po Lu wrote: > Alan Mackenzie writes: > > Hello, Po. > > On Fri, Jan 13, 2023 at 11:01:44 +0800, Po Lu via CC-Mode-help wrote: > >> Package: cc-mode > >> Here is another example of incorrect type recognition in C Mode as a > >> result of a typo: > >> static Lisp_Object > >> frame_geometry (Lisp_Object frame, Lisp_Object attribute) > >> { > >> struct frame *f = decode_live_frame (frame); > >> /** XWindowAttributes atts; **/ > >> Window rootw; > >> unsigned int ign, native_width, native_height, x_border_width = 0; > >> int x_native = 0, y_native = 0, xptr = 0, yptr = 0; > >> int left_off = 0, right_off = 0, top_off = 0, bottom_off = 0; > >> int outer_left, outer_top, outer_right, outer_bottom; > >> int native_left, native_top, native_right, native_bottom; > >> int inner_left, inner_top, inner_right, inner_bottom; > >> int internal_border_width; > >> bool menu_bar_external = false, tool_bar_external = false; > >> int menu_bar_height = 0, menu_bar_width = 0; > >> int tab_bar_height = 0, tab_bar_width = 0; > >> int tool_bar_height = 0, tool_bar_width = 0; > >> if (FRAME_INITIAL_P (f) || !FRAME_ANDROID_P (f) > >> || !FRAME_ANDROID_WINDOW (f)) > >> return Qnil; > >> block_input (); > >> android_get_geometry (FRAME_ANDROID_WINDOW (f), > >> &rootw, &x_native, &y_native, > >> &native_width, &native_height, &x_border_width, > >> &ign); > >> unblock_input (); > >> } > >> Place point after "android_get_geometry (", and accidentally type: > >> d > >> (this was meant to be C-M-d.) > >> Now, FRAME_ANDROID_WINDOW and android_get_geometry are stuck in > >> c-found-types. > > I'm afraid I can't reproduce this on either master or emacs-29. Am I > > correct in assuming that you mean insert the one single character "d" > > after the "(" in that line? Even when I additionally insert a space, > > M-: (c-list-found-types) just lists "Window", which seems correct. > Sorry for the confusion, Alan. I meant to insert the character "d" > immediately before "(". Ah! Yes, that's different. ;-) I can now reproduce the bug, and analysing it, it actually turned out to be two distinct cases, one for android_get_geometry and the other for FRAME_ANDROID_WINDOW. I've fixed both of them with the now familiar "unsafe-maybe" mechanism. Would you please do the usual with the attached patch, and let me know if anything is amiss. In particular, if you notice any types which were (correctly) fontified as types, but now no longer get fontified, please tell me. Thanks! I look forward to hearing from you again. -- Alan Mackenzie (Nuremberg, Germany). > Thanks. --tLtHHgs3YHJvFBmM Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="diff.20230118.diff" diff -r 17edbd3947aa cc-engine.el --- a/cc-engine.el Tue Jan 17 17:54:41 2023 +0000 +++ b/cc-engine.el Wed Jan 18 15:15:25 2023 +0000 @@ -10495,6 +10495,8 @@ got-prefix ;; True if the declarator is surrounded by a parenthesis pair. got-parens + ;; True if there is a terminated argument list. + got-arglist ;; True if there is an identifier in the declarator. got-identifier ;; True if we find a number where an identifier was expected. @@ -10642,13 +10644,17 @@ (when (> paren-depth 0) (setq paren-depth (1- paren-depth)) (forward-char) + (when (and (not got-parens) + (eq paren-depth 0)) + (setq got-arglist t)) t) - (when (if (save-match-data (looking-at "\\s(")) - (c-safe (c-forward-sexp 1) t) - (if (save-match-data - (looking-at c-fun-name-substitute-key)) ; requires - (c-forward-c++-requires-clause) - (goto-char (match-end 1)) + (when (cond + ((save-match-data (looking-at "\\s(")) + (c-safe (c-forward-sexp 1) t)) + ((save-match-data + (looking-at c-fun-name-substitute-key)) + (c-forward-c++-requires-clause)) + (t (goto-char (match-end 1)) t)) (when (and (not got-suffix-after-parens) (= paren-depth 0)) @@ -10710,8 +10716,11 @@ (goto-char pos) (setq pd (1- pd))) t))) - (c-fdoc-shift-type-backward) - t))) + (c-fdoc-shift-type-backward) + (when (and (not got-parens) + (eq paren-depth 0)) + (setq got-arglist t)) + t))) (c-forward-syntactic-ws)) @@ -10779,6 +10788,9 @@ (not (or got-prefix got-parens))) ;; Got another identifier directly after the type, so it's a ;; declaration. + (when (and got-arglist + (eq at-type 'maybe)) + (setq unsafe-maybe t)) (throw 'at-decl-or-cast t)) (when (and got-parens @@ -11167,9 +11179,17 @@ ;; inside an arglist that contains declarations. Update (2017-09): We ;; now recognize a top-level "foo(bar);" as a declaration in C. ;; CASE 19 - (or (eq context 'decl) - (and (c-major-mode-is 'c-mode) - (or (eq context 'top) make-top)))))) + (when + (or (eq context 'decl) + (and (c-major-mode-is 'c-mode) + (or (eq context 'top) make-top))) + (when (and (eq at-type 'maybe) + got-parens) + ;; If we've got "foo d(bar () ...)", the d could be a typing + ;; mistake, so we don't promote the 'maybe type "bar" to a 'found + ;; type. + (setq unsafe-maybe t)) + t)))) ;; The point is now after the type decl expression. --tLtHHgs3YHJvFBmM-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 18 20:06:12 2023 Received: (at 60769) by debbugs.gnu.org; 19 Jan 2023 01:06:12 +0000 Received: from localhost ([127.0.0.1]:42109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIJNc-0000o1-7l for submit@debbugs.gnu.org; Wed, 18 Jan 2023 20:06:12 -0500 Received: from sonic302-20.consmr.mail.ne1.yahoo.com ([66.163.186.146]:38750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIJNY-0000nm-UC for 60769@debbugs.gnu.org; Wed, 18 Jan 2023 20:06:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1674090361; bh=ZudZFh4iyx0Hpd87z+KIgEGP5slBgzPqUc77qlGEJDw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=jvHhMRu8/zzrT60A3SbkanBI8bA3cfJ9kLayQIRhjRUOWLDw3KHVHxWspqHvp7g7rj3U5ZvT/Dyv8E1Kj6CqlyZjT+W4jRIEp9DOvkFxpTE0+/mSa392HsOGoaTyRgHQRW6HXWCxt2nhcqxVE+PBfH63Pg1R2JAIW4XjxtUsZHM1BCRdeqM9GjWVVgYwzHUSaLc5j7iaM9q6WjIT7GrQk6JugcyPSEXz29qf0YTZY3VacUOtsVTdab5tmMtOKYBB6mUE0ToTBCeyhRmYT7TzvDYptUyBCHz+cLqvwYoOZMgwWs/G4v6eYXcK5V9JwDDcLC5rZwUQp1311sVjIKwfdw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1674090361; bh=/cCVK8r5wKzaYCuhu0k+j7bgGkPLUPzRIL3BXbYxOLZ=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=d6baOu94lJBf8KX+gjUzI+WD7++UsZ4L98wncB8yp9hgwP/DELDr3QK2uJPW00C8Ljhi8DwhcImvIYu8oCxy3wE/YRBpWEgVzjK/Kxs97CzUZWqEpsgOOCUhmEA0Xqt93aZptN2su/zt3wn0t/m33HWAPIzaHDUySs+s6dm2ahJd/DETcfj3Qm4Rmp38MAsh46RfPXtodUHfcMJqPrxBob3y97xHbyE+CQUQVUaqOIm/as7+kZicTAJHz49ZLF2KT6Na3Q7zIPCIIJoYtNXsWugrJXn2Tk98/B6nQeZAV9E/bF1aRDah8vBzUxUPBC7LaiEJltfiWYaiWc8+yEGYLA== X-YMail-OSG: 7e94o9oVM1n8wKLhj7kCj3Vm8K8fz.0Y6sn6rchhRKTwPg2M57QeRlMV4x2wEQo WDoUlVOQOb6spIuy2xqoQ40_sUQnFhvC14mVIGDK1ns99_NYkhNJ_NgryNkZ_Dtpt0JNM8.h4czP ap_E3NUBASPjvrs36mKoPGvftU2STIrkR6dRNFDnv6C_W6fuFQHS7fr6wLDVbegJ1FKuDrJZ.nDd M4Suc03P1NjkRYkwQQrvhbIt4qH4Mn3cp5oXcsGxA3v0EG2nTNsKLMpsZizZHxTBwF773QpSkCpe b6NL3FhkdaEH8z5hee2Gvly.j60tM5gd6zepmvytL5MVFVkQzuecwcIfICLy1cLAhQPHdXISMRks JYMZDY51vI8CYEG9pC10nVFCo7mEasXybxeWpvq8.Tq69NydpRbZuORO3OAjPsAPq0JtNdw14XHO bBkNT5AJYLXPlywaRq7lMXL2b9zZVTOAEi3dR3kISM7k9khDi7VgSOyU4YFCuAosniu9coOXhVkM Z_HvzK7fpEUWtDFtApihQzkQxOGM_sZ9e0INW4mrywSqLOB6Chn_CBohuxQwCKS5i0XgJtI1TElB wGXJd2pw0c.FtCiMWPODcJ64gQLcROqRY3DSqSpfXbGctMfX_zdbEsvidfWWLp9wAIDfK0NouF0Y T56zTP6yet1ZUbyQCq4ATEYg6lzl5w74eezH2Oitu6L.gSyxnAhm.CzNeUJMP1nbaIh5ZlCc171i kp3v.4ailLSY9tZmN_FgEDVXYq3x9EkunKkMFk9xDWMUtK_Aq5z8GyAIvMqM5.ulEbUzF4Ftx8T8 qKIdsG1sSeYNHwMO1QnLi50CEacHn39aNcDRk5cS52tr0LUuMNc33NnaIM0IzyduAnIj012bScbE rFUIxlVJAmYJhg4Cw_HckwfBC6x11glJFjSDn2UHyYMJmQVa.9X7WTpP3lVu2Vy21KssGAr7VJ7b vP7qG3C9NLdo8GRleucxgR6x6pdkwYd907VlfGm8.H_tu2dUx1aHoqE1mrmMr1UiRN8iUid2GWqp 10vh5jCC0sO3hzm8Z6eYU_JOezrYOkVX5zdrW5jqEGmc34Jm2w.RvXdunDej7gO1s2pWTzuYTU09 wTQJtSKy_ndE.1pUKXqw1vJDTnZ5RwmaQ.HFIj07X9O933Q4FSUNt1JEa2yIjf8iP_xhoJ2cmoS0 4BdAF.0Vb10kGR.iYSIGW1L7fN32gqc1W6NuMLQezWFKuGXewYpxaVigTAmo8vN5dzvlZTasyfGg GzIWIFUECz6U5JKB_Rjk_GytbNuhi64PfFY8Ri9e8tQ36_evXcSWuSGP7Dz_41Pd2nNwffLdSmWA 5oepfZzfF52DjQQ4IGIJon6Ps.HRipqSfKMBNm4SYVswCg80w9Zdax_rxcJRUtNTjmvAA7L3weFX drJsZy5xjR4UqBQmyb.TsA8QYLZDViT.EiK3D1jPP9FNCzmrvVipWTZroy1jQ3Tdn25CsDiTLQNr f40ja1RKWchzzpz7smmfh5YNnfCb6BvYmYQzI3z9MtlE7n.JzYUSB4DTsYdiXkUKF1wGYnXAz_Hx nC533hQ4pxu_BdsCJ_nS5AvfJl3OI9gmciyqFY4ao4KQTrWB.UQtK12LEL7Na5BEMYxnSf8B4y6K 7zuleV8GeE1r0HZc9ZsRHfynBA.bwVA9UEur8oApeSRNOJ7EgWFaG6I8mnGJkM6N2X52woqWkQ_K WL.vHIRKSmJGII6gEwqErbJtfMt0on5VfK5Iwc1UXA9efOTwUeWkgTl8qmhYlG53GoE.9m7D0IiO ZpizMusHkIenEs54qsBfuE4aLS1LGRr8rFs6XFYibXLmXefXNviCF2KTgXFqdOebVqG728XadKUW qus120wGjrkVVtAQPOJ7ITwp.OuWtn2aTnHvosgA8Jqp6u4j6W6yYfZnLUhJ_TN339ZZ58YLtiE7 HbpqBaMylxLqcAlgCP2Zr0UPHVB5jPzHLlaUYqEaXLA_qeVFsW600yu1KwMpmbFY3FBiOBafOySk .17EKCfH5gUG1tepyp.DSEEpvCGpwWFMpZP564qBMEdMngBb.hf.oTLtOmIXqaafH2AmSw._Bg4b jmU1SnGIALs.pZgAAeaA1yXOX6RCREyICD_SHUW27YA61tUu56QOG3tkg6Wc7BUSkPtCFQcKqIlh Xbk48QScowOgwPWrEfzHqVl5PmRpxMtHGm_lOLgc4VEaLTWIE_pPNlSOOpbFWQycM6NcdMa_X79k rBR7Mx1xc1DSgK2u2Q9caBT_5VZHmSpZfFLKVnbQBMf5KhrUPB8RUfV8qaNTl6r5B6w0- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.ne1.yahoo.com with HTTP; Thu, 19 Jan 2023 01:06:01 +0000 Received: by hermes--production-sg3-84766d64d7-nhll9 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 83c9564d1e8274410380d7107fddfad8; Thu, 19 Jan 2023 01:05:59 +0000 (UTC) From: Po Lu To: Alan Mackenzie Subject: Re: bug#60769: CC Mode 5.35.2 (C/*l); More incorrect type recognition In-Reply-To: (Alan Mackenzie's message of "Wed, 18 Jan 2023 15:24:15 +0000") References: <87pmbjcf3b.fsf.ref@yahoo.com> <87pmbjcf3b.fsf@yahoo.com> <87tu0p91w9.fsf@yahoo.com> Date: Thu, 19 Jan 2023 09:05:54 +0800 Message-ID: <87fsc772q5.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.21062 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 649 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60769 Cc: 60769@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alan Mackenzie writes: > Ah! Yes, that's different. ;-) > > I can now reproduce the bug, and analysing it, it actually turned out to > be two distinct cases, one for android_get_geometry and the other for > FRAME_ANDROID_WINDOW. I've fixed both of them with the now familiar > "unsafe-maybe" mechanism. > > Would you please do the usual with the attached patch, and let me know if > anything is amiss. In particular, if you notice any types which were > (correctly) fontified as types, but now no longer get fontified, please > tell me. Thanks! > > I look forward to hearing from you again. Seems to work nicely here, thank you. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 19 06:21:37 2023 Received: (at 60769-done) by debbugs.gnu.org; 19 Jan 2023 11:21:37 +0000 Received: from localhost ([127.0.0.1]:42779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pISzB-0004mK-FE for submit@debbugs.gnu.org; Thu, 19 Jan 2023 06:21:37 -0500 Received: from mx3.muc.de ([193.149.48.5]:31545) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pISz9-0004m5-Fc for 60769-done@debbugs.gnu.org; Thu, 19 Jan 2023 06:21:36 -0500 Received: (qmail 8956 invoked by uid 3782); 19 Jan 2023 12:21:28 +0100 Received: from acm.muc.de (p4fe15cd6.dip0.t-ipconnect.de [79.225.92.214]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 19 Jan 2023 12:21:28 +0100 Received: (qmail 5378 invoked by uid 1000); 19 Jan 2023 11:21:27 -0000 Date: Thu, 19 Jan 2023 11:21:27 +0000 To: Po Lu Subject: Re: bug#60769: CC Mode 5.35.2 (C/*l); More incorrect type recognition Message-ID: References: <87pmbjcf3b.fsf.ref@yahoo.com> <87pmbjcf3b.fsf@yahoo.com> <87tu0p91w9.fsf@yahoo.com> <87fsc772q5.fsf@yahoo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87fsc772q5.fsf@yahoo.com> X-Submission-Agent: TMDA/1.3.x (Ph3nix) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60769-done Cc: 60769-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Po. On Thu, Jan 19, 2023 at 09:05:54 +0800, Po Lu wrote: > Alan Mackenzie writes: > > Ah! Yes, that's different. ;-) > > I can now reproduce the bug, and analysing it, it actually turned out to > > be two distinct cases, one for android_get_geometry and the other for > > FRAME_ANDROID_WINDOW. I've fixed both of them with the now familiar > > "unsafe-maybe" mechanism. > > Would you please do the usual with the attached patch, and let me know if > > anything is amiss. In particular, if you notice any types which were > > (correctly) fontified as types, but now no longer get fontified, please > > tell me. Thanks! > > I look forward to hearing from you again. > Seems to work nicely here, thank you. Thanks! I've now committed that patch, and I'm closing the bug with this post. -- Alan Mackenzie (Nuremberg, Germany). From unknown Fri Jun 20 07:14:44 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 16 Feb 2023 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator