GNU bug report logs - #60763
[PATCH] tests: change `sort|uniq` to `sort -u`

Previous Next

Full log

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mike Frysinger <vapier <at> gentoo.org>
To: automake-patches <at> gnu.org
Subject: [PATCH] tests: change `sort|uniq` to `sort -u`
Date: Thu, 12 Jan 2023 20:28:38 -0500

These are equivalent, but more performant.  We already use `sort -u`
elsewhere in the codebase, so nothing new here really.

* t/add-missing.tap: Change `sort|uniq` to `sort -u`.
* t/CheckListOfTests.am: Likewise.
---
 t/CheckListOfTests.am | 2 +-
 t/add-missing.tap     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/t/CheckListOfTests.am b/t/CheckListOfTests.am
index e17083a62d47..672af700e88b 100644
--- a/t/CheckListOfTests.am
+++ b/t/CheckListOfTests.am
@@ -49,7 +49,7 @@ maintainer-check-list-of-tests:
 	       ($(am__cd) $(srcdir) && ls $$dir/*$$ext 2>/dev/null); \
 	     fi; \
 	   done; \
-	 done | sed 's,^\./,,' | sort | uniq >$(am__tfs); \
+	 done | sed 's,^\./,,' | sort -u >$(am__tfs); \
 ## Compare the two lists, complain if they differ.
 	 if $$diff $(am__tmk) $(am__tfs) >$(am__tdf); then \
 	    result=0; \
diff --git a/t/add-missing.tap b/t/add-missing.tap
index 010c03ec5864..ea42bc9cda05 100644
--- a/t/add-missing.tap
+++ b/t/add-missing.tap
@@ -196,7 +196,7 @@ check_ ()
     # Only the expected files should be installed.  But automake always
     # require 'missing' and 'install-sh', so account for them.
     all_files="install-sh missing $files"
-    for f in $all_files; do echo $f; done | sort | uniq > files.exp
+    for f in $all_files; do echo $f; done | sort -u > files.exp
     (cd $build_aux && ls) | sort > files.got
     cat files.exp
     cat files.got
-- 
2.39.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.