From unknown Mon Jun 23 11:25:05 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#60763 <60763@debbugs.gnu.org> To: bug#60763 <60763@debbugs.gnu.org> Subject: Status: [PATCH] tests: change `sort|uniq` to `sort -u` Reply-To: bug#60763 <60763@debbugs.gnu.org> Date: Mon, 23 Jun 2025 18:25:05 +0000 retitle 60763 [PATCH] tests: change `sort|uniq` to `sort -u` reassign 60763 automake-patches submitter 60763 Mike Frysinger severity 60763 normal tag 60763 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 12 20:28:49 2023 Received: (at submit) by debbugs.gnu.org; 13 Jan 2023 01:28:49 +0000 Received: from localhost ([127.0.0.1]:48961 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pG8sD-0001Dz-6s for submit@debbugs.gnu.org; Thu, 12 Jan 2023 20:28:49 -0500 Received: from lists.gnu.org ([209.51.188.17]:60488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pG8s9-0001Dq-Pf for submit@debbugs.gnu.org; Thu, 12 Jan 2023 20:28:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pG8s9-0001Oy-7W for automake-patches@gnu.org; Thu, 12 Jan 2023 20:28:45 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183] helo=smtp.gentoo.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1pG8s7-0002Vq-Fq for automake-patches@gnu.org; Thu, 12 Jan 2023 20:28:44 -0500 Received: by smtp.gentoo.org (Postfix, from userid 559) id 581D8340A9F; Fri, 13 Jan 2023 01:28:42 +0000 (UTC) From: Mike Frysinger To: automake-patches@gnu.org Subject: [PATCH] tests: change `sort|uniq` to `sort -u` Date: Thu, 12 Jan 2023 20:28:38 -0500 Message-Id: <20230113012838.25297-1-vapier@gentoo.org> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=140.211.166.183; envelope-from=vapier@gentoo.org; helo=smtp.gentoo.org X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) These are equivalent, but more performant. We already use `sort -u` elsewhere in the codebase, so nothing new here really. * t/add-missing.tap: Change `sort|uniq` to `sort -u`. * t/CheckListOfTests.am: Likewise. --- t/CheckListOfTests.am | 2 +- t/add-missing.tap | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/t/CheckListOfTests.am b/t/CheckListOfTests.am index e17083a62d47..672af700e88b 100644 --- a/t/CheckListOfTests.am +++ b/t/CheckListOfTests.am @@ -49,7 +49,7 @@ maintainer-check-list-of-tests: ($(am__cd) $(srcdir) && ls $$dir/*$$ext 2>/dev/null); \ fi; \ done; \ - done | sed 's,^\./,,' | sort | uniq >$(am__tfs); \ + done | sed 's,^\./,,' | sort -u >$(am__tfs); \ ## Compare the two lists, complain if they differ. if $$diff $(am__tmk) $(am__tfs) >$(am__tdf); then \ result=0; \ diff --git a/t/add-missing.tap b/t/add-missing.tap index 010c03ec5864..ea42bc9cda05 100644 --- a/t/add-missing.tap +++ b/t/add-missing.tap @@ -196,7 +196,7 @@ check_ () # Only the expected files should be installed. But automake always # require 'missing' and 'install-sh', so account for them. all_files="install-sh missing $files" - for f in $all_files; do echo $f; done | sort | uniq > files.exp + for f in $all_files; do echo $f; done | sort -u > files.exp (cd $build_aux && ls) | sort > files.got cat files.exp cat files.got -- 2.39.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 12 23:07:05 2023 Received: (at control) by debbugs.gnu.org; 13 Jan 2023 04:07:05 +0000 Received: from localhost ([127.0.0.1]:49074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGBLN-0001Wi-6f for submit@debbugs.gnu.org; Thu, 12 Jan 2023 23:07:05 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:56284 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGBLM-0001WD-7k for control@debbugs.gnu.org; Thu, 12 Jan 2023 23:07:04 -0500 Received: by smtp.gentoo.org (Postfix, from userid 559) id CCC56340AB5; Fri, 13 Jan 2023 04:06:58 +0000 (UTC) From: Mike Frysinger To: control@debbugs.gnu.org Subject: Control message Message-Id: <20230113040658.CCC56340AB5@smtp.gentoo.org> Date: Fri, 13 Jan 2023 04:06:58 +0000 (UTC) X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) merge 60764 60763 thankyou From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 13 17:36:38 2023 Received: (at 60763) by debbugs.gnu.org; 13 Jan 2023 22:36:38 +0000 Received: from localhost ([127.0.0.1]:52649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGSf8-0006zN-Dh for submit@debbugs.gnu.org; Fri, 13 Jan 2023 17:36:38 -0500 Received: from freefriends.org ([96.88.95.60]:39080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGSf6-0006z7-IF for 60763@debbugs.gnu.org; Fri, 13 Jan 2023 17:36:36 -0500 X-Envelope-From: karl@freefriends.org Received: from freefriends.org (freefriends.org [96.88.95.60]) by freefriends.org (8.14.7/8.14.7) with ESMTP id 30DMaZIr009874 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 Jan 2023 15:36:36 -0700 Received: (from apache@localhost) by freefriends.org (8.14.7/8.14.7/Submit) id 30DMaZoW009873; Fri, 13 Jan 2023 15:36:35 -0700 Date: Fri, 13 Jan 2023 15:36:35 -0700 Message-Id: <202301132236.30DMaZoW009873@freefriends.org> From: Karl Berry To: vapier@gentoo.org Subject: Re: [bug#60763] [PATCH] tests: change `sort|uniq` to `sort -u` In-Reply-To: <20230113012838.25297-1-vapier@gentoo.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60763 Cc: 60763@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) - done | sed 's,^\./,,' | sort | uniq >$(am__tfs); \ + done | sed 's,^\./,,' | sort -u >$(am__tfs); \ Sure, looks good, please commit. (60764 looks like a dup?) From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 13 19:07:29 2023 Received: (at control) by debbugs.gnu.org; 14 Jan 2023 00:07:29 +0000 Received: from localhost ([127.0.0.1]:52770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGU53-0000zt-Kj for submit@debbugs.gnu.org; Fri, 13 Jan 2023 19:07:29 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:41368 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGU51-0000zf-0N for control@debbugs.gnu.org; Fri, 13 Jan 2023 19:07:27 -0500 Received: by smtp.gentoo.org (Postfix, from userid 559) id 86044340E9C; Sat, 14 Jan 2023 00:07:20 +0000 (UTC) From: Mike Frysinger To: control@debbugs.gnu.org Subject: Control message User-Agent: GNU debbugs/0 Message-Id: <20230114000720.86044340E9C@smtp.gentoo.org> Date: Sat, 14 Jan 2023 00:07:20 +0000 (UTC) X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 60763 thankyou From unknown Mon Jun 23 11:25:05 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 11 Feb 2023 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator