GNU bug report logs - #6076
23.1.96; [PATCH] rcirc-complete for nicks and commands

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#6076: closed (23.1.96; [PATCH] rcirc-complete for nicks and
 commands)
Date: Sun, 12 Sep 2010 15:38:04 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 12 Sep 2010 13:11:47 +0200
with message-id <jwvtylvxm0n.fsf-monnier+emacs <at> gnu.org>
and subject line Re: bug#6076: 23.1.96; [PATCH] rcirc-complete for nicks and commands
has caused the GNU bug report #6076,
regarding 23.1.96; [PATCH] rcirc-complete for nicks and commands
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
6076: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6076
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Leo <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.1.96; [PATCH] rcirc-complete for nicks and commands
Date: Sun, 02 May 2010 09:49:09 +0100

[Message part 3 (text/plain, inline)]

The attached patch replaces rcirc-complete-nick with rcirc-complete that
completes both nicks and user commands. User command completion is only
done after '/'.

I have yet to find a reliable way to obtaining a list of commands
supported by an irc server. So in the end only the standard commands are
copied from RFCs. Let me know if there is a better solution.

[0001-New-command-rcirc-complete-that-completes-both-nicks.patch (text/x-patch, attachment)]

[Message part 5 (text/plain, inline)]

With best wishes,
Leo

[Message part 6 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Leo <sdl.web <at> gmail.com>
Cc: Ryan Yeske <rcyeske <at> gmail.com>
Subject: Re: bug#6076: 23.1.96; [PATCH] rcirc-complete for nicks and commands
Date: Sun, 12 Sep 2010 13:11:47 +0200

> The ChangeLog entry could looks something like this:

> 	* net/rcirc.el (rcirc-server-commands, rcirc-client-commands)
> 	(rcirc-completion-start): new variables.
> 	(rcirc-nick-completions): rename to rcirc-completions.
> 	(rcirc-nick-completion-start-offset): delete.
> 	(rcirc-completion-at-point): new function for constructing
> 	completion data for both nicks and irc commands. Add to
> 	completion-at-point-functions in rcirc mode.
> 	(rcirc-complete): rename from rcirc-nick-complete; use
> 	rcirc-completion-at-point.
> 	(defun-rcirc-command): update rcirc-client-commands.

Looks fine, except that we capitalize after the ":".
Installed, thank you,


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.