GNU bug report logs - #60758
29.0.60; while-let uses if-let* convention in contradiction to the docstring

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Sean Whitton <spwhitton <at> spwhitton.name>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#60758: closed (29.0.60; while-let uses if-let* convention in
 contradiction to the docstring)
Date: Fri, 13 Jan 2023 00:38:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 12 Jan 2023 17:37:35 -0700
with message-id <87zganl168.fsf <at> melete.silentflame.com>
and subject line Re: bug#60758: 29.0.60; while-let uses if-let* convention in contradiction to the docstring
has caused the debbugs.gnu.org bug report #60758,
regarding 29.0.60; while-let uses if-let* convention in contradiction to the docstring
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
60758: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60758
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.60; while-let uses if-let* convention in contradiction to the
 docstring
Date: Thu, 12 Jan 2023 20:21:57 +0100

The docstring of `while-let' says:

     The variable list SPEC is the same as in if-let.

However in the definition `if-let*' is used. `if-let*' differs from
`if-let' since it doesn't support the special single binding form.

     (while-let (var exp)
         ...)

Therefore `if-let*' should be replaced with `if-let' in the definition
of `while-let', bringing the implementation in accordance with the
docstring. The name `while-let' (in contrast to `while-let*') also
suggest that the `if-let' spec is supported.

In GNU Emacs 29.0.60 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.16.0, Xaw scroll bars) of 2022-12-30 built on projects
Repository revision: d086cd6cf877c6ca7af6712f9b79b52dd0caa934
Repository branch: emacs-29
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Debian GNU/Linux 11 (bullseye)

[Message part 3 (message/rfc822, inline)]

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: Daniel Mendler <mail <at> daniel-mendler.de>
Cc: 60758-done <at> debbugs.gnu.org
Subject: Re: bug#60758: 29.0.60; while-let uses if-let* convention in
 contradiction to the docstring
Date: Thu, 12 Jan 2023 17:37:35 -0700

Hello,

On Thu 12 Jan 2023 at 08:21PM +01, Daniel Mendler wrote:

> The docstring of `while-let' says:
>
>      The variable list SPEC is the same as in if-let.
>
> However in the definition `if-let*' is used. `if-let*' differs from
> `if-let' since it doesn't support the special single binding form.
>
>      (while-let (var exp)
>          ...)
>
> Therefore `if-let*' should be replaced with `if-let' in the definition
> of `while-let', bringing the implementation in accordance with the
> docstring. The name `while-let' (in contrast to `while-let*') also
> suggest that the `if-let' spec is supported.

I agree that if-let is right, for these reasons.  Now fixed, thank you.

-- 
Sean Whitton

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.