GNU bug report logs - #60758
29.0.60; while-let uses if-let* convention in contradiction to the docstring

Previous Next

Package: emacs;

Reported by: Daniel Mendler <mail <at> daniel-mendler.de>

Date: Thu, 12 Jan 2023 19:23:01 UTC

Severity: normal

Found in version 29.0.60

Done: Sean Whitton <spwhitton <at> spwhitton.name>

Bug is archived. No further changes may be made.

Full log


Message #58 received at 60758 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Sean Whitton <spwhitton <at> spwhitton.name>
Cc: mail <at> daniel-mendler.de, Eli Zaretskii <eliz <at> gnu.org>, 60758 <at> debbugs.gnu.org
Subject: Re: bug#60758: 29.0.60; while-let uses if-let* convention in
 contradiction to the docstring
Date: Sat, 14 Jan 2023 23:13:55 +0100
Sean Whitton <spwhitton <at> spwhitton.name> writes:

> We should fix the docstring or the code; there's still a bug if I just
> revert my change.  I haven't reviewed the old thread but it sounds like
> a decision was already taken to fix the docstring instead.
> Do you agree?  If so, I'll replace my change.

I'm not Eli, but I think you should fix the docstring.


Here is some part of the discussion I have found:

  https://lists.gnu.org/archive/html/emacs-devel/2018-03/msg00052.html

Summary: We underestimated how many packages used the macros when we had
declared the old versions (without "*") obsolete.  Lots of package
maintainers complained about the warnings they got - they could not
easily get rid of them without breaking backward compatibility of the
packages because if-let* etc (the new forms) are only available in newer
Emacs versions.  So we decided to keep the old variants for now to avoid
the trouble for them.

I'm not sure when it's the right time to do it.

Michael.




This bug report was last modified 2 years and 128 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.