GNU bug report logs - #60758
29.0.60; while-let uses if-let* convention in contradiction to the docstring

Previous Next

Package: emacs;

Reported by: Daniel Mendler <mail <at> daniel-mendler.de>

Date: Thu, 12 Jan 2023 19:23:01 UTC

Severity: normal

Found in version 29.0.60

Done: Sean Whitton <spwhitton <at> spwhitton.name>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Sean Whitton <spwhitton <at> spwhitton.name>
Cc: michael_heerdegen <at> web.de, mail <at> daniel-mendler.de, 60758 <at> debbugs.gnu.org
Subject: bug#60758: 29.0.60; while-let uses if-let* convention in contradiction to the docstring
Date: Sat, 14 Jan 2023 18:35:22 +0200
> Cc: Daniel Mendler <mail <at> daniel-mendler.de>, 60758 <at> debbugs.gnu.org,
>  60758-done <at> debbugs.gnu.org
> From: Sean Whitton <spwhitton <at> spwhitton.name>
> Date: Sat, 14 Jan 2023 09:25:26 -0700
> 
> > So it makes no sense to add this syntax to newly introduced macros.  We
> > should fix the docstring of `while-let' instead - unless the goal of
> > getting rid of this syntax has changed.  But then we should have a
> > discussion first.  Instead it seems you just reverted a change by Lars
> > that was the result of a discussion in emacs-dev.
> 
> Are you saying there was a while-let-specific discussion?
> 
> I did vc-annotate and saw that the code I was changing was in the first
> commit of the new macro.

Then something went wrong with vc-annotate, because that code was
modified in commit 0e72d4793c, on Sep 29, the day after the first
commit of this macro.




This bug report was last modified 2 years and 128 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.