GNU bug report logs - #60758
29.0.60; while-let uses if-let* convention in contradiction to the docstring

Previous Next

Full log

View this message in rfc822 format

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: Daniel Mendler <mail <at> daniel-mendler.de>, 60758 <at> debbugs.gnu.org, 60758-done <at> debbugs.gnu.org
Subject: bug#60758: 29.0.60; while-let uses if-let* convention in contradiction to the docstring
Date: Sat, 14 Jan 2023 09:25:26 -0700

Hello,

On Sat 14 Jan 2023 at 04:31PM +01, Michael Heerdegen wrote:

> Daniel Mendler <mail <at> daniel-mendler.de> writes:
>
>> On 1/13/23 01:37, Sean Whitton wrote:
>> > I agree that if-let is right, for these reasons.  Now fixed, thank
>> > you.
>
> The special case of a SPEC of the form (SYMBOL SOMETHING) is supported
> only for backward compatibility by `if-let'.  We wanted to get rid of
> this special syntax anomaly.
>
> So it makes no sense to add this syntax to newly introduced macros.  We
> should fix the docstring of `while-let' instead - unless the goal of
> getting rid of this syntax has changed.  But then we should have a
> discussion first.  Instead it seems you just reverted a change by Lars
> that was the result of a discussion in emacs-dev.

Are you saying there was a while-let-specific discussion?

I did vc-annotate and saw that the code I was changing was in the first
commit of the new macro.

-- 
Sean Whitton

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.