GNU bug report logs - #60758
29.0.60; while-let uses if-let* convention in contradiction to the docstring

Previous Next

Full log

Message #10 received at 60758-done <at> debbugs.gnu.org (full text, mbox):

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: Daniel Mendler <mail <at> daniel-mendler.de>
Cc: 60758-done <at> debbugs.gnu.org
Subject: Re: bug#60758: 29.0.60; while-let uses if-let* convention in
 contradiction to the docstring
Date: Thu, 12 Jan 2023 17:37:35 -0700

Hello,

On Thu 12 Jan 2023 at 08:21PM +01, Daniel Mendler wrote:

> The docstring of `while-let' says:
>
>      The variable list SPEC is the same as in if-let.
>
> However in the definition `if-let*' is used. `if-let*' differs from
> `if-let' since it doesn't support the special single binding form.
>
>      (while-let (var exp)
>          ...)
>
> Therefore `if-let*' should be replaced with `if-let' in the definition
> of `while-let', bringing the implementation in accordance with the
> docstring. The name `while-let' (in contrast to `while-let*') also
> suggest that the `if-let' spec is supported.

I agree that if-let is right, for these reasons.  Now fixed, thank you.

-- 
Sean Whitton

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.