GNU bug report logs - #60756
[PATCH 0/2] Add x11-socket-directory-service-type.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#60756: closed ([PATCH 0/2] Add x11-socket-directory-service-type.)
Date: Tue, 21 Mar 2023 20:51:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 21 Mar 2023 16:50:15 -0400
with message-id <87y1nplth4.fsf_-_ <at> gmail.com>
and subject line Re: bug#60756: [PATCH 0/2] Add x11-socket-directory-service-type.
has caused the debbugs.gnu.org bug report #60756,
regarding [PATCH 0/2] Add x11-socket-directory-service-type.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
60756: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60756
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Bruno Victal <mirai <at> makinata.eu>
To: guix-patches <at> gnu.org
Cc: Bruno Victal <mirai <at> makinata.eu>
Subject: [PATCH 0/2] Add x11-socket-directory-service-type.
Date: Thu, 12 Jan 2023 15:43:15 +0000

This replaces x11-socket-directory-service with a shepherd one-shot service
that takes file-system as a dependent target.


Fixes #57589.


Bruno Victal (2):
  services: Add x11-socket-directory-service-type.
  Revert "tests: Add gdm tests."

 gnu/local.mk             |   1 -
 gnu/services/desktop.scm |  44 ++++++++++----
 gnu/tests/gdm.scm        | 127 ---------------------------------------
 gnu/tests/lightdm.scm    |   2 +-
 4 files changed, 34 insertions(+), 140 deletions(-)
 delete mode 100644 gnu/tests/gdm.scm


base-commit: ef0613a81dca73602e702cb5f5444ee94566f983
-- 
2.38.1

[Message part 3 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Bruno Victal <mirai <at> makinata.eu>
Cc: dev <at> jpoiret.xyz, 60756-done <at> debbugs.gnu.org
Subject: Re: bug#60756: [PATCH 0/2] Add x11-socket-directory-service-type.
Date: Tue, 21 Mar 2023 16:50:15 -0400

Hi,

Bruno Victal <mirai <at> makinata.eu> writes:

> The x11-socket-directory-service misuses activation-service-type
> to create directories. This kind of usage is incorrect since
> activation-service-type does not depend on file-systems, hence incompatible
> with user defined /tmp mount.
>
> This commit turns x11-socket-directory-service into a shepherd one-shot
> service by defining a new x11-socket-directory-service-type.
>
> * gnu/services/desktop.scm (x11-socket-directory-service-type): New variable.
> (x11-socket-directory-service): Deprecate procedure.
> (desktop-services-for-system): Use new service-type.
> * gnu/tests/lightdm.scm: Ditto.

I've applied this series, with the small change:

--8<---------------cut here---------------start------------->8---
modified   gnu/services/desktop.scm
@@ -1578,7 +1578,7 @@ (define sugar-desktop-service-type
 (define x11-socket-directory-service-type
   (let ((x11-socket-directory-shepherd-service
          (shepherd-service
-          (documentation "Create /tmp/.X11-unix for XWayland.")
+          (documentation "Create @file{/tmp/.X11-unix} for XWayland.")
           (requirement '(file-systems))
           (provision '(x11-socket-directory))
           (one-shot? #t)
--8<---------------cut here---------------end--------------->8---

Thanks for the contribution and to Josselin for the review, which made
me much more confident to install it (along with the QA badge).

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.