GNU bug report logs - #60748
30.0.50; [PATCH]: Fix indentation of object_expressions in csharp-ts-mode

Previous Next

Full log

View this message in rfc822 format

From: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
To: Theodor Thornhill <theo <at> thornhill.no>, 60748 <at> debbugs.gnu.org
Subject: bug#60748: 30.0.50; [PATCH]: Fix indentation of object_expressions in csharp-ts-mode
Date: Fri, 13 Jan 2023 12:16:42 +0100

On 13.01.2023 11:41, Theodor Thornhill wrote:
> Theodor Thornhill <theo <at> thornhill.no> writes:
>
>> Hi Jostein!
>>
>> Are there any regressions, or is this ok to you?
>>
>> Theo
>>
>> [0]:
> Not sure if sent to correct mail, so just appending another one here :)
>
> I can't see any regressions right now, so I'll install the patch when
> you're ok with it :)
>
> Theo

You had a/the right email, but not the right point in time ;)

This last week I've been busy, and working almost entirely with 
TypeScript (and I will for the next weeks too), so I haven't been able 
to testdrive the new C# changes properly or thouroughly enough to feel 
confident enough to give feedback.

I've looked over the code though, and that looks good to me.

If you feel you've done adequate testing, don't wait for me to merge this.

--
Jostein

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.