GNU bug report logs - #60747
[PATCH] dirstamp: switch to a pattern rule

Previous Next

Package: automake-patches;

Reported by: Mike Frysinger <vapier <at> gentoo.org>

Date: Thu, 12 Jan 2023 03:23:02 UTC

Severity: normal

Tags: patch

Done: Mike Frysinger <vapier <at> gentoo.org>

Bug is archived. No further changes may be made.

Full log

Message #8 received at 60747 <at> debbugs.gnu.org (full text, mbox):

From: Karl Berry <karl <at> freefriends.org>
To: vapier <at> gentoo.org
Cc: 60747 <at> debbugs.gnu.org
Subject: Re: [bug#60747] [PATCH] dirstamp: switch to a pattern rule
Date: Thu, 12 Jan 2023 15:50:14 -0700

    There shouldn't be any concerns about portability with $(@D) because:
    (1) We only generate this rule iff we know the dirstamp is in a subdir
        (so we'd never have a case where $(@D) would expand to the cwd)
    (2) We already rely on $(@D) in our depdir code, and have since 2014
        (the Automake 1.16 release).

I can't say I've ever come across, let alone touched, the "dirstamp code",
but your arguments are convincing to me. I assume all tests pass
after the change. Please go ahead and commit. --thanks, karl.
This bug report was last modified 2 years and 208 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.