From unknown Sat Sep 06 00:30:11 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#60746 <60746@debbugs.gnu.org> To: bug#60746 <60746@debbugs.gnu.org> Subject: Status: [PATCH] dirstamp: use append too instead of truncate Reply-To: bug#60746 <60746@debbugs.gnu.org> Date: Sat, 06 Sep 2025 07:30:11 +0000 retitle 60746 [PATCH] dirstamp: use append too instead of truncate reassign 60746 automake-patches submitter 60746 Mike Frysinger severity 60746 normal tag 60746 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 11 22:02:30 2023 Received: (at submit) by debbugs.gnu.org; 12 Jan 2023 03:02:30 +0000 Received: from localhost ([127.0.0.1]:44312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFnrK-0004mo-68 for submit@debbugs.gnu.org; Wed, 11 Jan 2023 22:02:30 -0500 Received: from lists.gnu.org ([209.51.188.17]:54462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFnrF-0004me-J7 for submit@debbugs.gnu.org; Wed, 11 Jan 2023 22:02:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFnrF-0000pg-BR for automake-patches@gnu.org; Wed, 11 Jan 2023 22:02:25 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183] helo=smtp.gentoo.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1pFnrD-0000tc-Tm for automake-patches@gnu.org; Wed, 11 Jan 2023 22:02:25 -0500 Received: by smtp.gentoo.org (Postfix, from userid 559) id 8C175340DB7; Thu, 12 Jan 2023 03:02:15 +0000 (UTC) From: Mike Frysinger To: automake-patches@gnu.org Subject: [PATCH] dirstamp: use append too instead of truncate Date: Wed, 11 Jan 2023 22:02:11 -0500 Message-Id: <20230112030211.16124-1-vapier@gentoo.org> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=140.211.166.183; envelope-from=vapier@gentoo.org; helo=smtp.gentoo.org X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) We changed the depfiles logic to use >> (append) instead of > (truncate) due to it being slightly faster & nicer to the disk. Do the same with the dirstamp files as we only need the files to exist -- we don't care about their content, and we never put anything in them ourselves. If someone else were to, we clean them up normally with `make clean`. Simple test case on my Linux 6.1 w/ext4 on SSD: @: > foo.txt for (i = 0; i < 1000000; ++i) close(open("foo.txt", O_WRONLY|O_CREAT|O_TRUNC, 0666)); -> 769 msec @: >>foo.txt for (i = 0; i < 1000000; ++i) close(open("foo.txt", O_WRONLY|O_CREAT|O_APPEND, 0666)); -> 2 sec --- bin/automake.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/automake.in b/bin/automake.in index 3069132796f1..1c13a3187f46 100644 --- a/bin/automake.in +++ b/bin/automake.in @@ -7902,7 +7902,7 @@ sub require_build_directory $output_rules .= ("$dirstamp:\n" . "\t\@\$(MKDIR_P) $directory\n" - . "\t\@: > $dirstamp\n"); + . "\t\@: >>$dirstamp\n"); return $dirstamp; } -- 2.39.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 12 17:50:16 2023 Received: (at 60746) by debbugs.gnu.org; 12 Jan 2023 22:50:17 +0000 Received: from localhost ([127.0.0.1]:48822 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pG6Om-0005GU-Cb for submit@debbugs.gnu.org; Thu, 12 Jan 2023 17:50:16 -0500 Received: from freefriends.org ([96.88.95.60]:41978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pG6Ol-0005GK-Fv for 60746@debbugs.gnu.org; Thu, 12 Jan 2023 17:50:15 -0500 X-Envelope-From: karl@freefriends.org Received: from freefriends.org (freefriends.org [96.88.95.60]) by freefriends.org (8.14.7/8.14.7) with ESMTP id 30CMoDh7022370 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Jan 2023 15:50:14 -0700 Received: (from apache@localhost) by freefriends.org (8.14.7/8.14.7/Submit) id 30CMoD33022369; Thu, 12 Jan 2023 15:50:13 -0700 Date: Thu, 12 Jan 2023 15:50:13 -0700 Message-Id: <202301122250.30CMoD33022369@freefriends.org> From: Karl Berry To: vapier@gentoo.org Subject: Re: [bug#60746] [PATCH] dirstamp: use append too instead of truncate In-Reply-To: <20230112030211.16124-1-vapier@gentoo.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 60746 Cc: 60746@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) - . "\t\@: > $dirstamp\n"); + . "\t\@: >>$dirstamp\n"); No objection from me. Go for it. Thanks. -k From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 12 23:05:37 2023 Received: (at control) by debbugs.gnu.org; 13 Jan 2023 04:05:37 +0000 Received: from localhost ([127.0.0.1]:49062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGBJx-0001Tc-K4 for submit@debbugs.gnu.org; Thu, 12 Jan 2023 23:05:37 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:56076 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGBJv-0001TN-HJ for control@debbugs.gnu.org; Thu, 12 Jan 2023 23:05:36 -0500 Received: by smtp.gentoo.org (Postfix, from userid 559) id 2F3E2340AB2; Fri, 13 Jan 2023 04:05:29 +0000 (UTC) From: Mike Frysinger To: control@debbugs.gnu.org Subject: Control message Message-Id: <20230113040529.2F3E2340AB2@smtp.gentoo.org> Date: Fri, 13 Jan 2023 04:05:29 +0000 (UTC) X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 60746 thankyou From unknown Sat Sep 06 00:30:11 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 10 Feb 2023 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator