GNU bug report logs - #60730
29.0.60; Free variable with :buffer keyword in ert-with-temp-file

Previous Next

Full log

Message #10 received at 60730-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: "J.P." <jp <at> neverwas.me>
Cc: 60730-done <at> debbugs.gnu.org
Subject: Re: bug#60730: 29.0.60;
 Free variable with :buffer keyword in ert-with-temp-file
Date: Thu, 12 Jan 2023 17:56:33 -0800

"J.P." <jp <at> neverwas.me> writes:

> Pretty sure this is just a (functional) typo.
[...]
>   diff --git a/lisp/emacs-lisp/ert-x.el b/lisp/emacs-lisp/ert-x.el
>   index 83705ca5b8..7cf60bfeae 100644
>   --- a/lisp/emacs-lisp/ert-x.el
>   +++ b/lisp/emacs-lisp/ert-x.el
>   @@ -496,7 +496,7 @@ ert-with-temp-file
>                 (progn ,@body)
>               (ignore-errors
>                 ,@(when buffer
>   -                 (list `(with-current-buffer buf
>   +                 (list `(with-current-buffer ,buffer
>                              (set-buffer-modified-p nil))
>                           `(kill-buffer ,buffer))))
>               (ignore-errors
>
> seems to make it go away.

Thanks, fixed on emacs-29 (commit f27a330b99e).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.