Subject: bug#60730: closed (Re: bug#60730: 29.0.60; Free variable with :buffer keyword in ert-with-temp-file)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 13 Jan 2023 01:57:02 +0000

Your bug report

#60730: 29.0.60; Free variable with :buffer keyword in ert-with-temp-file

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
60730: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60730
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#60730: 29.0.60; Free variable with :buffer keyword in ert-with-temp-file
From: Stefan Kangas <[email-masked]>
To: "J.P." <[email-masked]>
Cc: [email-masked]
Date: Thu, 12 Jan 2023 17:56:33 -0800
List-Id: <debbugs-submit.debbugs.gnu.org>

"J.P." <[email-masked]> writes:

> Pretty sure this is just a (functional) typo.
[...]
>   diff --git a/lisp/emacs-lisp/ert-x.el b/lisp/emacs-lisp/ert-x.el
>   index 83705ca5b8..7cf60bfeae 100644
>   --- a/lisp/emacs-lisp/ert-x.el
>   +++ b/lisp/emacs-lisp/ert-x.el
>   @@ -496,7 +496,7 @@ ert-with-temp-file
>                 (progn ,@body)
>               (ignore-errors
>                 ,@(when buffer
>   -                 (list `(with-current-buffer buf
>   +                 (list `(with-current-buffer ,buffer
>                              (set-buffer-modified-p nil))
>                           `(kill-buffer ,buffer))))
>               (ignore-errors
>
> seems to make it go away.

Thanks, fixed on emacs-29 (commit f27a330b99e).

Subject: 29.0.60; Free variable with :buffer keyword in ert-with-temp-file
From: "J.P." <[email-masked]>
To: [email-masked]
Cc: Stefan Kangas <[email-masked]>
Date: Wed, 11 Jan 2023 05:50:17 -0800
List-Id: <debbugs-submit.debbugs.gnu.org>

Pretty sure this is just a (functional) typo.

If you put something like

  ;; -*- lexical-binding: t; -*-
  (require 'ert-x)
  (ert-deftest test ()
    (let (foo)
      (ert-with-temp-file f
        :suffix ".ext"
        :text "hw\n"
        :buffer b
        (should (equal (setq foo b) (get-file-buffer f))))
      (should-not (buffer-live-p foo))))

in a file and byte-compile it, you get

  ^L
  Compiling file /tmp/somefile.el at Wed Jan 11 00:28:11 2023
  Entering directory ‘/tmp/’
  somefile.el: Warning: reference to free variable ‘buf’

Doing

  diff --git a/lisp/emacs-lisp/ert-x.el b/lisp/emacs-lisp/ert-x.el
  index 83705ca5b8..7cf60bfeae 100644
  --- a/lisp/emacs-lisp/ert-x.el
  +++ b/lisp/emacs-lisp/ert-x.el
  @@ -496,7 +496,7 @@ ert-with-temp-file
                (progn ,@body)
              (ignore-errors
                ,@(when buffer
  -                 (list `(with-current-buffer buf
  +                 (list `(with-current-buffer ,buffer
                             (set-buffer-modified-p nil))
                          `(kill-buffer ,buffer))))
              (ignore-errors

seems to make it go away.

In GNU Emacs 29.0.60 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.24.35, cairo version 1.17.6) of 2023-01-10 built on localhost
Repository revision: 1cbc22b9c7f836f5b3311213dca8afa853513442
Repository branch: emacs-29
Windowing system distributor 'The X.Org Foundation', version 11.0.12014000
System Description: Fedora Linux 36 (Workstation Edition)

Configured using:
 'configure --enable-check-lisp-object-type --enable-checking=yes,glyphs
 'CFLAGS=-O0 -g3'
 PKG_CONFIG_PATH=:/usr/lib64/pkgconfig:/usr/share/pkgconfig'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media puny dired
dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068
epg-config gnus-util text-property-search time-date subr-x mm-decode
mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader
cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric
uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel
term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu
timer select scroll-bar mouse jit-lock font-lock syntax font-core
term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting cairo
move-toolbar gtk x-toolkit xinput2 x multi-tty make-network-process
emacs)

Memory information:
((conses 16 36352 11795)
 (symbols 48 5149 0)
 (strings 32 13148 1515)
 (string-bytes 1 374127)
 (vectors 16 9320)
 (vector-slots 8 148190 16310)
 (floats 8 21 26)
 (intervals 56 220 0)
 (buffers 976 10))