GNU bug report logs - #60722
30.0.50; [PATCH] Using Tramp to sudo in Eshell doesn't change prompt sigil

Previous Next

Full log

Message #29 received at 60722 <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 60722 <at> debbugs.gnu.org
Subject: Re: bug#60722: 30.0.50; [PATCH] Using Tramp to sudo in Eshell doesn't
 change prompt sigil
Date: Sun, 15 Jan 2023 21:38:41 -0800

[Message part 1 (text/plain, inline)]

On 1/15/2023 1:23 AM, Michael Albinus wrote:
> One question is left for me: do we really need FILENAME as argument? I
> believe it would be sufficient to check default-directory; this would also
> be consistent with the functions for remote hosts described in os.texi.

Good point. I removed the FILENAME argument.

> Btw, another idea is to simplify the implementation. Let Tramp set a
> connection-local variable `tramp-user-uid' or alike, and your function
> `remote-user-uid' or however you rename it will ask for this
> connection-local variable, like we do it already in functions
> `null-device' and `path-separator'. This would avoid the overhead of
> running the file name handler mechanism.

I didn't do this part though, since it wasn't so simple. Instead, I made 
the function (now named 'file-user-uid'[1]) work like the function 
'exec-path'. Since the regular 'user-uid' is also a function, I think 
this implementation is the most straightforward.

[1] I named it this way to mimic the relationship between 
'start-process' and 'start-file-process'. (But 'user-file-uid' didn't 
sound right, so 'file-user-uid' it is.)

[0001-Add-file-user-uid-to-get-the-connection-local-effect.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.