GNU bug report logs - #60722
30.0.50; [PATCH] Using Tramp to sudo in Eshell doesn't change prompt sigil

Previous Next

Package: emacs;

Reported by: Jim Porter <jporterbugs <at> gmail.com>

Date: Tue, 10 Jan 2023 23:51:02 UTC

Severity: normal

Tags: patch

Found in version 30.0.50

Done: Jim Porter <jporterbugs <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 60722 <at> debbugs.gnu.org
Subject: bug#60722: 30.0.50; [PATCH] Using Tramp to sudo in Eshell doesn't change prompt sigil
Date: Wed, 11 Jan 2023 14:59:39 +0100
Michael Albinus <michael.albinus <at> gmx.de> writes:

Hi Jim,

> We shouldn't do this. user-uid-for-file would return the *local* uid,
> which is wrong. So please, for all handlers apply
>
>> +    (user-uid-for-file . tramp-handle-user-uid-for-file)
>
> Except in tramp-archive.el, where ignore as handler seems to be appropriate.

Thinking about, I believe we need an own function for
tramp-archive.el. Something like (untested)

--8<---------------cut here---------------start------------->8---
(defun tramp-archive-user-uid-for-file (filename)
  "Like `user-uid-for-file' for file archives."
  (user-uid-for-file (tramp-archive-gvfs-file-name filename)))
--8<---------------cut here---------------end--------------->8---

This should return the local uid for local archives, and the remote uid
for remote archives.

Best regards, Michael.




This bug report was last modified 2 years and 126 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.