Subject: Re: bug#60722: 30.0.50; [PATCH] Using Tramp to sudo in Eshell doesn't change prompt sigil

From: Michael Albinus <[email-masked]>
Date: Tue, 17 Jan 2023 10:12:00 +0100

Jim Porter <[email-masked]> writes:

Hi Jim,

> I've now merged this to the master branch as 0bb8a011d5. Closing this
> bug, though we can obviously discuss further (here or elsewhere) if
> there's any fallout from the change.

Thanks. Pls note, that on emba two tests fail:

--8<---------------cut here---------------start------------->8---
lisp/eshell/esh-proc-tests.log:
  SKIPPED  esh-proc-test/kill-pipeline  ((skip-unless (not (getenv "EMACS_EMBA_CI"))) :form (not "1") :value nil)
lisp/eshell/em-prompt-tests.log:
   FAILED  em-prompt-test/field-properties  ((should (equal-including-properties last-prompt (propertize (format "%s $ " (directory-file-name default-directory)) 'read-only t 'field 'prompt 'font-lock-face 'eshell-prompt 'front-sticky '(read-only field font-lock-face) ...))) :form (equal-including-properties #("/checkout/test # " 0 17 (rear-nonsticky (read-only field font-lock-face) front-sticky (read-only field font-lock-face) font-lock-face eshell-prompt field prompt read-only t)) #("/checkout/test $ " 0 17 (read-only t field prompt font-lock-face eshell-prompt front-sticky (read-only field font-lock-face) rear-nonsticky (read-only field font-lock-face)))) :value nil :explanation (array-elt 15 (different-atoms (35 "#x23" "?#") (36 "#x24" "?$"))))
   FAILED  em-prompt-test/field-properties/no-highlight  ((should (equal-including-properties last-prompt (propertize (format "%s $ " (directory-file-name default-directory)) 'field 'prompt 'front-sticky '(field) 'rear-nonsticky '(field)))) :form (equal-including-properties #("/checkout/test # " 0 17 (rear-nonsticky (field) front-sticky (field) field prompt)) #("/checkout/test $ " 0 17 (field prompt front-sticky (field) rear-nonsticky (field)))) :value nil :explanation (array-elt 15 (different-atoms (35 "#x23" "?#") (36 "#x24" "?$"))))
--8<---------------cut here---------------end--------------->8---

Don't know whether this is related to your recent change, or something
else.

Best regards, Michael.